Oana Horvath
c830ed9986
For #20123 : Disable historyMetadataFeature flag
3 years ago
Travis Long
a2984e6863
[SDK-279] Adds a way to switch to the "preview" collection in Nimbus
...
This adds a toggle/switch to the debug settings menu that causes Nimbus to use the "preview" collection rather than the "main" collection when it initializes. Since it is only applied during init, it does require a restart in order to take effect.
3 years ago
Gabriel Luong
7aea29d57b
For #19951 - Use Proton icon for new home button
3 years ago
Arturo Mejia
29f5567869
For #19922 Fix the default autoplay setting to be block audio only
3 years ago
Mugurell
5d62fe11a6
For #20046 - Show the last accessed tab in Jump back in
3 years ago
jhugman
8b32f7dcda
Add error reporting via sentry to Nimbus caught exceptions ( #20049 )
3 years ago
Roger Yang
cabd004390
Closes #19182 : Close Tabs Tray when sharing completes
3 years ago
Roger Yang
74c1cc82fb
Closes #19921 : Update appcompat and fragment dependencies to 1.3.x
3 years ago
Arturo Mejia
1d76bc7ca2
For #19922 Update the default autoplay setting to be block audio only
3 years ago
Jonathan Almeida
15df06b294
Issue #20054 : Update recent tab on title or icon changes
3 years ago
Arturo Mejia
251bfc7fe9
Improvements to site permissions
3 years ago
codrut.topliceanu
37e2c6ceeb
For #19739 - Adds start tabsTray with multiSelect support
3 years ago
codrut.topliceanu
2c538dbb5d
For #16330 - Replaces Sentry.capture with submitCaughtException
3 years ago
Mugurell
b3a6dcccd7
For #19797 - Remove FenixAccountManager#authenticatedAccount
...
This api had a bug stemming from the property name - authenticatedAccount which
may return even an unauthenticated account.
After the recent refactorings it was left unused so best to remove it to
prevent from future misuses.
3 years ago
Mugurell
ce64c2439d
For #19797 - Use the FXA email only if the account is authenticated
...
An account may exist but it may need to be re-authenticated.
In this case also the email should not be exposed to the app.
3 years ago
Mugurell
19af5e9b15
For #19797 - Remove FenixAccountManager#signedInToFxa
...
After the changes from this patch this api is not used anymore so to prevent
future misuses of it this is removed in favor of the new "accountState".
3 years ago
Mugurell
1fc3bb84ca
For #19797 - Home menu: go to problems page if account exists but not signed in
3 years ago
Mugurell
3d071dd049
For #19797 - Browser menu: go to problems page if account exists but not signed in
3 years ago
Mugurell
d663383cf7
For #19797 - New FenixAccountManager#getAccountState()
...
This new method allows a single source of truth for getting the up-to-date
account status without clients interesting in this needing to know what to
check for.
3 years ago
Grisha Kruglov
2198298df5
Obtain searchTerms from previous page in tab's history
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Arturo Mejia
c2439914fa
For #19881 add telemetry for start on Home.
3 years ago
Mihai Adrian Carare
9c9e26953f
For #19813 : Invalidate tab tray adapter structure on screen rotation. ( #20044 )
3 years ago
Christian Sadilek
b123b50df7
HistoryMetadataMiddleware: Use state ext. functions from A-C
3 years ago
mcarare
df2efcf310
For #20024 : Visit FAB after synced tabs in a11y traversal.
...
This helps focus on FAB without going through whole tab lists.
3 years ago
Jonathan Almeida
5be35df969
Revert "For #19739 - Adds start tabsTray with multiSelect support"
...
This reverts commit d8288f5e89
.
3 years ago
Jonathan Almeida
aeb186f79c
Revert "For #19739 - Moves argument to initial state init"
...
This reverts commit f198e110d7
.
3 years ago
codrut.topliceanu
f198e110d7
For #19739 - Moves argument to initial state init
3 years ago
codrut.topliceanu
d8288f5e89
For #19739 - Adds start tabsTray with multiSelect support
3 years ago
Mihai Adrian Carare
83a5aa2838
For #20007 : Multiselect title is important for a11y just in select mode. ( #20008 )
3 years ago
Gabriel Luong
c0329f3c26
For #19988 - Part 2: Load tab icon from BrowserIcons cache if needed for the recent tab
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Gabriel Luong
ad91f91eb6
For #19988 - Part 1: Move RecentTabsListFeature into recenttabs package
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Mugurell
a1fa1a5df6
For #19135 - Offer more context for why STATE_HALF_EXPANDED is not used
3 years ago
Mugurell
abeb8b5576
For #19135 - Set different offsets for expanded trays
...
As in the previous version of tabs tray when tray is expanded while in portrait
it should have a 40dp offset and when the tray is expanded while in landscape
it should have a 0dp offset - effectively making it fullscreen.
These values were set in code, always overriding the xml set value so I
removed that xml declaration.
3 years ago
Mugurell
3cbb67da5c
For #19135 - Expand the tabs tray in landscape
...
Track the current orientation and collapse / expand it the tabs tray depending
on the orientation and the number of opened tabs.
3 years ago
Mugurell
d7544337b8
For #19135 - Refactor the behavior code to support more functionality later
...
Setup a new TabSheetBehaviorManager with all the dependencies it needs to
set the initial tray's behavior.
This same manager will later be called to update behavior's properties.
3 years ago
Sammy Khamis
950e36c053
changes required for uniffi-ing logins component=
3 years ago
Christian Sadilek
ba19960b7e
Issue FNX-22435: Introduce History metadata
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
mcarare
d43acbd03d
For #19938 : Remove a11y workaround for tab tray new tab button.
...
Historically, button was introduced in a3dc565c10
,
because FAB was not selectable by a11y in previous implementation of tab tray.
3 years ago
Jan-Erik Rediger
d55f55d70c
Suppress deprecation warnings for now-deprecated Glean APIs
...
Glean v39 allows to specify types for event extra keys.
The old API is therefore deprecated.
To avoid to much churn right now and keep the build going let's suppress
the deprecation warnings.
3 years ago
mcarare
2d2be26fbc
For #19915 : Add telemetry for the toolbar Home screen button.
3 years ago
Gabriel Luong
9d3cf79051
For #19916 - Add last viewed tab to home screen
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Sebastian Kaspari
c0531ffa82
Update Android Components to 91.0.20210610143711. ( #19946 )
3 years ago
Christian Sadilek
0c1e712ca8
Issue #17800 : Cleanup and fix request desktop site from home
3 years ago
Arturo Mejia
2f879f8e9d
Fix site permissions breaking changes
3 years ago
Sebastian Kaspari
4753a1d494
Complete browser-state migration and remove browser-session dependency.
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Gabriel Luong
ace835d1e8
For #19876 - Part 3: Add a FeatureFlag to keep the Home screen button in Nightly
3 years ago
Gabriel Luong
044c9a5b40
For #19876 - Part 2: Add a Home screen button to the browser toolbar
3 years ago
Gabriel Luong
86a9c56782
For #19876 - Part 1: Refactor BrowserToolbarInteractor
...
- Renames `BrowserInteractor` to `DefaultBrowserTolbarInteractor`
- Renames `BrowserTooolbarViewInteractor` to `BrowserToolbarInteractor`
- Refactors `BrowserToolbarViewInteractor` interface from `BrowserToolbarView.kt` to `BrowserToolbarInteractor` as `BrowserToolbarInteractor`
3 years ago
rxumoz
3a4f73be19
For #10300 - Fix Baidu search telemetry ( #19127 )
3 years ago
Jonathan Almeida
f06e3a6493
Issue #19178 : Apply new styling to Synced Tabs list
3 years ago
codrut.topliceanu
5729137ddb
For #19738 - Adds tests for SecureTabsTrayBinding.kt
3 years ago
codrut.topliceanu
0572cab97c
For #19738 - Secure mode enabled in private tabs tray
...
Prevents screenshots while tabs tray with private tabs page is open.
3 years ago
Arturo Mejia
f0bb70e354
For #19789 Start on Home after some amount of time
3 years ago
Gabriel Luong
74a96905a3
For #19495 - Add validation for the name on card ( #19836 )
...
- We want to ensure that name on card in the credit card is not empty when submitted. Display an appropriate error when the field is invalid.
3 years ago
Christian Sadilek
68a761388a
Suppress TooGenericExceptionCaught for NimbusApi.withExperiment
3 years ago
James Hugman
5981a92148
Re-instate catch-all to withExperiment
3 years ago
Jonathan Almeida
a64cac6c7f
Issue #19792 : Add content description for tab tray action button
3 years ago
Roger Yang
2e4635334a
Closes #19090 : Show snackbar on adding to bookmarks from tabs tray ( #19807 )
3 years ago
Jonathan Almeida
811dd3e618
Issue #19809 : Change default tab tray view to grid layout
3 years ago
Jonathan Almeida
27280e6683
Issue #19809 : Remove Grid layout info banner in tabs tray
3 years ago
codrut.topliceanu
85c438798e
For #19191 - Fixes missing multi-select checkmarks
3 years ago
Jonathan Almeida
bf3f81d271
Issue #19112 : Remove old Synced Tabs code
3 years ago
Jonathan Almeida
dc11c334b6
Issue #19112 : Remove old tab tray code
3 years ago
Mugurell
0455cc3cd4
For #18877 - Support updated PromptRequest AC APIs ( #19767 )
...
* For #18877 - Support updated PromptRequest AC APIs
This issue stemming from a race condition is fully resolved in AC by adding
support for having multiple prompts at a time.
Fenix needs just a small change to support the AC refactoring.
* Update Android Components version to 91.0.20210603145049
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Gabriel Luong
a5110f8c0a
For #19746 - Remove FeatureFlags.nimbusExperiments ( #19771 )
3 years ago
ZianeA
e4fa71fde7
For #[15083]: Add multi select to recently closed tabs
3 years ago
Elise Richards
6dbe5acc5b
For #19746 - Remove feature flag for the three-dot menu redesign ( #19750 )
...
* Remove feature flag for the three-dot menu redesign
* Remove menu feature flag from unit tests
3 years ago
codrut.topliceanu
13f9a35131
For #19571 - Adds gdprForgetMe when stopping Adjust
3 years ago
Gabriel Luong
33b2789270
For #19734 - Enable Credit cards autofill for Release ( #19735 )
3 years ago
Gabriel Luong
172a118a51
For #18711 - Refactor credit card telemetry under the Metrics ping ( #19733 )
3 years ago
Jonathan Almeida
fc46ab2804
Close #19731 : Track metrics before we dismiss the tabs tray
3 years ago
Mihai Adrian Carare
e69bf4e26a
For #19564 : Explicitly update switch state for a11y event announcements. ( #19589 )
3 years ago
Gabriel Luong
d30ebf86f9
For #19693 - Display a biometric prompt when a credit card is selected to autofill ( #19697 )
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Grisha Kruglov
daba5595f6
Enable addresses sync for nightly/debug builds
3 years ago
Grisha Kruglov
e891139db9
Minor cleanup of the account settings
3 years ago
Elise Richards
e0b410efdf
For #18711 : Telemetry for credit card autofill ( #19548 )
3 years ago
Gabriel Luong
89a1b0016c
For #19492 - Provide the correct CreditCardNumber type to UpdatableCreditCardFields when updating a credit card ( #19692 )
...
We were crashing because we were specifying the wrong `CreditCardNumber` type when constructing the `UpdatableCreditCardFields`.
We only had the plaintext card number from the user input, but was placing it off as an encrypted card number, which resulted in the crash.
3 years ago
Christian Sadilek
9d1e51dfff
Fix breaking change in MetricController
3 years ago
Christian Sadilek
3a57188c35
Fix lint/detekt issues
3 years ago
James Hugman
ab678a21ff
Add an experiment to demontrate the Feature API
...
This is not visible in production, but only debug. It shows three variables
being used to change the settings screen (title, icon and title-punctuation).
3 years ago
Elise Richards
279d59897c
For #18264 - Add biometric prompt to credit card settings ( #19505 )
3 years ago
Jonathan Almeida
758700cbb0
Issue #19647 : Navigate to browser from home via Synced Tabs page
3 years ago
Gabriel Luong
338c488fae
For #19680 - Show the card number when editing a credit card ( #19681 )
3 years ago
Gabriel Luong
c11335fafc
For #18271 - [Saved cards] Display the credit card provider icon and report the correct card type ( #19652 )
3 years ago
Mugurell
bd8facb025
For #18263 - Allow dynamically toggling credit cards autofill
3 years ago
Ionut Cristian Bedregeanu
ac71b47c61
For #19653 - Address 19643 PR comments
...
Rename handleAddCreditCard to handleAddCreditCardClicked
Rename onClickAddCreditCard to onAddCreditCardClick
Format layout_add_credit_card.xml
3 years ago
Mugurell
3fb40e1f40
For #19475 - Introduce a DefaultTabsTrayInteractor
...
Refactored the TabsTrayFragment to not implement the TabsTrayInteractor which
among other advantages allowed for easier testing.
3 years ago
Mugurell
dc26272381
For #19475 - Cleanup - respect naming scheme in TabsTrayController
...
In our current MVI implementation the View Interactors are first called in
response to a direct user action and contain methods following the
"onXXHappened" naming scheme and then delegate other Interactors / Controllers
for specific actions.
Controllers contain the business logic for actually updating the app's state
and offer methods following the "handleXXAction" naming scheme.
3 years ago
Sebastian Kaspari
84f4ff0d86
Issue #17819 : Update detekt to 1.17.1
3 years ago
Ionut Cristian Bedregeanu
0a226962bb
For #18881 - Create a new layout for 'Add credit card' button
...
Add functionality for 'Add credit card' button
Add unit tests for 'Add credit card' functionality
3 years ago
Codrut Topliceanu
5f2b3fec38
For #18270 - Adds ellipses+last 4 digits to CC display ( #19420 )
...
* For #18270 - Adds ellipses+last 4 digits to CC display
3 years ago
mcarare
0141d96465
For #19554 : Add SyncEngine.CreditCards to sync supportedEngines.
3 years ago
mcarare
9400f58e2a
For #17538 : Perform autofill storage warm-up after visual completeness.
3 years ago
mcarare
a862824697
For #19600 : Change manage cards preference UI dynamically.
3 years ago
mcarare
bcf6b901ee
For #19600 : Change manage cards preference UI dynamically.
3 years ago
Mugurell
bbc25e430e
For #19590 - Enable credit card autofill in Debug and Nightly ( #19601 )
3 years ago
Sebastian Kaspari
761752e382
AutofillConfiguration: Correctly specify autofill confirm activity.
3 years ago
Mihai Adrian Carare
d96415111b
For #19054 - Navigate to the Credit card screen when deleting last card. ( #19451 )
3 years ago
Mihai Adrian Carare
11efbaacc4
For #18507 - Prevent screenshots on credit card screens. ( #19560 )
3 years ago
mcarare
888b45b079
For #8370 : Remove extra characters from name mapping.
3 years ago
Arturo Mejia
52587753a5
Remove feature flag for proton icons re-design #18132
3 years ago
Gabriel Luong
75fc116043
For #18287 - Display a credit card autofill prompt ( #19477 )
3 years ago
Arturo Mejia
bf42a1786e
For issue AC#10231 update proton icons third batch
3 years ago
Elise Richards
6459a859b9
For #17537 : Add preferences for syncing credit cards and addresses ( #19471 )
...
* Add preferences for enable/disable sync for cc and addresses
* Set pref visibility based on feature flags
* Helper function for pin warning preferences and set default values for cc and addresses to false.
* Kdocs for relevant sync functions in account settings
* Default visibility to false for credit cards and addresses in account settings
3 years ago
Jonathan Almeida
ede909e858
Issue #19176 : Exit select mode when removing tab ( #19486 )
3 years ago
mcarare
4dd4e35982
For #19258 : Replace default Android back button with a custom icon.
3 years ago
Codrut Topliceanu
d08b00717a
For #19091 - Fix Undo of close multiple tabs ( #19466 )
...
Fixes the issue where closing multiple selected tabs and then pressing Undo would only restore one of the tabs.
3 years ago
Roger Yang
f13560ae52
Issue #19147 : Move set startup metrics off main thread
3 years ago
Jonathan Almeida
f0d352f47e
Issue #19002 : Correct naming of pager viewholders
3 years ago
Jonathan Almeida
a95a26b2c6
Issue #19002 : Use a single BrowserTrayList for normal/private list
...
We now have a BrowserTrayList.
- Renamed from `BaseBrowserTrayList`.
- Removed the abstract `configuration` and used a `lateinit var`
instead.
- Removed `NormalBrowserTrayList` and `PrivateBrowserTrayList`.
3 years ago
Jonathan Almeida
bd753d3f94
Issue #19002 : Correct browser viewholder naming
3 years ago
Jonathan Almeida
809c82a9f9
Issue #19002 : Move TabsTrayViewHolder to browser package
3 years ago
Jonathan Almeida
78af3d80b3
Issue #19002 : Remove unused TrayItem interface
3 years ago
Jonathan Almeida
e66983d093
Issue #19002 : Use AbstractBinding from lib-state
3 years ago
Mugurell
551031eee3
For #18672 - Renaming a TopSite changes just the title
...
Previously renaming a TopSite would bind that as a new item and in such update
the entire list. This could potentially leading changes in the list and then
it's ViewPager parent's layout.
This patch switches the code to use the existing TopSitePayload and so do a
partial update of an on-screen TopSite instead of rebind it as a new item.
If a layout is requested while showing <=4 TopSites on the second page, by
having "offscreenPageLimit = 1" the biggest height of ViewPager pages is used
preventing an edgecase where the ViewPager would hide half of the items from
the first page.
3 years ago
kanish671
9e30833506
For #18672 - Rename TopSites even on the second page
...
Index calculation for notifying changes while renaming a top site in the second
page was being wrongly calculated. Since it is page 2, we would need to take a
mod with the number of top sites per page to get the actual index of the top
site that was being renamed.
3 years ago
Jonathan Almeida
392ace67d6
Issue #19175 : Fix SyncTabs list not updating on changes
...
The main cause for this is that the `LifecycleProvider` needs to be set
to `State.RESUMED` to avoid the account manager's internal
`ObserverRegistry` from putting the UI observers into the paused state.
The rest of the changes is to rely the internal (safe) logic to
correctly sync and then update the tabs list.
3 years ago
mcarare
93c6403882
For #19357 : Remove bookmarks experiment and keep star-with-line icon.
3 years ago
Elise Richards
cf9a84eed5
Move locale restoration on startup to the visual completeness queue to prevent perf impact ( #19315 )
3 years ago
Dharan Aditya
6cbc35b7d8
Fixed mozilla-mobile#18641: [Bug] Fill link from clipboard overlaps search engines ( #18657 )
3 years ago
Gabriel Luong
d83c9d1e72
For #18993 - Nimbus: Allow internal tooling to opt into specific branches of an experiment ( #19333 )
3 years ago
Roger Yang
a9e0557d83
Closes #3728 : Add secret menu switch for allowing third party root certificates ( #19398 )
3 years ago
Arturo Mejia
9bfb31519a
For issue #19290 update to proton icons second batch
3 years ago
mcarare
516d52997d
For #18266 : Validate credit card entry info.
3 years ago
mcarare
3428dd67ed
For #18266 : Refactor fragment and view to remove duplicate code.
3 years ago
Codrut Topliceanu
277034546f
For #18262 - [Credit cards] Turn the "Sync cards across devices" button into a "Sync cards" toggle ( #19207 )
...
* For #18262 - Turns "Sync cards/logins" into toggle
3 years ago
Roger Yang
74047cdceb
Closes #19147 : Move startup metrics to right after Glean initialization ( #19252 )
3 years ago
codrut.topliceanu
0c74756d39
For #19132 - Fix navigation on disconnect started from tabsTray
...
- Added checks to popBackStack from the Disconnect Logged-in User Dialog, either back to settings, browserFragment or homeFragment.
3 years ago
Jonathan Almeida
f421f82f2c
Close #19259 : Pass CoroutineContext to nav interactor constructor
3 years ago
Roger Yang
79cf3fc765
Closes #18253 : Bookmark and History open new tabs in the background ( #19275 )
3 years ago
Elise Richards
5b5e7ebf47
Turn on feature flag for three-dot menu redesign for beta. ( #19111 )
3 years ago
Sebastian Kaspari
5f4a590418
Issue #19040 - Update marketing data setting description
3 years ago
Roger Yang
59de530a9c
Closes #18253 : Remove spaces from Addons telemetry comma-separated list ( #19292 )
3 years ago
Arturo Mejia
21cf0b31a4
For issue #18132 update to proton icons first batch
3 years ago
mcarare
8c0f86bd96
For #19213 : Adjust synced tabs to properly show in RTL.
3 years ago
Mugurell
d495d84208
For #11819 - Show the mic in widget only if setting is enabled
...
If "Show voice search" is disabled under Settings, the mic icon should not be
shown in the search widget.
3 years ago
Arturo Mejia
c725493bea
Fix openFile breaking changes
3 years ago
Sebastian Kaspari
7d690219ea
Issue #19040 : Remove Leanplum (Nightly)
3 years ago
Grisha Kruglov
4e16c46b27
Fix breaking changes introduced by credit card encryption APIs
3 years ago
Sebastian Kaspari
6a1b5875b0
Use new SearchSuggestionProvider flag.
3 years ago
Mihai Adrian Carare
e952513569
For #19065 - Add extension functions to be used with credit cards. ( #19187 )
3 years ago
Mugurell
dc51cd47b5
For #18591 - Make the navbar sticky in the new menu
3 years ago
Roger Yang
cd37f398f1
Closes #18816 : Disable TabsTray FAB on accessibility enabled ( #19170 )
3 years ago
mcarare
ded686d533
For #19125 : Move top site pin net to title.
3 years ago
Sebastian Kaspari
cf4847dc17
Remove browser-search references.
3 years ago
mcarare
00744fa9e5
For #18267 : Updates preferences visibility depending on creditCardsStore
3 years ago
Elise Richards
db76b8fe21
For #19114 : check state of sync account when navigating from sync sign in menu item ( #19118 )
3 years ago
mcarare
8f1b3e03f1
For #18608 : Also add default browser item in new menu.
3 years ago
Arturo Mejia
acb24396e5
Address WebExtensionBrowserMenuBuilder breaking change
3 years ago
Sebastian Kaspari
a126f0913a
Update to Mozilla Android Components 90.0
3 years ago