Commit Graph

3948 Commits (627cd8b8bd54467e968d6b51b73f747b5a97b0c8)

Author SHA1 Message Date
ekager 76a7b37440 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12954 - Remove all ConstraintLayout casts in SearchEngineListPreference 4 years ago
Oana Horvath 1748d2d012 [fenix] For: https://github.com/mozilla-mobile/fenix/issues/12894, https://github.com/mozilla-mobile/fenix/issues/12899, https://github.com/mozilla-mobile/fenix/issues/12968, https://github.com/mozilla-mobile/fenix/issues/11239, disables failing UI tests 4 years ago
Mihai Branescu 0507017605 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7716 - modified xml to let 'Learn more' button have min 48dp for a11y
Added a margin top of 20dp as well on the buttons so as not to change UI
4 years ago
ekager 1dbc00f08d [fenix] For https://github.com/mozilla-mobile/fenix/issues/12947 - Adjust tab selected state on bind 4 years ago
Tiger Oakes a0f58194e2 [fenix] Add concept-menu dependency 4 years ago
ekager 180590e776 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12721 - Remove SessionManager usages in TabCounter 4 years ago
Hakkı Kaan Çalışkan 2dff66eee9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12929: Change cast to LinearLayout 4 years ago
Hakkı Kaan Çalışkan 9845637378 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12804: Set min height for search engine radio button 4 years ago
ekager 1ced27bda6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10163 - Adds tab multiselect mode 4 years ago
Jonathan Almeida 312addd8be [fenix] For https://github.com/mozilla-mobile/fenix/issues/10925: Fix breaking APIs in tabs tray 4 years ago
Tiger Oakes 2c08b342e8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12871 - Use local TWA DAL API (https://github.com/mozilla-mobile/fenix/pull/12872) 4 years ago
Kainalu Hagiwara ee201255cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/12880 - Pass a CoordinatorLayout to Snackbars created by the context menu. 4 years ago
Sawyer Blatz fdf22f7e74 [fenix] No issue: fix master 4 years ago
ekager a939f4ee8f [fenix] For https://github.com/mozilla-mobile/fenix/issues/12364 - Improve PWA onboarding timing logic 4 years ago
Sawyer Blatz adc1813fd6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12793: Improve snackbars for tabs tray 4 years ago
Sawyer Blatz 6317a79222 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12791: Fix issue with undo snackbar last tab 4 years ago
Sawyer Blatz b4a0e122d1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10997: Remove scrolling from home (https://github.com/mozilla-mobile/fenix/pull/12866) 4 years ago
Michael Comella aff5a4f5c4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12345: replace Activity.reportFullyDrawnSafe with a-c impl. 4 years ago
Oana Horvath d6ead0a749 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12893: Disables failing deleteAllHistoryTest (https://github.com/mozilla-mobile/fenix/pull/12902) 4 years ago
Oana Horvath c286ebe55e [fenix] For https://github.com/mozilla-mobile/fenix/issues/12473: Disable failing verifyContextCopyLink (https://github.com/mozilla-mobile/fenix/pull/12891) 4 years ago
mcarare ae809790c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10026: Update scroll flags on a11y state change. 4 years ago
mcarare 38cb941da9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10026: Add a11y state listener to BaseBrowserFragment. 4 years ago
mcarare dad550613d [fenix] For https://github.com/mozilla-mobile/fenix/issues/10026: Add Context extension to get AccessibilityManager. 4 years ago
Kainalu Hagiwara 559f83302e [fenix] For https://github.com/mozilla-mobile/fenix/issues/12868 - Fix tab counter menu snackbar position. 4 years ago
Sawyer Blatz d63bd0b2e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12430: Hide the mic when not using Google 4 years ago
Tiger Oakes 4037103a95 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Don't pass contest to SortingStrategy 4 years ago
Aaron Train f0f972a053 [fenix] No issue: Fix recent UI test breakage (https://github.com/mozilla-mobile/fenix/pull/12869) 4 years ago
Tiger Oakes 0d37525151 [fenix] Migrate from Session.toTab to BrowserStore (https://github.com/mozilla-mobile/fenix/pull/12221) 4 years ago
Tiger Oakes 0d5d9631c1 [fenix] Add tests for some classes in home/browser (https://github.com/mozilla-mobile/fenix/pull/12837) 4 years ago
Tiger Oakes d2d30f0e5e [fenix] Test sync adapter (https://github.com/mozilla-mobile/fenix/pull/12810) 4 years ago
Arturo Mejia 9f8851294b [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/11676: Features phone that doesn't a site permission exception shouldn't be shown (https://github.com/mozilla-mobile/fenix/pull/12855)
exception shouldn't be shown
4 years ago
Mozilla L10n Automation Bot 69d6c450c5 [fenix] Import l10n. 4 years ago
Tiger Oakes bf4a7cd969 [fenix] Create ToolbarPosition enum (https://github.com/mozilla-mobile/fenix/pull/12747) 4 years ago
Jonathan Almeida bb3e5bfbf9 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/11333: Set ContentBlocking settings directly on GeckoRuntime
We set the ContentBlockingSettings directly on the GeckoRuntime now to
improve the startup of the engine.

This change has requirements from Android Components and GeckoView, so
we would only see the full perf benefits in Nightly as the changes ride
the train, although we might start to see some of them as we're updating
the GeckoProvider for the `geckoBeta` variant as well.

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
4 years ago
Kainalu Hagiwara 9153350cd2 [fenix] No issue - Fix compilation error caused by removed extension function. 4 years ago
Kainalu Hagiwara d4d68f2b77 [fenix] Fix UI tests.
We need to pass a CoordinatorLayout instead of a SwipeGestureLayout to
FenixSnackbar.make() in BaseBrowserFragment to prevent UI tests from
breaking. We also need to remove a few view IDs from the tab preview.
4 years ago
Kainalu Hagiwara a6a8c4dc08 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3481 - Implement swipe on toolbar to switch tabs. 4 years ago
Mozilla L10n Automation Bot d85e95f6b8 [fenix] Import l10n. 4 years ago
Kainalu Hagiwara 9d3f8a7e0f [fenix] For https://github.com/mozilla-mobile/fenix/issues/1048 - Add ability to view tab history by long-pressing the back or forward button. 4 years ago
Hakkı Kaan Çalışkan 082cddf7d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12571: Rename 'Shortcuts' to 'Search engines'
Co-Authored-By: Khushraj Rathod <khushrajrathod@gmail.com>
4 years ago
Tiger Oakes 75817b004c [fenix] Use AC RunWhenReadyQueue (https://github.com/mozilla-mobile/fenix/pull/12800) 4 years ago
Tiger Oakes fb7c801b38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12801 - Extra debug menu trigger, disable if already triggered 4 years ago
Jonathan Almeida 1df7dce5d0 [fenix] Update to Android Components 52.0.20200722023149
Fixes breaking APIs in SyncedTabsFeature and
BookmarksStorageSuggestionProvider
4 years ago
Michael Comella 67d1e5f935 [fenix] No issue: add missing newline. 4 years ago
Michael Comella e84b6e82e8 [fenix] No issue: clean up initVisualCompletenessQueue... method.
A no-op clean up.
4 years ago
Michael Comella 032ca003cd [fenix] No issue: extract initVisualCompletenessQueueAndQueueTasks.
This refactor, done entirely by IDE, is a no-op cleanup.
4 years ago
Michael Comella 1f65ba446e [fenix] No issue: extract startMetricsIfEnabled function.
This refactor, done entirely by IDE, is a no-op clean-up of this file.
4 years ago
Jeff Boek b2d6f5746b [fenix] For https://github.com/mozilla-mobile/fenix/issues/12806 - Adds unit tests to cover `ToolbarView.update()` (https://github.com/mozilla-mobile/fenix/pull/12807) 4 years ago
Jonathan Almeida 758f0b0b96 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12797: Use measured height/width for loading a thumbnail
Using `onNextLayout` has the side-effect of showing the thumbnail with
the tab.id from a recycled view.

The root cause of needing that call is to retrieve the measured
height/width from the view first before requesting. A simpler solution
to avoid the complexity is to retrieve these values from the dimen
resources.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
4 years ago
Sawyer Blatz a48f1f8591 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12461: Update content description for tabs tray open tab count 4 years ago
Sebastian Kaspari 8de62c28cf [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7877: Add SearchActionProvider for faster responses that mirror entered text. 4 years ago
Tiger Oakes adbadba250 [fenix] Move settings in components (https://github.com/mozilla-mobile/fenix/pull/12675) 4 years ago
Mihai Eduard Badea 130de798fb [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12387 - Display tab tray using .show
Replaced the global navigation action used for displaying the tab tray with the .show() function.
4 years ago
mcarare 2320c617b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9722: Refactor onboarding buttons with text.
Add title and description to button text, remove extra Textviews.
4 years ago
Tiger Oakes ef885fe482 [fenix] Add tests for web push integration 4 years ago
mcarare 5ddf809ee8 [fenix] For android-l10n https://github.com/mozilla-mobile/fenix/pull/241: Mark a11y link type as not translatable. 4 years ago
Johan Lorenzo 13e8560acf [fenix] Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta (https://github.com/mozilla-mobile/fenix/pull/12225) 4 years ago
TejaswiKarasani 00cd8b8f35 [fenix] No issue: verify ETP toolbar shield icon is not displayed if ETP is OFF globally in ETP UI tests (https://github.com/mozilla-mobile/fenix/pull/12623) 4 years ago
Oana Horvath 82a76042d9 [fenix] Fix UI tests from https://github.com/mozilla-mobile/fenix/issues/12752 https://github.com/mozilla-mobile/fenix/issues/12637 https://github.com/mozilla-mobile/fenix/issues/12764 (https://github.com/mozilla-mobile/fenix/pull/12779)
* For https://github.com/mozilla-mobile/fenix/issues/12752 & https://github.com/mozilla-mobile/fenix/issues/12764: Fixes tabs tray behavior in UI tests

* For https://github.com/mozilla-mobile/fenix/issues/12637: fixes goBackTest
4 years ago
Tiger Oakes 3bccc0dd50 [fenix] Pass settings and metrics to CFR 4 years ago
mozilla-l10n-automation-bot 72e6448a1d [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/12766) 4 years ago
Richard Pappalardo 41bb2cb087 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/12752, https://github.com/mozilla-mobile/fenix/issues/12764 - Temp disable openHistoryInNewTabTest intermittent UI test failures (https://github.com/mozilla-mobile/fenix/pull/12754)
* Fixes https://github.com/mozilla-mobile/fenix/issues/12752 - Temp disable intermittent failing test
4 years ago
Kainalu Hagiwara 5a895d6125 [fenix] No issue - Suppress new warnings from detekt update 4 years ago
Sawyer Blatz de6145c967 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12461: Add tab count to tab tray 4 years ago
Tiger Oakes 712dce391d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5499 - Unify CFR drawables and dimens (https://github.com/mozilla-mobile/fenix/pull/12749) 4 years ago
Hakkı Kaan Çalışkan 898defc3a2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12532: Quick fix for radio button alignment (https://github.com/mozilla-mobile/fenix/pull/12691) 4 years ago
Kainalu Hagiwara 3320f82bfb [fenix] For https://github.com/mozilla-mobile/fenix/issues/12551 - Implement swipe to delete for bookmarks. 4 years ago
Kainalu Hagiwara 0671fc50e8 [fenix] Rename tab_tray_background.xml 4 years ago
Michael Comella e85dd6a09c [fenix] No issue: correct position of StartupTimeline; add warning. 4 years ago
Sawyer Blatz 80b4fb0808 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10466: Add search privately to top of list (https://github.com/mozilla-mobile/fenix/pull/12744) 4 years ago
Tiger Oakes 5b7d951590 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/10924 - Cleanup SavedLoginsAuthFragment (https://github.com/mozilla-mobile/fenix/pull/10930) 4 years ago
Kainalu Hagiwara 055620f117 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12730 - Fix ripple for font size setting. 4 years ago
Sawyer Blatz d8ecc2e19c [fenix] For https://github.com/mozilla-mobile/fenix/issues/11851: Close tab tray when last tab closed (https://github.com/mozilla-mobile/fenix/pull/12615) 4 years ago
ekager b8b3d8b367 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10784 - Fixes memory leak in BrowserAnimator 4 years ago
Sawyer Blatz 54a6de9b84 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12735: Fixes issue with tab deletion undo (https://github.com/mozilla-mobile/fenix/pull/12737) 4 years ago
Hakkı Kaan Çalışkan 197a076ef2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12554: Helper class for password reveal on logins 4 years ago
mozilla-l10n-automation-bot 24f19cd763 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/12687) 4 years ago
Christian Sadilek 250c95eb28 [fenix] Update Android Components to 51.0.20200717190031 4 years ago
Tiger Oakes e740819acd [fenix] Fix lint issues (https://github.com/mozilla-mobile/fenix/pull/12683) 4 years ago
Tiger Oakes cb59729010 [fenix] Change enabled lint rules (https://github.com/mozilla-mobile/fenix/pull/12517) 4 years ago
Tiger Oakes 25a5f478ef [fenix] Test migration classes (https://github.com/mozilla-mobile/fenix/pull/12677) 4 years ago
Tiger Oakes a7bbc86f4a [fenix] Add tests for login exceptions (https://github.com/mozilla-mobile/fenix/pull/12681) 4 years ago
Tiger Oakes 5c9876dcff [fenix] Fix failure in handleWhatsNewGetAnswersClicked (https://github.com/mozilla-mobile/fenix/pull/12682) 4 years ago
Mihai Adrian Carare 3823c632ac [fenix] For https://github.com/mozilla-mobile/fenix/issues/7966: Update toolbar content description. (https://github.com/mozilla-mobile/fenix/pull/12667) 4 years ago
Elise Richards 508854ea07 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12532: Align Settings -> Site permissions -> Sub-pages to 72dp keyline (https://github.com/mozilla-mobile/fenix/pull/12680)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
Mihai-Eduard Badea 65c98d6c16 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9949 - Bookmarks/History deletion inconsistencies (https://github.com/mozilla-mobile/fenix/pull/12630)
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in https://github.com/mozilla-mobile/fenix/issues/8648.

Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
4 years ago
Tiger Oakes 549acfa6f1 [fenix] Test session control controller (https://github.com/mozilla-mobile/fenix/pull/12652) 4 years ago
Hakkı Kaan Çalışkan 415bbf6574 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12509: Set height of remove add on button to 36dp 4 years ago
ekager f7f80ad6cb [fenix] Update ContextMenuUseCases to just take a store 4 years ago
ekager 2deadc2e22 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12453 - Sets secure flags on private tab of tabs tray 4 years ago
ekager bc08df1c8f [fenix] For https://github.com/mozilla-mobile/fenix/issues/12364 - Only show PWA prompt the third time a user visits installable site 4 years ago
Tiger Oakes ded7cde177 [fenix] Add tests for adapters in collections (https://github.com/mozilla-mobile/fenix/pull/12649) 4 years ago
Kainalu Hagiwara 46a9bba6e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12531: Align Settings -> Private browsing to 72dp keyline (https://github.com/mozilla-mobile/fenix/pull/12654)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
Elise Richards 5b46f572df [fenix] For https://github.com/mozilla-mobile/fenix/issues/10173: login duplicates and save (https://github.com/mozilla-mobile/fenix/pull/11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
4 years ago
Tiger Oakes 046682f889 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12457: Add MockK matcher for intents (https://github.com/mozilla-mobile/fenix/pull/12612) 4 years ago
Mugurell ac85ba0945 [fenix] Ensure logins deletion (https://github.com/mozilla-mobile/fenix/pull/12507)
* For https://github.com/mozilla-mobile/fenix/issues/11227 - Cleanup saved logins list when one is selected

Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.

To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.

* For https://github.com/mozilla-mobile/fenix/issues/11227 - Refactor SavedLoginsView to be closer to MVI

- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
4 years ago
Tiger Oakes 2a7e8f7adb [fenix] Add tests for sync, wifi, and push (https://github.com/mozilla-mobile/fenix/pull/12581) 4 years ago
Tiger Oakes fe5b219a89 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Add Locale settings tests & use activity (https://github.com/mozilla-mobile/fenix/pull/12579) 4 years ago
jhugman 773884bdc4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12600 - remove AddonInstalled event when the permission dialog is shown (https://github.com/mozilla-mobile/fenix/pull/12601) r=csadilek,sblatz 4 years ago
Mihai Branescu 582fc2cff7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12201 - forced callbacks to be on the main thread (https://github.com/mozilla-mobile/fenix/pull/12543) 4 years ago