2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-11 13:11:01 +00:00
Commit Graph

1066 Commits

Author SHA1 Message Date
Tiger Oakes
55f5c5d049 Use lifecycleScope for settings fragments 2019-06-25 13:56:33 -07:00
Tiger Oakes
d01bb8c442 Use lifecycleScope for collections fragments 2019-06-25 13:56:15 -07:00
Tiger Oakes
6bf8d6be34 Use @JvmOverloads instead of multiple constructors 2019-06-25 13:55:31 -07:00
Colin Lee
94e99cf877
For #3364: Edit bookmarks should show corrected bookmarks tree (#3446) 2019-06-25 14:19:33 -05:00
Emily Kager
74111c75de For #3639 - Remove fontInflationEnabled (#3640) 2019-06-25 10:24:32 -05:00
Emily Kager
ddebc98718 No issue: Follow up on optional filter style 2019-06-24 17:03:38 -07:00
Colin Lee
ea7841b8c5 No issue: Add Sentry breadcrumbs to ease crash investigations 2019-06-24 16:21:43 -07:00
Denys M
6d6b240e48 Add unit tests for Settings.
Add unit tests for `Settings`.
2019-06-24 16:02:34 -07:00
Emily Kager
718ac5612c For #3593 For #3581 - Pass sessions to delete to delete all with undo (#3594) 2019-06-24 15:41:38 -07:00
Emily Kager
084fab77d4 For #3609 - Remove FIP Integration, Use FIP Feature (#3637) 2019-06-24 15:31:32 -07:00
Emily Kager
6e3197f61c For #3622 - Add ID to engine shortcut suggestions (#3636) 2019-06-24 15:30:27 -07:00
royang51
e244aae104 For #3214 - History multi-selection aborted, the same item can't be selected again (#3607) 2019-06-24 15:27:06 -07:00
Sawyer Blatz
07516f47c3
For #3215: Adds collection restoration with unique IDs (#3635) 2019-06-24 14:12:51 -07:00
vmbaicu
021900e7ad Fixes #3527 - Set Collection name max length (#3531) 2019-06-24 13:58:04 -07:00
Nikit Bhandari
cfefc5632b For #3489: Disables blank collection names (#3490) 2019-06-24 13:44:02 -07:00
Andrei Teslovan
2ebe0a2a48 Fixes #3529 - Display "Edit folder" title when editing a bookmark folder (#3549) 2019-06-24 13:34:15 -07:00
Emily Kager
03a5cb2fb4 For #3620 - Adds automatic theme onboarding content description (#3629) 2019-06-24 13:15:38 -07:00
Sawyer Blatz
a5a518f4a5
For #2940: Hides send tab on FxA error (#3595) 2019-06-24 12:52:20 -07:00
Sawyer Blatz
721908ade6
For #3055: Adds android components version to about page (#3596) 2019-06-24 12:52:04 -07:00
Colin Lee
22bcd70edc
For #3213: Fix multi-select bookmarks on return to fragment (#3413) 2019-06-24 10:10:49 -07:00
Emily Kager
afb59251c1 For #3588 - Preload the content process when starting Gecko (#3589) 2019-06-20 13:00:22 -07:00
Emily Kager
b1102c2e76 For #3544 - Set SearchSuggestions preference value from settings 2019-06-18 16:56:34 -07:00
Tiger Oakes
ab6101b0f4 Fixes #3539 - vectordrawablecompat for gradients (#3541) 2019-06-18 16:38:56 -07:00
Tiger Oakes
b70dced16e Fixes #3538 - Fix ic_tabs icon path (#3540) 2019-06-18 16:38:42 -07:00
Colin Lee
0135424883 For #3508: "Send crash report" checkbox is ignored (#3512) 2019-06-18 16:38:29 -07:00
Grisha Kruglov
521312c6f8 Disable send tab for non-nightly, non-debug builds (#3542)
* Put deviceCapabilities list behind a SEND_TAB_ENABLED flag

* Disable SEND_TAB for non-debug, non-nightly builds
2019-06-18 16:37:50 -07:00
Mihai Tabara
ccc5b91992 Import PR 3500 from ekager 2019-06-14 18:52:27 -07:00
Stefan Arentz
6e6e662c47 Update HomeFragment.kt 2019-06-14 18:34:58 -07:00
Jeff Boek
90bdbd04e0 No Issue - Capture session manager in scope before creating the delete operation 2019-06-14 18:34:58 -07:00
Emily Kager
ac5c4a0f79 Closes #3493 - Show tab saved to collection snackbar in BrowserFragment 2019-06-14 15:49:56 -07:00
Jeff Boek
7ebdfcc87b For #1116 - Uses alias link for help 2019-06-14 15:33:34 -07:00
Jeff Boek
5540230e3d For #1116 - Changes help link (#3491) 2019-06-14 15:29:10 -05:00
Jeff Boek
3b848393f7 For #981 - Adds link to mma.md to telemetry.md 2019-06-14 13:27:50 -07:00
Jeff Boek
45b096c84f For #981 - mma docs 2019-06-14 13:27:50 -07:00
Jeff Boek
f323c38be0 For #981 - Adds missing Leanplum events 2019-06-14 13:27:50 -07:00
Emily Kager
6bd9b82385 No issue: Remove flash of tab adapter updating data in create collection 2019-06-14 11:01:54 -07:00
Colin Lee
d5c5587a0c
For #3209: Disable shared element animations for crash temporarily (#3482) 2019-06-14 12:13:13 -05:00
Sawyer Blatz
041eaa2a5c
For #3275: Cleans up feedback from James (#3398) 2019-06-14 08:59:57 -07:00
Emily Kager
e28277693b Closes #3428 - Make + in collection creation selection stage clickable 2019-06-13 22:37:47 -07:00
Jonathan Almeida
986bc91347 For #3401: Update toolbar tab counter when view is attached
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-06-13 16:12:19 -07:00
vladikoff
dfe181aa0a Add application-services fretboard feature flags 2019-06-13 15:29:59 -07:00
Emily Kager
8b4c2db4e4 For #3433 - Add checkbox hide changes to change payload 2019-06-13 13:01:44 -07:00
Emily Kager
1f1320920f For #3275 - Invoke pending single session delete job on close all (#3438) 2019-06-13 12:58:45 -05:00
Jeff Boek
1212887e08 For #1242 - properly record metrics (#3437) 2019-06-13 09:57:56 -07:00
Emily Kager
510b6f7373 For #2899 - Improve collections scroll and highlight animations 2019-06-13 09:21:12 -07:00
Andrei Teslovan
e458d8b6a1 Fixes #3365 - Set selectedFolder to null if it's already selected (#3415) 2019-06-13 10:52:35 -05:00
Emily Kager
5eb2bc6d55 For #3138 - Sets height of toolbar in SearchFragment to match_parent (#3400) 2019-06-12 19:44:44 -05:00
Sawyer Blatz
381a5e6089 For #3403: Subscribes to tab collections in BrowserFragment 2019-06-12 16:44:35 -07:00
Jeff Boek
227a80957e For #382 - Include Marshmellow in the guard.. 2019-06-12 15:45:58 -07:00
Jeff Boek
dad671ca3c For #382 - Hides default browser switch for older versions of Android 2019-06-12 15:07:58 -07:00
Jonathan Almeida
1b7a9817e2 For #2905: Remove device name during sync logout 2019-06-12 17:07:56 -04:00
Jonathan Almeida
f71bdcfd10 For #3388: Set max length for device name (#3397) 2019-06-12 15:35:06 -05:00
Colin Lee
f1088222b4
For #3203: Updates edit bookmarks to have user friendly names (#3372)
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
2019-06-12 14:10:43 -05:00
Emily Kager
186983b786 For #3275 - Adds PendingSessionDeletion data class to handle multiple emit session calls (#3393) 2019-06-12 10:49:20 -07:00
Jonathan Almeida
80e7868fd7 For #1134: Set UA to GeckoView 69.0 for whitelisted domains 2019-06-12 13:27:42 -04:00
Sawyer Blatz
7bcc8d576e For #2219: Inflates toolbar menu from bottom (#3389) 2019-06-12 11:17:33 -05:00
Colin Lee
66a836cf3a
For #3314: Toolbar and QAB unresponsive after Android 6 perms check (#3373) 2019-06-12 10:08:39 -05:00
Jeff Boek
332b4c4da5 For #3278 - makes the string a constant 2019-06-11 16:24:28 -07:00
Jeff Boek
fc603e65a5 For #3278 - Removed redundant override 2019-06-11 16:24:28 -07:00
Jeff Boek
fead5183c8 For #3278 - pin the default search engine to the top 2019-06-11 16:24:28 -07:00
Jeff Boek
a86ec60f8f For #3278 - Fixes search engine selector layout 2019-06-11 16:24:28 -07:00
Emily Kager
71f2b0bdaa For #2253 - Use toolbar as anchorView with fullscreen snackbar 2019-06-11 15:09:07 -07:00
Christian Sadilek
ccc7c70967 For #3252: Reader mode appearance buttons are not visible in PB
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-11 18:02:29 -04:00
a79014
d2c3427f1e Doesn't print gecko emoji on android ver < 7 (android N) (#3115)
* Doesnt print gecko emoji on android ver < 7

* fixed typo on maybeGecko variable

* Closes #3076: Lizard char now doesn't appear if not supported androidver

* Closes #3115: Prints string instead of gecko emoji in unsupported
android versions
2019-06-11 16:40:51 -05:00
Emily Kager
edc1422b68 For #3288 - call setChecked after calling setOnCheckedChangeListener (#3357) 2019-06-11 16:38:32 -05:00
Colin Lee
b498f5559b
For #3333: Only show desktop bookmarks if logged in (#3356) 2019-06-11 16:37:34 -05:00
jhugman
26d0ddda98 Fixes #3358 - disable feature-app-links (#3359) 2019-06-11 16:34:28 -05:00
Emily Kager
de45dfd98a For #3131 - Add new task and clear task flags when opening intent (#3363) 2019-06-11 16:33:38 -05:00
Gabriel Luong
f05eb032d4 For #2684: Add an extension function Session.toTab to map Session to Tab and clean up their usage 2019-06-11 13:14:23 -07:00
vmbaicu
a2f2a23a15 Fixes #3281 - Fix Report and onboarding lint errors and issues (#3339) 2019-06-11 12:33:12 -05:00
Sawyer Blatz
3e5b6ca007 For #975: Removes leakcanary and default browser telemetry (#3350) 2019-06-11 12:30:25 -05:00
Emily Kager
82cf81242f For #3331 - Delay restoring layout while list restores (#3354) 2019-06-11 12:27:32 -05:00
Sawyer Blatz
decacbfc97 For #3323 Runs PublicSuffixList synchronously 2019-06-11 09:19:51 -07:00
Grisha Kruglov
a58a77317e Automatically close the 'auth-problems fragment' once we're through the auth flow (#3340) 2019-06-11 09:36:05 -05:00
Emily Kager
e57e7b50ee For #2899 - Scroll to Collections on change, animate new collections (#3279)
* For #2899 - Scroll to Collections on change, animate new collections

* For #2899 - Scroll to tabs when tabs opened from collection
2019-06-11 09:01:00 -05:00
Emily Kager
975975e789 For #3326 - Remove open image in tab from context menu (#3327) 2019-06-11 08:59:00 -05:00
Sawyer Blatz
c17d024452
For #975: Adds preferenceToggled event (#3316)
🤦🏼‍♂️
2019-06-10 13:56:12 -07:00
Sawyer Blatz
ab000d2e51
For #3280: Revert "For #3215: Restores collections properly" (#3320)
This reverts commit 3e9ee79c00f4a6b34af74ce7c179e0cbe37decf5.
2019-06-10 13:54:03 -07:00
Arturo Mejia
5df726715f Revert "For #3008, For #2162 Add Simple Logic for Menu Orientation" (#3310)
#3114
2019-06-10 10:58:18 -05:00
Colin Lee
f7b5fc3e18
For #3186: Add environment to Sentry reports (#3261) 2019-06-10 10:55:39 -05:00
Tiger Oakes
82d2a0661b Remove deprecatd support-ktx methods (#3305) 2019-06-10 09:12:11 -05:00
Denys M
c9570fd6ff Use Drawable.toBitmap() from androidx-ktx. (#3286) 2019-06-10 08:50:37 -04:00
Nikit Bhandari
d814e95794 fix crash on renaming a collection 2019-06-08 06:44:15 -07:00
Sawyer Blatz
86aac3e313 For #3176: Hides camera options on devices without cameras (#3273) 2019-06-07 19:37:43 -05:00
Emily Kager
bf4916418a For #1998 - Removes stable flag in entering fullscreen navigation 2019-06-07 15:20:30 -07:00
Sawyer Blatz
b2ca77269b
For #3251: Fixes shortcut typing (#3271) 2019-06-07 15:07:46 -07:00
Sawyer Blatz
054635735a
For #2750: Removes unecessary invalidate CollectionViewHolder call (#3264) 2019-06-07 13:38:18 -07:00
Sawyer Blatz
45c509fbce
For #2648: Updates trimming of url hostname (#3191)
* For #2648: Updates trimming of url hostname

* For #2648: Fix nits
2019-06-07 09:33:07 -07:00
Emily Kager
7368a95d29 No issue: Sets up observers for tab collection changes (#3248) 2019-06-07 09:45:38 -05:00
Jonathan Almeida
f7bd39da77 For #3138: Fix white background on search bar 2019-06-06 17:11:06 -07:00
Colin Lee
1e6da54263 For #3238: fixes race condition crash, nav destination unknown 2019-06-06 15:46:34 -07:00
Jonathan Almeida
0a3b001abe For #3167: Show help page in browser menu (#3230) 2019-06-06 16:55:15 -05:00
Emily Kager
acea0d5668 For #2785 - Adds back item animator session control (#3233) 2019-06-06 16:54:49 -05:00
Emily Kager
ed39b7828b For #3234 - Updates labels of fragments in the nav graph to avoid flash (#3235) 2019-06-06 16:52:25 -05:00
Jeff Boek
0fefbbf5fb For #1809 - Restore all crashed tabs 2019-06-06 12:58:32 -07:00
Sawyer Blatz
8537ff10a8 For #3215: Restores collections properly (#3219) 2019-06-06 14:26:05 -05:00
Emily Kager
4954aadd84 For #3156 - If only one tab adding to collection make it selected (#3222) 2019-06-06 14:24:25 -05:00
Colin Lee
28ecf241f5
For #1301: Always observe sessions to keep uri_count (#3172) 2019-06-06 14:16:31 -05:00
Sawyer Blatz
6682386fc8 For #1242 & #975: Fixes camelcase of telemetry 2019-06-06 10:59:09 -07:00
Denys M
605a552f16 For #1366. Update toolbar search state when typing. (#2908) 2019-06-06 08:16:22 -07:00
Emily Kager
33eb26861d For #3141 For #3142 Do not try to fade BrowserFragment in transitions (#3195) 2019-06-05 20:37:58 -05:00
Emily Kager
9624964bc3 For #3087 - Adds disabled color attr (#3192)
* For #3087 - Adds disabled color attr

* Change alpha to 40%
2019-06-05 20:37:16 -05:00
Emily Kager
93a5456785 For #2253 - Shorten Fullscreen snackbar length (#3190) 2019-06-05 20:36:13 -05:00
Emily Kager
704f1e6a3d For #3004 - Restore MotionLayout on Home View only in onCreateView 2019-06-05 14:46:38 -07:00
Grisha Kruglov
fe3c163a20 Fix how we reflect FxA state in preference
This cleans up how we're displaying account state in the main preference UI.
Before when it worked, it worked mostly accidentally.
'launch' wrapper around "update ui" methods would trigger a race condition
between binding the account pref view holder and actually updating that view
with values. Sometimes the "update view with values" would happen after view
was bound, and the UI will be correct. Most of the time it would happen before,
and so there will be nothing to update and we'd get into an inconsistent state.

This also splits up the "accountpreference" into two: account is good,
and account needs re-auth. This greatly simplifies their management.
2019-06-05 14:38:06 -07:00
Grisha Kruglov
0e1d81126d Make 'remove account' work on the "reconnect to sync" screen
This seems to have been copy-pasted and wasn't hooked up correctly.
2019-06-05 14:38:06 -07:00
Grisha Kruglov
7af61b1560 Navigate away from account settings after encountering auth problems 2019-06-05 14:38:06 -07:00
Sawyer Blatz
47c14b07dd For #1190: Removes syncing items from FxA telemetry 2019-06-05 13:57:18 -07:00
Sawyer Blatz
c4c5d44430 For #975: Updates telemetry for settings (#3171) 2019-06-05 13:34:42 -05:00
Sebastian Kaspari
b2d81aba43 Issue #2381: Add feature-media component and enable notification for recording devices. 2019-06-05 20:20:44 +02:00
Jeff Boek
27fdd9605b For #2395 - Adds an early return statement and documents why we copy a feature 2019-06-05 10:47:21 -07:00
Jeff Boek
f26c402f0a For #2395 - Properly takes you back to where you start authentication on completion 2019-06-05 10:47:21 -07:00
Sawyer Blatz
12eabd5eb3 For #977: Listens to correct custom tab open menu fact 2019-06-05 09:34:50 -07:00
mythio
2daa75db2c Closes #3000: Replace deprecated method 2019-06-05 09:33:58 -07:00
Emily Kager
14c581c012 For #3004 - Do not restore motionlayout state in ReloadData 2019-06-05 09:33:07 -07:00
Emily Kager
94881f8241 For #3135 - Reduce swipe to delete sensitivity 2019-06-04 16:10:28 -07:00
Sawyer Blatz
0b3a8b7a54 For #2316: Adds confirmation dialog to delete bookmark 2019-06-04 14:47:11 -07:00
Sawyer Blatz
8e24feefc2 For #1192: Updates detection for Lockwise 2019-06-04 11:23:18 -07:00
ekager
87f6268816 For #3101 - Do not show tab selection screen for 1 tab 2019-06-04 10:08:43 -07:00
Emily Kager
dc0d153580 For #3008, For #2162 Add Simple Logic for Menu Orientation (#3114)
* For #3008 - Adjust orientation of collections menu based on view location

* For #2162 - Add simple menu orientation logic to bookmark menu
2019-06-04 10:37:57 -05:00
Emily Kager
ef0618a3d1 For #3103 - Exit fullscreen on pause (#3112) 2019-06-04 10:36:16 -05:00
Emily Kager
ca186c8776 Closes #1618 - Add fade to awesome bar list instead of shadow (#3110)
* Closes #1618 - Add fade to awesome bar list instead of shadow

* For #1211 - Hide keyboard on fling suggestions list
2019-06-04 10:35:47 -05:00
Colin Lee
5fb100debd
For #1966: Up button should cancel multi-selection first (#3108) 2019-06-04 10:08:06 -05:00
Jeff Boek
40a3246c32 Adds dialog style for Firefox Accounts 2019-06-03 19:08:26 -07:00
Colin Lee
04a759f0b0
For #2693: Launching Fenix via adb with URL crashes (#3099) 2019-06-03 16:24:37 -05:00
Tiger Oakes
94c4013810 Closes #3091 - Hide Pull to Refresh under flag (#3092)
This was merged in after feature freeze so we're pulling it out for
now. Pull to refresh will continue to work in debug mode so that the
design can be iterated on easily.
2019-06-03 14:10:53 -05:00
Colin Lee
04bbeb5ae6 For #3073 'Open in Firefox Preview' no longer opens in app
Saving and restoring the custom tab session ID fixed one problem while causing another. I added code to only restore the ID if the session has a customTabConfig associated.
2019-06-03 10:04:17 -07:00
Mitchell Hentges
62473e5e86
Migrates "raptor" build type to work for chrome-perf-testing, too (#2926) 2019-06-03 16:32:38 +02:00
ekager
d285e799b9 Clean up logic to return margin pairs for readability 2019-06-03 10:00:00 -04:00
ekager
14fe356d62 For #2794 - Adjust engine margins when enter/exit fullscreen 2019-06-03 10:00:00 -04:00
ekager
98a40aabd7 For #2223 , For #371 - Replace Toolbar with FIP when opened 2019-06-01 10:24:55 -07:00
ekager
388581f76f For #3056 - Filter sessions on invoke for pending delete all job 2019-05-31 18:52:02 -07:00
Jeff Boek
e15ab3f958 For #1158 - Use a dot instead of an underscore to seperate values 2019-05-31 18:15:07 -07:00
Colin Lee
532483498a
No issue: Store the Custom Tab Session ID to avoid a crash (#3062) 2019-05-31 17:03:58 -05:00
Arturo Mejia
038aecc0ee For #1919- Websites' icons are not displayed on Site permissions (#3050)
Exceptions.
2019-05-31 16:27:12 -05:00
Emily Kager
d5a9627273 For #2941 - Remove Delete Dialog, Theme Dialogs (#3052) 2019-05-31 16:26:34 -05:00
Emily Kager
0327b1146b For #2977 - Update add new collections flow (#2991)
* For #2977 - Update add new collections flow

* Rename shared elements to be more general

* Make tab list not clickable in other modes

* For #2577 - Stop Flickering in List

* Add extensions function for next step with collections list size
2019-05-31 12:59:51 -05:00
Emily Kager
f48db90716 No issue: Always try to pop to browser when navigating to browser (#3043) 2019-05-31 12:57:34 -05:00
Jeff Boek
14f1d40e10 Fixes #3041 - Fixes the string that gets displayed in the FxA Onboarding card 2019-05-31 10:44:14 -07:00
James Hugman
060cd646c8 Fixes #1570 - Enable app-links feature 2019-05-31 10:39:47 -07:00
Sawyer Blatz
35a745d67d For #2836: Fixes custom tab close button color 2019-05-31 09:50:46 -07:00
Jeff Boek
301984733a For #225 - Adds completion snackbar 2019-05-31 09:42:44 -07:00
Jeff Boek
eda70ab74c Fixes #3037 - Unchecks boxes after deletion 2019-05-31 09:42:44 -07:00
Jeff Boek
0036938312 For #225 - Fixes crash by moving GeckoView calls t othe main thread 2019-05-31 09:42:44 -07:00
Emily Kager
1bb4d72fd1 For #3027, For #2858 Pass in Fenix Snackbar for Context Menu Candidate (#3028) 2019-05-31 10:16:08 -05:00
Jonathan Almeida
ab39a5088a For #2052: Fix BrowserToolbar overlapping web content 2019-05-30 20:40:56 -04:00
Jeff Boek
209b50016e For #2723 - Cleans up code formatting 2019-05-30 16:38:31 -07:00
Jeff Boek
f9d70dbc92 For #2723 - Creates callbacks to wire up the mode and theme manager together 2019-05-30 16:38:31 -07:00
Jeff Boek
a7d5cdcb9d For #2723 - Fixes theme manager 2019-05-30 16:38:31 -07:00
Emily Kager
18cd9e58f9 Fixes Crash: Pop up to Browser Fragment if exists when coming from Search 2019-05-30 16:30:06 -07:00
Emily Kager
8dbed67f7f No issue: Simplify and speed up shared element transitions 2019-05-30 16:30:06 -07:00
Emily Kager
43a961fe73 For #1973 - Toggle QR button on deny permissions, fix engineView crashes 2019-05-30 16:06:37 -07:00
Colin Lee
72c5cb304c
For #2893, #2673, #2916, #2314: Fix race condition navigating to browser (#3023)
Since the Navigation library restores the fragment after memory eviction, if we're already on the BrowserFragment and we deep link navigate to the BrowserFragment, we briefly get two of them. This crashes GeckoView.
2019-05-30 17:43:32 -05:00
Emily Kager
4c970a545d For #2230 - Fix theme selection radio button for Android 6 (#3019) 2019-05-30 17:06:46 -05:00
Tiger Oakes
74dd2a5f23 Issue #103 - Pull to refresh (#3020) 2019-05-30 17:05:49 -05:00
Sawyer Blatz
cd19f36b96 For #2227: Fixes issue with bookmark selection (#3021) 2019-05-30 17:01:51 -05:00
Sawyer Blatz
9e0e5d95d9 For #2931: Show browser snackbar above quick action sheet 2019-05-30 14:52:09 -07:00
Sawyer Blatz
5e0771a6f0 For #2327: Fix early return from displayAccountError 2019-05-30 13:45:56 -07:00
Sawyer Blatz
7fff475fd8 For #1679: Pause media playback when backgrounded 2019-05-30 13:06:37 -07:00
Jeff Boek
0054e017ea For #255 - Moves all deletion operations to the same coroutine 2019-05-30 13:05:51 -07:00
Christian Sadilek
0b00c0ce9b No issue: ClipboardProvider no longer needs to be added/removed based on input 2019-05-30 13:03:50 -07:00
Emily Kager
3685b05586 For #3011 - Size EngineView for Custom Tab Fixed Toolbar 2019-05-30 12:40:54 -07:00
Emily Kager
c027feecd0 For #3011 - Size EngineView for Custom Tab Fixed Toolbar 2019-05-30 12:40:54 -07:00
Sawyer Blatz
b8c04e02e9 For #2327: Fixes nits 2019-05-30 11:45:39 -07:00
Sawyer Blatz
fe50e88fc8 For #2327: Adds error state syncing 2019-05-30 11:45:39 -07:00
Emily Kager
caa36c31cd For #2979 - Prevent double navigation to Create Collection Fragment 2019-05-30 10:58:56 -07:00
Grisha Kruglov
5f42a65c2a No issue: improve allowUndo
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on

New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
2019-05-30 10:48:59 -07:00
Emily Kager
3560e1793c For #2980 - Pop to home if no session exists in Browser Fragment 2019-05-30 09:05:10 -07:00
Emily Kager
c589e4d4c3 For #2938 - Remove save to collection from PB browsing menu 2019-05-30 08:42:20 -07:00
Emily Kager
e61cebf38d No issue: Check search engine icon exists before setting drawable 2019-05-30 08:33:30 -07:00
Denys M
8bed44819d Fixes #2254/#2709. Observe browser sessions changes on HomeFragment. 2019-05-29 15:13:15 -07:00
Jeff Boek
6527e05405 For #2738 - Re-throws exceptions to send better data into the crash reporters 2019-05-29 13:33:36 -07:00
Emily Kager
f142be8c92 Refactor new param to startInEditMode 2019-05-29 12:27:48 -07:00
Emily Kager
d6c1f65d72 Start MotionLayout animation to end while navigating to search fragment 2019-05-29 12:27:48 -07:00
Emily Kager
8181705b58 Init Toolbar in edit mode so we don't see the flash 2019-05-29 12:27:48 -07:00
ekager
dee3c059dc Adds Shared Transition between Home and Search 2019-05-29 12:27:48 -07:00
Jeff Boek
3920cda693 For #2419 - Adds a deletion state to the history component 2019-05-29 12:20:19 -07:00
Denys M
39df4c8522 For #747. Improve HistoryFragment readability. 2019-05-29 10:21:48 -07:00
Denys M
13f144f212 For #747. Fix coroutines leaks in HistoryFragment. 2019-05-29 10:21:48 -07:00
Jonathan Almeida
b05e9ab14b Closes #2968: Specify the activity name in the share item 2019-05-29 13:12:46 -04:00
Grisha Kruglov
70453ef2d5 No issue: increase likelyhood of notification showing up as 'heads-up' 2019-05-29 09:52:35 -07:00
Grisha Kruglov
fda0f1de97 No issue: sync and refresh device state on foreground 2019-05-29 09:52:35 -07:00
Emily Kager
039990f608 For #2972 - Call session feature back press before custom tab back press 2019-05-29 09:40:52 -07:00
Grisha Kruglov
9e7269214c Closes #2835: Do not assume bookmarks fragment is attached while processing operations
This is mostly necessary when we're running stuff in a coroutine, so the patch likely goes
overboard a bit with the nullability checks... but it shouldn't hurt.
2019-05-29 09:19:03 -07:00
Sawyer Blatz
6a53127ef9 For #2948: Adds menu button add tab to collection 2019-05-29 09:08:11 -07:00
Sawyer Blatz
3fd831cc4d Fixes #2942: Updates strings for l10n (#2950) 2019-05-29 10:47:19 -05:00
Emily Kager
1ef85433b4 For #2891 - Make checkbox invisible so text isn't cut off 2019-05-28 20:57:02 -07:00
Emily Kager
6290d7b890 For #2110 - Pressing back on external link should close the tab 2019-05-28 17:55:17 -07:00
Emily Kager
cae95c0ee1 For #2952 - Delete All Tabs should run on Main Thread 2019-05-28 16:25:39 -07:00
Arturo Mejia
b2e27d26dc Closes #2903: Fixed crash when trying to rate the app on a devices without
the play store app.
2019-05-28 15:14:56 -07:00
Jonathan Almeida
540b0939d2 Closes #2878: Cleanup with card-like styling 2019-05-28 15:11:41 -07:00
Arturo Mejia
b5d1d04d88 Closes #2900: Fix crash when trying to show site info panel with
a null session.
2019-05-28 15:05:49 -07:00
Jonathan Almeida
3da6cfd98a For #2886: Fix sending multiple tabs to another device (#2923)
* For #2886: Fix sending multiple tabs to another device

* Update share methods to use new API
2019-05-28 15:05:16 -07:00
Arturo Mejia
ba6bb916e4 Closes #2789: Custom tabs is not covering the full screen size. 2019-05-28 15:01:18 -07:00
Emily Kager
bfc0fa36b1 For #2133 - Add destructive text color to delete history button 2019-05-28 14:59:21 -07:00
Emily Kager
506f332b85 For #2919 - Invoke Pending Delete Jobs in onPause 2019-05-28 14:59:05 -07:00
Emily Kager
a6a72885d2 For #2898 - Adds Deselect All in Collection Creation Select Tabs Step 2019-05-28 14:58:16 -07:00
Emily Kager
e0ceb195ff For #2337 - Open Report Site in Browser from Custom Tab 2019-05-28 14:56:01 -07:00
Emily Kager
7d65e21b83 For #2941 - Creates delete dialog style 2019-05-28 13:41:38 -07:00
Emily Kager
250548a72f For #2823 - Invoke pending jobs with context on switch to private mode 2019-05-28 12:48:02 -07:00