Commit Graph

318 Commits (4de1edaa19061288a4a262422b59d1b56bc15e66)

Author SHA1 Message Date
Tiger Oakes 422faaf7c0 Add toolbar helpers (#6531) 5 years ago
mcarare 1d36098878 For #1019 Add onboarding search suggestion hint panel 5 years ago
mcarare 5543f3272d For #1019 Add option to enable search suggestions in private mode 5 years ago
mcarare ef3c3de8a1 For #6625 Fix back navigation in search mode from browser 5 years ago
ekager 81ab082c1c For #6707 #6708 - Fix UI Tests for new Search Engine Behavior 5 years ago
Jeff Boek 607c3d4c87
Adds custom search engines (#6551)
* For #5577 - Adds button to add a new search engine

* For #5577 - Adds custom engine store

* For #5577 - Creates a custom SearchEngineProvider

* For #5577 - Gives the ability to delete search engines

* For #5577 - Adds the UI to add a custom search engine

* For #5577 - Adds form to create a custom search engine

* For #5577 - Adds the ability to add a custom search engine

*  For #5577 - Adds the ability to delete custom search engines

* For #5577 - Selects the first element on the add custom search engine screen

* For #5577 - Prevents adding a search engine that already exists

* For #5577 - Styles the add search engine preference

* For #5577 - Makes the name check case-insensitive

* For #5577 - Fix bug where home screen doesnt see new search engines

* For #5577 - Moves Search URL validation to its own type

* For #5577 - Fixes linting errors

* For #5577 - Adds the ability to edit a custom search engine

* For #5577 - Allows the user to edit a serach engine even when it is the last item in the list

* For #5577 - Adds an undo snackbar when deleting a search engine

* For #5577 - Moves all of the strings to be translated

* For #5577 - Fixes bug when deleting your default search engine

* For #5577 - Puts adding search engines behind a feature flag

* For #5577 - Navigate to custom search engine SUMO article when tapping learn more

* For #5577 - Fixes nits

* For #5577 - Uses concept-fetch to validate search string

* For #5577 - Adds string resources for the cannot reach error state
5 years ago
Mihai Adrian 1388156953 For #1211 Hide the keyboard when scrolling through engine suggestions (#6474) 5 years ago
Sawyer Blatz 0d5fb67303 For #6284: Fixes SearchShortcut button functionality when in a session
This makes it so searchShortcuts button works when going from browser -> search
5 years ago
Mihai Branescu 2b955c1a1a For #6087
- added engine hashmap so that we create each type of search provider once
(previously the providers to be added were checked by id, but since the id
is a UUID, it was always unique -> bug with multiple providers with same engine
but different id
- refactored update() flow so that it's more understandable + remove complex
method warning
5 years ago
Sebastian Kaspari 9543f38978 Use new toolbar API of AC 18.0.0. 5 years ago
Mihai Branescu 2be4d08228 For #6018 - Added back shortcuts button in awesomebar
Refactored logic for adding providers, since shortcut providers should
be alone in the list, while all others can be as list
5 years ago
shldhll 8e17ac05b1 Optimized imports. Closes #5876 5 years ago
shldhll f907ec52f0 Removed ObsoleteCoroutinesApi in tests. Closes #5876 5 years ago
Sawyer Blatz 4045fb0107 For #4190: Removes waterfall animation from awesomebar 5 years ago
Sawyer Blatz 19a2d9df4f For #1620: Hide search results when they match URL 5 years ago
Sawyer Blatz 785b8b9519
For #5567: Removes search shortcuts button (#5739)
* For #5567: Removes search shortcut button

* No issue: Simplifies logic for displaying shortcuts
5 years ago
Emily Kager 3f41a4e9c6 No issue: Update navigation library 5 years ago
Tiger Oakes 8c30200ced Only use Context.settings() function (not getter) (#5335)
Remove unused String extensions
5 years ago
Sawyer Blatz f02603be37
For #5460: Fixes styling of fill link from clipboard (#5464) 5 years ago
Sawyer Blatz 2db2d9ceae For #1744: Adds tests for clipboard 5 years ago
Sawyer Blatz e961a9d63d For #1744: Adds clipboard provider to search engine screen 5 years ago
Tiger Oakes 284cbab9ea Use .orEmpty() 5 years ago
Sawyer Blatz fdd2b59fb8 For #4155: Adds popup menu for browser toolbar 5 years ago
Mihai Adrian a31eb1f371 Code Health #4883: Refactored accessing settings by using Context extensions (#4973) 5 years ago
Sawyer Blatz 2653b5966e
For #964: Adds ability to disable each suggestion provider (#5096)
* For #964: Adds ability to disable each suggestion provider

* Fix nit
5 years ago
Sebastian Kaspari 38d97fda8b Stores: Reduce visibility of reducer functions. 5 years ago
Sebastian Kaspari 61e84c161d Rename SearchStore/State/Action to SearchFragmentStore/State/Action. 5 years ago
Christian Sadilek 4cf03be236 For #2088: Use new async API to load default search engine in HomeFragment 5 years ago
Will Hawkins 3abffd5d77 Use new async API to load and access search engines
Use the new asynchronous features of the search engine
manager from a-c to avoid the latency required to load
the default search engine.
5 years ago
Emily Kager b9f6f7fa93 For #4779 : Don't double navigate with global directions in HomeActivity 5 years ago
Emily Kager 416e25e8a5 No issue: Don't show session provider in private mode 5 years ago
Sourabh 1afc0eacd8 For #4399: Create LibState Controller for Search (#4673)
* For #4399: Create LibState Controller for Search

* fix code format

* add unit tests for DefaultSearchController

* add more test

* fix unit tests
5 years ago
Yeon Taek Jeong d4c83f9668 For #4736: Display search shortcuts only from home or search widget 5 years ago
Yeon Taek Jeong 2f265eccbd
For #4732: Fix search engine display issue (#4735) 5 years ago
Tiger Oakes 52542708aa Consodilate private browsing code 5 years ago
Emily Kager 0b98d43c23 Closes #4602 - Add back transitions 5 years ago
Sawyer Blatz da06b0fb15
For #4508: Treats warnings as errors (#4543) 5 years ago
ValentinTimisica 59c60ef189 Fixes #4354: Updated SearchFragment state after returning from SearchEngineFragment.
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
5 years ago
Yeon Taek Jeong 6f962d3376
For #1744: Open search shortcuts when entering search mode (#4536) 5 years ago
Nikit Bhandari 671727c3e8 For #4341 use camelCase for views referenced from code 5 years ago
Yeon Taek Jeong 83ceec6289 For #201: Search Widget 5 years ago
Nikit Bhandari 46de06d132 For #4339 reduce build warnings (#4340) 5 years ago
Amaan Marfatia 4c13f45e9e Fixes #4192: Private keyboard in private browsing (#4345)
Sets compliant keyboards to private mode when in private browsing.
5 years ago
Sawyer Blatz 6fa022c2f8
For #4124: Migrate BrowserToolbar to Libstate (#4279)
* For #4124: Migrate BrowserToolbar to Libstate

* Restores QuickActionSheetReducer

* Improve tests

* Make QuickActionSheetController

* Finalize tests

* Breaks out QuickActionSheetState

* Fix comments

* Adds BrowserStoreTest
5 years ago
Tiger Oakes c2e6e25bef Fixes #4005 - Move getColorFromAttr to Context 5 years ago
Colin Lee 48aeb19db1
For #3695: Make SessionSuggestionProvider link to existing tab (#4280) 5 years ago
Christian Sadilek 1846a61475 For #4096: Use new A-C API to observe store / state changes
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
5 years ago
Sawyer Blatz 28eb5c541a
For #1944 & #1750: Updates private & night mode colors (#4232) 5 years ago
Tiger Oakes edb0a3ed08 For #3633 - Update StoreProvider to use a callback
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
5 years ago
Christian Sadilek c04dcec03f Closes #4096: IllegalStateException in SearchFragment (#4131) 5 years ago
Jeff Boek ec099a6e11
For #3633 - Creates generic store provider (#4060) 5 years ago
Christian Sadilek e91a2e61a2 For #3633: Add unit tests for SearchStore 5 years ago
Jeff Boek e4ff70c542
For #3633 - Refactors the search screen to use lib-state
* For #3633 - Adds SearchStore

* For #3633 - Refactors AwesomeBarUIView

* For #3633 - Refactors ToolbarUIView to use lib-state

* For #3633 - Fixes a couple of state bugs

* For #3633 - Moves all user interaction to SearchInteractor

* For #3633 - Adds kdocs to SearchStore and SearchInteractor

* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property

* For #3633 - Creates `StateViewModel` to handle state restoration

* For #3633 - Adds a test for onTextChanged

* For #3633 - Adds tests for SearchInteractor

* For #3633 - Fixes bugs and adds documentation
5 years ago
Emily Kager 867067537a For #3568 - Use correct styling for QR and Share Alert Dialogs 5 years ago
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 5 years ago
Colin Lee 161e7b3b57
No issue: Fix master builds (#3825) 5 years ago
ekager 61a8795576 For #1211 - Hide keyboard on fling suggestions list 5 years ago
Emily Kager 427bc5c1e6 Revert "For #1211 - Hide keyboard on fling suggestions list"
This reverts commit cb6fd83c9879c268cb739fb768187d5276c5af66.
5 years ago
Tiger Oakes 30930cdc88 Import variables referred to by path 5 years ago
Emily Kager 6e3197f61c For #3622 - Add ID to engine shortcut suggestions (#3636) 5 years ago
Emily Kager b1102c2e76 For #3544 - Set SearchSuggestions preference value from settings 5 years ago
Jeff Boek f323c38be0 For #981 - Adds missing Leanplum events 5 years ago
Colin Lee d5c5587a0c
For #3209: Disable shared element animations for crash temporarily (#3482) 5 years ago
Emily Kager 5eb2bc6d55 For #3138 - Sets height of toolbar in SearchFragment to match_parent (#3400) 5 years ago
Colin Lee 66a836cf3a
For #3314: Toolbar and QAB unresponsive after Android 6 perms check (#3373) 5 years ago
Tiger Oakes 82d2a0661b Remove deprecatd support-ktx methods (#3305) 5 years ago
Denys M c9570fd6ff Use `Drawable.toBitmap()` from androidx-ktx. (#3286) 5 years ago
Sawyer Blatz 86aac3e313 For #3176: Hides camera options on devices without cameras (#3273) 5 years ago
Jonathan Almeida f7bd39da77 For #3138: Fix white background on search bar 5 years ago
Denys M 605a552f16 For #1366. Update toolbar search state when typing. (#2908) 5 years ago
Emily Kager ca186c8776 Closes #1618 - Add fade to awesome bar list instead of shadow (#3110)
* Closes #1618 - Add fade to awesome bar list instead of shadow

* For #1211 - Hide keyboard on fling suggestions list
5 years ago
Jeff Boek a7d5cdcb9d For #2723 - Fixes theme manager 5 years ago
Emily Kager 8dbed67f7f No issue: Simplify and speed up shared element transitions 5 years ago
Emily Kager 43a961fe73 For #1973 - Toggle QR button on deny permissions, fix engineView crashes 5 years ago
Christian Sadilek 0b00c0ce9b No issue: ClipboardProvider no longer needs to be added/removed based on input 5 years ago
Emily Kager 8181705b58 Init Toolbar in edit mode so we don't see the flash 5 years ago
ekager dee3c059dc Adds Shared Transition between Home and Search 5 years ago
Emily Kager a80053547e For #2806 - navigate up from SearchFragment instead of activity back press (#2812) 5 years ago
Sebastian Kaspari 291df48c4e Install the "icons" WebExtension to automatically load icons for every visited website. 5 years ago
Emily Kager e534dad199 For #2028 - Pass Session ID for Custom Tab Prompts, Theme Dialogs 5 years ago
Emily Kager 028c6cad70 For #2025 - Create and theme Dialog for deleting all history 5 years ago
Sawyer Blatz 9e50b55340 For #1857: Adds telemetry for QR scanner 5 years ago
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
5 years ago
Colin Lee 49ac62ab85 Fix ViewModel States (#2457)
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
5 years ago
Denys M 24f15c8b77 Closes #1083. Don't print sensitive data to logs in the production app. (#2437) 5 years ago
Colin Lee ccbc14a71f For #1994: Re-architect state handling code (#2382) 5 years ago
Emily Kager e4b4934f53 For #2393 - SearchTermsTapped even on URL should search (#2398) 5 years ago
Sawyer Blatz 70486039c0 Closes #2147: Refactors usage of openToBrowserAndLoad 5 years ago
Colin Lee 5b7e297adf
For #1955: Add prompt before loading QR code (#2096) 5 years ago
Emily Kager 97e4f43fda No issue: null check context on permission granted (#2104) 5 years ago
Sawyer Blatz 29238d6e5f For #1954: Hides keyboard when requesting camera permission 5 years ago
Sawyer Blatz 11918d45f4
For #1619: Hides clipboard provider when text is entered (#2081) 5 years ago
Sawyer Blatz 46924544b6 For #1975 & #1627: Refactors getSessionById in BrowserFragment 5 years ago
Sawyer Blatz 4945805e37
For #1954: Resolves QR scanner back press and keyboard issues (#2036) 5 years ago
Sawyer Blatz 36cd275eed
For #1917: Hides search suggestions in shortcuts when needed (#1988) 5 years ago
Jeff Boek 31494a4341 Sets the search engine to the default if no shortcut is used 5 years ago
Sawyer Blatz 8a4995099f For #1205: Adds search term to EditToolbar 5 years ago
Harsh Shandilya e20fa5dc32 AwesomeBarUIView: Rename variable to prevent name shadowing
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
5 years ago
Colin Lee 6199d31924 For #1851: QR code scanner doesn't load right after permission grant 5 years ago
Colin Lee d1fd5ec879 For #113: QR Scan 5 years ago
Emily Kager bf056b73c1 For #1375 - Add Bookmarks Suggestion Provider 5 years ago
Jeff Boek cb7ad32b62 For #1158 - Add search counts 5 years ago
Sawyer Blatz f48e2b072e No issue: Cleans up SearchShortcut changes 5 years ago
Sawyer Blatz 353270a5c7 Fixes #1610: Gives unique identifier to shortcut engine picker suggestions 5 years ago
Sawyer Blatz 29832c5e84 For #724: Consolidates colors 5 years ago
Emily Kager 5f0fe216cb For #1375 - Suppress history suggestions in awesome bar via setting 5 years ago
Emily Kager 9cb252da40 For #1421 - Fix Shortcut ToggleButton states 5 years ago
Emily Kager 5d1738e011 For #208 - Dark Mode UX edits 5 years ago
Sawyer Blatz 471b08d97a Closes #1194: Adds shortcut telemetry 5 years ago
Emily Kager a2200b6335 For #208 - Dark/Night Theme 5 years ago
Sawyer Blatz 36af5107c6
Closes #875: Adds search shortcuts (#882)
* Closes #875: Adds shortcuts

* Refactor and clean up

* Remove TODO

* Removes local

* Fix nits

* Refactors to add ShortcutEngineManager
5 years ago
Jeff Boek edb197d10b Adds search engine icon to the toolbar 5 years ago
Jeff Boek 32f8e06e98 For #959 - Adds search related telemetry 5 years ago
Colin Lee df40ec970e Simplify ItsNotBrokenSnack() and make resilient
Co-authored by: Emily Kager <ekager@mozilla.com>
5 years ago
Emily Kager 4963f7ccdb Add Snackbar to link testers to Github issue for features 5 years ago
Sebastian Kaspari 8f11ab6fcf AwesomeBar: Limit number of search engine suggestions. 5 years ago
Sebastian Kaspari 52e9394324 Pass BrowserIcons instance to SessionSuggestionProvider and HistoryStorageSuggestionProvider. 5 years ago
Grisha Kruglov 8eb113fa32 Bump A-C snapshot version to 0.48
This is necessary to pick up an application-services dependency bump, and unbreak master.

AwesomeBarUIView changes are needed because, evidently, a new parameter was introduced, and
not at the end.
5 years ago
Grisha Kruglov 1e1c8a7b46 Pre: fix an IDE warning 5 years ago
Sawyer Blatz 9d18bbad12
Closes #847: Implement onCancelEditing to handle keyboard backPress (#929) 5 years ago
Emily Kager f66bae0801 Closes #963 - Hooks up show search suggestion pref 5 years ago
Arturo Mejia fd4acf6e92 Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443 (#958)
* Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443

* Fix compliation errors
5 years ago
Emily Kager d15e4bb3fa Closes #877 - Add Search Engine Settings 5 years ago
Sawyer Blatz a79134fdc3
Closes #823 & Closes #835: Refactors openToBrowserAndLoad to include fromFragment (#833) 5 years ago
ekager c4674a9026 Closes #754 - Restore SearchFragment navigation logic 5 years ago
Jeff Boek 104b6fbf22 No issue - pulls logic outside of the UIView 5 years ago
Sawyer Blatz e57aa67d60
Closes #664 & Closes #665: Refactors load to respect private mode (#667) 5 years ago
Emily Kager 5b8d40e6e0 Closes #655 - Show/Hide toolbar in onResume 5 years ago
nikit19 9d6ea0ac28 disable blank searches 5 years ago
Sawyer Blatz 53f391de60
Closes #537: Refactors private sessions (#629) 5 years ago
Jeff Boek 5ab49ff7cf For #507 - Leaves a comment to explain the current state 5 years ago
Jeff Boek bacf84678d For #507 - Moves the loading of the URL to the fragment 5 years ago
Sawyer Blatz 797d1cc423 Fixes #566: Clears search on new tab 5 years ago
Colin Lee 291f21aa8e Handle listener state bugs as onViewCreated isn't always called 5 years ago
Colin Lee 6d71faa44d Fixes #541: Crash on Home Screen
The Android Lifecycle Architecture component does not have fine-grained enough lifecycle event callbacks to safely manage Rx subscriptions in Fragment lifecycles. Added autodispose to simplify.
5 years ago
Sawyer Blatz e5fe80f928
Closes #347: Adds private browsing logic (#506)
* For #347: Adds private browsing logic

*  For #347: Adds private session explainer

* Adds persistence
5 years ago
Sebastian Kaspari 4a66c60548 Pass concept-fetch Client implementation to SearchSuggestionProvider. 5 years ago
Jeff Boek 4873d989a0 Moves the shared toolbar component to the components package 5 years ago
Colin Lee cbb26cb45f Handle multitasking via toolbar actions 5 years ago
Colin Lee f09dc2453f Fixes #351 Create home screen component for multitasking 5 years ago
Emily Kager 77883c0f30 Closes #403 Use Fragments for Navigation, Add Toolbar to HomeActivity 5 years ago
Sebastian Kaspari cf260e4b8d Use ViewBoundFeatureWrapper and BackHandler from the base component. 5 years ago
Sawyer Blatz a4fe413537 Closes #412: Enforces consistent naming in colors.xml 5 years ago
Sawyer Blatz 3ff95880eb
Closes #358: Adds local history to AwesomeBar (#413) 5 years ago
Sawyer Blatz d09dc149ed
Closes #363 & Closes #364: Adds private browsing theme (#405)
* For #345 #346 - Adds private browsing theme

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>

* Abstracts theme management

* Theme browser toolbar

* Remove unused imports

* Begin work on sharedPreferences

* fix lint

* #346 - Refactors ThemeManager to take a callback

* Adds clean status bar and nav bar

* lint

* Themes settings icons better

* Small clean up
5 years ago
ekager 0298950025 Closes #335 - Adds Report Site Issue Menu Item 5 years ago
Jeff Boek b8ab51318e For #355 - re-adds the request desktop functionality 5 years ago
Jeff Boek 98a1ae578e For #355 - Present the Library when the menu item is tapped 5 years ago
Colin Lee 623dc55eac Fixes #391: Home button is not visible 5 years ago
Jonathan Almeida 21508f49ca WIP: Integrate feature-customtabs component 5 years ago
Emily Kager e358ea138a Adds new home icon and adds padding to URL background 5 years ago
Jeff Boek 461664ed87 For #364 - Refactors BrowserFragment to use the ToolbarComponent
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
5 years ago
Jeff Boek dbea570747 For #364 - Moves edit mode to be a part of the toolbar component state
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
5 years ago
Colin Lee 0120558fce Enforce unidirectional arch better 5 years ago
Jeff Boek 5a57b9a6c5 Cleans up clipboard awesomebar suggestion 5 years ago
Jeff Boek ed1e563087 Pull awesome bar into a component 5 years ago
Colin Lee 273f33b244 Fixes #290: Integrate new Fenix architecture 5 years ago
Colin Lee b2b6a530d0 Make ktlint and detekt style changes 5 years ago
Jeff Boek ebb5da7f4e For #141 - Cleans up search UI 5 years ago
Grisha Kruglov 0e3965632a Closes #270: Integrate browser-storage-sync for history storage and toolbar autocompletion 5 years ago
Jeff Boek ef7122a147 For #144 - Adds the clipboard to the awesomebar 6 years ago
Jeff Boek 6f17107e87 Migrates away from using the chip suggestions, fixes text colors 6 years ago
Jeff Boek 926fa22909 Fixes transition to browserFragment 6 years ago
Jeff Boek 6587518ed6 Use more user-friendly method name 6 years ago
Jeff Boek 3a8a99d8f0 unhardcode sessionId 6 years ago
Jeff Boek 560aea9b56 For #141 - wires up toolbar and awesomebar 6 years ago
Jeff Boek 480ae93a72 For #141 - Adds autocomplete ot the search screen
- Adds convenience extensions to Context and Fragment
- Imports more components from Android Components
6 years ago
Emily Kager 4421adecbb Implement Navigation, Add Search Fragment, Add Browser Fragment 6 years ago