Commit Graph

3489 Commits (499aa858b2f680f40564e3d7a21664a0efe8783d)

Author SHA1 Message Date
Gabriel Luong ebadbdb352
For #14920 - Show a Tabs Tray CFR Banner for grid view tip (#16466) 4 years ago
Codrut Topliceanu f3edce5f16
For #11376 - Reverse tabs list order (#16245) 4 years ago
Johan Lorenzo 4570f5a14f Revert "Update Android Components version to 66.0.20201111143206."
This reverts commit dbdb68ac72.
4 years ago
Kate Glazko 6c68e79a22 For #14772: Crash in Downloads 4 years ago
Mugurell a097b135b3 For #16076 - Add new "share_image" telemetry event 4 years ago
MickeyMoz dbdb68ac72 Update Android Components version to 66.0.20201111143206. 4 years ago
mcarare c427ebf8d5 For #16416: Remove save to collection button from tab a11y list. 4 years ago
ekager a8db85fc22 For #16132 - Revise multiselect mode UI 4 years ago
Mugurell 5e58377948
For #16424 - Focus the right item in tabs tray when using Talkback (#16472)
To get the index of the current selected browser tab when using reverse layout
we should also account for items placed below of the browser tabs.
The patch here unifies the logic already used for some calls but not all.
4 years ago
Codrut Topliceanu 6e4393a199
For #15720 - Remove unused telemetry (#15887) 4 years ago
Gabriel Luong b5c25ccf3b
For #15960 - Enable Grid View in Nightly only (#16462) 4 years ago
Christian Sadilek 0fbc8410a4 Closes #16430: ExternalAppBrowserActivity should not handle incoming intents 4 years ago
Mihai Adrian Carare c641ed72dc
For #15764 - Update Tabs summary description. (#16428) 4 years ago
Christian Sadilek 96e2123f86
Update Android Components version to 66.0.20201106143126 (#16439) 4 years ago
Christian Sadilek 4abd399002 Closes #16327: Refactor MenuPresenter to use browser store 4 years ago
Arturo Mejia 50d7792330 For issue #15934 fix ConcurrentModificationException
on WifiConnectionMonitor
4 years ago
Michael Comella afa080c956 For #15279 - review: set LazyMonitored to private. 4 years ago
Michael Comella 090650485f For #15279: remove redundant lazy wrapper from storage APIs.
They're currently lazy { lazy { value } }. Accessing `lazy.value`
directly allows us to make it lazy { value }. This should be more
performant and prevents us from double-counting these components.
4 years ago
Michael Comella 89541a17f7 For #15279: LazyMonitored implement Lazy + update built-in API use.
By having LazyMonitored implement Lazy, we can continue to pass these
values directly into the ac APIs that require Lazy references. For some
reason, implementing `Lazy.value` can replace `operator fun getValue`
required for delegates.
4 years ago
Michael Comella 901c78684c For #15279: replace lazy with lazyMonitored in component groups.
By component groups, I mean I applied this to any class with the
class kdoc, "Component group for...".

There are a few instances of lazy we had to keep using the old API to
avoid having to update constructor arguments.
4 years ago
Michael Comella f37ace0630 For #15279: add LazyMonitored and tests. 4 years ago
Kate Glazko 0ae268914b For #352: Delete a download 4 years ago
ekager c0e01373e1 No issue: Update stable androidx and material versions 4 years ago
Mugurell 88bfaaabe7
For #6521 - Remove auto sigin onboarding card (#16315)
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when #15694 would add
to Fenix the ability to serve as a custom account provider.
4 years ago
Mugurell 172977f698
For #14980 - Effectively disable tabs tray STATE_HALF_EXPANDED (#16052)
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
4 years ago
Mihai Adrian Carare db58022fbb
For #13172 - Tab swipe order follows text direction from oldest to newest (#16178) 4 years ago
Rafał Opiłowski 96fb9f4676
For #12971 - Show collection saved snackbar above FAB (#16311) 4 years ago
Mugurell 34f0c84d46
For #16339 - Initialize FxaAccountManager with also a CrashReporter (#16340) 4 years ago
Sebastian Kaspari baaa85db80 Closes #16256: Introduce build flag for "Mozilla Online" variant.
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).

At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
4 years ago
Michael Comella 2b621fcb1b No issue - review: clarify thread safety of suppressionCount. 4 years ago
Michael Comella bff8a0d6a7 No issue: make StrictMode suppression count thread safe. 4 years ago
Christian Sadilek d7688c8427 For #12062: Switch to consumeFlow and add tests 4 years ago
ekager bd2c407943 For #4652 - Remove activityViewModels workarounds 4 years ago
MarcLeclair 7b1af41b40
15278 detekt rule runblocking (#15942)
* For #15278: added CoroutineManager to count runBlocking calls

* For #15278: Added actual detekt rule for runblocking and its config to the yaml

* For #15278: Added unit test for RunblockingCounter

* For #15278: renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test

* Lint fix

* For #15278: made runblocking a Long to prevent overflow

* For #15278: fixed MozRunblocking name, description and moved RunBlockingCounter to perf package

* For #15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck

* For #15278: Added setup for unit test, since it failed without restting counter

* For #15278: Fixed naming for RunBlocking lint check

* For #15278: removed changes made to test to use runBlockingIncrement

* For #15728: added test exclusion for runBlocking check

* For #15278: changed null check and added Synchronized to count setter

* For #15278: fix for nits

* For #15278: added StartupExcessiveResourceUseTest to CODEOWNERS

* For #15278: fixed for nits

* For #15278: Moved increment function to extension function and fixed indentation

* For #15278: Added tests for Atomic Integer extension and nit fix
4 years ago
ekager d46fc7b142 For #6313 - Remove unneeded delay in BrowserAnimator 4 years ago
Roger Yang b65c798450
For #16268 - Allowing multiple task while sharing (#16275) 4 years ago
Jocelyne Abi Haidar 1b204158e5
For #15931: Sort Downloads from newest to oldest (#15939) 4 years ago
mcarare 142d7a418c For #15430: Fix StrictMode death on opening app from widget voice search. 4 years ago
mcarare 5b0bdda974 For #15430: Fix StrictMode death on opening app from widget text search. 4 years ago
Mugurell a6092c34cc For #15963 - Increase touch target for the close button in the tabs tray grid layout
We need to ensure it has at least 48dp while also not appearing too big.
4 years ago
Mugurell 83bd80c873 For #15757 - Avoid the double spacing issues for grid items in tabs tray
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
4 years ago
Mugurell 0324baef03 For #15968 - Show a border for the selected tab in the grid based tabs tray
The border for the grid item will now be updated in the same method that
updates the background for the list item.
4 years ago
Gabriel Luong 66210469c0
For #9548 - Ability to rename top sites (#16285)
* Ability to rename top sites, closes #9548

* Highlight the "Remove" top site action as destructive

With more menu items in the top site contextual menu, it makes sense to differentiate

* Added test for the top site renaming action

* Fixed lint check (wildcard imports, blank spaces)

* Applied suggestions from code review

* Apply suggestions from code review

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

* Implemented dialog click listener with manual dismiss/cancel

Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
4 years ago
Codrut Topliceanu 975a5b76ec
For #14637 - Fix sitePermissionsFeature breaking change + AC bump (#16229)
* For #14637 - Compatibility patch for AC - 8554

* Update Android Components version to 65.0.20201029143039

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
4 years ago
mcarare 3cb2c83980 For #16250: Disable remote USB debugging for SDK <23. 4 years ago
Mihai Adrian Carare 0ee7e1c28d
For # 15929: Remove the search widget discoverability experiment. (#16081)
* For #15929: Remove SearchWidgetCFR telemetry.

* For #15929: Remove SearchWidgetCFR and search widget experiment.

* For #15929: Remove unit tests references to search widget experiment.
4 years ago
mcarare 9748c65c71 For #15413: Use proper url when bookmarking a page. 4 years ago
Arturo Mejia bb7d821804 Fix AddonsManagementFragment detekt error 4 years ago
Christian Sadilek c330426bb7 No issue: Fix onConfigurationChange crashes in Debug build 4 years ago
Christian Sadilek 601aa19176 Closes #11285: Replace Session[Manager] observers in BaseBrowserFragment 4 years ago
Grisha Kruglov 655a5cbf54 Closes #15816 - Attempt to handle 'allowInPrivate..' pref with detached context 4 years ago
mcarare 21a67de947 For #15379: Use proper url when sharing. 4 years ago
ekager 9b2162fca2 For #16199 - Don't pass BrowserToolbarView in onStart when we just need parent 4 years ago
Arturo Mejia 0ae0b89d65 Fix add-on translation braking changes 4 years ago
ekager e15f50712a For #6313 - Set session ClearColor through Engine DefaultSettings 4 years ago
Jocelyne Abi Haidar f514f6099a
For #15508: Show error when trying to save empty or invalid bookmark URL (#15674) 4 years ago
Mugurell 358ca2c87f
For #15543 - Adjust the height of the tabs tray depending on the number of tabs (#15749) 4 years ago
ekager aae43b84eb
For #12062 - Feature Flag return to browser (#16099) 4 years ago
ekager 6b8f2001df
For #16084 - Match elevation of Tab in Collection to header (#16100) 4 years ago
ekager d5cb9c599c
For #15910 - Adds back automatic toggle, disables slider when enabled (#16070) 4 years ago
mcarare 1a10215caf For #14619: Show half a tab top offset when scrolling to selected tab. 4 years ago
Mugurell 57462d612f
For #16054 - Enable pull to refresh webpage in Nightly and Debug (#16060) 4 years ago
Elise Richards 7e3c26914c
For #15080: Handle default search engine when editing or removing (#15768) 4 years ago
Juan C. Goncalves eb0712d9b4
For #11397 - Add lint rule for AppCompatResources instead of ContextCompat (#16011) 4 years ago
Sebastian Kaspari 0d97862824 FennecWebAppIntentProcessor: Catch JSONException. 4 years ago
Mihai Adrian Carare b1bc024ff5
For #11631: Move report site issue extension to main menu. (#15884)
* For #11631: Move report site issue extension to main menu.

* For #11631: Update UI test for installing add-on.
4 years ago
Tom Klein 57ba92080f For #15480 - Update the UI when a collection is renamed 4 years ago
mcarare 9274558e2f For #15688: Navigate to home screen with arguments on new tab action. 4 years ago
Sebastian Kaspari 2da24cd91d
Update Android Components, Kotlin, Gradle plugin (#16021)
* Closes #13262: Update AGP to 4

* Update to Mozilla Android Components 63.0.20201019090011.

* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.

* Fix new compiler warnings.

* Fix compilation of lint rules module.

* Pin JNA version.

* Fix new lint errors.

Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Mihai Adrian Carare 3ed49d8802
For #14744: Also show Fill link from clipboard with search shortcuts. (#15885) 4 years ago
Gabriel Luong d33bd76e40
For #15796 - Use the device locale for the system locale subtitle (#15975) 4 years ago
Gabriel Luong 87ec7a77ae
For #15937 - Remove topFrecentSite feature flag (#15967)
* For #15937 - Remove the topFrecentSite feature flag

* For #15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
4 years ago
ekager d208ffe002
For #7345 - Update new shield icons, remove lottie (#15909) 4 years ago
Christian Sadilek c852301c93 Closes #11286: Add TelemetryMiddleware to remove Session[Manager] observers 4 years ago
Gabriel Luong 412b412d5f
For #15796 - show device language under follow device language (#15966) 4 years ago
Jeff Boek 55515d8f7c
For #15596 - Removes upgrade faq link from fennec builds (#15643) 4 years ago
Michael Comella 4a000ab4f9 For #15644: change apply to with in GleanMetricsService.
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.

I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
4 years ago
Michael Comella 690554b5c6 For #15644: mock package inspection dependencies in GleanMetricsService.
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
4 years ago
ekager 4d348dd26a Fixes existing lint errors 4 years ago
Gabriel Luong 665a71cbb0 For #15907 - Remove the usage of the TabTrayGridItemDecorator 4 years ago
ekager 508ec8b8ff For #15347 - Adds telemetry for tabs settings 4 years ago
ekager b6587455f8 fix detekt errors 4 years ago
Sebastian Kaspari 430282c8ec Use new SearchEngineProvider interface. 4 years ago
ekager e56043c485 For #15265 - Save cached top sites for metrics ping 4 years ago
ekager cbe293d3e4 For #12062 - Launch back to browser if we previoulsy had tabs 4 years ago
ekager 7931d66c8e For #15853 - Always set fontSizeFactor setting with new text scale 4 years ago
Mihai Adrian Carare 0e2657e262
For #14735: Remove debug logs from release build. (#15747) 4 years ago
Grisha Kruglov 2030580fc8 Closes #15812: Check for a null context during onScanResult 4 years ago
Shen 45e3f7805b For #13168 - Removed the close button from history navigation bar 4 years ago
Michael Comella 4179ab05bb For #10069 - review: clarify init time for External...Activity. 4 years ago
Michael Comella a1bbd2589e For #10069 - review: change extra name to firstFramePreDrawNanos. 4 years ago
sraturi 8f16f9cb37 for #10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types. 4 years ago
ekager 881e3d6ccd For #14923 - Removes auto size preference toggle 4 years ago
Sijan Rijal 127d006d66
For #15402: Hide ETP pop-up if the toolbar is not visible (#15667)
For #15402: Hide ETP pop-up when top or bottom toolbar is not visible
4 years ago
Sijan Rijal 70908307fc
For #15497: Hide and remove the three dot menu from the Desktop Bookmarks folder (#15649)
For #15497: Remove and disable the three dot menu button
4 years ago
Jonathan Almeida 666781aa62 Fix lint warnings and test in site permissions 4 years ago
Arturo Mejia de521192e0 Add support for local storage permission 4 years ago
Gabriel Luong 2dd019c05f For #15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting 4 years ago
Gabriel Luong af0af7f88a For #15115 - Part 7: Draw a border around the selected tab 4 years ago
Gabriel Luong 5fcc486caa For #15115 - Part 6: Display the tab's favicon in the grid view 4 years ago
Gabriel Luong 5fa72cf48c For #15115 - Part 5: Don't draw any background when swiping to delete a tab 4 years ago
Gabriel Luong a001004add For #15115 - Part 4: Formatted TabTrayView.kt 4 years ago
Gabriel Luong 6c77cdab41 For #15115 - Part 3: Implement a grid view layout for the tabs
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
4 years ago
Gabriel Luong ed3986662f For #15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
4 years ago
Michael Comella 7c0d00c800 No issue: fix tests related to inline change.
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
4 years ago
Michael Comella 7b5cd8c165 No issue: remove inline from StrictModeManager.resetAfter.
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet  we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
4 years ago
Jonathan Almeida 23d9951e78 Upgrade to Android Component 62.0.20201006190820 with breaking changes 4 years ago
mcarare 9845626eca For #15711: Also add custom engines to fallback list. 4 years ago
Elise Richards 13f3304912
For #8765: Use shared list widget in collections (#15733)
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Michael Comella 3e96f6b385 For #13959 - review: add clarifying comments. 4 years ago
Michael Comella 50959d997e For #13959: add marker when StrictMode is suppressed. 4 years ago
Michael Comella 3b5d6d58d9 For #13959: add MozillaStrictModeSuppression detekt check. 4 years ago
Michael Comella 4a4edeb184 For #13959: count StrictMode suppressions on startup. 4 years ago
Jocelyne Abi Haidar a5de2c0352 For #15675: Disable Save button when editing saved login until something has been changed
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago
mcarare 07748f69b7 For #15632: Improve checking open tabs logic to show collection button.
Check now considers selected tab tray mode.
4 years ago
ekager ec3595d4fc For #15600 - Move removal of timed out sessions to immediately after restoration 4 years ago
ekager 01eedd159a No issue: Update biometric, core, and recyclerview libraries 4 years ago
mcarare b696fc4c4b For #13031: Show size in KB for smaller downloaded files. 4 years ago
Jocelyne 0154c81f81
For #10107: Show Today and Yesterday labels in History (#15415) 4 years ago
Jeff Boek 41a92a8d8b For #15593 - Reverts back to simple UUID creation without Fenix side caching 4 years ago
Jocelyne e74a12b442
For #15471: Show Delete button in red in multi-select overflow menu (#15576) 4 years ago
Grisha Kruglov 51dab196c4 Closes #15443: Use fragment's lifecycleScope for AlertDialog actions 4 years ago
Stefan Arentz ff930175de
For #15537 - Be more verbose about leanplum identifiers (#15538) 4 years ago
mcarare 19b377c021 For #15535: hasOpenTabs now considers the selected tab mode in tray tab. 4 years ago
Michael Comella 56f78cb30c No issue: elaborate on Components class doc.
This is to clarify a misunderstanding I found in PR review.
4 years ago
Sebastian Kaspari 2fda22e857 Revert "For #12565: Pass metrics to share controller" for debug test failures.
This reverts commit bbaca06274.
4 years ago
Sebastian Kaspari 4de466883b Revert "For #12565: Pass bookmark storage to controller" for debug test failures.
This reverts commit 3c22100b84.
4 years ago
Andrew Gaul cfbad1dae9 Show undo snackbars with padding with static bottom toolbar
This specifically fixes the close tab snackbar.  This commit mirrors
the logic when not using Undo from
9e876ebc44.  References #14982.
4 years ago
ekager 01e802fef0 For #15324 - Show tab settings and recently closed items in menu when no tabs 4 years ago
ekager e49cd9c558 For #15503 - Change recently closed max to 10 4 years ago
TrianguloY b07af9ccd3
For #13856 - Prevent overscroll in swipe to switch tabs gesture 4 years ago
Tiger Oakes 25f62f1c76 Extract locale settings initial state 4 years ago
Tiger Oakes acbad66f45 Add test for initial logins list state 4 years ago
Tiger Oakes f2a6aa4f25 Add tests for initial collection creation state 4 years ago
Tiger Oakes 3c22100b84 For #12565: Pass bookmark storage to controller 4 years ago
Tiger Oakes bbaca06274 For #12565: Pass metrics to share controller 4 years ago
Michael Comella d767cd199e For #13959: fix startup crash by using arg Context.
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago
Michael Comella 42cca072e2 For #13959: remove resetAfter & port tests to StrictModeManager. 4 years ago
Michael Comella f19c9920f9 For #13959: move resetAfter into StrictModeManager.
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.

Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```

We're going to have to add a lint check to prevent them from doing that.
4 years ago
Michael Comella 6abeb2d9e7 For #13959: change StrictModeManager to class from object.
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
4 years ago
Christian Sadilek d4ab728cff For #14034: Add debug preference to override AMO collection in Nightly 4 years ago
Michael Comella a92356fe00 For #13959: comment about duplication in logic in StrictMode.
I had to drop a commit that addressed the issue because it was too hard
to fix.
4 years ago
Michael Comella e1bd6191c7 For #13959: add comment to explain why we only resetAfter in certain build modes. 4 years ago
Michael Comella 3bf71ef655 For #13959: use ac StrictMode.resetAfter rather than duplicating functionality. 4 years ago
Michael Comella 2c1befaa25 For #13959: rename to attachListenerToDisablePenaltyDeath for clarity. 4 years ago
Michael Comella c03c7ef793 For #13959: remove unused penaltyDialog parameter.
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
4 years ago
Michael Comella f05a542060 For #13959: always enable detectNonSdkApiUsage.
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
4 years ago
Sebastian Kaspari 3983c509dc Use "undo" implementation from Android Components.
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.

Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
4 years ago
mcarare 6289da892c For #15310: Also catch ActivityNotFoundException when sharing to app. 4 years ago
ekager 0d0a28d551 No issue: Update AC to 61.0.20200925190057 4 years ago
ekager 7d5c199e51 For #12383 #15407 #12860 - Switch to using shared view model for session to delete on home 4 years ago
Grisha Kruglov 2999f64d0a Closes #15434: Don't try to display a 'signed in' snackbar in a 'headless' mode 4 years ago
Grisha Kruglov d98eba1d64 Closes #15432: Invoke UI updates on main thread in response to account events 4 years ago
Grisha Kruglov 24985d54fa Closes #15436: Auto-close tabs during startup on the main thread 4 years ago
mcarare 04e59e0ac5 For #15130: Remove "what's new card" from onboarding screen. 4 years ago
Kate Glazko e8855c09e6 For #15320: Ensure Mimetype Other PDF Shows PDF Icon 4 years ago
Elise Richards 1adf467248
For #14280, #14743: Remove old search fragment (#15169)
* Remove search fragment

* Use new folder to search dialog

* Rebase and lint

* Update tests with search dialog nav directions

* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
4 years ago
Jonathan Almeida add60611b4 For #15349: Fixes SyncedTabs suggestion not clicking 4 years ago
Grisha Kruglov f1b0827a0b For #15296: Allow excluding bookmark subtrees when editing parent folder
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
4 years ago
Sawyer Blatz 0fa2509bef
For #14243: Pre-land visuals for Close Tabs CFR (#15171) 4 years ago
Grisha Kruglov 71b51146cb Update breaking changes in the FxA/Sync integration 4 years ago
Jocelyne d45e482373
For #11800: Hide reveal and clear password icons if the password is empty when editing a saved login (#15244)
Co-authored-by: Jocelyne Abi Haidar <jocelyne.abihaidar@gotocme.com>
4 years ago
mcarare c1bf66618e #274-android-l10n: Update create account string to avoid partial translations. 4 years ago
person808 baccb153b7 For #15219 - Fix tab tray handle size.
Also use dimens for the tab history handle.
4 years ago
ekager 24983af94e For #15291 - Limit current CFRs to show max one every 3 days 4 years ago
mcarare 94d9a2a1ed For #15263: Properly update open links in app preference. 4 years ago
ekager a9075ff87b For #15272 - Remove bottom margin for toolbar on enter fullscreen 4 years ago
ekager 030d6a5b36 For #15121 - Ensure tabs removed while on browser select an available parent session 4 years ago
mcarare 896c1b7875 For #15268: Use safe navigation to addon details fragments. 4 years ago
Grisha Kruglov f51b570654 For #15284: Process root titles when creating new folders
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
4 years ago
ekager f16ade33df For #15089 - Disable recently closed in multiselect 4 years ago
ekager b5f1e772bd For #15112 - Still show recently closed when history empty 4 years ago
Grisha Kruglov 5691088787 For #15286: Don't crash when separators are long-touched 4 years ago
ekager 9a2103a9a7 For #13934 - Make TabHistory work on PWA/Custom Tabs 4 years ago
ekager 407c31fdb3 No issue: Fixes strict mode death in debug custom tab 4 years ago
ekager 9e876ebc44 For #14982 - Show snackbars with padding with static bottom toolbar 4 years ago
ekager 18ca211434 For #14458 - dismiss keyboard on fill link from clipboard 4 years ago
ekager e162aefbc6 For #15245 - Remove margin for toolbar on toolbar-less PWA 4 years ago
Grisha Kruglov b7b3ee5ce6 For #2792: Display bookmark folders at the top of the bookmarks UI 4 years ago
Grisha Kruglov 078843675b For #15211: Make sure bookmarks are moved to the end of folders 4 years ago
Grisha Kruglov 027c1f9ea7 Closes #15206: Only track 'move' event if bookmark parent was changed 4 years ago
Grisha Kruglov b5b32ba6ea For #11502: Make sure to always process root titles for parent folders during edit
This also switches to a simpler bookmarks query API ('getBookmark') which doesn't fetch
children. We don't need 'children' for this dialog, and so don't need to do the extra work.
4 years ago
Grisha Kruglov 958474f9fb For #13157: Filter out folder being edited from 'select folder' dialog 4 years ago
Grisha Kruglov fe288edb5d Rename 'visitedAddBookmark' arg to a less confusing name 4 years ago
Grisha Kruglov 24de85f805 Remove unused nav arg from 'select folder' 4 years ago
Tiger Oakes b563576335
Closes #14131: Move constants to dimens.xml (#14135)
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
Elise Richards a4ff782565
For #13812: add ETP category for redirect trackers (#15139)
* Feature flag for ETP cookie purging

* Strings for new ETP description

* Remove icons from ETP info screeen and add category for redirect trackers

* ETP policy factory tests

* Remove icons from ETP panel and add cross tracking allowed field.

* Remove icons on ETP panel. Add blocked category for redirect trackers to panel.

* Add margins to tracking protection settings
4 years ago
Jeff Boek 6781018556 For mozilla-mobile/android-components#8429 - Dont initialize MLS if token is null 4 years ago
Jeff Boek 8bdc9d0431 Revert "For #12544 - Prevent search engines mixup"
This reverts commit 0a4a170f7e.
4 years ago
Hakkı Kaan Çalışkan 0afb7a3f25 For #13922: Add indicator to synced tabs suggestions in awesomebar 4 years ago
Jonathan Almeida d063cd5396 For #14230: Stop redrawing all top sites when one is removed 4 years ago
mcarare 5b33044999 For #12829: Add create account option on the the sign in screen. 4 years ago
mcarare 81985f4179 For #12829: Update addUnderline extension function to accept parameters. 4 years ago
mcarare cc9667f722 For #15150: Do not show open banner if open in app is ON in settings. 4 years ago
mcarare 79135b1df5 For #13943: Change strict mode penalty to penaltyDeath.
Also, keep dialogPenalty as replacement option for penaltyDeath.
4 years ago
Sören Hentzschel 55b5a452d1 For #14933 - Fixed private browsing icon color in preferences fragment 4 years ago
Tiger Oakes b927b688c9 Merge bookmark item and folder view holders 4 years ago
Tiger Oakes 3059a57747 Change separator to use its own view holder 4 years ago
Elise Richards 9afe9679d8
For #15079: handle QR permissions when changed in Android settings (#15097)
* Define intent data for activity

* Search dialog shows permissions for allow and deny camera

* Check camera permissions for fxa pairing

* Check camera permissions for old search

* Tests for pairing sync interactor and controller.

* Cleanup

* Use bool pref for setting. Use interfaces and default implementations for the sync interactor and controller.

* Lint
4 years ago
Sawyer Blatz 1f17371df6 For #14565: Add telemetry for top sites 4 years ago
Arturo Mejia 19f0c543fe Fix add-ons permissions breaking change 4 years ago
mcarare e5a9311613 For #15116: Also do not expand or set bottom toolbar behavior on TWA tabs. 4 years ago
mcarare 83478b9db4 For #15116: Do not set bottom toolbar behavior on PWA tabs. 4 years ago
mcarare c5a2e2e5a0 For #15116: Do not expand toolbar on PWA tabs. 4 years ago
mcarare 1f004aff8c For #15116: Use safe cast for layout params. 4 years ago
Sebastian Kaspari ee3384ac52 Issue #14225: Remove task when finishing ExternalAppBrowserActivity. 4 years ago
Hakkı Kaan Çalışkan f87ca730a9 For #11245: Integrate Synced Tabs AwesomeBar suggestions
fix pr
4 years ago
Jeff Boek c632b6b0a1
For #15007 - Puts swipe to delete behind a feature flag (#15009) 4 years ago
codrut.topliceanu b892af773e For #14546 - Speculative fix for ANR 4 years ago
Gabriel Luong 05857ba55d For #14145 - Add pinned badge for pinned sites 4 years ago
Mugurell 75aa2d413a For #14974 - Ensure website bottom elements stay at bottom
engineView.setDynamicToolbarMaxHeight(0) vs
engineView.setDynamicToolbarMaxHeight(toolbarHeight)
ensures webpage's bottom elements are aligned to the bottom of the browser.

We also need to make sure that when the toolbar is static it does not cover the
bottom of the page - something desired when the toolbar was dynamic.
For this the engineView will have a toolbarHeight bottom margin.
4 years ago
codrut.topliceanu b5cf484360 For #14559 - Persist searchFragment keyboard status 4 years ago
Elise Richards 4afaf34a78
Access shared prefs in fxa pairing (#14997) 4 years ago
Jeff Boek 79180250ea For #14283 - Fixes overlapping search suggestions and hint 4 years ago
ekager 09fbb43f80 For #2486 - Adds Recently Closed Tabs 4 years ago
ekager b986730031 No issue - Updates AC to 58.0.20200910190642 and fixes imports 4 years ago
Mugurell b54949e58f
For #14902 - Disabling bottom toolbar animation now works (#14927) 4 years ago
Jeff Boek f9b2d65993 For #5745 - Create preference to disable domain autocompletion 4 years ago
Elise Richards 87bd44145f
For #14239: Notification for QR scan when permissions have been denied (#14553)
* Show dialog when permissions are denied

* Add qr permissions dialog to search dialog fragment

* Add qr permissions dialog to the pairing screen

* Show dialog after permissions have been denied

* Reset focus after denying permissions

* Show dialog after permissions denied in search frag and par frag

* Use shared preferences to store camera permission state

* Move dialog creation into the search controller and add tests

* Dialog controller implementation and test

* Route to intent with correct activity. Set focus when dismissing dialog

* Get preferences in old search
4 years ago
Mugurell a6a50d78e0 For #14903 - Prevent BrowserFragment's view leak 4 years ago
ekager 82d7313add For #13467 For #14910 - Dismiss dialog on blank URL commit 4 years ago
ekager 806f74abe7 For #14680 - Revert ObserverRegistry changes to WifiConnectionMonitor 4 years ago
Michael Debertol 4142c36820 For #14212: Pass historyStorage to ToolbarView 4 years ago
Michael Debertol cc8aa1f381 For #13423: Pass isPrivate flag to ToolbarView 4 years ago
Sören Hentzschel 103c183265 For #14194 - avoid leak when opening the "Libraries that we use" screen 4 years ago
Jeff Boek 66ecc15b40 For #14543 - Prevents IllegalStateException by not moving to another thread 4 years ago
mcarare 4de80a0493 For #14540: Fix updating list and item info for a11y services. 4 years ago
Gabriel Luong 6d133c8d0c For #14529 - Show a dialog when the top sites limit has been reached 4 years ago
ekager de7e6663ce Closes #14895 - Adds paste to context menu ordering preference 4 years ago
codrut.topliceanu 21cbbdc7c8 For #13949 - Turn off tip regarding beta/nightly 4 years ago
Mugurell d8d896c500 For #10240 - New preferences to control gesture based features
Three new settings and one for which this patch just pre-lands the strings.
The behavior for the "Swipe toolbar up to open tabs" is to be added as part of
a later ticket.
4 years ago
Tiger Oakes 4b6a589f24
Extract checkbox selected mask (#14308) 4 years ago
Tiger Oakes 53d16e78e1
For #14460: Fix PBM notification tint (#14699) 4 years ago
Tiger Oakes 043e061087
For #14376: Reverse items with bottom toolbar (#14451) 4 years ago
Tiger Oakes 113241e8ce
Enforce IO thread inside of components (#14704)
* Automatically run PermissionStorage on IO thread

* Run TabCollectionStorage on dedicated scope + IO

* Update findSitePermissionsBy calls
4 years ago
Gabriel Luong 7aa6514499
For #14629 - Enable showing frequently visited sites ON by default (#14630) 4 years ago
Sebastian Kaspari e0071341c7 Update to new state API and update Mozilla Android Components version.
The EngineSessionState of a tab is now always accessible through tab.engineState.engineSessionState. It will
never get cleared.
4 years ago
mcarare c350a5f3b9 For #9506: Add session observer to check conditions for displaying banner. 4 years ago
mcarare d7668b16fc For #9506: Create show open in app banner preference. 4 years ago
mcarare 653a279101 For #9506: Implement banner custom view based on material design specs. 4 years ago
mcarare 20794296dc For #9506: Add possibility to navigate to a preference in settings. 4 years ago
Mugurell 33fc520468 For #10241 - Use VerticalSwipeRefreshLayout for pull to refresh
And so resolve many of the issues found in the platform's SwipeRefreshLayout.
4 years ago
ekager 09d1dba133 For #14679 For #14676 - Dismiss MP Migration tip, init in disabled state 4 years ago
ekager e80b46ced0 For #14609 - Correct nav from new search experience to browser 4 years ago
mcarare 85cb74a3c9 For #14665: Replace hardcoded label with string resource. 4 years ago
Shane Synan 2231fe2d52
For #14642: Use correct 'Close tabs' summary text (#14644)
For "closeTabsAfterOneMonth", use the correct summary string of
"close_tabs_after_one_month" instead of "close_tabs_after_one_week".

This fixes the Settings page "Close tabs" summary showing the wrong
tab duration when "Close tabs" is set to "After one month".

Closes #14642
4 years ago
Dennis Schubert abfc91519a
Bug 1645844 - Add label to reports sent via the webcompat-reporter. (#14625) 4 years ago
liuche 408000e450
Issue #7620 - Remove Nightly flag for external download manager (#14632) 4 years ago
Sören Hentzschel 81dd1a9192
For #8343, #9709 - replace "phone" with "device" in translations (#14083) 4 years ago
Arturo Mejia 6f5e9bad26
Pin AC TO 57.0.0 and remove feature flag for view downloads (#14592)
* Update Android Components version to 57.0.0.

* Remove feature flag for "View Downloads".

* Update search enginer list from changes by #13452

Co-authored-by: Chenxia Liu <liuche@mozilla.com>
4 years ago
ekager 83ffcac57e For #13926 - MP migration 4 years ago
Jeff Boek 0c748c0500 For #14279 - Prevent GeckoView from resizing while searching 4 years ago
ekager 2d67e4b748 For #4118 - Creates setting for auto closing tabs 4 years ago
ekager 7c7aa46811 Closes #14254 - Removes Login select feature flag 4 years ago
Codrut Topliceanu 72edaaf067
For #11465 - Fix default engine for widget voice search (#14015)
For #11465  - Fix default engine for widget voice search
4 years ago
Tiger Oakes bf2ac22d03
Simplify media state drawables (#13474) 4 years ago
Kainalu Hagiwara d668a82f14
For #13498 - Use custom long press back handling for Huawei devices. (#14387) 4 years ago
Sören Hentzschel 2532cecf6c
for #13329 - removed unused feature flag (#14438) 4 years ago
Michael Debertol 351d66230c
For #14354: Update the search shortcuts icon on state update (#14355) 4 years ago
Gabriel Luong dcb99856f9
For #13264 - Scroll to the tab above the selected tab in the tabs tray (#14372) 4 years ago
mcarare 2f1b903005 For #14289: Check if toolbar is initialised before setting flags. 4 years ago
Arturo Mejia c63fd3f9ac Add support for restoring downloads 4 years ago
Tiger Oakes e93a8b7d34
For #14376: Use concept-menu with tab counter menu (#14374) 4 years ago
Tiger Oakes a8291bf641
Remove un-needed nullables (#13816) 4 years ago
Jeff Boek ff805e53ed For #14318 - Use old API to try to fix startup crash without GPS 4 years ago
Tiger Oakes ace6b99c89
Split toolbar controller into two classes (#13854) 4 years ago
Tiger Oakes f81b401738
Remove unneeded tint for ic_link (#14381) 4 years ago
Tiger Oakes 75e7cd3c64
FNX-14583 ⁃ Extract and test preference helpers for Settings (#13402) 4 years ago
Mugurell acdef76b71 For #12980 - Clear icons when deleting browsing data 4 years ago
Mugurell aa7283def9 For #12980 - Unify deleteBrowsingData() and deleteHistoryAndDOMStorages()
The two methods are serving the same purpose, with one calling the other.
This prepares the ground for adding a method to delete icons in only one place
and remove confusion about what that place should be.
4 years ago
Tiger Oakes 50ac4fe17d
Use shared list widget in tab history (#13884) 4 years ago
Tiger Oakes 0102e03d75
Add tests for collection creation (#13909) 4 years ago
Tiger Oakes 9777b8fad6
FNX-14661 ⁃ Delete drawables (#13481)
* Delete unused drawabled

Mostly leftovers from quick action bar

* Remove duplicate drawables using tints
4 years ago
Jeff Boek 50c955723c No Issue - Add prompt to secret settings 4 years ago
Gabriel Luong 31455070b1
For #14119 - Add a setting to toggle the display of frequently visited top sites (#14183) 4 years ago
Jeff Boek 4cbbc52ad0 No Issue - Fixes bug where shortcuts and hint are visible at the same time 4 years ago
Tiger Oakes e067ad5363
For #8157: Redirect about:addons search (#13990) 4 years ago
mcarare 91a9200fe3 For #13911: Fix resolving color attribute for title and description.
For SDK < 23 color attr cannot be resolved in selectors.
4 years ago
mcarare 50948ef06e For #12905: Update dialog title so it won't be read by a11y services. 4 years ago
mcarare 410980fe27 For #11425: Improve editing bookmarks flow. 4 years ago
Sachin 316b70940f
for #12573, added startup type and hasSavedInstance keys to app_startup_type telemetry (#13494) 4 years ago
Jeff Boek 3713b5a63a For #14251 - Dont show CFR if were navigating to Search 4 years ago
Jeff Boek c73870b794 For #13507 - Performance fixes for the ReviewPromptController 4 years ago
Jeff Boek c6687d976e For #13507 - Adds tests for ReviewPromptController 4 years ago
Jeff Boek 56b730f0e8 For #13507 - Extracts review prompt behavior into ReviewPromptController 4 years ago
Elise Richards e96eb25682 Allow play store in app review to be shown to users 4 years ago
Jeff Boek 4b997c1334 No Issue - Fixes UI Tests with new search experience 4 years ago
Jeff Boek f734509ac4 No Issue - Removes pref, toggles new search based on feature flag only 4 years ago
ekager 179a86ce64 Puts login selection behind a nightly feature flag 4 years ago
ekager 53eebd681b For #5551 - Adds select login prompts 4 years ago
Jonathan Almeida 5f92de58ae Disabling StrictMode policy for Top Sites changes 4 years ago
Christian Sadilek 8b9c3e0108 Fixes for A-C 57.0.20200826190111: Move EngineSession to BrowserState 4 years ago
Tiger Oakes 0b333fe48a For #9056: Search from custom tab 4 years ago
Gabriel Luong 4f76699ab7 For #10342 - Part 6: Show "Delete from history" instead of "Remove" for top frecent sites in the top site menu 4 years ago
Gabriel Luong 1f564c10ce For #10342 - Part 4: Use the TopSitesFeature in the HomeFragment for displaying top sites 4 years ago
Gabriel Luong 46aa6a003e For #10342 - Part 3: Use the TopSitesUseCase in the BrowserToolbarController and SessionControlController
Use the provided `addPinnedSites` and `removeTopSites` use cases in `BrowserToolbarController` and `SessionControlController`.
4 years ago
Gabriel Luong d824dd1e35 For #10342 - Part 2: Replace the local TopSiteStorage with the A-C DefaultTopSiteStorage 4 years ago
Gabriel Luong 7d9274e990 For #10342 - Part 1: Remove top sites prefetch and observation of live data 4 years ago
Christian Sadilek 0162fd68a9 Revert "For 11660: fixing nits for previous #11668 (#11821)"
This reverts commit bd7a5375f2.
4 years ago
Jeff Boek c58fa028bf For #13368 - Ignores strict mode for LeanplumMetricsService 4 years ago
MarcLeclair bd7a5375f2
For 11660: fixing nits for previous #11668 (#11821) 4 years ago
Sebastian Kaspari 4782705af9 Add diagnostic breadcrumbs for debugging "Display already aquired" crashes.
For:
https://github.com/mozilla-mobile/android-components/issues/7960
4 years ago
Grisha Kruglov f694861f1f Pass along crash reporter instance to PlacesHistoryStorage 4 years ago
Mugurell 75c496f237 For #13037 - Cleanup - have the camera check in just one place
This patch reverts a previous commit for the issue which added the camera check
in two places.
With a new solution to check if the device has camera only in
TurnOnSyncFragment we need to cleanup the previous checks.
4 years ago
Mugurell 84976f308a For #13037 - Use email to sign in to fxa if device has no camera
App can be installed on devices with no camera modules. Like Android TV boxes.
Will skip presenting the option to sign in by scanning a qr code in this case
and default to login with email and password.
4 years ago
Jeff Boek f763a50384 No Issue - Enables new search for all channels. Brings over missing metric 4 years ago
Tiger Oakes bb3fd4eb16
For #8765: Use shared list widget in exceptions (#14113)
* For #8765: Add resource for shared list widget

* For #8765: Use shared list widget in exceptions
4 years ago
Tiger Oakes ac2d65cc5e
Replace setPadding with updatePadding (#14137) 4 years ago
liuche b01dbeeebf
For #12046 - Renew telemetry probes before migration completion (#13958)
* For #12046 - Renew telemetry probes before migration completion
* Delay remaining probes renewal for one more month.
4 years ago
mcarare 294a187ba8 For #14157: Pass correct anchor for context menu popup. 4 years ago
Tiger Oakes a48c05a359 Fix breaking AC change to support monochrome icons 4 years ago
Jeff Boek 9a56dcd786 For #13784 - Addresses nits 4 years ago
Jeff Boek f173c81b03 No Issue - Ports over accessabiltiy fixes to new search experience 4 years ago
Jeff Boek e92cf50a1c No Issue - Adds the fill with clipboard button 4 years ago
Jeff Boek 8f25c984a8 No Issue - Moves over functionality from the old SearchFragment 4 years ago
Jeff Boek 73321eb2bb No Issue - Hide keyboard when navigating or scrolling 4 years ago
Jeff Boek 5f56e02ac3 For #13766 - Adds voice search 4 years ago
Jeff Boek dedbd28550 For #13845 - Add search suggestion hint 4 years ago
Jonathan Almeida 37f2cb1697 For #14168: Fix click listener on migration button 4 years ago
Gabriel Luong 04dcfa5cab
For #8312 - Show Top Sites in a ViewPager (#14116) 4 years ago
Gilbert Gilb's 9430546d12 for #7584 - fix about libraries toolbar theme
fixes #7584 #13970
4 years ago
Elise Richards 433a20db50
Update string for FxA signin onboarding header (#14132) 4 years ago
sraturi 5ccbca25c0 for #13479, added a VisualCompletenessQueue.kt class to handle all the functionality related to visual completeness 4 years ago
ekager 655d2b8a88 For #12377 - Choice to hide no collections placeholder from homescreen 4 years ago
bawyap a1a211d6e4 FNX2-15608:Removes unused feature flag import 4 years ago
bawyap 83f6e2ae41 FNX2-15608:Removes unused feature flag 4 years ago
sraturi c73baae4e9 for #13478, letting go of the fragment resource inside onDestroyView of AddonsManagementFragment to avoid memory leak 4 years ago
mcarare 6c2220bffc For #13388: Use safe call for nullable swipeRefresh. 4 years ago
bawyap 88a2273e4c FNX2-15653:Removes empty check 4 years ago
bawyap 8641fa39e0 FNX2-15653:Removes unused import 4 years ago
bawyap fb02b8a314 FNX2-15653:Refactors check method 4 years ago
bawyap b57601df1e FNX2-15653:checks blanks name in homescreen shortcut name 4 years ago
Jonathan Almeida f3b870d356 For #11918: Take a screenshot when clicking the tab tray
We looked into taking a screenshot right before leaving the
BrowserFragment, however this call will always fail since it's
non-blocking (we never want it to be blocking too), and we will never
receive a screenshot when a session is detached from an EngineView
before the callback is complete.

In Fenix, we can nicely evade this by taking a screenshot when click
the tabs tray icon, which is where you would want to see the most
up-to-date thumbnail of the tab and also does not leave the
BrowserFragment as well.
4 years ago
kglazko 5ecab0f48a
For #13935: Enhanced File Type List Icons (#14036)
* For #13935: Enhanced File Type List Icons

* For #13935 - Pulls out and tests logic for getting the icon for a DownloadItem

Co-authored-by: Kate Glazko <kglazko@Kates-MacBook-Pro.local>
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
4 years ago
Kate Glazko 3370762248 For #13983: Show Only Completed Downloads in List 4 years ago
Kate Glazko 7f9e2255f7 For #13979: Deleted Download Files Shouldnt Show 4 years ago
Mihai Branescu 3e1bc524b9 For #11051 - added intent check for voice search
Also made the activity translucent so that it won't flicker when the user pressses the button and Google app is disabled
4 years ago
Mihai Adrian Carare ea688cce09
For #13938: Implement nav to notification settings for all OS versions. (#13972) 4 years ago
Jeff Boek 61cb052156 For #13473 - Addresses nits 4 years ago
Jeff Boek 18d829750c For #13483 - Checks if the device has a camera before showing the QR scanning button 4 years ago
Jeff Boek a11a5cefb0 No Issue - Fixes up linting errors 4 years ago
Jeff Boek 516268406f For #13473 - Fixes edge cases with Awesomebar not visible 4 years ago
Jeff Boek 8536284c08 For #13483 - Adds QR scanning to new search dialog 4 years ago
Jeff Boek d8f3050487 For #13473 - Adds pill_wraper to the search dialog 4 years ago
Kate Glazko 95970dbfef For #13974: Long Press Should Not Result In Crash 4 years ago
Elise Richards feae7fff2f
FNX-14498 ⁃ For #9487: improve fxa onboarding manual sign in card (#13317)
* Replace strings, add learn more, hook up button

* Constrain learn more and icon to the text

* View holder tests

* Lint

* Update homescreen ui test
4 years ago
Mugurell 499ff83b18 For #8578 - Don't attempt to use different addons icons backgrounds
After the change from AC #8054 specifying different addons icons backgrounds
is not possible anymore.
All favicons used all throughout the app will have the same background.
4 years ago
Kate Glazko 751efb7bfb For #13940: Pull To Refresh View Causes Throbber Downloads 4 years ago
Kate Glazko 86c5a38ed8 For #13939: Missing empty state for downloads view 4 years ago
Jonathan Almeida 0de8aedd6f No issue: Fix missing FeatureFlags imports 4 years ago
Kate Glazko 3c0334141c No Issue: Fix Lint Issues Downloads Manager 4 years ago
Jonathan Almeida 99fab556f4 For #12287: Address review comments 4 years ago
Jonathan Almeida f92485d1e8 For #12287: Add feature flag for Synced Tabs in tabs tray 4 years ago
Jonathan Almeida b54b743d83 For #12287: Show devices with no tabs in Synced Tabs list 4 years ago
Jonathan Almeida f614c0b18d For #12287: Add Synced Tabs to Tabs Tray 4 years ago
Elise Richards 2e62dd5c87
FNX-14546 ⁃ For #13096: Add notifications pref in top level settings (#13366)
* Add notifications pref in top level settings to route to Android app and notification settings

* Make pref visible on Oreo and higher

* Only show notifications pref when Oreo and above
4 years ago
Kate Glazko f83372b67c For #349: View Downloads 4 years ago
Jeff Boek 446f1d678e For #11656 - Adds addon user attributes to leanplum 4 years ago
Kainalu Hagiwara d49ca515f4 For #13330 - Remove feature flag for swipe to switch tabs. 4 years ago
Kainalu Hagiwara c119070e21 For #13030 - Use material design animation values for swipe to switch tabs. 4 years ago
Gilbert Gilb's 2743c37b40 Add custom Activity to show libraries licenses.
As Google's library for showing licences isn't open-source, this commit
reimplements its main Activity. This is in prevision to having an OSS
flavor of fenix.

We chose to not introduce dependencies to third-party libraries
such as AboutLibraries for now, and we'll stick to using Google's gradle
plugin for the dependencies extraction.

Fixes #7584

See also #162
4 years ago
ekager 54c24016ba For #13251 - Use bottomSheetCallback in multiselect mode 4 years ago
mcarare 1e223a8a53 For #13761: Add a11y change listener after toolbar is initialised.
Also removed it before reference is removed in onDestroy.
4 years ago
Arturo Mejia 5d14688448 For issue #12796: Ensure Cookie purging is only active in nightly or debug. 4 years ago
Sachin 4b85f3e53b
for #11364 added a resetAfter for onboarding variable inside HomeFragment to avoid random system strictmode violations during UI testing. (#13811) 4 years ago
Tiger Oakes a04b91ee3c
FNX-14513 ⁃ For #12862: Use concept-menu in library (#13332) 4 years ago
Simon Chae 2e61425f2b For #13256: Set add-on settings tab mode based on BrowsingModeManager 4 years ago
Tiger Oakes 57e557fd18
Use AC version of PrivateNotificationService (#12459) 4 years ago
Roger Yang da1579b361
Closes #13459: Pass DefaultLoadUrlUseCase to AppLinksFeature (#13460) 4 years ago
Kainalu Hagiwara 1ad9da09b0 Remove selection holder from bookmark viewholder constructors.
Now that we're passing the mode to the viewholders in their bind
methods, there's no real need to pass them into their constructors. This
also allows us to remove the indirection of having the adapter implement
the SelectionHolder interface and have the mode implement it directly.
4 years ago
Kainalu Hagiwara b1db1cf976 Add tests for Bookmarks DiffUtil and ViewHolders. 4 years ago
Kainalu Hagiwara 6d8cfe1a50 For #13156, #13280 - Use payloads to bind bookmark viewholders.
Change the DiffUtil callback for bookmarks to use the generated equals()
method instead of only checking the title and url fields. This prevents
the BookmarkNode in our state from getting out of sync with the
BookmarkNode the viewholder is bound to.
4 years ago
Tiger Oakes 1fab28f043 Add createInitialSearchFragmentState function 4 years ago
Kainalu Hagiwara afd0af1075
Clear button (#13842)
Co-authored-by: Darren <finchdarren25@gmail.com>
4 years ago
Arturo Mejia 88f01731d7 For issue #13827: "Set as default browser" option disappears from Settings. 4 years ago
Tiger Oakes c7611b529c For #13357: Validate PWA manifest folder 4 years ago
Tiger Oakes fce6b4488e
For #13176: Remove race condition for shortcuts (#13815) 4 years ago
Jonathan Almeida 4ba4b589de For #13293: Show Add To Collections after tabs load 4 years ago
Kainalu Hagiwara d9ffac0c89 For #13405 - Use toolbar location relative to the whole screen instead of window. 4 years ago
codrut.topliceanu f0a045f9b9 For #13390 - Fix for stuck readerMode appearance controls 4 years ago
Shen 0356d86784 For #12976 - Show infinity symbol in the tab counter when the count is greater than 99 4 years ago
Kainalu Hagiwara 2bdcbe5db9 For #11935 - Move BrowserThumbnails to BrowserFragment. 4 years ago
Sawyer Blatz e42a8f5fa2 For #11531: Fixes some issues with default event not firing 4 years ago
Kainalu Hagiwara ba0c0b134b For #13329 - Remove tab history feature flag. 4 years ago
Kainalu Hagiwara a5e9542a6b For #13016 - Only scroll to current page in tab history after the initial layout. 4 years ago
Kainalu Hagiwara 52d4ffdef0 For #13424 - Fix detekt config and warnings. 4 years ago
Mugurell b993b94be1 For #12857 - Use Collection title when sharing tabs collection
Avoided passing the subject for sharing a collection of tabs in the ShareData
object since ShareData is part of a web standard.
4 years ago
Arturo Mejia c52e4fd9f5 For issue #7620: Add support for external download managers 4 years ago
Kainalu Hagiwara 09473b991d For #12926 - Add back button to menu. 4 years ago
Sebastian Kaspari 77263aad70 Validate deep links. 4 years ago
Jonathan Almeida 9568bdaed8 Update Android Components and fix breaking tests 4 years ago
Kirill Rakhman bee2ae6c83 Closes #8043 Hook up AwesomeBarView.setOnEditSuggestionListener 4 years ago
Matthew Finkel a1b7e61d36 For #13361: Prevent Sentry usage behind isSentryEnabled 4 years ago
Jeff Boek 06ba8a0200 For #13053 - Handles common dismiss interactions 4 years ago
Jeff Boek 682b082100 For #13052 - Bumps feature flag to Nightly builds as well 4 years ago
Jeff Boek 540c1d2ada For #13052 - When opening a new tab pre-open search 4 years ago
Jeff Boek c4d32bd75c For #13325 - Positions toolbar according to user preference 4 years ago
ankur dd5bb94f8c For #13301, #13038: hide overflow menu for all bookmark items in selected mode 4 years ago
Sebastian Kaspari c93a29f89a Simplify build variants to just: debug, nightly, beta and release.
Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
4 years ago
Emily Kager 37b166d033
For #13298 - Make private tabs in tabs tray not long clickable (#13316) 4 years ago