Tiger Oakes
79e58250fc
Make Settings.instance private
2019-08-22 08:14:08 -07:00
Sebastian Kaspari
f62e295fc6
Closes #4874 : Use new build types in FeatureFlags class.
2019-08-22 08:12:49 -07:00
Tiger Oakes
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
Jeff Boek
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
Colin Lee
051ae9f584
For #3869 : Switch to A-C SearchLocalizationProvider ( #4858 )
...
* For #3869 : Switch to A-C SearchLocalizationProvider
* Fix test
2019-08-21 11:14:59 -07:00
Mihai Adrian
df3e1bf9d3
Fixes #4795 fixed requestDesktopStateProvider value from private to desktopMode ( #4810 )
...
RequestDesktopStateProvider was taken from private instead of desktopMode
2019-08-21 09:10:06 -07:00
Tiger Oakes
aab357845b
No issue: Clean up preferences code ( #4699 )
2019-08-21 08:38:14 -07:00
Emily Kager
c1b1c2f332
For #3967 - Invokes pending deletion with more bookmark actions ( #4522 )
2019-08-21 08:36:41 -07:00
Jonathan Almeida
71a2478f4d
Use Mozilla Android Components 10.0.0
2019-08-21 10:06:05 -04:00
Emily Kager
416e25e8a5
No issue: Don't show session provider in private mode
2019-08-20 16:09:55 -07:00
Yeon Taek Jeong
6f899c7fb5
For #2834 : Delete all Private Tabs redesign ( #4787 )
2019-08-20 13:10:08 -07:00
(´⌣`ʃƪ)
c076cc85f9
For #4436 : Dismiss onboarding before navigating away from home ( #4801 )
2019-08-20 10:56:28 -07:00
Tiger Oakes
33f3b14c29
Adds setters and property delegates in Settings ( #4809 )
...
* Change Settings to use setters
* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
Tiger Oakes
ac6c1ec2ee
Closes #2690 - Clean up CreateCollection viewmodel ( #4731 )
2019-08-20 10:45:41 -07:00
Tiger Oakes
9ee8c00928
For #4774 - Use vector drawable compat ( #4811 )
2019-08-20 10:43:02 -07:00
Tiger Oakes
ad98b2f3ea
For #4744 - Extract private browsing button ( #4813 )
2019-08-20 10:41:18 -07:00
Tiger Oakes
090e8006b0
Color the system bars in custom tabs ( #4819 )
2019-08-20 10:13:01 -07:00
Tiger Oakes
95ef312b1e
Issue #1000 - Remove isCustomTab flag ( #4656 )
2019-08-20 10:00:49 -07:00
Sourabh
1afc0eacd8
For #4399 : Create LibState Controller for Search ( #4673 )
...
* For #4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
Mugurell
ab6e7dc52b
Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
2019-08-20 13:45:55 +02:00
Tiger Oakes
b8c93107c0
For #4744 - Extract TransitionPreDrawListener ( #4812 )
2019-08-19 16:27:43 -07:00
Tiger Oakes
a632d8f1dc
For #4744 - Move search bar icon padding to dimens ( #4814 )
2019-08-19 16:22:51 -07:00
Emily Kager
fb1d655d96
Closes #4822 - Update Bookmark State in onResume ( #4823 )
2019-08-19 16:22:20 -07:00
Sawyer Blatz
0d4eceed56
For #2706 : Refactor Glean to reduce errors ( #4753 )
...
* For #2706 : Adds recording for untracked events
* For #2706 : Adds key alignment to Metrics
2019-08-19 15:25:48 -07:00
Sawyer Blatz
4731977f5d
For #4421 : Fixes issues with new glean events ( #4816 )
2019-08-19 14:49:48 -07:00
Sawyer Blatz
73e3db8fe0
For #4804 : Resolves issue with crash reporter stack
2019-08-19 16:40:41 -04:00
Arturo Mejia
210868f5bc
Use Mozilla Android Components 9.0.0-SNAPSHOT. ( #4750 )
2019-08-19 10:29:10 -07:00
Suraj Shah
806961094b
Fixes #4704 ( #4728 )
...
* Fixes #4704 . Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.
* Updates CHANGELOG.md
* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
2019-08-19 09:23:12 -07:00
Mugurell
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Tiger Oakes
de14962e3f
Extract quick action sheet observer code ( #4368 )
2019-08-19 08:28:33 -07:00
Emily Kager
7d02354f4f
For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController ( #4800 )
2019-08-18 20:36:40 -05:00
Colin Lee
d1aed157dd
For #4686 : Fix potential security issue ( #4764 )
2019-08-16 16:50:54 -05:00
Yeon Taek Jeong
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
Yeon Taek Jeong
a680d733c8
For #4384 : Hide mic icon if speech-to-text is unavailable ( #4701 )
2019-08-14 16:40:21 -07:00
Yeon Taek Jeong
2441592ef2
For #4516 : Use full width for large search widgets ( #4659 )
2019-08-14 16:00:13 -07:00
Emily Kager
f71106cb51
Closes #3860 - Update description text for collections
2019-08-14 17:13:52 -04:00
Sawyer Blatz
b7ca520787
For #4421 : Adds Leanplum events and attributes ( #4626 )
...
* For #4421 : Adds Leanplum events and attributes
* For #4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
67f3b63ae5
For #4421 : Add search widget attribute to Leanplum ( #4694 )
2019-08-14 12:00:29 -07:00
Yeon Taek Jeong
f5ffe3734c
For #4457 : Adds telemetry for search widget actions ( #4714 )
2019-08-14 11:39:54 -07:00
Yeon Taek Jeong
2f265eccbd
For #4732 : Fix search engine display issue ( #4735 )
2019-08-14 11:03:14 -07:00
Michael Cooper
12371ca9c1
Add no-op experiment to test service-experiments integration ( #4551 )
...
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
2019-08-14 12:07:41 -05:00
Tiger Oakes
3acabeb6c3
Use global navigation action for browser fragment ( #4691 )
2019-08-14 11:58:29 -05:00
Colin Lee
5b4a441bcb
For #1667 : Screen reader can't reach other UI items when QAB expanded ( #4695 )
2019-08-14 09:56:29 -07:00
Emily Kager
1328d686aa
No issue - Autoformatting ( #4715 )
2019-08-14 09:40:46 -05:00
Sourabh
42e3b2771e
fix #4633 : show toast only on first login ( #4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
2019-08-13 16:28:34 -05:00
(´⌣`ʃƪ)
5aac05859d
Fix #4436 : hide onboarding before navigating to settings ( #4675 )
...
* Fix #4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
2019-08-13 15:49:42 -05:00
Sebastian Kaspari
d03c15d15c
Issue #4431 : Integrate feature-media component (Nightly and debug builds only). ( #4683 )
2019-08-13 15:02:20 -05:00
Colin Lee
0c8bcd39be
For #4652 : HomeFragment Crash "Can not.. after onSaveInstanceState"
2019-08-12 15:51:49 -04:00
Jorge De Los Santos
337ad1e88e
For #3424 - Make talkback ignore ImageButton in Collection Sele… ( #3792 )
...
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
2019-08-12 11:49:25 -04:00
Grisha Kruglov
b38b94ed79
Closes #4671 : Fix a potential NPE in BookmarkFragment
2019-08-12 11:16:28 -04:00
Grisha Kruglov
634ee184a6
No issue: add some BookmarkFragmentInteractor tests
2019-08-09 17:27:58 -07:00
Grisha Kruglov
f323105163
No issue: reduce code duplication in BookmarkFragmentInteractor
2019-08-09 17:27:58 -07:00
Christian Sadilek
5fe05e919a
For #4125 : Suppress coroutine warning to fix release build
2019-08-09 17:30:27 -04:00
Sawyer Blatz
0ec92d716f
For #4123 : Adds telemetry for quick action open in app ( #4629 )
2019-08-09 13:51:12 -07:00
Yeon Taek Jeong
6c9ce784b1
Fix, add some tests
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
2a6069bfb7
Fix rest of issues
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
69434a765f
Fix most issues
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
faf0ecbcc0
For #4125 : Migrate Sign in to Sync to Libstate
2019-08-09 13:39:51 -07:00
Colin Lee
7f07eabbd8
For #4652 : Crash "Can not perform this action after onSaveInstanceState" ( #4654 )
2019-08-09 14:46:40 -05:00
Tiger Oakes
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
Jonathan Almeida
23f5ac0fb9
For #4066 : Create InflationAwareFeature for lazy inflation
2019-08-09 11:48:55 -04:00
Colin Lee
519c3bde5d
For #4066 : Provide lazy inflation of Find In Page View
2019-08-09 11:48:55 -04:00
Colin Lee
c9c43260c9
For #4529 : Handle crash initializing CreateCollectionViewModel late ( #4628 )
2019-08-08 17:40:55 -05:00
Christian Sadilek
e26570054a
Suppress warning in LeanplumMetricsService to fix release builds
2019-08-08 15:17:12 -04:00
Mathieu Leplatre
04daf21437
Fix #4612 : Fetch experiments from Remote Settings CDN
2019-08-08 10:15:01 -07:00
Colin Lee
ef97173cd9
For #4529 , #4427 : Resuming after restoring instance state breaks UI ( #4571 )
...
* For #4529 , #4427 : Resuming after restoring instance state breaks UI
* Clear up warnings
2019-08-08 11:05:01 -05:00
Sawyer Blatz
ff6e9bccb7
For #4451 : Adds tests for DefaultBrowserToolbarController ( #4493 )
...
* For #4451 : Adds tests for DefaultBrowserToolbarController
* Continue working
* Large refactoring of test
* Mock analytics
* Fix merge conflicts
2019-08-08 09:02:42 -07:00
Hakkı Kaan Çalışkan
0ea595743d
Fixes #4562 : Add a-c git hash to about page
2019-08-07 16:59:11 -07:00
Emily Kager
0b98d43c23
Closes #4602 - Add back transitions
2019-08-07 16:56:21 -07:00
Sawyer Blatz
4566bd6fba
Fixes feedback
2019-08-07 16:41:29 -07:00
Sawyer Blatz
4d14735935
For #3060 : Adds Leanplum attributes for fxa syncing
2019-08-07 16:41:29 -07:00
Sawyer Blatz
9d65e665e5
No issue: Removes deprecated usage of ViewModelProviders
2019-08-07 19:21:41 -04:00
Yeon Taek Jeong
ec4d62c895
Fix ktlint
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
00bd26abe3
Remove task flags
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
f952234c57
Keep CLEAR_TASK
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
c87468d031
Remove popBackStack
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
a8526a0606
For #4438 : Fix crash when opening any URL from URL bar w/ long press
2019-08-07 19:17:56 -04:00
Sawyer Blatz
969d17b4a9
For #969 : Adds more telemetry for collections ( #4539 )
2019-08-07 16:05:20 -07:00
Sawyer Blatz
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
Grisha Kruglov
f23f3b7489
Closes #4467 : Use a-c version of FirefoxAccountsAuthFeature
2019-08-07 13:42:39 -07:00
ValentinTimisica
59c60ef189
Fixes #4354 : Updated SearchFragment state after returning from SearchEngineFragment.
...
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
2019-08-07 13:19:53 -07:00
Colin Lee
a514cb3f8c
No issue: Add OSS licenses link to About page
2019-08-07 12:40:10 -07:00
Sawyer Blatz
f9288c7fbd
For #969 : Finalizes collections telemetry ( #4592 )
2019-08-07 10:26:52 -07:00
Emily Kager
8194e0778e
For #4026 - Update BookmarkDiffUtil to update on Title or URL change
2019-08-07 00:37:16 -04:00
Emily Kager
0604e9858d
Closes #3939 - Adds strings for delete browsing history
2019-08-06 16:06:56 -07:00
ValentinTimisica
71aedc79fe
Fixes #3922 : Added accessibility announcement for history empty state.
...
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
2019-08-06 12:32:59 -07:00
Tiger Oakes
631b7ba7cb
Issue #1000 - Split out common browser functions
2019-08-06 12:31:25 -07:00
Emily Kager
23bc8f4320
Fro #4563 - Update delete button alpha when history mode changes
2019-08-06 12:26:25 -07:00
Tiger Oakes
3c1ce90f6f
Fixes #2379 - Generic library selection
2019-08-06 11:10:50 -07:00
Yeon Taek Jeong
6f962d3376
For #1744 : Open search shortcuts when entering search mode ( #4536 )
2019-08-05 15:07:03 -07:00
Emily Kager
6f7ae227a8
Closes #4540 - Set correct tint for select bookmark folder icon ( #4541 )
2019-08-05 14:54:39 -07:00
ekager
5edc9d0b4e
For #2021 - Update custom preferences' views with email/account changes
2019-08-05 09:53:27 -07:00
Travis Long
51218bc93e
Integrate service-experiments component ( #4098 )
2019-08-05 11:14:42 -05:00
Emily Kager
a526e0fad3
For #4455 - Rename history headers by hours and days ( #4478 )
2019-08-05 11:12:22 -05:00
Nikit Bhandari
8aecc2b850
For #4530 Reduce build warnings ( #4531 )
2019-08-05 11:10:57 -05:00
ekager
d0071d0177
For #4495 - Clean up homescreen toolbar focus and content descriptions
2019-08-05 08:58:03 -07:00
Sören Hentzschel
bfd4849064
For #1427 - enter multi select mode with single click on favicon in library
2019-08-03 16:43:51 -07:00
Nikit Bhandari
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
Nikit Bhandari
1cb9f88787
For #4199 make checkbox disabled when there is no data ( #4200 )
...
* For #4199 make checkbox unclickable when there is no data
2019-08-02 17:42:39 -07:00
Tiger Oakes
1e4399ee38
Use auto pause with BrowserFragment observers
2019-08-02 17:32:58 -07:00
