Michael Comella
f19c9920f9
For #13959 : move resetAfter into StrictModeManager.
...
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
2020-09-28 18:01:19 -07:00
Michael Comella
6abeb2d9e7
For #13959 : change StrictModeManager to class from object.
...
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
2020-09-28 18:01:19 -07:00
Christian Sadilek
d4ab728cff
For #14034 : Add debug preference to override AMO collection in Nightly
2020-09-28 17:25:52 -04:00
Michael Comella
a92356fe00
For #13959 : comment about duplication in logic in StrictMode.
...
I had to drop a commit that addressed the issue because it was too hard
to fix.
2020-09-28 13:52:40 -07:00
Michael Comella
e1bd6191c7
For #13959 : add comment to explain why we only resetAfter in certain build modes.
2020-09-28 13:52:40 -07:00
Michael Comella
3bf71ef655
For #13959 : use ac StrictMode.resetAfter rather than duplicating functionality.
2020-09-28 13:52:40 -07:00
Michael Comella
2c1befaa25
For #13959 : rename to attachListenerToDisablePenaltyDeath for clarity.
2020-09-28 13:52:40 -07:00
Michael Comella
c03c7ef793
For #13959 : remove unused penaltyDialog parameter.
...
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
2020-09-28 13:52:40 -07:00
Michael Comella
f05a542060
For #13959 : always enable detectNonSdkApiUsage.
...
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
2020-09-28 13:52:40 -07:00
Sebastian Kaspari
3983c509dc
Use "undo" implementation from Android Components.
...
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
2020-09-28 10:04:46 -07:00
mcarare
6289da892c
For #15310 : Also catch ActivityNotFoundException when sharing to app.
2020-09-28 13:29:17 +03:00
ekager
0d0a28d551
No issue: Update AC to 61.0.20200925190057
2020-09-26 12:21:10 +02:00
ekager
7d5c199e51
For #12383 #15407 #12860 - Switch to using shared view model for session to delete on home
2020-09-25 16:54:54 -07:00
Grisha Kruglov
2999f64d0a
Closes #15434 : Don't try to display a 'signed in' snackbar in a 'headless' mode
2020-09-25 15:31:07 -07:00
Grisha Kruglov
d98eba1d64
Closes #15432 : Invoke UI updates on main thread in response to account events
2020-09-25 15:30:48 -07:00
Grisha Kruglov
24985d54fa
Closes #15436 : Auto-close tabs during startup on the main thread
2020-09-25 15:11:21 -07:00
mcarare
04e59e0ac5
For #15130 : Remove "what's new card" from onboarding screen.
2020-09-25 18:04:48 +03:00
Kate Glazko
e8855c09e6
For #15320 : Ensure Mimetype Other PDF Shows PDF Icon
2020-09-24 13:49:51 -07:00
Elise Richards
1adf467248
For #14280 , #14743 : Remove old search fragment ( #15169 )
...
* Remove search fragment
* Use new folder to search dialog
* Rebase and lint
* Update tests with search dialog nav directions
* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
2020-09-24 15:46:42 -05:00
Jonathan Almeida
add60611b4
For #15349 : Fixes SyncedTabs suggestion not clicking
2020-09-24 15:35:06 -04:00
Grisha Kruglov
f1b0827a0b
For #15296 : Allow excluding bookmark subtrees when editing parent folder
...
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
2020-09-23 23:22:44 -07:00
Sawyer Blatz
0fa2509bef
For #14243 : Pre-land visuals for Close Tabs CFR ( #15171 )
2020-09-23 14:57:52 -07:00
Grisha Kruglov
71b51146cb
Update breaking changes in the FxA/Sync integration
2020-09-23 14:51:04 -07:00
Jocelyne
d45e482373
For #11800 : Hide reveal and clear password icons if the password is empty when editing a saved login ( #15244 )
...
Co-authored-by: Jocelyne Abi Haidar <jocelyne.abihaidar@gotocme.com>
2020-09-23 12:10:49 -07:00
mcarare
c1bf66618e
#274-android-l10n: Update create account string to avoid partial translations.
2020-09-23 08:49:23 -07:00
person808
baccb153b7
For #15219 - Fix tab tray handle size.
...
Also use dimens for the tab history handle.
2020-09-22 15:24:22 -07:00
ekager
24983af94e
For #15291 - Limit current CFRs to show max one every 3 days
2020-09-22 10:43:14 -07:00
mcarare
94d9a2a1ed
For #15263 : Properly update open links in app preference.
2020-09-22 09:44:32 -07:00
ekager
a9075ff87b
For #15272 - Remove bottom margin for toolbar on enter fullscreen
2020-09-22 08:34:29 -07:00
ekager
030d6a5b36
For #15121 - Ensure tabs removed while on browser select an available parent session
2020-09-22 08:33:39 -07:00
mcarare
896c1b7875
For #15268 : Use safe navigation to addon details fragments.
2020-09-22 18:23:17 +03:00
Grisha Kruglov
f51b570654
For #15284 : Process root titles when creating new folders
...
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
2020-09-21 20:03:04 -07:00
ekager
f16ade33df
For #15089 - Disable recently closed in multiselect
2020-09-21 18:35:08 -07:00
ekager
b5f1e772bd
For #15112 - Still show recently closed when history empty
2020-09-21 18:35:08 -07:00
Grisha Kruglov
5691088787
For #15286 : Don't crash when separators are long-touched
2020-09-21 18:34:08 -07:00
ekager
9a2103a9a7
For #13934 - Make TabHistory work on PWA/Custom Tabs
2020-09-21 16:07:56 -07:00
ekager
407c31fdb3
No issue: Fixes strict mode death in debug custom tab
2020-09-21 12:59:33 -07:00
ekager
9e876ebc44
For #14982 - Show snackbars with padding with static bottom toolbar
2020-09-21 10:05:28 -07:00
ekager
18ca211434
For #14458 - dismiss keyboard on fill link from clipboard
2020-09-21 08:27:46 -07:00
ekager
e162aefbc6
For #15245 - Remove margin for toolbar on toolbar-less PWA
2020-09-20 19:41:29 -07:00
Grisha Kruglov
b7b3ee5ce6
For #2792 : Display bookmark folders at the top of the bookmarks UI
2020-09-18 22:01:17 -07:00
Grisha Kruglov
078843675b
For #15211 : Make sure bookmarks are moved to the end of folders
2020-09-18 21:52:58 -07:00
Grisha Kruglov
027c1f9ea7
Closes #15206 : Only track 'move' event if bookmark parent was changed
2020-09-18 21:52:58 -07:00
Grisha Kruglov
b5b32ba6ea
For #11502 : Make sure to always process root titles for parent folders during edit
...
This also switches to a simpler bookmarks query API ('getBookmark') which doesn't fetch
children. We don't need 'children' for this dialog, and so don't need to do the extra work.
2020-09-18 21:16:57 -07:00
Grisha Kruglov
958474f9fb
For #13157 : Filter out folder being edited from 'select folder' dialog
2020-09-18 20:13:45 -07:00
Grisha Kruglov
fe288edb5d
Rename 'visitedAddBookmark' arg to a less confusing name
2020-09-18 20:13:45 -07:00
Grisha Kruglov
24de85f805
Remove unused nav arg from 'select folder'
2020-09-18 20:13:45 -07:00
Tiger Oakes
b563576335
Closes #14131 : Move constants to dimens.xml ( #14135 )
...
Co-authored-by: Elise Richards <erichards@mozilla.com>
2020-09-18 16:13:57 -07:00
Elise Richards
a4ff782565
For #13812 : add ETP category for redirect trackers ( #15139 )
...
* Feature flag for ETP cookie purging
* Strings for new ETP description
* Remove icons from ETP info screeen and add category for redirect trackers
* ETP policy factory tests
* Remove icons from ETP panel and add cross tracking allowed field.
* Remove icons on ETP panel. Add blocked category for redirect trackers to panel.
* Add margins to tracking protection settings
2020-09-18 14:03:51 -05:00
Jeff Boek
6781018556
For mozilla-mobile/android-components#8429 - Dont initialize MLS if token is null
2020-09-18 11:51:50 -07:00
Jeff Boek
8bdc9d0431
Revert "For #12544 - Prevent search engines mixup"
...
This reverts commit 0a4a170f7e
.
2020-09-18 11:51:50 -07:00
Hakkı Kaan Çalışkan
0afb7a3f25
For #13922 : Add indicator to synced tabs suggestions in awesomebar
2020-09-18 09:54:19 -07:00
Jonathan Almeida
d063cd5396
For #14230 : Stop redrawing all top sites when one is removed
2020-09-18 12:53:23 -04:00
mcarare
5b33044999
For #12829 : Add create account option on the the sign in screen.
2020-09-18 09:04:54 -07:00
mcarare
81985f4179
For #12829 : Update addUnderline extension function to accept parameters.
2020-09-18 09:04:54 -07:00
mcarare
cc9667f722
For #15150 : Do not show open banner if open in app is ON in settings.
2020-09-18 10:47:02 +03:00
mcarare
79135b1df5
For #13943 : Change strict mode penalty to penaltyDeath.
...
Also, keep dialogPenalty as replacement option for penaltyDeath.
2020-09-18 09:45:08 +03:00
Sören Hentzschel
55b5a452d1
For #14933 - Fixed private browsing icon color in preferences fragment
2020-09-17 16:41:02 -07:00
Tiger Oakes
b927b688c9
Merge bookmark item and folder view holders
2020-09-17 15:59:42 -07:00
Tiger Oakes
3059a57747
Change separator to use its own view holder
2020-09-17 15:59:42 -07:00
Elise Richards
9afe9679d8
For #15079 : handle QR permissions when changed in Android settings ( #15097 )
...
* Define intent data for activity
* Search dialog shows permissions for allow and deny camera
* Check camera permissions for fxa pairing
* Check camera permissions for old search
* Tests for pairing sync interactor and controller.
* Cleanup
* Use bool pref for setting. Use interfaces and default implementations for the sync interactor and controller.
* Lint
2020-09-17 16:41:28 -05:00
Sawyer Blatz
1f17371df6
For #14565 : Add telemetry for top sites
2020-09-17 10:06:39 -07:00
Arturo Mejia
19f0c543fe
Fix add-ons permissions breaking change
2020-09-17 09:48:57 -07:00
mcarare
e5a9311613
For #15116 : Also do not expand or set bottom toolbar behavior on TWA tabs.
2020-09-17 09:30:27 -07:00
mcarare
83478b9db4
For #15116 : Do not set bottom toolbar behavior on PWA tabs.
2020-09-17 09:30:27 -07:00
mcarare
c5a2e2e5a0
For #15116 : Do not expand toolbar on PWA tabs.
2020-09-17 09:30:27 -07:00
mcarare
1f004aff8c
For #15116 : Use safe cast for layout params.
2020-09-17 09:30:27 -07:00
Sebastian Kaspari
ee3384ac52
Issue #14225 : Remove task when finishing ExternalAppBrowserActivity.
2020-09-17 18:13:47 +02:00
Hakkı Kaan Çalışkan
f87ca730a9
For #11245 : Integrate Synced Tabs AwesomeBar suggestions
...
fix pr
2020-09-15 13:58:29 -04:00
Jeff Boek
c632b6b0a1
For #15007 - Puts swipe to delete behind a feature flag ( #15009 )
2020-09-14 15:20:46 -07:00
codrut.topliceanu
b892af773e
For #14546 - Speculative fix for ANR
2020-09-14 09:10:28 -07:00
Gabriel Luong
05857ba55d
For #14145 - Add pinned badge for pinned sites
2020-09-11 20:42:40 -04:00
Mugurell
75aa2d413a
For #14974 - Ensure website bottom elements stay at bottom
...
engineView.setDynamicToolbarMaxHeight(0) vs
engineView.setDynamicToolbarMaxHeight(toolbarHeight)
ensures webpage's bottom elements are aligned to the bottom of the browser.
We also need to make sure that when the toolbar is static it does not cover the
bottom of the page - something desired when the toolbar was dynamic.
For this the engineView will have a toolbarHeight bottom margin.
2020-09-11 16:39:34 -07:00
codrut.topliceanu
b5cf484360
For #14559 - Persist searchFragment keyboard status
2020-09-11 13:58:47 -07:00
Elise Richards
4afaf34a78
Access shared prefs in fxa pairing ( #14997 )
2020-09-11 14:56:03 -05:00
Jeff Boek
79180250ea
For #14283 - Fixes overlapping search suggestions and hint
2020-09-11 12:25:09 -07:00
ekager
09fbb43f80
For #2486 - Adds Recently Closed Tabs
2020-09-11 12:02:30 -07:00
ekager
b986730031
No issue - Updates AC to 58.0.20200910190642 and fixes imports
2020-09-11 10:57:24 +03:00
Mugurell
b54949e58f
For #14902 - Disabling bottom toolbar animation now works ( #14927 )
2020-09-10 18:06:38 -07:00
Jeff Boek
f9b2d65993
For #5745 - Create preference to disable domain autocompletion
2020-09-10 17:39:42 -07:00
Elise Richards
87bd44145f
For #14239 : Notification for QR scan when permissions have been denied ( #14553 )
...
* Show dialog when permissions are denied
* Add qr permissions dialog to search dialog fragment
* Add qr permissions dialog to the pairing screen
* Show dialog after permissions have been denied
* Reset focus after denying permissions
* Show dialog after permissions denied in search frag and par frag
* Use shared preferences to store camera permission state
* Move dialog creation into the search controller and add tests
* Dialog controller implementation and test
* Route to intent with correct activity. Set focus when dismissing dialog
* Get preferences in old search
2020-09-10 19:09:38 -05:00
Mugurell
a6a50d78e0
For #14903 - Prevent BrowserFragment's view leak
2020-09-10 18:25:54 +03:00
ekager
82d7313add
For #13467 For #14910 - Dismiss dialog on blank URL commit
2020-09-09 20:51:54 -07:00
ekager
806f74abe7
For #14680 - Revert ObserverRegistry changes to WifiConnectionMonitor
2020-09-09 20:49:56 -07:00
Michael Debertol
4142c36820
For #14212 : Pass historyStorage to ToolbarView
2020-09-09 20:47:43 -07:00
Michael Debertol
cc8aa1f381
For #13423 : Pass isPrivate flag to ToolbarView
2020-09-09 20:47:43 -07:00
Sören Hentzschel
103c183265
For #14194 - avoid leak when opening the "Libraries that we use" screen
2020-09-09 14:40:15 -07:00
Jeff Boek
66ecc15b40
For #14543 - Prevents IllegalStateException by not moving to another thread
2020-09-09 13:21:49 -07:00
mcarare
4de80a0493
For #14540 : Fix updating list and item info for a11y services.
2020-09-09 11:31:52 -07:00
Gabriel Luong
6d133c8d0c
For #14529 - Show a dialog when the top sites limit has been reached
2020-09-09 14:12:55 -04:00
ekager
de7e6663ce
Closes #14895 - Adds paste to context menu ordering preference
2020-09-09 10:51:59 -07:00
codrut.topliceanu
21cbbdc7c8
For #13949 - Turn off tip regarding beta/nightly
2020-09-09 08:42:40 -07:00
Mugurell
d8d896c500
For #10240 - New preferences to control gesture based features
...
Three new settings and one for which this patch just pre-lands the strings.
The behavior for the "Swipe toolbar up to open tabs" is to be added as part of
a later ticket.
2020-09-09 08:21:05 -07:00
Tiger Oakes
4b6a589f24
Extract checkbox selected mask ( #14308 )
2020-09-08 18:10:35 -07:00
Tiger Oakes
53d16e78e1
For #14460 : Fix PBM notification tint ( #14699 )
2020-09-08 17:56:25 -04:00
Tiger Oakes
043e061087
For #14376 : Reverse items with bottom toolbar ( #14451 )
2020-09-08 13:55:10 -07:00
Tiger Oakes
113241e8ce
Enforce IO thread inside of components ( #14704 )
...
* Automatically run PermissionStorage on IO thread
* Run TabCollectionStorage on dedicated scope + IO
* Update findSitePermissionsBy calls
2020-09-08 13:55:01 -07:00
Gabriel Luong
7aa6514499
For #14629 - Enable showing frequently visited sites ON by default ( #14630 )
2020-09-08 11:30:13 -07:00
Sebastian Kaspari
e0071341c7
Update to new state API and update Mozilla Android Components version.
...
The EngineSessionState of a tab is now always accessible through tab.engineState.engineSessionState. It will
never get cleared.
2020-09-08 18:08:01 +02:00
mcarare
c350a5f3b9
For #9506 : Add session observer to check conditions for displaying banner.
2020-09-07 10:22:14 +03:00