Commit Graph

2721 Commits (3e8cab19c02001c019a7fcaa5a444a143d6f0aa2)

Author SHA1 Message Date
Tiger Oakes 596c579bbb Replace nullable findPreference 4 years ago
Tiger Oakes 45ef88f6b9 Replace requireNotNull(findPreference()) 4 years ago
Tiger Oakes 3e03439259 Add requirePreference helper 4 years ago
codrut.topliceanu 0eb2f328dc For #11371 - Fix for Dynamic Download Dialog 4 years ago
David Walsh 3feab90b19 For issue #9949 - Bookmarks/History deletion inconsistencies
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648.
4 years ago
Tiger Oakes f6efb386d6 Add tests for addon details 4 years ago
Hakkı Kaan Çalışkan 8cbdce58e6 Update FxaServer.kt 4 years ago
Hakkı Kaan Çalışkan 670e03c3b2 Update app/src/main/java/org/mozilla/fenix/components/FxaServer.kt
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
4 years ago
Hakkı Kaan Çalışkan bd85a9c399 remove suppress and unnecessary otherwise = private 4 years ago
Hakkı Kaan Çalışkan 87a65d2445 For #9782: Clean up unused FeatureFlags
I've currently found out this ones unused.
webPushIntegration removed because looks like all fatal bugs solved as it said from note.
4 years ago
Sören Hentzschel 396cd61efa For #9712 - show "AC: " before AC version on "About" screen 4 years ago
Sachin 36b1c710e7
for #11617 added a resetPoliciesAfter ext function for StrictMode, and replaced all existing calls to "resetAfter" with "resetPoliciesAfter" (#11619) 4 years ago
Tiger Oakes d81aa62683 Fix PIP toolbar 4 years ago
Tiger Oakes d3d5c8934f Cleanup tests for toolbar controller 4 years ago
person808 9e3e95e351 For #11442 - Telemetry for tab counter menu. 4 years ago
Mihai Branescu 4f870e9251 For #6126 - moved the sessionObserver init to the onCreate
This helps because we will always need the observer to be initiated, not only when the `openToBrowser` method gets called. Example: Opening a tab from the tab tray had it's own method for opening the browser, causing this to not be called.
4 years ago
Jonathan Almeida e6da2bd910 Fix breaking APIs in TabsAdapter and ViewHolder 4 years ago
Tiger Oakes 704fc6f983 Use updated webapphidetoolbarfeature 4 years ago
Tiger Oakes fc96e188ab Convert flow from AC to livedata 4 years ago
David Walsh 149efc1683
For 9640 - Focus on last selected tab in tab tray with a11y turned on (#11487) 4 years ago
David Walsh 8b24cdec42
For 11428 - Focus on home screen address bar when tab tray new tab is tapped (#11429) 4 years ago
David Walsh 063cf457ba
For #11291 - Provide New Tab button when accessibility enabled (#11441) 4 years ago
liuche 35fa445165
Issue #11112 - Update empty collections string + tests. (#11538) 4 years ago
Arturo Mejia a36ec7279e No issue: Decrease the frequency for checking for new supported add-ons 4 years ago
Tiger Oakes 294f29768d Test logins settings 4 years ago
Sawyer Blatz 0a9afbed42 For #11380: Update migration tip text 4 years ago
Sawyer Blatz fffbadbfca
For #11118: Add browsing history suggestion in metrics (#11525) 4 years ago
Sawyer Blatz 13d077eb66
For #11269: Telemetry for new reader mode position (#11385) 4 years ago
Sawyer Blatz d1cd877374 For #11118: Add missing telemetry 4 years ago
mcarare 0ebfa4f947 For #11497: Disable pull to refresh in error states. 4 years ago
Jeff Boek 1639b1d3a1 For #11342 - Fixes missing space for the FAB 4 years ago
Tiger Oakes 651b2831fe Fix tests in toolbar controller 4 years ago
Sachin cd26ba9a9c
for #11364 added a exception list for manufacturers violating strict mode policies on startup (#11407)
for #11364 changed blackList -> exceptionList, added one plus to the list

change magic strings into const Val
4 years ago
person808 d14b39a56e For #2165 - Implement pull-to-refresh gesture to sync history. 4 years ago
mcarare 4b04a140fc For #11229: Update etp strict option title content description. 4 years ago
Sawyer Blatz 932a2f3703 For #11063: Update telemetry for etp settings 4 years ago
Tiger Oakes f0295048fa Remove Mockito 4 years ago
Jeff Boek cd3b6181b3 For #10374 - Adds quick contextual menu to tab switcher
Co-authored-by: person808 <kainaluh808@gmail.com>
4 years ago
Elise Richards 137d66a511
For 10172: Set edit text listeners (#11196)
* Set edit text listeners

* Set clearable icons and change with error states

* Clear text buttons show and hide

* Move error checks to afterTextChanged. Refactor. Remove unused color.
4 years ago
Tiger Oakes 31edbc924c
Fixes #9056 - Start Fenix activity on search in external app (#10932) 4 years ago
Tiger Oakes 4b064afb81
Add tests for ext package (#11334) 4 years ago
Christian Sadilek d16c70d8be Wire up UI to make add-on installation cancelable 4 years ago
ValentinTimisica bc53296603 For #11365: Reorganizes 'SettingsFragment' items
Moved all the functionality form 'DefaultBrowserSettingsFragment' to
'SettingsFragment'.
4 years ago
ekager 11697c1363 For #11390 - Removes redundant session observer init for ETP overlay 4 years ago
Sawyer Blatz 27c7ef5ad4 For #8775: Removes feature flag for dynamic bottom toolbar 4 years ago
ValentinTimisica f937c96c12 For #5148: Switch to the correct tab on media notification clicked
Processing the intent in OpenSpecificTabIntentProcessor to be able to switch
to the tab where audio/video is playing
4 years ago
David Walsh 1356b3e426 For 11271 - Provide useful tab counter message for accessibility 4 years ago
Tiger Oakes 96d2307df0 Add tests for widget 4 years ago
ValentinTimisica 3a28704fa6 For #11132: Replaces wrong icons from menus 4 years ago
ValentinTimisica dc37baff0b For #11132: Rearranges home menu items 4 years ago
Jeff Boek f41ca2f424 No Issue - Moves from being a tabstray observer to overriding tab use cases 4 years ago
Christian Sadilek 05496faa66 Clear speculative session on engine settings change 4 years ago
Sawyer Blatz 5445d34ac4 For #11357: Use AppCompatResources for reader mode icon 4 years ago
Jeff Boek 4ee1cd6716 For #11361 - Nulls out tabsFeature in the correct spot 4 years ago
Jeff Boek d8ef0722e3 For #11175 - Moves tab tray strings to be translated, fixes description of the fab string 4 years ago
ekager 6d4a673c6f For #8967 - Expose autofill logins setting in nightly 4 years ago
Mozilla L10n Automation Bot 5373a75f57 For #10502 - Show snackbar after adding tabs to collection from tab tray 4 years ago
Grisha Kruglov 8769d98e71 Pass crashReporter instance to RustLog 4 years ago
Sachin 8fdc28010d
for #10839 added IO coroutine to check onboarding stat from sharedpref (#11338)
changed coroutine scope to fragments lifecycle
4 years ago
Jeff Boek e4e7cc5108 For #11260 - Fixes lifecycle issues with the tabs tray
- Also check to make sure the fragment manager is still valid before trying to show the tabs tray

Co-authored-by: Emily Kager <emilykager@gmail.com>
4 years ago
Sawyer Blatz e9189dc089 For #11045: Add reader mode to urlView 4 years ago
Tiger Oakes 1a19b06227
Simplify `PhoneFeature` code (#10810) 4 years ago
Sachin 74948cb3f1
for #7225, Changed strictMode thread penalty to dialog on startup and back to logs after startup is done. (#10831)
for #7225, refactored and cleanup the branch.

for #7225, change strict mode policy only on main process.

for #7225, setting thread policy inside a seperate thread to keep it from getting overridden in activities.

for #7225 removed Handler().postAtFrontOfQueue as a solution due to unknown side effects. moved the enableStrictMode function to be static so we can reuse it.

for #7225 lint check

for #7225 created strict mode manager and moved enabledStrictMode function inside it.

for #7225 removed penalty death on network

for #7225 added allow disk access on thread for already existing violation


strict mode running in main process to see if it passes the gitlab check, will revert it if it doesnt

allowed diskread for super.onCreate for home activity

added comments for disk violation oncreate homeactivity

added fragment manager inside strictmode manager

allowed disk read for onboarding

allowed disk read for cachedTopSites
4 years ago
David Walsh d33080571b
For #11267 - Announce "Your open tabs will be shown here (#11272) 4 years ago
mcarare 512aa46224 For #11229: Update ETP cfr string and behaviour. 4 years ago
mcarare 91c27a023e For #11229: Update settings ETP copy. 4 years ago
mcarare a0d9189321 For #11229: Update onboarding ETP copy. 4 years ago
Jeff Boek 52c2fdb310
Remove tab tray feature flag (#11176)
* For #11171 - Removes feature flag for the new tab tray

* For #11171 - Removes all tab references from homeFragment

* For #11171 - Fixes unit tests

* For #11171 - Gets UI tests to compile and HomeScreenTest to pass

* For #11171 - Fixes `deleteMultipleSelectionTest`

* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`

* For #11171 - Fixes `openHistoryInPrivateTabTest`

* For #11171 - Fixes `openHistoryInNewTabTest`

* For #11171 - Fixes `openNewPrivateTabTest`

* For #11171 - Fixes tabbedBrowsingTests

* For #11171 - Fixes SettingsPrivacyTest

* For #11171 - Fixes TopSitesTest

* For #11171 - Fixes lint errors

* Ignore
4 years ago
mcarare 2d24369362 For #7725: Increase info button touch target while keeping size.
Also removed unnecessary touch delegate.
4 years ago
person808 8c47b988b8 For #10525 - Remove tab tray item dividers. 4 years ago
Jeff Boek bc53b94feb For #10989 - Fixes memory leak caused by retaining the TabTrayView and TabsFeature 4 years ago
Sawyer Blatz 1be2ec2cbf For #9488: Init widgetExperiment after Experimenter init 4 years ago
mcarare 886c1882c5 For #11230: Set default to false for allow screenshots in private setting 4 years ago
Dennis Schubert e41fc7841a Bug 1643132 - Add WebCompat Reporter feature. 4 years ago
Dennis Schubert d046d908fc Bug 1643132 - Remove native "Report site issue" functionality.
This will be replaced by the WebCompat team's system extension that ships as an android-component.
4 years ago
Sawyer Blatz 42f58a1984 For #9488: Add experimentation support 4 years ago
ekager 54df729fb3 For #8374 - Don't recreate ExternalAppBrowserActivity or finishing activities 4 years ago
Sawyer Blatz 9302d07d13 For #11118: Add toggle states to metrics ping 4 years ago
mcarare 5a23fb33f8 For #11182: Fix back button text update according to save step. 4 years ago
mcarare a910698007 For #11182: Set click listener also to icon button. 4 years ago
Gabriel Luong 9520c9dd32 For #8920 - [Telemetry] Send add-on ids in a metrics ping 4 years ago
mcarare 29f1800021 For #11182: Explicitly clone select tabs on updating SaveCollectionStep. 4 years ago
mcarare 68286d263a For #11182: Set click listener to full layout instead of just icon. 4 years ago
person808 9272026b7e For #10193 - Remove page title when sharing links 4 years ago
Tiger Oakes a7e74e308b
Migrate some SessionManager usage to BrowserStore (#10789) 4 years ago
mcarare 138c12696f For #11153:Add FLAG_SECURE on pause and clear on resume for private session. 4 years ago
David Walsh d862d58051 Scroll to the top of home when using the tab tray 4 years ago
mcarare 2090b11c97 For #10434: Handle cases when proc/$pid/stat is not accessible. 4 years ago
ekager ead3194d86 For #8759 - Allow recently used in share fragment to scroll 4 years ago
Jeff Boek 2dd0a3cb9e
Implement tab tray design improvements and fix close functionality. 4 years ago
Tiger Oakes 6317eea690 Add tests for some of collection creation 4 years ago
ValentinTimisica 591e2c9a6f Fixes #9696: Adds Add-ons menu item to the home menu 4 years ago
mcarare c4f7a32eae For #9583: Increase touch targets for onboarding elements. 4 years ago
Tiger Oakes 50441e28f1 Tests and cleanup for tracking protection 4 years ago
ekager 9ef4d9bdae For #10968 - Don't show ETP CFR if toolbar doesn't have window focus 4 years ago
Vishwa Patel 4da22c605a For #10834 - Adding Sync Tabs Feature in Fenix 4 years ago
Gabriel Luong 0300f15df1
Fix crash from TabThumbnailView where drawable is null (#11121) 4 years ago
Gabriel Luong 60b68a265a
For #10921 - Integrate BrowserThumbnails feature into the tabs tray (#11093) 4 years ago
Sawyer Blatz 82facbfa00 For #1216: Remove feature flag for voice search 4 years ago
David Walsh 84d9e5b1fb
For 11031 - Fix landscape mode for tab tray (#11084) 4 years ago
Jeff Boek a6e77e3e8f For #10848 - Fixes unit tests 4 years ago
Jeff Boek c8e8566668 For #10848 - Fixes navigationbar colors on tab dialog fragment 4 years ago
Jeff Boek f05890efec For #10848 - Fixes bug where selected index wouldnt be properly calculated in private mode 4 years ago
Jeff Boek d5c20bc0d0 For #10848 - Fixes menu background color 4 years ago
Jeff Boek 19a709a04d For #10848 - Fixes tab tray colors 4 years ago
Jonathan Almeida ce15763cc4 Use new AuotPushFeature.getSubscription API 4 years ago
Tiger Oakes 221792c074
Add tests for FenixOnboarding (#11057) 4 years ago
Gabriel Luong 63e529ac2b Added BrowserThumbnails dependencies 4 years ago
Jeff Boek 8662164b8a
Refactors the TabTrayDialogFragment to ditch that weird interactor (#11061)
* For #11056 - Removes unused argument when navigating to the collection creation fragment

* For #11056 - Moved the collection creation navigation logic to the TabTrayDialogFragment

* For #11056 - Moves navigating to the share screen from home/browser to the TabTrayDialogFragment

* For #11056 - We moved tab selection logic from home/browser to the tab tray dialog

* For #11056 - Moved new tab tapped logic to the tab tray dialog fragment

* For #11056 - Removes all interactor logic for the TabTrayDialogFragment

* For #11056 - Migrates the presentation / navigation around the TabTrayDialog to the androidx navigation library
4 years ago
Jeff Boek 3946ec11de
Polish homescreen (#11065)
* For #10505 - Adjusts wordmark margins

* For #10505 - Removes topsite header, fixes collections header size and removes divider

* For #10505 - Restyle the top site items on the homescreen
4 years ago
ekager 20e358228e For #11015 - Switch Default ETP Setting to Standard 4 years ago
Tiger Oakes 749c95e0f0
Add tests for ReaderModeController (#11049) 4 years ago
Mihai Eduard Badea 11df3aaca1 For issue#10727 - Logins auth redirect
Added an extension function that pops the backstack of the fragment so the user is redirected to the Logins and passwords screen.
This is done to force the user to re-authenticate if he wants to re-enter the saved logins flow.

Additionally, some UI elements are being hidden on each Fragment since they were remained visible on the Logins and passwords screen's UI.
4 years ago
Jeff Boek 58a42828a1 For #10496 - Fully expand bottom sheet when loaded 4 years ago
Jeff Boek 0566790257 For #10496 - Automatically scroll to the selected tab when you open the tab tray 4 years ago
ValentinTimisica 9f265fd62f Fixes #10064: Open help articles in normal tab instead of custom tab 4 years ago
David Walsh 267cf35edb For 11001 - Show close all tabs above tab tray 4 years ago
David Walsh a70ba76cc9 Provided unique no tabs message per mode 4 years ago
apoorv9990 3469eeed9e removed auto play permissions while determining isVisible for WebsitePermissionsState 4 years ago
apoorv9990 97704bfdbd Closes #9529: changed styling for permissions dialog to set proper padding
- Changed the visibility check to check just for the permissions shown instead of all the permissions in WebsitePermissionsState
- Added bottom padding to the permissions root view so there is balanced padding on top and bottom
4 years ago
Sawyer Blatz b06be1fcde For #9488 Add telemetry for search widget CFR 4 years ago
Sawyer Blatz 94d741864e For #9488: Add search widget CFR 4 years ago
Sawyer Blatz 27a85d86dc
For #10803: Hide voice icon in search if not available (#11005) 4 years ago
Christian Sadilek 7b5661ed10 Update Android Components version to 44.0.20200528190114
Pass store to download manager and service to address API changes.
4 years ago
Jonathan Almeida 63b4fcd4c4 For #11004: Fix invisible text on migration UI
For some text and colors, we were using the default styling where
possible. These styles contain references that react to theme changes
like dark mode. Since the migration UI does not respect these changes,
we should not use them.
4 years ago
David Walsh c0c895af33
For 10665 - Show the most recent tabs at the top of the tab tray (#10687) 4 years ago
ValentinTimisica 03284e2da0 Fixes #10674: Add SignInView only once 4 years ago
David Walsh 4fdac4d608
For 10734 - Open tab tray when collection is opened from Home (#10751)
* For 10734 - Open tab tray when collection is opened from Home

* Update to work with tab tray drawer
4 years ago
David Walsh ea4c342797
For #10877 - Show 'no tabs' message when no tabs are open (#10960) 4 years ago
Roger Yang 6cef0edd5e
Closes #10980: Stop sending native crashes to Sentry (#10982) 4 years ago
ValentinTimisica 7974a5c77c Fixes #10815: Sort login items on initial load 4 years ago
mcarare 9ec6ebc92a For #10969: Fix and clarify logic for checking showing PWA dialog. 4 years ago
David Walsh 248237290e
For #10865 - Implement 3 dot menu for tab tray (#10869) 4 years ago
David Walsh 54cb8f0194 Remove unused import 4 years ago
David Walsh 5e4fd460f8 Remove onTabClosed from interactor 4 years ago
David Walsh 8b843ac9e5 Fix elevation for snackbar and fab 4 years ago
David Walsh e9bcc9bb1e Move snackbar to TabTrayDialogFragment 4 years ago
David Walsh f653964ee1 For #10864 - Display snack bar to undo closing tabs 4 years ago
mcarare a59917cdc0 For #9626: Swap margin for padding and remove use of touch delegate.
Also remove text margin to maintain visual appearance.
4 years ago
mcarare d706b085a9 For #9626: Delay cloning ConstraintSet to only when needed for updating. 4 years ago
Mugurell d0e2d02b34 For #10948 - Avoid PWA onboarding if user already has them on screen
It is possible that after migration users would already have Firefox PWAs on
their screen.
Since they already know about this functionality, we should not promote it to
them with the one-off `FirstTimePwaFragment`.

To query installed PWAs we'll use an API available only on Android >= 26 which
means that we will probably have half of users with PWAs still see the
onboarding but half which will not.
4 years ago
Sebastian Kaspari 21bd379438 Issue #9815: Allow Intents to set HomeActivity.OPEN_TO_BROWSER. 4 years ago
Roger Yang 538a7917e4
Closes #10906: Add Open in app option in custom tab (#10929) 4 years ago
Tiger Oakes 2397695fe5
For #10596 - Redirect moz://a URL (#10688) 4 years ago
Simon Chae 422cf74731 For #8319: Integrate nest WebExtensionBrowserMenu support 4 years ago
mcarare 6e325d6242 For #6198: Update copy and position of pair QR code scan message. 4 years ago
Sebastian Kaspari b666fbe3fe CrashReporter: Set release channel specific sentry project URL. 4 years ago
Mugurell 2dfd833941 For #10844 - Fennec page shortcuts will open in normal tabs
This comes to resolve a small regression in which they were opened in new
custom tab.
4 years ago
Grisha Kruglov b26ac51e90 For #10494: Process HomeMenu builder changes on the main thread
Problem was that we were trying to process menu changes (in response to account manager events) on some background thread as that's what account manager emits them on, so some code internally in PopupWindow's dismiss handling (i think, didn't dig very deeply here) was silently giving up and we'd get into a bad state.

The reason this seemingly only happened if you quickly opened a menu on startup is because account manager isn't initialized until sometime after the startup finished. So the trick was to open the menu (and register account manager state callbacks) before it got initialized, so that the callbacks are invoked.

This should also reproduce in other, much more obscure ways, e.g. if you open the menu right before sync is scheduled to run in the background, change FxA password on another connected client, and then eventually receive a onAuthenticationProblem callback.
4 years ago
Sawyer Blatz 7067e5c000
For #8125: Add default top site telemetry (#10752) 4 years ago
sraturi 29d1893430 for #7032 add scroll listener to make the keyboard disappear on scroll.
touch listener was blocking the scroll
4 years ago
sraturi 4ee65755dc for #7032 fixed issue where pressing back button exited the application 4 years ago
sraturi 2c85a62a5e for #7032 removed recyclerview scroll listener from Awesomebarview 4 years ago
sraturi c8ec25fde9 fixed lint issues 4 years ago
sraturi 703a8ed565 added a onTouch listener to scrollview in search fragment to make it disappear on scroll 4 years ago
Jeff Boek 601aedda46 For #10504 - Removes "old" TabTrayFragment 4 years ago
Jeff Boek c32904a1d0 For #10504 - opens the tab tray and filters the tab based on the browser mode 4 years ago
Jeff Boek a674c5dfe7 For #10504 - cleans up tabLayout colors 4 years ago
Jeff Boek 4e499e7a48 For #10504 - Adds tabTrayDialogInteractor to browserfragment 4 years ago
Jeff Boek cc6a380d45 For #10504 - Show tab dialog on browserfragment 4 years ago
Jeff Boek 90cef752b0 For #10504 - Fixes up tab tray dialog styles 4 years ago
Jeff Boek 0b9484a172 For #10504 - Adds padding fto account for navigation bar in landscape 4 years ago
Jeff Boek dd2a26fc7c For #10504 - Added the tab tray to the TabTrayDialogFragment and wired up dismiss actions 4 years ago
Jeff Boek 34ac9df481 For 10504 - Adds dialog style and fab 4 years ago
Jeff Boek 97d66cce56 For #10504 - Creates the TabTrayDialogFragment 4 years ago
ekager 516a6fe9f7 For #6832 - Only emit session changes if fragment is attached 4 years ago
ekager 83ab7646c1 For #7602 - Integrate media fullscreen orientation feature 4 years ago
Christian Sadilek 4e25f41a41 For #1824: Prevent extremely long URLs from locking up HomeFragment 4 years ago
codrut.topliceanu 7feae98944 For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view
- Renamed DownloadNotification and removed DownloadState.dismissed dependency
- Improved DynamicDownloadDialog behaviour when scrolling
- DynamicDownloadDialog remains attached to tab until dismissed
- Fixed onTryAgain not working for resumed DownloadDialogs
4 years ago
David Walsh 346b4aa3fd
For #10321: Wire up play and pause buttons in tab tray (#10422) 4 years ago
Sawyer Blatz 477493e197
For #10465: Add telemetry for voice search (#10785) 4 years ago
David Walsh 2795a34b0b For 10731 - Don't show tab tray menu if there are no tabs 4 years ago
Sawyer Blatz 535e020683 For #1216: Put voice search behind a nightly & debug flag 4 years ago
Sawyer Blatz d33edd8841 No issue: Clean up SearchFragment a bit 4 years ago
Sawyer Blatz 011a9e7d96 For #1216: Add voice search 4 years ago
ekager d46369696f For #10718 - Finish activity after removing external session 4 years ago
Tiger Oakes cd64647a4d For #9286 - Add isDefault to topsites 4 years ago
Juan Goncalves ee62297b4c For #7854 - Update the views only if the bookmark node has changed
As the bookmark node data is loaded from storage every time the fragment's view is created, when the user navigates to the SelectFolderFragment and returns, the bookmark is loaded once again from storage, replacing the EditText's content (title and URL) which causes the loss of user input.

Validating that the loaded bookmark is different from the one that is already referenced in the fragment avoids unnecessarily replacing the `EditText`s values.
4 years ago
Emily Kager 32e74aae61 Revert "For #6313 - On first load, hides engineView until firstContentfulPaint"
This reverts commit d66762910f.
4 years ago
Emily Kager 9b16017d1d Revert "For #7032: Add scroll to dismiss keyboard in search fragment"
This reverts commit 536921bcea.
4 years ago
ekager d66762910f For #6313 - On first load, hides engineView until firstContentfulPaint 4 years ago
Sachin 536921bcea
For #7032: Add scroll to dismiss keyboard in search fragment
* added a onTouch listener to scrollview in search fragment to make it disappear on scroll

* fixed lint issues
4 years ago
Grisha Kruglov d37529e416 Perf telemetry for awesomebar suggestion provider durations
See mozilla-mobile/android-components#6802 for details; requires that PR.
4 years ago
Mihai Branescu 750ae4a340 For #10393 and #10469 - browser fragment now observes collection changes
Useful for links from other apps + adding a page to multiple collections
4 years ago
Christian Sadilek 7993f1017d Migrate feature-accounts to browser-state 4 years ago
sraturi 372bb421cc created kotlin doc for FenixApplication 4 years ago
Simon Chae 7cc4816618
For #10398: Add AddonInstallationDialogFragment support (#10608) 4 years ago
Elise Richards edc75c3ad0
Fixes #9504: Edit logins (#9693)
* Create editable view and fragment. Update login info page to display options menu with edit and delete.

* Create feature flag for edit. Check flag in the login detail fragment and default to just delete.

* Add three-dot kebab options menu in login detail fragment. Add title to the login item.

* Nav to and from edit view on save and back pressed.

* Save login through AC login manager. Clear text in editable field on button click.

* Match colors, fonts, dimens to UX specs for edit logins. Enable password reveal/hide and clearing text fields.

* Refactoring logins fragments. Using component Login object for consistency.

Fetch login list when saved logins are opened. Fetch login details when detail view is opened.

Revert "Fetch login list when saved logins are opened. Fetch login details when detail view is opened."

This reverts commit 44fe17166c3332b330229258b2e8982832672e3b.

* Using parcelable login and Login component class to pass ids and items between fragments

* Retrieve login from storage when viewing login details.

Rename login logic for consistency.

Ktlint cleanup

Fix nits and naming consistency.

* UX consistency for login detail and edit login pages

* Rebasing with logins sort - updating logins store.

* Rebasing with logins sort - merging fragments and controllers.

* Lint and removing unused files.

* UX cleanup.

* Update string description
4 years ago
Tiger Oakes f7b4f1c959
Cache findViewById calls in session control (#10575) 4 years ago
David Walsh 86dabe09c8
For 10503 - Update save to collection flow in tab tray (#10523) 4 years ago
mcarare 58df38105b For #10453: Use TabsTray API to set divider, avoiding related crashes. 4 years ago
Sebastian Kaspari d58c022619 Integrate activity for showing past crashes. 4 years ago
Jeff Boek a249334976
🎲 For #10332 - Adds undo snackbar when closing tabs in the tab tray (#10456) 4 years ago
Simon Chae 5ba9cc6ec9
For #10253: Add disableFirstTimePWAPopup for performance testing (#10442) 4 years ago
ValentinTimisica 15dfe0811d For #10343: Updates metrics accordingly to 'Library' removal 4 years ago
ValentinTimisica b2e5820364 For #10343: Remove 'Library' functionality from the app
Also adds Bookmarks and History items to browser menu.
4 years ago
Simon Chae ca7695854a
For #10552: Set initial add-on details fragment visibility to false (#10565) 4 years ago
Sawyer Blatz 17fb7c1df7
For #10426: Removes installation ping GAID (#10532) 4 years ago
Simon Chae d58e7d3138 For #10473: Fetch the addon from addon manager instead of the store 4 years ago
Sawyer Blatz b87c40d42f
For #10426: Sends GAID to Installation instead of Activation ping. (#10529) 4 years ago
codrut.topliceanu d1005dd236 For #8589 - Fix for accessibility navigation in ETP panel 4 years ago
Arturo Mejia ca01965f90 Fix PictureInPictureFeature breaking change 4 years ago
ekager 7fe6f68e00 For #10485 - Restore block video/audio on cellular data radio button 4 years ago
ValentinTimisica f63cb4e09f For #10244: Creates drawable for add-ons private browsing label.
The drawable is sent to AddonsManagerAdapter.Style constructor and is displayed
near the add-on name if it is allowed to run in private browsing
4 years ago
Jeff Boek 58ca5d0e3a For #10341 - Always show collections placeholder with new tab tray enabled 4 years ago
Mihai Branescu eef5cf3469 For #10482 - made SVG gradient compatible with API < 22 4 years ago
ekager 138d8e647d No issue - Use ViewLifecycleOwner lifecycleScope for Bookmark deletion scope 4 years ago
Sawyer Blatz 02f6e6868e
For #10426: Adds identifier to Glean for 24 hours (#10446) 4 years ago
Jonathan Almeida 57eb2b9549 For #10453: Do not set item decoration when creating ViewHolder 4 years ago
ValentinTimisica 24ba9f2fc8 For #9505: Adds possibility to sort saved logins
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
4 years ago
mcarare 9177871edc For #10408: Check current destination before navigating. 4 years ago
ekager 9fd835de0f For #10433 - Pass in viewLifecycleScope to BrowserAnimator 4 years ago
ekager 9ec1f8e2d8 For #8981 - Sort devices in share list by last access time 4 years ago
Michael Comella 4cf7280916 No issue: add clarifying kdoc for BookmarkFragment. 4 years ago
David Walsh 8b27a48635 For #10329 - Implement tab tray divider 4 years ago
Simon Chae 609936d632
For #10196: Remove clickable locks for enable and private-browsing UI (#10445) 4 years ago
Simon Chae a851b76ea3
Update Android Components version to 41.0.20200506130132 (#10443) 4 years ago
Mihai Branescu 6f97e75579 For #8643 and #7606 - illustrations are now connected to their radio buttons 4 years ago
Mihai Branescu cde31cf785 For #8643 and #7606 - Changed toolbar picker illustrations according to theme 4 years ago
Mihai Branescu 16b7a9399b For #8643 and #7606 - Changed theme picker illustrations according to theme 4 years ago
Mihai Branescu 4c0af91b7b For #8643 and #7606 - Changed tint for onboarding icons 4 years ago
Arturo Mejia 398b516fb7 No issue: Add Fingerprinters to the standard trancking protection policy 4 years ago
Christian Sadilek fee09c3092 No issue: Show article/page url instead of reader extension url 4 years ago
Jeff Boek d72e455c0d No Issue - Update to AC 41.0.20200505190119 4 years ago
Mihai Adrian 43d30793f5
For #9794: Announce installing state for screen readers (#10111) 4 years ago
Mihai Adrian 5106134786
For #10408: Dismiss menu when navigating away. (#10415)
The menu is dismissed when toolbar view is detached from window.
4 years ago
David Walsh 542f31f970
For #10392 - Don't provide a "Save to collection" button in private mode for the tabs tray (#10399) 4 years ago
Sören Hentzschel 10d07912da no issue - removed unused feature flag 4 years ago
Jeff Boek 94cd195dc7
Adds swipe to delete tab (#10355)
* No Issue - Increases tap area of close button

* For #10331 - Adds swipe to delete to the tab tray
4 years ago
Simon Chae 3dcd52ef7a For #10195, #10196: Allow private browsing mode switch to sync with enable state 4 years ago
Jeff Boek 5c7e9b98cd
Fix home navigation (#10350) 4 years ago
Jeff Boek a8a90bd4d6
For #1063: Put tab tray behind a feature flag and hidden pref (#10313)
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
4 years ago
Chenxia Liu 390c5a0189 Issue #7996: fix lint issues 4 years ago
Jovan Gerodetti 4a12f1b6aa For #7996: Private mode doesn't play nicely with sites added to home screen
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
4 years ago
Arturo Mejia 56bb3e38ec For issue #10142 Update sitePermissions state when toggling its value 4 years ago
ekager 2e27bbd15d No issue - Remove unused data class TopSiteItem 4 years ago
Sawyer Blatz 38e9b34659
For #10071: Fixes PWA showing toolbar onPause (#10306) 4 years ago
mcarare 4006501d41 For #9728: Add actionbar search for language list. 4 years ago
ekager 52d09930a6 No issue - Update new strings for quarantine 4 years ago
Mihai Eduard Badea 02bd0cc203 For issue #8648 4 years ago
Jonathan Almeida 76002c5987 Fix breaking API changes in CrashReporter 4 years ago
Falaye Iyanuoluwa c86209ff98 Closes #9694 Bug when user denies permission 4 years ago
mcarare 3c5d8d31ea For #10083: Adjust thumb offset to thumb circumference to avoid cutoff 4 years ago
David Walsh 6afcd2cee6 For #10201 - Provide proper button padding and no tabs message visibility in tabs tray 4 years ago
Arturo Mejia e55a4fd274 No issue: Partially update the add-on manager list 4 years ago
mcarare 1aa473b112 For #9913, For #9914: Remove touch delegate when button is disabled. 4 years ago
ekager a9692d9bce For #10204 - Address viewLifecycleOwner IllegalStateException crashes 4 years ago
Mihai Branescu a16bfb27ef For #6557 - added unit tests 4 years ago
Mihai Branescu 0c2d22f595 For #6557 - add in_content telemetry class 4 years ago
Mihai Branescu 28496fecc0 For #6557 - split base extension functionality from ads 4 years ago
Mihai Branescu f09bc4566c For #6557 - added metric for in_content 4 years ago
mcarare e830da59b7 For #10180: Remove touch delegate when button is disabled.
Also refactored multiple if's into a when.
4 years ago
mcarare 3e13927c25 For #10180: Add extension to remove touch delegate from parent. 4 years ago
Mihai Branescu c4d76dce5a For #6558 - cleanup + added unit tests 4 years ago
Mihai Branescu f03d65b13d For #6558 - added logic for ad_clicked metric 4 years ago
Mihai Branescu 93ca1f6d9f For #6558 - added handling of web extension + sending metric for has_ads 4 years ago
Simon Chae f1559ed2da
For #10162: Set switch back to prev state when failed to enable/disable addon (#10164) 4 years ago
mcarare 2edd4b39a4 For #9913, For #9914: Remove button when disabling it.
Setting visibility to GONE allows clicks to parent view in that space.
4 years ago
Arturo Mejia 956bf01cd5 For issue #9493: Reload after cleaning individual site permissions exceptions 4 years ago
David Walsh 6f5f48c30e
For #10148 - Add basic tab tray implementation without exposing to rest of app (#9934) 4 years ago
Vlad Filippov e51e1c878b Add 'useEmail' and 'useEmailProblem' metrics event
Fixes #9834
4 years ago
Simon Chae b3248ec769 For #6123: Expose WebExtensions in private browsing control 4 years ago
mcarare cc67de29bf For #10091 Also disable play/pause button when hiding it. 4 years ago
mcarare 9dd8314d14 For #10091 Add extension to remove and disable button 4 years ago
mcarare 932fd44823 For #7387: Change ETP onboarding from popup to a dialog.
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
4 years ago
mcarare 72fe52fcb8 For #9987: Set FLAG_SECURE to dialog when flag set in activity. 4 years ago
ValentinTimisica da3fca0f29 Fixes #10109: Adds content description for browse privately card content 4 years ago
mcarare e11f1b62dc For #10027: Make toolbar context menu popup dismissible on SDK<23 4 years ago
ekager c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 4 years ago
ekager 6457a02a82 For #2818 - Enable PiP for all builds 4 years ago
Roger Yang 0227e953ae Close #9760: Add external app links context menu candidate 4 years ago
Sawyer Blatz dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 4 years ago
Arturo Mejia 0a23d66756 For issue #7566 Handle deny & don't ask again for site permissions 4 years ago
Arturo Mejia 995da59fa8 For issue #9493: Reload after cleaning all site permissions exceptions 4 years ago
ekager 70755adf6e For #10036 - Workaround for System Theme changes with config change 4 years ago
Michael 1f8b7ff962 Closes #8541: Hide find bar when entering fullscreen 4 years ago
Jeff Boek 164e6cd079 For #9816 - Adds SessionObserver to session on selection 4 years ago
Jonathan Almeida 6ad046714d Close #9338: Enable WebPush engine integration in all builds 4 years ago
ekager f3847d0d7c For #8735 - Adjust fontInflation engine setting when toggling useAutoSize 4 years ago
ekager 66d9a24b28 Closes #9928 - Updates private browsing text description 4 years ago
ekager 5d51c4f059 Don't use ProcessLifecycleOwner for view-tied consume 4 years ago
ekager f801f32027 No issue: Fix leaks in BookmarkFragment 4 years ago
ekager 5014cd78ec No issue: Fix leaking sessionControlInteractor 4 years ago
Grisha Kruglov 853a0acab4 Closes #4046: Always display 'Desktop' bookmarks folder
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.

In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
4 years ago
Jonathan Almeida c16283a923 For #9932: Fix navigation icon theme missing from migration UI
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
4 years ago
Sawyer Blatz a8e624959e
For #6940: Fixes top dynamic toolbar behavior (#9900) 4 years ago
Roger Yang 40550e88de
Close #9960: Launch URI in Fenix if failed to launch in custom tab (#9964) 4 years ago
Christian Sadilek ec1d4e8fca For #8399: Hide keyboard to prevent content resizes
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
4 years ago
Michael Comella f3ed207bdb For #8803 - review: Add clarifying comments to onAppInit capture methods. 4 years ago
Michael Comella f49fc6dad2 For #8803: hook up frameworkStart metric. 4 years ago
Michael Comella dbf733d70a For #8803: add StartupFrameworkStartMeasurement.
This class controls the central logic around the metrics we want to
record.
4 years ago
Michael Comella 7f618a6a7c For #8803: add Stat and test.
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
4 years ago
Emily Kager 39107b4036
For #9703 - Exit fullscreen in onPause and onSessionSelected (#10016)
* For #9703 - Call fullScreenChanged in onPause

* For #10015 - Exit full screen if new session selected
4 years ago
ekager 6f77ec5951 Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver 4 years ago
Grisha Kruglov 0ec6d266e8 Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
4 years ago
Mihai Adrian 72fe9fad0c
For #9987: Set FLAG_SECURE to dialog when flag set in activity. (#9998)
* For #9987: Add extension to secures dialog if parent activity is secured

* For #9987: Set FLAG_SECURE to dialog when flag set in activity
4 years ago
Mihai Eduard Badea 725ba1e856 For #9951 - Removed the extra empty spaces that were causing the spacing issue 4 years ago
mcarare 83d2208c6b For #9536: Open report issue tab depending on current browsing mode.
Checking if session is private uses the new browser state API.
4 years ago
Sawyer Blatz 1f8f69548a For #7158: Fixes browser to search animation fade 4 years ago
Jonathan Almeida 25d5b0d31c For #8422: Add spacing between migration items 4 years ago
ekager 4a06a228f3 For #9981 - Make Bookmark Menu UI respond to session selection 4 years ago
mcarare 25e12e2f77 For #9984: Update addon before settings visibility check 4 years ago
Sawyer Blatz 8185ba793e
For #9857: Create button style (#9858)
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
4 years ago
Jonathan Almeida 997f6c72d6 For #9409: Add app icon to Leanplum push notifications 4 years ago
Jonathan Almeida e97904662c Remove duplicate FirebasePushService
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
4 years ago
Mihai Branescu bded28a017
For #9420 - relaxed custom engine rules (#9967)
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
4 years ago
ekager aef827e607 For #9887 - Respect screenshot setting when resetting window flags in logins 4 years ago
Arturo Mejia 37a277febb For issue #9930 Do not assume all add-ons have a settings page 4 years ago
Arturo Mejia 8872baef39 Update Android Components version 4 years ago
Arturo Mejia 7c279b6e1f No issue: Fix add-on translate() breaking change 4 years ago
ekager 5b1cdbd8bf For #3194 - Pause media while undo snackbar appears 4 years ago
ekager 9c56a8b387 For #204 - Remove PWA Feature Flag 4 years ago
Jeff Boek 4cbb9aebaf
Cleans up nav_graph.xml (#9829)
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
4 years ago
Arturo Mejia eace991859 For issue #8520: Improve add-ons UI 4 years ago
ekager b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 4 years ago
ekager ac3a557ddf For #9703 - Exit full screen on pause if pip not entered 4 years ago
Sawyer Blatz 7c3394ea7c
For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (#9893) 4 years ago
ekager 8c238402e2 For #9692 - Fix "Install" PWA menu item labeling 4 years ago
ekager 5039546dc5 For #7208 For #7212 - Update parameterized strings 4 years ago
mcarare a214f04b4a For #9698: Use extension to ensure fallback to English and avoid crash 4 years ago
mcarare 4a1a875233 For #9698: Add Context extension to avoid format IllegalArgumentException 4 years ago
mcarare 177baf58a8 For #9798: Disable buttons on hiding and enable on showing.
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
4 years ago
Simon Chae de311aef85
Update not yet unavailable add-on string (#9677) 4 years ago
Roger Yang c9141c9ae5 Close #9827: Support display cutouts 4 years ago
Christian Sadilek 7f1ef17d8b No issue: Re-use existing usecases for addons 4 years ago
ekager 56eb2ec1d7 For #2818 - Adds Picture-in-Picture feature 4 years ago
Michael Comella 4437ddd536 No issue: Move Do and OpenClass to utils pkg.
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
4 years ago
mcarare 413af92bc5 For #9797: Set min height of dialog edit text to 48dp. 4 years ago
Abhay Agarwal 1c65bb8255 Closes #9495: Dismiss the ShareFragment in onPause() 4 years ago
Christian Sadilek 0f1bff7402 No issue: Refactor readerview to use browser-state 4 years ago
Sawyer Blatz e94af334fc
No issue: Add more settings animations (#9750) 4 years ago
Mihai Eduard Badea d66da53c9a For #2768 - Prevent screenshots in private mode
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
4 years ago
Mugurell 29539c458e For #9770 - Disable pull to refresh pending changes 4 years ago
Jeff Boek c632b93ee7
For #220 - Removes feature flag for language picker (#9191)
* For #220 - Removes feature flag for language picker

* For #220 - Updates Android Components
4 years ago
Mihai Adrian dfded8e69c
For #9687: Refactor onboarding cards to follow app architecture (#9743)
* For #9687: Refactor onboarding cards to follow app architecture

* For #9687: Update unit test to new controller parameters
4 years ago
Arturo Mejia 025656d8fd For issue #9647 Crash when tapping settings after quickly
enabling/disabling add-on
4 years ago
Michael Droettboom 3789f50423 Fix errors in top_sites_count metric
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.

[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
4 years ago
Mugurell 904bfc9ebe For #3262 - Enable pull down to refresh in Nightly 4 years ago
MickeyMoz f46cfc2ad2 Update Android Components version to 38.0.20200403130109. 4 years ago
Michael Comella 4a8dc5b54f No issue: add kdoc to HomeActivity.
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
4 years ago
Sawyer Blatz e3ed7ed268
Issue #9128 & #9222 & #9499: Refactors snackbar creation and fixes placement (#9628) 4 years ago
Gabriel Luong dc6d479da3
For #6174 - Add telemetry for WebExtensions (#8318) 4 years ago
Emily Kager 327009efc4
For #768: Add first time PWA dialog (#9308)
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
David Walsh 26137f63a2
Prevent favicons from flashing when items are selected in History (#9233) 4 years ago
Mihai Adrian 8cd6d7460c
For #9336 Check current destination before navigating (#9353)
* For #9336 Check current destination before navigating

* For #9336 Update unit test to check for navigateSafe
4 years ago
ekager fd60270da8 For #9533 - Switch to using enum for Library Item Selected Telemetry 4 years ago
Grisha Kruglov 8d3d030feb Closes #9553: Only update account UI state once when creating SettingsFragment 4 years ago
ekager 96c6401457 For #8125 - Send top sites count with metrics ping 4 years ago
mcarare 8c398c86ef For #9365: Partially reverse menu items order when using top toolbar 4 years ago
mcarare b119700820 For #9365: Update naming to reflect history item 4 years ago