Commit Graph

6106 Commits (3632ed77d5d76c1ff47dd7fc2b319dd5092e7a01)

Author SHA1 Message Date
Roger Yang 3632ed77d5 No issue: Update Pocket categories spacing to 16dp. 3 years ago
Sebastian Kaspari 099e463b4f Issue #21102: Set compileSdkVersion to 31. 3 years ago
Roger Yang 23e51c250a No issue: Small layout update for Pocket Stories 3 years ago
Gabriel Luong dd20d98779 For #21729 - Refactor SectionHeader to use the right font size 3 years ago
Sebastian Kaspari 5208f74cd7 SearchDialogFragment: Start to split consumeFrom() into independent observers that trigger less often 3 years ago
Arturo Mejia 0f07703c3e For #21611: Show the jump back in Contextual Hints independently of the home onboarding dialog. 3 years ago
Arturo Mejia 7e3a2ba89d For #21574: disabled the homescreen onboarding dialog. 3 years ago
Roger Yang fb345a4131 Close #21573: Update design for jump back in section and recently bookmarked section 3 years ago
codrut.topliceanu b1a5025610 For #21708 - Fixes missing header bottom border
The bottom gray border of the header item from the Inactive Tabs section was correctly set when collapsing or expanding said section, but not on init. So if the section was initialized collapsed the gray border would not be present.
3 years ago
Arturo Mejia bd7476cce4 Update feature flags for 94. 3 years ago
AndiAJ 8a8bbd9517 For #20814 fix flaky tabMediaControlButtonTest UI test 3 years ago
Mugurell 6faafe4688 For #21599 - Add UTM parameters for Pocket recommendations links 3 years ago
codrut.topliceanu a53b52b764 For #21565 - Adds inactive tabs onboarding popup 3 years ago
Mugurell 571a2fc88e For #21621 - Add 16dp horizontal spacing to home composables.
Added from the ViewHolders, the same as for XML Views.
3 years ago
Mugurell 2eb5fe2159 For #21621 - Add 16dp horizontal spacing to all normal browsing home items 3 years ago
Mugurell a6b4c3e370 For #21621 - Add 16dp horizontal spacing to the private browsing home description 3 years ago
Mugurell bb498cc223 For #21621 - Add 16dp horizontal spacing to all onboarding items 3 years ago
Mugurell d189b37a09 For #21621 - Remove the parent horizontal padding 3 years ago
Jonathan Almeida f9dd0d9f6f Issue #21582: Use ThumbnailStorage in recent tabs on home 3 years ago
Gabriel Luong a1e6872f6f For #21694 - Remove RoundedCornerShape around the inner Column in RecentlyVisited 3 years ago
Gabriel Luong 5fc979090a For #21694 - Only show the divider line in between items in the Recent Searches 3 years ago
Jonathan Almeida 8c2cbb4e41 Issue #21642: Remove in-progress media tab from homescreen 3 years ago
Christian Sadilek 66e54860bb Move tabs out of search group if direct load occurs
This regressed in our previous fix that made sure child tabs don't
mistakenly get moved out of the group if their parent is navigated
away, or in case the child tabs are redirected.

However, when a subsequent load occurs in any tab in the group the
search terms need to be cleared and the tab removed from the group
to prevent false positives.
3 years ago
Elise Richards f359557ef4
CI for Fix description for home_screen_displayed metric (#21697)
* Fix description for `home_screen_displayed` metric

The current description appears to be incorrect by my reading of the source.

* Update app/metrics.yaml

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

Co-authored-by: Will Lachance <wlachance@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Elise Richards e2c9d9abb1
CI for Docs: Add extra context to events.browser_menu_action (#21696)
* Docs only: Add extra context to `events.browser_menu_action`

This came up as a potential point of confusion in a discussion with DS. This is a docs only change.

* Update metrics.yaml

Co-authored-by: Will Lachance <wrlach@gmail.com>
3 years ago
Gabriel Luong 6abb2fffa1 For #21658 - Don't pass Client into composable functions 3 years ago
Jonathan Almeida b8946f807a Issue #21671: Remove Recently Closed from Inactive Tabs 3 years ago
Mugurell 16a3b92d34 For #21593 - Refactor the coroutine from PocketStoriesShown to outside the middleware
In so this code will no longer have access to the MiddlewareContext which only
makes sense in the thread of the Middleware itself.
3 years ago
Mugurell e4489b8d7d For #21593 - Persist stories categories selections in a Proto DataStore
A fast and easy solution with all the ACID requirements.
Also supports easy migrations if later the data we need persisted changes.
3 years ago
Mugurell 565beb88c9 For #21593 - Refactor out "isSelected" from PocketRecommendedStoriesCategory
Having the list of categories and the list of selected categories separate in
State allows updating them independently.
3 years ago
AndiAJ 84c61e24a7 For #21644 fix disabled alwaysStartOnHomeTest UI test 3 years ago
Jonathan Almeida 061de54291 Issue #21576: Hide 'Other' title when there are no search groups 3 years ago
Mugurell 361673ae3e For #21626 - Avoid showing story invalid properties 3 years ago
Arturo Mejia 2b363b9868 For #21618: Integrate Nimbus with MR2 Home Page to enable experimentation 3 years ago
Arturo Mejia ebd336501b For #21611: Add jump back in Contextual Hints 3 years ago
Jonathan Almeida e5f58eaade
Issue #21632: Correct inactive tabs survey string (#21669) 3 years ago
Christian Sadilek 8f187af9ae Make search term grouping tolerant to (parent tab) navigation
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
Elise Richards 76c0c4ad14 For #21648: match Pocket sections on home to designs 3 years ago
Jonathan Almeida c877a25400 Issue #21641: Do not add a group of only one tab 3 years ago
Elise Richards b213a51188 For #21653: pre-land section title for tab preferences 3 years ago
Noah Bond aa28b6f142
For #21360 - Added toggle for search term tab groups (#21615)
* For #21360  - Added toggle for search term tab groups

* For #21360 - Lint cleanup

* PR: Added missing licenses and possibly fixed UI test

* PR: Added a "scrollTo" to potentially fix a UI test

* PR: Added potential fix for alwaysStartOnHomeTest

* PR: Added temporary ignore to alwaysStartOnHomeTest

* PR: added missing ignore comment

* For #21360 - Added missing feature flag driven visibility logic

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Elise Richards c7067a50cb For #21646: Update section titles and customize button name on home 3 years ago
Elise Richards 3a2b9e5d2b
For #21643: Pre-land strings for inactive tabs CFR. Update section title for normal, non-search group tabs. (#21645) 3 years ago
Noah Bond 07b53f1e73
For #21635 - Preland strings for tab auto close message (#21636)
* For #21635 - Prelanded strings for tab auto close message

* PR: Updated String descriptions and added temporary tools ignore
3 years ago
Gabriel Luong 69485da0f8 For #21632 - Preland strings for the inactive tab survey 3 years ago
Biren-Nayak c1effd946d For #16437: Remove unnecessary space for tracking protection exceptions 3 years ago
Mugurell bf876e2593 For #21392 - Update new strings descriptions. 3 years ago
Christian Sadilek fafa72c0ff Allow opening pocket stories when search dialog is active 3 years ago
Oana Horvath a4a04173cc For #21540, #21620: disables failing UI tests 3 years ago
Oana Horvath 526501160c For #21441, #21477, #21500, #21499 #21476, #21474: retry dismissing the search bar 3 years ago