6 Commits (34d99f89ac4dc7be6f0de4c7e55abe94d7c5131f)

Author	SHA1	Message	Date
Michael Comella	cc380695b8	No issue: remove unnecessary robolectric annotations. ... Theoretically, this should marginally decrease the duration of our unit test suite. In my testing, for 1 iteration each (i.e. noise is very possible), the duration changed from 9m 32s to 8m 21s – a 71s improvement. --- To identify tests that were running with robolectric that didn't need to be, I removed the @RunWith(FenixRobo... from all relevant files: sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt I ran the tests and discovered which ones failed from the Classes tab of the index.html test result file. Something like: tests = document.querySelectorAll('table')[3].querySelectorAll('tr'); failureElements = tests.querySelectorAll('.failures'); // TODO: extract the test names Then I copied these results to a text file and compared them to all the files that had robolectric test runners to figure out which ones still pass: comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt And undid the changes to the failing files: for i in $(cat robolectric_not_needed.txt); do git checkout $i; done Then I removed the import statements on those files: for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done	3 years ago
Sebastian Kaspari	971b419d77	Run ktlintFormat to adapt to latest formatting rules.	3 years ago
Christian Sadilek	58e8cdfedb	Issue #20533: Fix intermittent failures of DefaultTabsTrayControllerTest	3 years ago
Roger Yang	74c1cc82fb	Closes #19921: Update appcompat and fragment dependencies to 1.3.x	3 years ago
Jonathan Almeida	dc11c334b6	Issue #19112: Remove old tab tray code	3 years ago
Mugurell	3fb40e1f40	For #19475 - Introduce a DefaultTabsTrayInteractor ... Refactored the TabsTrayFragment to not implement the TabsTrayInteractor which among other advantages allowed for easier testing.	3 years ago