Grisha Kruglov
95b60a0495
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1902 : Remove direct appservices dependencies
...
Our main dependency - android-components - is tightly integrated
against a certain version of appservices. Having a direct dependency
at the Fenix level is a foot-gun: it allows Fenix to consume an API-incompatible
version of appservices, breaking parts of android-components. Due to
how gradle dependency resolution works, this breakage is "silent": there are
no compile time warnings. A recent example of this is broken history sync,
and buggy FxA experience in Fenix.
This patch removes a direct dependency, letting android-components dictate
which appservices version should be used Fenix builds.
2019-04-23 17:41:07 -05:00
Jeff Boek
ac4370c1f5
[fenix] Sets the search engine to the default if no shortcut is used
2019-04-23 17:39:57 -05:00
Colin Lee
c0fbb5dda6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1923 : Title of bookmarks folder is not displayed
2019-04-23 17:37:58 -05:00
Sawyer Blatz
dd19ee5702
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1868 : Corrects private browsing myths link ( https://github.com/mozilla-mobile/fenix/pull/1930 )
2019-04-23 14:26:56 -07:00
Emily Kager
0ad62e2355
[fenix] No issue: Update quick action divider to neutral faded
2019-04-23 13:59:15 -07:00
Emily Kager
d3002146fd
[fenix] No issue: Fixed visibility bugs in quick action sheet ( https://github.com/mozilla-mobile/fenix/pull/1927 )
2019-04-23 11:46:52 -07:00
Sawyer Blatz
e04a7b05a7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1205 : Adds search term to EditToolbar
2019-04-23 09:59:48 -07:00
Harsh Shandilya
aff56b9e38
[fenix] BrowserToolbarBottomBehaviour: Remove unused parameter
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
Harsh Shandilya
9a8fadfdbe
[fenix] TabViewHolder: Remove unused parameter
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
Harsh Shandilya
caae5e0bfb
[fenix] AwesomeBarUIView: Rename variable to prevent name shadowing
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
Harsh Shandilya
e4d2e4b3d0
[fenix] QuickSettingsUIView: Remove unused variable
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
Harsh Shandilya
c4bd29085b
[fenix] TabViewHolder: Remove useless lateinit
...
Fixes build-time warning: fenix/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabViewHolder.kt: (45, 13): Lateinit is unnecessary: definitely initialized in constructors
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-04-23 09:59:36 -07:00
Sawyer Blatz
2e645d0d76
[fenix] For https://github.com/mozilla-mobile/fenix/issues/724 : Adds contrastText color for buttons using accent backgrounds
2019-04-23 09:57:54 -07:00
Sawyer Blatz
82107be429
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1886 : Applies theme to toolbar onResume of library fragment ( https://github.com/mozilla-mobile/fenix/pull/1888 )
2019-04-23 07:23:27 -07:00
Sawyer Blatz
e1376c46f4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1714 : Updates product to Firefox Preview ( https://github.com/mozilla-mobile/fenix/pull/1907 )
2019-04-23 07:20:19 -07:00
Emily Kager
f82e6fc49c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1912 - Quick action bottom sheet should fade in
2019-04-22 23:25:15 -07:00
Emily Kager
e549178204
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1894 - Fixes Help Page Navigation
2019-04-23 00:22:46 -05:00
Emily Kager
9444267bab
[fenix] No issue: Update bottom margin of quick action sheet to 12dp
2019-04-22 21:47:07 -05:00
Will Hawkins
e1dc2cd686
[fenix] Fix for 2428 from a-c
...
In 2428 from android-components, they removed part of
the tab layout XML for localization/usability and fenix
copied that file directly. Fenix needs to make the
equivalent change. This patch does that.
2019-04-22 17:34:09 -07:00
Jeff Boek
3f84f820f8
[fenix] Fixes tab sizing ( https://github.com/mozilla-mobile/fenix/pull/1906 )
2019-04-22 14:50:22 -07:00
Emily Kager
9b0bca8a09
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1879 - Create toolbar background drawable instead of view
2019-04-22 14:22:28 -07:00
Sawyer Blatz
d26c380c72
[fenix] No issue: Updates crash report back press and string ( https://github.com/mozilla-mobile/fenix/pull/1773 )
2019-04-22 14:05:23 -07:00
Colin Lee
e0bd5a33c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1851 : QR code scanner doesn't load right after permission grant
2019-04-22 13:56:43 -07:00
Emily Kager
44125bc4c9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1784 - Make separate private vector without background
2019-04-22 13:25:00 -07:00
Jeff Boek
f47bcc225c
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1890 - Remove unused strings ( https://github.com/mozilla-mobile/fenix/pull/1891 )
2019-04-22 11:24:49 -07:00
Mitchell Hentges
d2ea8148c8
[fenix] Moves release flavour to build type ( https://github.com/mozilla-mobile/fenix/pull/1693 )
2019-04-22 11:02:39 -07:00
Jatin Kumar
c2f9dbe61d
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1860 : fixed text views in About Fenix page
2019-04-22 10:27:38 -05:00
Kourosh
3ba9cb253f
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1864 - made about page scrollable ( https://github.com/mozilla-mobile/fenix/pull/1865 )
2019-04-21 12:14:53 -07:00
Emily Kager
f53df52a1e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1759 - Try to change copy URL to plainText ( https://github.com/mozilla-mobile/fenix/pull/1850 )
2019-04-20 14:15:37 -07:00
Jeff Boek
ed156888ab
[fenix] Merge pull request https://github.com/mozilla-mobile/fenix/pull/1842 from boek/i1840-collections_featureflag
...
For https://github.com/mozilla-mobile/fenix/issues/1840 - Adds a save tab group button and puts it behind a feature flag
2019-04-20 14:15:18 -07:00
Colin Lee
e346070dee
[fenix] No issue: Fix crash on bookmark folder selection and Snackbar color
2019-04-20 15:10:24 -05:00
Colin Lee
f3ad87cbd2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1817 : Multi-select toolbar changes when minimized
2019-04-19 22:35:24 -05:00
Jeff Boek
fc61d849a5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1830 - Adds the ability to share a tab
2019-04-19 15:31:12 -07:00
Jeff Boek
6c2ffd9777
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1830 - Updates the tab visual style
2019-04-19 15:31:12 -07:00
ekager
96391bedfb
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1798 , Closes https://github.com/mozilla-mobile/fenix/issues/1581 Corrects divider views and padding for toolbar and action sheet
2019-04-19 15:19:48 -07:00
ekager
0b69acfced
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1593 - Remove evenodd from vector files
2019-04-19 17:18:03 -05:00
ekager
bab73ab448
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1835 - Do not crash because of snackbar
2019-04-19 17:17:20 -05:00
Colin Lee
b98ca450d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/113 : QR Scan
2019-04-19 14:47:53 -07:00
Sawyer Blatz
2075ccf02e
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1683 : Only show/hide keyboard in search fragment
2019-04-19 16:22:10 -05:00
Jeff Boek
72607b5a48
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1828 - Adds an empty tab state
2019-04-19 14:06:31 -07:00
Sawyer Blatz
18f92314e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/724 : Corrects colors for all themes
2019-04-19 13:46:43 -07:00
Colin Lee
b21176a3bf
[fenix] Fix https://github.com/mozilla-mobile/fenix/issues/1770 : Share icon from quick action bar poorly rasterized
2019-04-19 15:17:47 -05:00
Sören Hentzschel
962a25e1ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1719 : tracking protection icon in quick settings is almost invisible
2019-04-19 13:36:15 -05:00
Sawyer Blatz
4d77b0bd08
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1717 : Removes search button from library
2019-04-19 13:34:14 -05:00
ekager
dbebd1f0eb
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1803 : remove text for swipe delete
2019-04-19 13:32:32 -05:00
ekager
6d50cc22a0
[fenix] Only set the engine's theme when it is instantiated
2019-04-19 08:11:57 -07:00
Colin Lee
b1cc487f14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1596 : Bookmarks get the last used folder as parent
2019-04-19 08:11:43 -07:00
Colin Lee
cd088cd4fa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1555 : Bookmark Overflow menu tap area should be larger
2019-04-19 08:09:26 -07:00
Colin Lee
2cf953198a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1598 : Auto-select new created folder for moving bookmarks
2019-04-19 08:08:27 -07:00
Colin Lee
f6a05938ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1701 , https://github.com/mozilla-mobile/fenix/issues/1703 : Bookmark multi-select icons wrong color after deselect
2019-04-19 08:07:08 -07:00
Colin Lee
c997ebd1ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1682 : Bookmark string fix for l10n
2019-04-19 08:05:49 -07:00
Emily Kager
6de9f620a7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1375 - Add Bookmarks Suggestion Provider
2019-04-18 19:21:12 -05:00
Emily Kager
cba84924d7
[fenix] No issue: Removes session time out related code
2019-04-18 17:04:02 -07:00
Emily Kager
d517c946f2
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1790 - Add QuickSettingsChange for TP Toggle Action
2019-04-18 19:02:48 -05:00
Emily Kager
41433a4329
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1049 - Round out progress bar
2019-04-18 14:01:45 -07:00
Jeff Boek
416634db4b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1116 - Fix the language code generation
2019-04-18 15:42:14 -05:00
Emily Kager
9ddbf8526d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1084 - Remove Exceptions from TP setting for Beta
2019-04-18 15:37:12 -05:00
Colin Lee
70a5721d97
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1719 : tracking protection label in quick settings almost invisible
2019-04-18 13:17:32 -07:00
Sören Hentzschel
13f9c97d20
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1775 - Remove Language from settings for Beta
2019-04-18 13:49:50 -05:00
Emily Kager
72596525ab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1751 - Add Delete Button to Private Toolbar
2019-04-18 11:24:05 -07:00
James Hugman
3e96e202e8
[fenix] Fix blank custom tabs following an NPE.
...
Fixes https://github.com/mozilla-mobile/fenix/issues/1771 .
This PR protects against the initial `NullPointerException` ever happening.
This is a rare case, and we do not have anything to go on at this point, so we fallback to a new intent, and the user is routed to the home activity.
2019-04-18 13:22:25 -05:00
Colin Lee
8f35a7422e
[fenix] Fix https://github.com/mozilla-mobile/fenix/issues/1732 : Fix crashes opening bookmarks
2019-04-18 13:21:05 -05:00
Axel Hecht
012bb4b0a2
[fenix] Import strings from android-l10n
...
Status: mozilla-l10n/android-l10n@4d1d72880f
2019-04-18 13:07:44 -05:00
Arturo Mejia
166cc30def
[fenix] https://github.com/mozilla-mobile/fenix/issues/1682 Fixing typos on strings comments
2019-04-18 13:04:52 -05:00
Jeff Boek
510ee881e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1696 - Removes sessions from session control
2019-04-17 22:41:59 -07:00
Jeff Boek
5ae634a9e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1696 - Removes sessions from the bottomsheetfragment
2019-04-17 22:41:59 -07:00
Jeff Boek
e081fba700
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1696 - Replace session bundle storage with session storage
2019-04-17 22:41:59 -07:00
Colin Lee
ac9b6fc726
[fenix] Fix crash loading AdjustLifecycleCallbacks
2019-04-17 22:12:20 -05:00
Jeff Boek
88f8efeeed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1264 - Removes data choice options
2019-04-17 21:45:12 -05:00
kouroshydn
663e1c5ebf
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1691 - Site permissions' pages are not entirely visible
2019-04-17 15:59:44 -07:00
Colin Lee
d3d178240e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/974 : Telemetry for Bookmarks
2019-04-17 15:58:58 -07:00
Emily Kager
cc3ae6fe34
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/689 : Adds fade animation to Android <9.0"
...
This reverts commit dd2d1533203f388cfb4d8b2602fd0bb96d1b23ab.
2019-04-17 15:50:11 -07:00
Jeff Boek
808ecb69f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1297 - Re-adds adjust to build task
2019-04-17 14:42:21 -07:00
Sawyer Blatz
3a5797e0e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/921 : Adds styling to error pages
2019-04-17 16:22:25 -05:00
Jeff Boek
41e504ec61
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1700 - Hides incomplete features in the quick action bar
2019-04-17 13:57:15 -05:00
Jeff Boek
1863800d57
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1698 - Removes unimplemented library sections for the beta
2019-04-17 13:49:27 -05:00
Jeff Boek
4aeead63d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1699 - Remove links to settings sections for beta
2019-04-17 13:46:59 -05:00
Jeff Boek
cbef12ded9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1676 - Removes setting for location services
2019-04-17 13:46:20 -05:00
Sawyer Blatz
facdaee5e8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/977 : Adds telemetry for custom tabs ( https://github.com/mozilla-mobile/fenix/pull/1697 )
2019-04-17 11:13:48 -07:00
Jeff Boek
cb2f2cf080
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1158 - Add search counts
2019-04-17 10:04:49 -07:00
Colin Lee
84f6734bbe
[fenix] Bump application-services version and initialize networking in the megazord
2019-04-17 11:22:57 -05:00
Sawyer Blatz
60dfbf4826
[fenix] No issue: Cleans up SearchShortcut changes
2019-04-17 11:20:59 -05:00
Sawyer Blatz
bdae7561f8
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1662 : Corrects ripple style for private browsing button
2019-04-17 10:43:20 -05:00
Colin Lee
a47300dfbc
[fenix] Merge branch 'master' into a-s-networking
2019-04-17 10:36:35 -05:00
Emily Kager
b6cfed01be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1658 - Reload current session (if exists) when theme changes
2019-04-16 14:23:36 -07:00
Emily Kager
403c1514a1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1644 - Correct progress bar gravity
2019-04-16 14:22:25 -07:00
Sawyer Blatz
aa2f1c84ce
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1632 : Hides keyboard on exit, shows on entry
2019-04-16 14:13:35 -07:00
Kevin Brosnan
3f181f63c9
[fenix] UI tests for the home screen
2019-04-16 13:38:06 -07:00
Emily Kager
3833132803
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1655 - Use accent bright for switch in quick settings
2019-04-16 13:06:48 -07:00
Thom Chiovoloni
41578b9632
[fenix] Bump application-services version and initialize networking in the megazord
2019-04-16 08:27:13 -07:00
Sawyer Blatz
418fae40b5
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1646 : Changes bookmarks toolbar color ( https://github.com/mozilla-mobile/fenix/pull/1651 )
2019-04-16 08:03:22 -07:00
Sawyer Blatz
de3429789c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/933 : Adds caching of sign in state ( https://github.com/mozilla-mobile/fenix/pull/1647 )
2019-04-16 08:00:28 -07:00
Will Hawkins
2ab1cee9d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1616 : Parallelize the loading of experiments.
2019-04-15 21:45:44 -05:00
Emily Kager
bd8ec034ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1084 - Add tracking protection toggle to quick settings dialog
2019-04-15 19:59:10 -05:00
Axel Hecht
e6fa8ec276
[fenix] Import strings from android-l10n
...
Status: mozilla-l10n/android-l10n@ce0bbdb947
2019-04-15 15:39:22 -07:00
Jeff Boek
e60dda681e
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1430 - Implements UX feedback for the FenixSnackbar
2019-04-15 13:34:50 -07:00
Sawyer Blatz
c95575059f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/724 : Fixes white color in dark mode and removes android:tint ( https://github.com/mozilla-mobile/fenix/pull/1641 )
2019-04-15 13:14:49 -07:00
Emily Kager
a8b73dcb04
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1084 - Update TP Policy for the current engineSession
2019-04-15 13:07:49 -07:00
Jeff Boek
58b29982c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1495 - Reverts editing translated string and creates a new string
2019-04-15 13:33:09 -05:00
Sawyer Blatz
4469e83917
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1610 : Gives unique identifier to shortcut engine picker suggestions
2019-04-15 13:32:34 -05:00