Commit Graph

495 Commits (300d8317e1e0726fd66ea18f73543d0dafd3bdd1)

Author SHA1 Message Date
ekager 9dd9400600 For #5178 - Do not truncate delete browsing text 5 years ago
Colin Lee 2b9efccfca For #3106: Granular options for clearing user data 5 years ago
Sawyer Blatz b86a32fa17
No issue: Top aligns close button for tab in collection (#5161)
See https://github.com/mozilla-mobile/fenix/pull/4442#issuecomment-528580904 for more info
5 years ago
Mihai Adrian ed0b6bd5ef For #4193 - Makes close button for tabs more accessible (#4442)
* fixes #4193 - made close button for tabs more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible

* Fix margins
5 years ago
mihai-adrian c8d622c43d For #5142 Removed RadioButton from accessibility keeping one option for Talkback
Set android:importantForAccessibility = "no" for RadioButton
5 years ago
mihai-adrian 2e544145b7 For #5095: Changed search engine text color from default to ?primaryText 5 years ago
Sawyer Blatz 09dcdb079d For #4474: Adds what's new button to home screen menu (#5088)
* For #4474: Adds what's new button to home screen menu

* For #4474: Adds tests for what's new button
5 years ago
Mugurell 095870145f For #4007 - Refactor AppShareView in standalone Share Views
In an effort to respect the initial MVI architecture I've broken the
complex `AppShareView` in 3 separate Views
- `ShareCloseView`
- `ShareToAccountDevicesView`
- `ShareToAppsView`
They are standalone Views (extending LayoutContainer) which know nothing about
each other or their parent and so offer their container the possibility to
order or display them in any form later.
According to the lib-state contract they are only responsible to
- inflate themselves in their injected containerView
- render a certain state (to be added in later commits)
- delegate all user interaction to an associated Interactor
5 years ago
Mugurell 5e19741ddd For #4007 - Use camelCase for views referenced from code
As per #4341.
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
5 years ago
Mihai Adrian 9b911f3276 Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944)
Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
5 years ago
Mihai Adrian 594569164d Fixes #4211 changed SeekBar height to wrap_content to prevent misaligned dot (#4832)
Changed height from match_constrained to wrap_content.
5 years ago
Mihai Adrian 5d13c53706 Fixes #4440 changed padding for account_preference (#4830)
Changed padding to default value in @android:style/Preference.Material.Category.
Also changed paddingEnd value to default value.
5 years ago
Amaan Marfatia dc9fdd9db3 Fixes #4067 besides snackbar (#4777)
* Fixes #4067 besides snackbar

Makes layout hierarchy more shallow to increase performance.

* Fix #4067 Feedback

Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
5 years ago
Tiger Oakes aab357845b No issue: Clean up preferences code (#4699) 5 years ago
Yeon Taek Jeong 26c9d5d297 For #2834: Add contentDescription to tabs button icons 5 years ago
Yeon Taek Jeong 6f899c7fb5
For #2834: Delete all Private Tabs redesign (#4787) 5 years ago
Yeon Taek Jeong 727457f0ed No issue: fixes click failures on search widget icon 5 years ago
Emily Kager 3f820366a6 Closes #4680 - Align collection creation text center vertical 5 years ago
Yeon Taek Jeong a680d733c8 For #4384: Hide mic icon if speech-to-text is unavailable (#4701) 5 years ago
Yeon Taek Jeong 2441592ef2 For #4516: Use full width for large search widgets (#4659) 5 years ago
Mihai Adrian 1a4ef1535c For #4434 - made close button for collections more accessible. (#4443)
* fixes #4434 - made close button for collections more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for #4193 - close button for tabs

* fixes #4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button

set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
5 years ago
Colin Lee 5b4a441bcb For #1667: Screen reader can't reach other UI items when QAB expanded (#4695) 5 years ago
Jorge De Los Santos 337ad1e88e For #3424 - Make talkback ignore ImageButton in Collection Sele… (#3792)
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
5 years ago
Jonathan Almeida 23f5ac0fb9 For #4066: Create InflationAwareFeature for lazy inflation 5 years ago
Colin Lee 519c3bde5d For #4066: Provide lazy inflation of Find In Page View 5 years ago
ValentinTimisica 63d50d9827 Fixes #4323: Modified UI of component_collection_creation.
To fix the overlapping issue I used Guideline and
layout_constraintWidth_default property. I also used the
layout_constraintHorizontal_bias property to make the back_button to
lean to the left and the select_all_button to lean to the right.
5 years ago
Colin Lee a514cb3f8c No issue: Add OSS licenses link to About page 5 years ago
ekager 0320efee84 No issue: Removes focusableInTouchMode from home searchbar view 5 years ago
Emily Kager 6f7ae227a8 Closes #4540 - Set correct tint for select bookmark folder icon (#4541) 5 years ago
ekager 5edc9d0b4e For #2021 - Update custom preferences' views with email/account changes 5 years ago
ekager d0071d0177 For #4495 - Clean up homescreen toolbar focus and content descriptions 5 years ago
Nikit Bhandari 671727c3e8 For #4341 use camelCase for views referenced from code 5 years ago
Tiger Oakes 6e2ea0750e Issue #2379 - Use LibrarySiteItemView in history 5 years ago
ekager 015922ddd2 No issue: Fix Crash lower API by setting gradient drawables in onBind 5 years ago
ekager 79160255c8 No issue: Just use TextView, not AppCompatTextView 5 years ago
Yeon Taek Jeong 83ceec6289 For #201: Search Widget 5 years ago
Sawyer Blatz 29f089c414 For #2203: Polishes BrowserToolbarMenu 5 years ago
Grisha Kruglov ae33234bbc Closes #2593: FxA automatic sign-in integration 5 years ago
Tiger Oakes ccae66c08a Issue #2379 - Use LibraryPageView in history 5 years ago
mihai-adrian fa8199f429 fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small
changed size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
5 years ago
mihai-adrian 30ecbc6000 fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small
changes size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
5 years ago
ekager 4494e40dbc For #4137 - Adds pagination to the history view 5 years ago
Maurya Talisetti 093b76593d Closes #3419: Use better accessibility strings for tab collections 5 years ago
ekager 3fb20aea6a Closes #4040 - Remove NestedScrollView from Bookmark Layout 5 years ago
mihai-adrian 4ee8a890a8 fixes #3843 - (L10N) regression: alignment issue when saving tabs to collection
changed height to match_constraints instead of wrap_content - this makes for a better calculation of space, avoids setting textView on two lines, with blank line below.
5 years ago
bloslo 7ab4498771 For #3548 - Fix close tab button visibility. (#3801)
* For #3548 - Fix close tab button visibility.

* Switch to 'wrap_content' instead of fixed values.

* Align close tab button with settings button.

* Change margin top
5 years ago
Tiger Oakes d1651ecf71 Closes #4012 - Animate quick settings (#4047) 5 years ago
Tiger Oakes 2467588c4a Create shared custom view for library items 5 years ago
Andrey Mukamolov d5eeadda66 Closes #2142: Enable private browsing button is focused instead of Search or address 5 years ago
ValentinTimisica 4747f2c165 Fixes #4161: Modified style of bookmark_folders_sign_in button. (#4291)
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
5 years ago
Sawyer Blatz 9db0d88346
For #4262: Updates color and text of buttons (#4250) 5 years ago
Sawyer Blatz 28eb5c541a
For #1944 & #1750: Updates private & night mode colors (#4232) 5 years ago
Emily Kager 9b5baa2358 For #3360 - Adds empty state for TP Exceptions 5 years ago
Sawyer Blatz 7588251f8b
Closes #3986 & Closes #3661: Migrate QuickActionSheet to LibState & add tests (#4058)
* Closes #3986: Migrate QuickActionSheet to LibState

* Closes #3661: Add tests for QuickActionSheet

Co-authored-by: boek <jeff@jeffboek.com>

* For #3986: Fix feedback
5 years ago
Sawyer Blatz becdb88f4b Revert "For #1944 & #1750: Updates private & night mode colors (#4162)"
This reverts commit 2c95bb614a.
5 years ago
James Hugman 62850430b7 Closes AC#3695 - Add UI to open current page in external app 5 years ago
Tiger Oakes 6da6ddb095 Use StateListDrawable & resources w/ TabCollection 5 years ago
Emily Kager 451093fd9e Closes #2560 - Updates Private Browsing explanation string 5 years ago
Sawyer Blatz 2c95bb614a
For #1944 & #1750: Updates private & night mode colors (#4162) 5 years ago
Emily Kager 8daaa6378d Closes #4038 - Adds margin before close icon in tab item 5 years ago
Emily Kager 3143227692 For #3998 - Make Turn On Sync Fragment scrollable in landscape 5 years ago
Tiger Oakes 447123367a Remove unused sessions resources 5 years ago
Emily Kager 13b7e64c9b For #3134 - Add confirmation dialog to sign out of FxA (#3959) 5 years ago
Tiger Oakes 7747d5c240 Use tools:text to avoid inflating strings twice (#3619) 5 years ago
ekager 706f7d5961 For #3554 - Add DiffUtil to HistoryAdapter 5 years ago
Tiger Oakes 5de1678e65 No issue: Use putCompoundDrawables helper (#3982) 5 years ago
Emily Kager a9bfb303f7 For #3997 - Use ScrollView so landscape mode displays entire view 5 years ago
Emily Kager 5b10badc00 No issue: Remove rounded QAB corners to avoid overlapping web content 5 years ago
Emily Kager 7cea2ed048 For #3997 - Use srcCompat for sign in ImageView 5 years ago
Emily Kager 1f108f3c88 For #3806 - Adds corner radius to QAB and dialogs 5 years ago
Emily Kager c81dd0a4a8 For #3772 - Update FXA sign in UI (#3933) 5 years ago
Emily Kager 547c5d7bbe For #3906 - Add backgrounds to Permissions Buttons (#3958) 5 years ago
Emily Kager 9e7282cf18 For #1949 - Fixes bookmark separator appearance, removes menu (#3957) 5 years ago
Mugurell 0bf8b96790 Fix #3425 - Use Share header text as contentDescription (#3822) 5 years ago
ekager eaa9df7018 For #3547 - Use MaterialButton for Share Component Close Button 5 years ago
Weverson Nascimento 887102d215 For #3645: Fix search engine selection (#3665)
* Remove RadioButton drawable applied in runtime

* Add default RadioButton layout
5 years ago
Tiger Oakes d42052079a No issue: Remove duplicate wordmark and update about page (#3590) 5 years ago
Emily Kager c477c781a5 For #3355 - Allow multilines on bottom bar in Collection Creation (#3782) 5 years ago
Sawyer Blatz 4ccd19a585 For #2210: Improves UI of search fragment (#3773) 5 years ago
Tiger Oakes 606e66219c No issue: Use chains for bookmark items (#3696)
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
5 years ago
Emily Kager 77edb7afe1 For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list 5 years ago
ekager eb54d7c97f For #3690 - Gives defined size to pill_wrapper 5 years ago
Tiger Oakes e8bd090a8e No issue: Use ImageView rather than rebuilding drawable (#3616)
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
5 years ago
Emily Kager a1ddf17364 Closes #3569 - Uses primary text attr for bookmark folder icon (#3675) 5 years ago
Tiger Oakes a78d36354a Switch RadioButtonPreference to ConstraintLayout
Also ensure that RTL works properly.
5 years ago
Sören Hentzschel e1e4c7c1f9 No issue - reduce margin between favicon and title/url in library 5 years ago
Emily Kager 03a5cb2fb4 For #3620 - Adds automatic theme onboarding content description (#3629) 5 years ago
Tiger Oakes ab6101b0f4 Fixes #3539 - vectordrawablecompat for gradients (#3541) 5 years ago
Emily Kager 6bd9b82385 No issue: Remove flash of tab adapter updating data in create collection 5 years ago
Emily Kager 1de63df01f Closes #3080 - Update constraints so first collection visible by default 5 years ago
Emily Kager 9009d16ac6 Closes #3452 Closes #3553 - Implement one button style for all themes 5 years ago
Tiger Oakes f0f5374a57 Minify vector drawables 5 years ago
Emily Kager a941b875b4 For #3439 - Clean up where accent colors didn't work with dark theming 5 years ago
Emily Kager 7abf135c89 For #2896 - Update Checkbox color on tab in collection creation 5 years ago
Sawyer Blatz c48d7fb0c3 For #3447: Fixes folder icon color 5 years ago
Andrei Teslovan d70b6418b4 Issue 3334 - Fix icons alignment in Collections cards (#3382) 5 years ago
Jeff Boek 94556cceda For #3278 - Fixes property order in search_engine_radio_button.xml 5 years ago
Jeff Boek a86ec60f8f For #3278 - Fixes search engine selector layout 5 years ago
Tiger Oakes c73ba83f45 Minify drawable assets 5 years ago
Emily Kager e57e7b50ee For #2899 - Scroll to Collections on change, animate new collections (#3279)
* For #2899 - Scroll to Collections on change, animate new collections

* For #2899 - Scroll to tabs when tabs opened from collection
5 years ago
Emily Kager 704f1e6a3d For #3004 - Restore MotionLayout on Home View only in onCreateView 5 years ago
Grisha Kruglov fe3c163a20 Fix how we reflect FxA state in preference
This cleans up how we're displaying account state in the main preference UI.
Before when it worked, it worked mostly accidentally.
'launch' wrapper around "update ui" methods would trigger a race condition
between binding the account pref view holder and actually updating that view
with values. Sometimes the "update view with values" would happen after view
was bound, and the UI will be correct. Most of the time it would happen before,
and so there will be nothing to update and we'd get into an inconsistent state.

This also splits up the "accountpreference" into two: account is good,
and account needs re-auth. This greatly simplifies their management.
5 years ago
Emily Kager 60e3c81942 No issue: Update home screen margins 5 years ago
Emily Kager ca186c8776 Closes #1618 - Add fade to awesome bar list instead of shadow (#3110)
* Closes #1618 - Add fade to awesome bar list instead of shadow

* For #1211 - Hide keyboard on fling suggestions list
5 years ago
Colin Lee 5fb100debd
For #1966: Up button should cancel multi-selection first (#3108) 5 years ago
Jeff Boek 40a3246c32 Adds dialog style for Firefox Accounts 5 years ago
Jonathan Almeida f3b7a87852 For #2562: Make version codes selectable 5 years ago
Emily Kager 50ec91d6a2 For #2896 - Polish Save To Collection Button (#3093) 5 years ago
ekager 98a40aabd7 For #2223 , For #371 - Replace Toolbar with FIP when opened 5 years ago
Emily Kager 2da401357d For #2133 - Remove delete icon from delete history button (#3053) 5 years ago
Arturo Mejia 038aecc0ee For #1919- Websites' icons are not displayed on Site permissions (#3050)
Exceptions.
5 years ago
Jeff Boek ebe894801c For #3049 - Updates sign in card visual style 5 years ago
Emily Kager 0327b1146b For #2977 - Update add new collections flow (#2991)
* For #2977 - Update add new collections flow

* Rename shared elements to be more general

* Make tab list not clickable in other modes

* For #2577 - Stop Flickering in List

* Add extensions function for next step with collections list size
5 years ago
Jonathan Almeida ab39a5088a For #2052: Fix BrowserToolbar overlapping web content 5 years ago
Emily Kager 8d0174fff2 Closes #2990 - Remove library content descriptions from browsing data items (#3017) 5 years ago
Tiger Oakes 74dd2a5f23 Issue #103 - Pull to refresh (#3020) 5 years ago
Sawyer Blatz fe50e88fc8 For #2327: Adds error state syncing 5 years ago
Emily Kager 4347d22d9b Closes #2186 - Search Fragment search bar margins should be 8dp 5 years ago
Emily Kager d6c1f65d72 Start MotionLayout animation to end while navigating to search fragment 5 years ago
Emily Kager 8181705b58 Init Toolbar in edit mode so we don't see the flash 5 years ago
ekager dee3c059dc Adds Shared Transition between Home and Search 5 years ago
Jeff Boek 3920cda693 For #2419 - Adds a deletion state to the history component 5 years ago
Jonathan Almeida 540b0939d2 Closes #2878: Cleanup with card-like styling 5 years ago
Emily Kager bfc0fa36b1 For #2133 - Add destructive text color to delete history button 5 years ago
Emily Kager 9871c9b2e3 For #2417 - Fade end of Edit Bookmark edit text 5 years ago
Jeff Boek 51451ff002 For #225 - Deletes data on button press 5 years ago
Jeff Boek 3cf91fc303 For #225 - Adds button to delete browsing data 5 years ago
Jeff Boek 072ef5785d For #225 -Adds checkbox listener to data items 5 years ago
Jeff Boek e9c7943fe8 For #225 - Adds icons for list items 5 years ago
Jeff Boek 3006b21508 For #225 - Adds list items for delete browsing data 5 years ago
Jeff Boek 182bbdf359 For #225 - Adds delete browsing data fragment 5 years ago
Emily Kager 01c9317be0 For #2843 - Improve Collections UI and UX (#2851) 5 years ago
Sawyer Blatz e8943a2d9c No issue: Updates l10n static strings 5 years ago
Emily Kager beb2dec79f For #2780 - Fix home screen attributes for API 21-22 (#2844) 5 years ago
Tiger Oakes 207a8d6772 Use a ListAdapter for SessionControl 5 years ago
Emily Kager 09588dfda6 For #2529 - Remove "Delete Collection" button from private browsing 5 years ago
Sawyer Blatz 549292d06e For #2732: Removes view model usage from collection creation 5 years ago
Jonathan Almeida 8fbbcceb21 Adds send tab functionality to UI (#2790)
* Closes #2782: Hide send tab when no devices available

* For #2752: Enabled send tab for debug and nightly builds

* For #2753: Add Send Tab functionality to UI
5 years ago
Emily Kager 5bc143df4c Do not use ClipChildren false on homeLayout parent 5 years ago
Emily Kager 40f2fe5166 For #1287 - Create animation for opening and closing tab from home 5 years ago
Jonathan Almeida eb7646f073 Add custom share sheet and send tab support (#2757)
* Closes #2751: Add custom app share sheet

* Closes #2753: Add send tab devices to share sheet

* Closes #2752: Add build flag for send tab

* Replace Context.share with ShareFragment
5 years ago
Emily Kager 6057c3703a For #2061 - Added Find in Page Bar No Matches Text Color (#2746) 5 years ago
Jeff Boek ab590df18b For #2717 - Adds auto signed in state to the accounts onboarding card 5 years ago
Emily Kager 7492de321d For #2530 - Show report site issue and TP off globally in quick settings 5 years ago
Sawyer Blatz 220a843534 For #2205: Updates collection title constraints 5 years ago
Sören Hentzschel cc03aeb9f0 For #2435 - adds URL to bookmarks in library 5 years ago
Sawyer Blatz afbe397f94 For #1575: Enables adding tabs to existing collection 5 years ago
Jeff Boek 692724be2f For #2395 - Navigates to turn on sync on button press 5 years ago
Jeff Boek 9d74697ab3 For #2395 - Adds sign into sync card 5 years ago
Jeff Boek b3650cacff For #2399 - Wires up tracking protection onboarding card 5 years ago