Michael Comella
4493b90366
[fenix] No issue: move relevant files in :mozilla-lint-rules to perf pkg.
2020-11-13 16:07:59 -08:00
Michael Comella
9ddef29862
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : add ConstraintLayoutPerfDetectorTest.
...
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
2020-10-30 18:23:35 -07:00
Michael Comella
cb07bf265d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : remove super.visitElement for ConstraintLayout lint.
...
It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
2020-10-30 18:23:35 -07:00
Michael Comella
3f31e4cc1b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : clean up lint rules dependencies.
...
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.
mozilla-lint-rules worked but they were not clean.
2020-10-30 18:23:35 -07:00
ekager
2ae46088f6
[fenix] No issue - Update lint detector tests to run
2020-10-26 15:09:54 -07:00
Juan C. Goncalves
a3fce6b92d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11397 - Add lint rule for AppCompatResources instead of ContextCompat ( https://github.com/mozilla-mobile/fenix/pull/16011 )
2020-10-20 13:23:43 -07:00
Sebastian Kaspari
9c7e0ad770
[fenix] Update Android Components, Kotlin, Gradle plugin ( https://github.com/mozilla-mobile/fenix/pull/16021 )
...
* Closes https://github.com/mozilla-mobile/fenix/issues/13262 : Update AGP to 4
* Update to Mozilla Android Components 63.0.20201019090011.
* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.
* Fix new compiler warnings.
* Fix compilation of lint rules module.
* Pin JNA version.
* Fix new lint errors.
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-10-19 14:07:47 -04:00
Juan C. Goncalves
a68b2b2ec0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8947 - Lint check for licenses in Kotlin/Java source files ( https://github.com/mozilla-mobile/fenix/pull/15639 )
2020-10-16 17:41:08 -07:00
ekager
74b4866e3d
[fenix] Fixes existing lint errors
2020-10-15 09:53:13 -07:00
Michael Comella
0e8148f253
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : update Android Gradle Plugin version.
...
This ensures our custom lint rules are running on the command line.
2020-10-15 09:53:13 -07:00
Michael Comella
de1a390dba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : add ConstraintLayoutPerfDetector custom lint rule.
2020-10-14 15:20:28 -07:00
Michael Comella
095078a325
[fenix] No issue: minimize Button...Detector violation location.
...
This changes the error highlighting from being the entire contents of
<Button ...> to just the first line of <Button>.
2020-10-07 09:39:13 -07:00
TangHuaiZhe
20e0787404
[fenix] Update mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/TextViewAndroidSrcXmlDetector.kt
...
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
2020-08-21 20:07:18 -07:00
Tang HuaiZhe
43861331e7
[fenix] Fix the comment of TextViewAndroidSrcXmlDetector.
2020-08-21 20:07:18 -07:00
Elise Richards
fc847d79e7
[fenix] No issue: Delete unnecessary to-dos ( https://github.com/mozilla-mobile/fenix/pull/12603 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 13:38:07 -05:00
Mihai Branescu
bff1eb12c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8643 and https://github.com/mozilla-mobile/fenix/issues/7606 - added styles and new colors
2020-05-06 09:18:27 +03:00
Sawyer Blatz
e33e84bcbc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9857 : Create button style ( https://github.com/mozilla-mobile/fenix/pull/9858 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9857 : Creates text button style
* Adds lint check
* Fixes onboarding cards
2020-04-15 15:49:02 -07:00
ekager
ccee01a230
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/8944 - Adds custom lint checks
2020-03-27 13:59:51 -07:00
