Michael Comella
91ce22f753
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 - post: update metrics & pings data review URL.
4 years ago
Michael Comella
a4d569db34
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 - review: Add clarifying comments to onAppInit capture methods.
4 years ago
Michael Comella
12e7ad43c8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 - review: move forward metric expiration date.
...
We primarily want to determine if this is a problem area for us to
investigate rather than a long term measurement to keep so we should set
the expiration date accordingly. Furthermore, this code executes before
crash reporting is init so it's ideal to remove it sooner rather than
later.
4 years ago
Michael Comella
a3be78d7e8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 : hook up frameworkStart metric.
4 years ago
Michael Comella
deafedeada
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 : add StartupFrameworkStartMeasurement.
...
This class controls the central logic around the metrics we want to
record.
4 years ago
Michael Comella
162a93a190
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 : add Stat and test.
...
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
4 years ago
Michael Comella
3556b5a10f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 : add StartupTimeline ping type and framework_start metrics.
4 years ago
Emily Kager
04af2a59e8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9703 - Exit fullscreen in onPause and onSessionSelected ( https://github.com/mozilla-mobile/fenix/pull/10016 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9703 - Call fullScreenChanged in onPause
* For https://github.com/mozilla-mobile/fenix/issues/10015 - Exit full screen if new session selected
4 years ago
ekager
94515941cf
[fenix] Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver
4 years ago
Grisha Kruglov
2a4ad0e4eb
[fenix] Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
...
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
4 years ago
Mihai Adrian
b510210dce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9987 : Set FLAG_SECURE to dialog when flag set in activity. ( https://github.com/mozilla-mobile/fenix/pull/9998 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9987 : Add extension to secures dialog if parent activity is secured
* For https://github.com/mozilla-mobile/fenix/issues/9987 : Set FLAG_SECURE to dialog when flag set in activity
4 years ago
mozilla-l10n-automation-bot
a384ea16d0
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/10011 )
4 years ago
Emily Kager
e68491d737
[fenix] Fix: Set correct height for EditText ( https://github.com/mozilla-mobile/fenix/pull/10014 )
...
Created a dimension for the correct height that the EditText in the
fragment_edit_bookmark.xml has to have.
Co-authored-by: DrCesar <josuejacobstercero@gmail.com>
4 years ago
Mihai Eduard Badea
590a65a894
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9951 - Removed the extra empty spaces that were causing the spacing issue
4 years ago
mcarare
4010e9b64e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9565 : Adjust padding and height to allow longer text
4 years ago
mcarare
a697247aae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9536 : Update tests to check opened tab is in same browsing mode
4 years ago
mcarare
b5255177fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9536 : Open report issue tab depending on current browsing mode.
...
Checking if session is private uses the new browser state API.
4 years ago
mcarare
86677b3bf3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9989 : Add start & end margin to button.
4 years ago
Sawyer Blatz
fba1e732ef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7158 : Fixes browser to search animation fade
4 years ago
ekager
053f2017e6
[fenix] No issue: Uses NeutralButton for Migration Activity
4 years ago
Jonathan Almeida
1ce8e8383c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8422 : Add misc migration UI fixes
4 years ago
Jonathan Almeida
154ade7d64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8422 : Add spacing between migration items
4 years ago
ekager
7f3ca10103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9981 - Make Bookmark Menu UI respond to session selection
4 years ago
mcarare
880722de99
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9984 : Update addon before settings visibility check
4 years ago
Mozilla L10n Automation Bot
e3712155f9
[fenix] Import l10n.
4 years ago
ekager
e4136c64d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9516 - Adds selectable background to dialog and snackbar buttons
4 years ago
Sawyer Blatz
e33e84bcbc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9857 : Create button style ( https://github.com/mozilla-mobile/fenix/pull/9858 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9857 : Creates text button style
* Adds lint check
* Fixes onboarding cards
4 years ago
Jonathan Almeida
9a162480c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9409 : Add app icon to Leanplum push notifications
4 years ago
Jonathan Almeida
8ea49eb36a
[fenix] Remove duplicate FirebasePushService
...
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
4 years ago
Mihai Branescu
d2b9f203b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9420 - relaxed custom engine rules ( https://github.com/mozilla-mobile/fenix/pull/9967 )
...
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
4 years ago
Michael Comella
de6bbb791a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9644 : restrict deps to specific repositories ( https://github.com/mozilla-mobile/fenix/pull/9649 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9644 : remove unnecessary leanplum maven repository.
The docs say it is [1] "only needed for Android SDK versions below 4.3.0".
That is API 18 and our min SDK is 21.
[1]: https://docs.leanplum.com/reference#android-setup
* For https://github.com/mozilla-mobile/fenix/issues/9644 : move buildscript block from :app to root project.
This will reduce the amount of duplication we need in specifying
restricted dependencies and centralize repository definitions. Since
we're a one project app, it shouldn't have a significant impact on
performance.
* For https://github.com/mozilla-mobile/fenix/issues/9644 : restrict dependencies following FFTV config.
However, there is a resolution error to be fixed in the next commit.
This is verbatim from FFTV except I removed the no-op "improve security
if code is refactored incorrectly" lines: these lines rarely changed and
I'm not that concerned. It might be better to simplify the
configuration.
Source:
62a2fa680c/buildSrc/src/main/java/org/mozilla/gradle/Dependencies.kt (L7)
62a2fa680c/build.gradle (L31)
* For https://github.com/mozilla-mobile/fenix/issues/9644 : restrict firebase deps to google repo.
This fixes the resolution error from the previous PR.
4 years ago
ValentinTimisica
5504208fcd
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9710 : Vertically aligns users_count with rating ( https://github.com/mozilla-mobile/fenix/pull/9950 )
4 years ago
ekager
6b4334b699
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9887 - Respect screenshot setting when resetting window flags in logins
4 years ago
Jeff Boek
f35e5f3526
[fenix] No Issue - Fixes nav_graph issues ( https://github.com/mozilla-mobile/fenix/pull/9926 )
4 years ago
Arturo Mejia
bda6aa50f3
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9930 Do not assume all add-ons have a settings page
4 years ago
Mozilla L10n Automation Bot
d96a6b206c
[fenix] Import l10n.
4 years ago
ekager
4b5c454de7
[fenix] Update UI test to match Support Page title
4 years ago
ekager
e0a4a63d52
[fenix] Update Server.dev to Server.stage to fix A-S upgrade breaking change
4 years ago
Arturo Mejia
e5041e2fd8
[fenix] Update Android Components version
4 years ago
Arturo Mejia
f38165ad6d
[fenix] No issue: Fix add-on translate() breaking change
4 years ago
ekager
3b980dadad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3194 - Pause media while undo snackbar appears
4 years ago
ekager
c33ac4edc0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/204 - Remove PWA Feature Flag
4 years ago
Mozilla L10n Automation Bot
21dde5fe0b
[fenix] Import l10n.
4 years ago
Jeff Boek
6308049167
[fenix] Cleans up nav_graph.xml ( https://github.com/mozilla-mobile/fenix/pull/9829 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up homeFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Uses global actions for fragments not owned by homeFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up SearchFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes settings action from DeleteBrowsingDataFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes browser action from SettingsFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Adds ManagePhoneFeature global action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Clean up unused deletebrowsingfragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans Up HistoryFragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes Home -> Search action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes the Bookmark -> Browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up bookmark fragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up actions from ShareController
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes defaultBrowserFragment to browserFragment action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes about -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Adds global action to TrackingProtectionFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes exception -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes login -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Fixes LoginFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes ExternalAppBrowser directions
* for https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Fixes unit tests
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Addresses nits in PR
4 years ago
Arturo Mejia
fa157d252b
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520 : Improve add-ons UI
4 years ago
ekager
101d815231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9890 - Do not display full screen snackbar with toolbar padding
4 years ago
ekager
cf3f14b795
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9703 - Exit full screen on pause if pip not entered
4 years ago
Sawyer Blatz
92ea1cc5b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9892 : Set dynamicToolbarMaxHeigtht to 0 for PWAs ( https://github.com/mozilla-mobile/fenix/pull/9893 )
4 years ago
ekager
27adb232c7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9692 - Fix "Install" PWA menu item labeling
4 years ago
ekager
089e2db827
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7208 For https://github.com/mozilla-mobile/fenix/issues/7212 - Update parameterized strings
4 years ago
Christian Sadilek
7ca7557c17
[fenix] Configure M2 AMO collection for Nightly/Debug
4 years ago
Oana Horvath
acc46c960b
[fenix] fix https://github.com/mozilla-mobile/fenix/issues/9670 intermittent tests ( https://github.com/mozilla-mobile/fenix/pull/9767 )
...
also disabled intermittent closePrivateTabsNotification
4 years ago
mcarare
682b6db6a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9698 : Add unit tests for Context extension getStringWithArgSafe
4 years ago
mcarare
fca63c72d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9698 : Use extension to ensure fallback to English and avoid crash
4 years ago
mcarare
79e3a1c328
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9698 : Add Context extension to avoid format IllegalArgumentException
4 years ago
Mozilla L10n Automation Bot
b1aebe96de
[fenix] Import l10n.
4 years ago
Mugurell
83063d66f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7157 - Set BrowserMenu width to be max 314 dp ( https://github.com/mozilla-mobile/fenix/pull/9731 )
...
Instead of having a fixed width of 250dp the BrowserMenu will now have a
dynamic width between 250dp and 314dp allowing for a better fit for the menu
items it could display.
4 years ago
mcarare
c3a5be128f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9793 : Adjust relative positions to provide correct a11y traversal
4 years ago
Mozilla L10n Automation Bot
9baa18640c
[fenix] Import l10n.
4 years ago
mcarare
290141865c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9798 : Disable buttons on hiding and enable on showing.
...
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
4 years ago
Simon Chae
fdd629b61f
[fenix] Update not yet unavailable add-on string ( https://github.com/mozilla-mobile/fenix/pull/9677 )
4 years ago
Roger Yang
cc81201934
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/9827 : Support display cutouts
4 years ago
Christian Sadilek
07b1f84ec6
[fenix] No issue: Re-use existing usecases for addons
4 years ago
ekager
b57314cc8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2818 - Adds Picture-in-Picture feature
4 years ago
Mozilla L10n Automation Bot
a1cf9f7780
[fenix] Import l10n.
4 years ago
Michael Comella
b9fe826cef
[fenix] No issue: Move Do and OpenClass to utils pkg.
...
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
4 years ago
mcarare
c579e388d3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9797 : Set min height of dialog edit text to 48dp.
4 years ago
Abhay Agarwal
bcd9f52607
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9495 : Dismiss the ShareFragment in onPause()
4 years ago
Sawyer Blatz
7001260885
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9682 : Reduces size of branding ( https://github.com/mozilla-mobile/fenix/pull/9784 )
4 years ago
Christian Sadilek
7df242c354
[fenix] No issue: Refactor readerview to use browser-state
4 years ago
Sawyer Blatz
42a823fe24
[fenix] No issue: Add more settings animations ( https://github.com/mozilla-mobile/fenix/pull/9750 )
4 years ago
Mihai Eduard Badea
68a5b44663
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2768 - Prevent screenshots in private mode
...
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.
This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.
The setting is by default set to true (screenshots are allowed to be taken)
4 years ago
Mugurell
8fd1b5ef87
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9770 - Disable pull to refresh pending changes
4 years ago
Mozilla L10n Automation Bot
8f65dd9856
[fenix] Import l10n.
4 years ago
Michael Comella
18a639a64d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9631 : remove assertk dependency.
5 years ago
Michael Comella
f2dbaf24d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9631 : replace assertk assertions with junit.
...
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
5 years ago
Jeff Boek
4371996382
[fenix] For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker ( https://github.com/mozilla-mobile/fenix/pull/9191 )
...
* For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker
* For https://github.com/mozilla-mobile/fenix/issues/220 - Updates Android Components
5 years ago
Mihai Adrian
8f1876407b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture ( https://github.com/mozilla-mobile/fenix/pull/9743 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Update unit test to new controller parameters
5 years ago
Arturo Mejia
174af614f4
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9647 Crash when tapping settings after quickly
...
enabling/disabling add-on
5 years ago
Michael Droettboom
461853e252
[fenix] Fix errors in top_sites_count metric
...
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.
[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
5 years ago
Mozilla L10n Automation Bot
ff708e4ff1
[fenix] Import l10n.
5 years ago
mcarare
3647494de3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9663 : Allow more than one line for onboarding card header
5 years ago
Mozilla L10n Automation Bot
50bb5be4db
[fenix] Import l10n.
5 years ago
Aaron Train
4d216e26ea
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9688 : Disable ReaderViewTest for intermittent investigation in detection issues
5 years ago
Oana Horvath
47366000e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9670 : Disabled intermittent tabMediaControlButton test ( https://github.com/mozilla-mobile/fenix/pull/9679 )
...
and removed file created by mistake -e
added reason for disabled tests
5 years ago
Mugurell
dca4c74a30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3262 - Enable pull down to refresh in Nightly
5 years ago
Michael Comella
09253e7566
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 - review: clarify comments in new test runner.
5 years ago
Michael Comella
74fbc518db
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : Add LintUnitTestRunner gradle task.
...
This will prevent us from regressing on adding older versions of the
unit test runner.
5 years ago
Michael Comella
5d2c577c64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : TestApplication -> FenixRobolectricTestApplication.
...
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
5 years ago
Michael Comella
dff3a69dc3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : move TestApplication to the helpers package.
...
The helpers/ package is created to separate the test support code from
the code under test.
5 years ago
Michael Comella
f11bb37121
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : replace unit test runners with FenixRobolectricTestRunner.
...
This is how we can apply the new test runner to remove duplication.
This commit was generated programmatically with the following commands:
```
// Replace test runners with new one.
find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
// Replace imports of old test runners with new one
find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
// Remove unused imports
find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```
Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
5 years ago
Michael Comella
b401d400b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : add FenixRobolectricTestRunner.
...
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.
This class is adapted from Firefox for Fire TV:
https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
5 years ago
Michael Comella
774a07d5f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : remove unnecessary @RunWith(Robolectric in unit tests.
...
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.
Between this change and the last one, the unit test runtime was reduced
by ~10s.
5 years ago
Michael Comella
b9ffb3ddcc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : remove unnecessary @RunWith(AndroidJUnit4) in unit tests.
...
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
5 years ago
Aaron Train
3489fe1e22
[fenix] No issue: re-enable libraryMenuItemsTest and backButtonTest ( https://github.com/mozilla-mobile/fenix/pull/9639 )
5 years ago
MickeyMoz
0487e0ad62
[fenix] Update Android Components version to 38.0.20200403130109.
5 years ago
Mozilla L10n Automation Bot
caded80288
[fenix] Import l10n.
5 years ago
Michael Comella
cb29b33e21
[fenix] No issue: add kdoc to HomeActivity.
...
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
5 years ago
Sawyer Blatz
9e5e780a9a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9128 & https://github.com/mozilla-mobile/fenix/issues/9222 & https://github.com/mozilla-mobile/fenix/issues/9499 : Refactors snackbar creation and fixes placement ( https://github.com/mozilla-mobile/fenix/pull/9628 )
5 years ago
Codrut Topliceanu
b2d81076f9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7978 - Put views above button in scrollView ( https://github.com/mozilla-mobile/fenix/pull/8819 )
5 years ago
Gabriel Luong
e754578cef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6174 - Add telemetry for WebExtensions ( https://github.com/mozilla-mobile/fenix/pull/8318 )
5 years ago
Mihai Adrian
2f02eeb972
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9604 : Swap and adjust margin with padding to avoid text being cut ( https://github.com/mozilla-mobile/fenix/pull/9617 )
5 years ago
Michael Comella
006e32c454
[fenix] No issue: remove unused FirefoxTestRunner.
...
It would be used for on device tests but it doesn't seem to hooked up
currently.
5 years ago
Mozilla L10n Automation Bot
f7f452367d
[fenix] Import l10n.
5 years ago
mcarare
7e54f731db
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9422 : Nit: Fix xml indenting
5 years ago
mcarare
34394af021
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9422 : Align widget text to viewStart to support RTL layouts
5 years ago
Emily Kager
2ec2ee395b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/768 : Add first time PWA dialog ( https://github.com/mozilla-mobile/fenix/pull/9308 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
5 years ago
Sebastian Kaspari
548a18ba32
[fenix] Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds.
5 years ago
David Walsh
a96fa3b790
[fenix] Prevent favicons from flashing when items are selected in History ( https://github.com/mozilla-mobile/fenix/pull/9233 )
5 years ago
Mihai Adrian
66d28a700c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating ( https://github.com/mozilla-mobile/fenix/pull/9353 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating
* For https://github.com/mozilla-mobile/fenix/issues/9336 Update unit test to check for navigateSafe
5 years ago
Mihai Adrian
d6fe360148
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9423 : Align preference title and summary to viewStart ( https://github.com/mozilla-mobile/fenix/pull/9426 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9423 : Align preference title and summary to viewStart
* Update checkbox_left_preference_etp.xml
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
5 years ago
ekager
8224f61cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9533 - Switch to using enum for Library Item Selected Telemetry
5 years ago
Grisha Kruglov
4b91238222
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9553 : Only update account UI state once when creating SettingsFragment
5 years ago
ekager
ea9add8d2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8125 - Send top sites count with metrics ping
5 years ago
mcarare
ef2d26efee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Partially reverse menu items order when using top toolbar
5 years ago
mcarare
011b4f7fbd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Update naming to reflect history item
5 years ago
Kate Glazko
67bf4073ad
[fenix] NoIssueFixMetropolisAccountPref
5 years ago
Sawyer Blatz
eb99ae1fef
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9598 & https://github.com/mozilla-mobile/fenix/issues/8697 : Fixes force expand crash ( https://github.com/mozilla-mobile/fenix/pull/9599 )
5 years ago
codrut.topliceanu
7b333febc0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9549 - Scrolling to top sites now includes header.
5 years ago
mcarare
c0b09436d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9574 : Remove category layout from LeakCanary SwitchPreference
5 years ago
ekager
d1d0a09f21
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9564 : Fixes cut off strings in ETP panel
5 years ago
Mihai Branescu
d80763ee11
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9109 - remove the sync error highlight from three-dot menu
5 years ago
Kate Glazko
1ccd93d99a
[fenix] For 3687 Use Metropolis Font for Header
5 years ago
Mozilla L10n Automation Bot
9cb58154bb
[fenix] Import l10n.
5 years ago
Grisha Kruglov
12e3619a2e
[fenix] Make sure reconnect item is displayed in HomeMenu in case of account problems
...
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
5 years ago
Grisha Kruglov
8d1befd34c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9561 : Fix initialization order in HomeMenu
...
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.
Simply re-ordering initialization fixes the problem.
5 years ago
Arturo Mejia
12237fdca1
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520 : Polish Add-on manager UIs
5 years ago
Sawyer Blatz
72e91ad94a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9472 : ForceExpand browser toolbar when navigating ( https://github.com/mozilla-mobile/fenix/pull/9552 )
5 years ago
Oana Horvath
8dbcd4ed35
[fenix] Updated the method to verify system notifications and added new tests for media notifications ( https://github.com/mozilla-mobile/fenix/pull/9330 )
5 years ago
ValentinTimisica
7d57c791f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8412 : Passes error handling function to 'CustomTabWindowFeature' ( https://github.com/mozilla-mobile/fenix/pull/8903 )
...
* For https://github.com/mozilla-mobile/fenix/issues/8412 : Passes error handling function to 'CustomTabWindowFeature'
Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122
* Upgrade AC version
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
5 years ago
Grisha Kruglov
3d7f7cbe5d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9530 : Don't crash on failed avatar fetches
5 years ago
Mozilla L10n Automation Bot
59910e8d82
[fenix] Import l10n.
5 years ago
Grisha Kruglov
423d7cfdda
[fenix] Part 6: Kick-off account manager initialization after visual completeness
...
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.
Also, for signed-in users, this will establish background sync workers.
5 years ago
Grisha Kruglov
1a25bc758e
[fenix] Part 5: Refactor HomeMenu<->HomeFragment interaction
...
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.
Once that's in place, we start observing account manager changes (once its ready)
for account problems.
This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
5 years ago
Grisha Kruglov
13deec03a1
[fenix] Part 4: Make sure 'sync is on' snackbar does not initialize account manager
5 years ago
Grisha Kruglov
71564af97d
[fenix] Part 3: Mark accountManager as 'lazy' in Mode.kt
...
This is enough to cause it to be initialized only if we're going through onboarding.
5 years ago
Grisha Kruglov
1a6e1c0b7f
[fenix] Part 2: Do not eagerly initilize account manager within HomeActivity
...
Instead of always kicking off accountManager's init and telling it to sync right away in
'onResume', we move these tasks to some abstract point later on, whenever account manager
is available.
5 years ago
Grisha Kruglov
4e308faf35
[fenix] Part 1: Add 'accountManagerReady' queue to BackgroundServices
...
This gives us an ability to perform tasks against 'accountManager' without
causing its immediate initialization.
5 years ago
Grisha Kruglov
ccb08070a7
[fenix] Pre: introduce a RunWhenReadyQueue
...
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.
This ability to either execute or queue a task will be useful later on in the
commit series.
5 years ago
Aaron Train
e8cfeeb0a1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9189 : Fixes "static asset not found" error in doNotSaveLoginFromPromptTest, saveLoginFromPromptTest UI tests ( https://github.com/mozilla-mobile/fenix/pull/9439 )
...
AndroidAssetDispatcher class dispatcher was attempting to open a local asset with a query suffix from the request. If query suffix is found, remove it. Re-enable saveLoginFromPromptTest() and doNotSaveLoginFromPromptTest()
5 years ago
David Walsh
207fa5752a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9525 - Add bottom margin to top sites header
5 years ago
Sawyer Blatz
e488ed1773
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9132 : Update to search animation for top toolbar ( https://github.com/mozilla-mobile/fenix/pull/9524 )
...
* let animation in top toolbar mode play nicely.
* remove duplicate methods, make code readable.
* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.
* Update linting
Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
5 years ago
ekager
23656b2f53
[fenix] Use existing strings for announcement
5 years ago
asavill
e3427ab39f
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7720 :
...
- Increased atp switch size to be consistent with `dimen/tracking_protection_item_height`(48dp).
- Cut out redundant traversal of TextViews in SwitchWithTraversal as per https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md
- Reuse `QuickSettingsText.Icon` style on the switch component to be consistent with other items in the component_tracking_protection_panel.xml
- Added new string resources for textOff and textOn state to get appropriate screen reader description (unsure of the translation/localisation process here!)
5 years ago
David Walsh
af892ba291
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7059 - Allow search engines to scroll
5 years ago
David Walsh
8b88382e82
[fenix] Add top sites heading to home screen
5 years ago
mcarare
3fa441bedb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9498 : Update unit tests with new constructor argument
5 years ago
mcarare
ceec72715d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9498 : Replace navargs with viewModel to remember if scroll to tab
5 years ago
mcarare
f75a0e4347
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9496 : Vertically align collection name and icons to collection icon
5 years ago
Simon Chae
f3e86f841d
[fenix] Update NotYetSupported add-ons copy
5 years ago