Commit Graph

176 Commits (2de6a9aca7079ee3e80ea8b1408313bb73830136)

Author SHA1 Message Date
MozLando b963a3eab5 Merge #6102 #6106
6102: For #6018 Re-add Search Shortcuts Button r=boek a=BranescuMihai



6106: For #5872 & #6075: Set TabHeader buttons to invisible instead of gone. r=boek a=mcarare

At least one button has to be invisible instead of gone to keep layout height.
Tabs overflow button kept gone to avoid empty space on view end in private mode.



Co-authored-by: Mihai Branescu <branescu.mihai2@gmail.com>
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
5 years ago
Sebastian Kaspari 94c5aaac53 Update to Mozilla Android Components 18.0.0-SNAPSHOT. 5 years ago
Mihai Branescu be81a14b04 For #6018 - Added unit tests for interactor and controller 5 years ago
Kate Glazko 6210bb1da2 ExtTest for BookmarkNode 5 years ago
MozLando 662be3f686 Merge #5974
5974: Ext Test For ImageButton r=mcomella a=kglazko



Co-authored-by: Kate Glazko <katglazko@gmail.com>
5 years ago
Kate Glazko 829da2e546 Ext Test For ImageButton 5 years ago
MozLando 8e4d7248ac Merge #5908
5908: Closes #5876: Removed @ObsoleteCoroutinesApi in tests r=sblatz a=shldhll


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: shldhll <iam.shldhll@gmail.com>
5 years ago
MozLando f66b9f3e8f Merge #5633
5633: Add fxa/sync integration tests r=csadilek a=isabelrios

 Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [-] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [-] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

This PR tries to add new tests, sync integration tests, to check the sync process Desktop<->Fenix, first for Bookmarks and in the future for more.

Co-authored-by: Isabel Rios <isabelrios@mackbookirios.home>
Co-authored-by: isabelrios <isabelrios@gmail.com>
5 years ago
shldhll 265f89e772 Added required coroutines in tests. Closes #5876 5 years ago
shldhll 1ac806898e Removed ObsoleteCoroutinesApi from share tests. Closes #5876 5 years ago
shldhll f2158e4a98 Fixed imports. Closes #5876 5 years ago
shldhll 8e17ac05b1 Optimized imports. Closes #5876 5 years ago
shldhll f907ec52f0 Removed ObsoleteCoroutinesApi in tests. Closes #5876 5 years ago
Emily Kager f9afd97a68 For #1901 - Get rid of black flash when leaving GV Engine 5 years ago
Ahmed I. Khalil f008d29bf3 Closes #5852 - Use createAddedTestFragments in tests. 5 years ago
Roger Yang e9760fb185 Closes #5847: Use IO thread when submitting crash report 5 years ago
Tiger Oakes 5e2f0dcf26 Remove @ObsoleteCoroutinesApi from TestCore 5 years ago
Severin Rudie 411ccc8f1f For 4780: add DefaultBrowsingModeManager tests 5 years ago
Severin Rudie c9e68bda31 For 4780: remove Settings#usePrivateMode and tests 5 years ago
isabelrios 0e3148f0da fixing more reviewers comments 5 years ago
isabelrios cdefb0d099 Fix TC error and run only ui tests 5 years ago
Denys M a4439ff373 For #3563. Use `ListAdapter` for App Share list. 5 years ago
Colin Lee b7647a454f
For #5599: Remove dependency on fetch_httpurlconnection (#5716)
* For #5599: Remove dependency on fetch_httpurlconnection

* For #5599: Switch Glean to GeckoViewFetchClient

* Use existing Gecko client for Glean
5 years ago
Sawyer Blatz 841b06b02f
No issue: fixes master (#5777) 5 years ago
Sawyer Blatz 371e2ac3d8
For #514 & #5742: Updates "launch links in private tab" functionality (#5721)
* For #514 & #5742: Updates "launch links in private tab" functionality

* Fixes comments
5 years ago
Severin Rudie 3be06953d6 For #4780 switch off private mode (#5614)
* Do not launch in Private Mode

When the app launches do not launch in Private Mode in order to prevent usage leaks to other users of the device.

* Issue #4780: add comments to use private mode

* For #4780: write tests for clear private mode on create app

* For #4780: clear private mode when privacy notification is removed
5 years ago
Sawyer Blatz 785b8b9519
For #5567: Removes search shortcuts button (#5739)
* For #5567: Removes search shortcut button

* No issue: Simplifies logic for displaying shortcuts
5 years ago
Sawyer Blatz 2896b36d14
No issue: Updates naming of launch links privately var (#5701)
The previous name was pretty confusing
5 years ago
ekager ef29fe2584 Update BackgroundServicesTest, Suppress Complex Method 5 years ago
Sawyer Blatz 5e18ead45e For #4474: Adds tests and fixes issues 5 years ago
Tiger Oakes ee1f040e53 No issue: Move signedIn tracking to BookmarksSharedViewModel (#4755) 5 years ago
Tiger Oakes 88aa519210 Closes #4711 - Extract VoiceSearchActivity (#5502) 5 years ago
Severin Rudie dffa61bf16 Closes #4513: fixes bookmark tests broken by loading change
Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies
5 years ago
Severin Rudie fd7f1b2665 Closes #4513: adds tests for bookmark loading state 5 years ago
Colin Lee de93b05cac For #2754 Add tab cards to share sheet (#5493)
* For #2754 Add tab cards to share sheet

* For #2754: Fix background near rounded corners and ShareButtonAppearanceTest

* Add license to share_tab_item
5 years ago
Christian Sadilek ac2611d744 Upgrade to A-C 15.0.0-SNAPSHOT (incl. required changes) (#5578)
* Upgrade to Mozilla Android components 15.0.0-SNAPSHOT

* Update findinpage integration to use browser-state

* Use new UseCases APIs after download migration.
5 years ago
Mugurell c5330c6880 For 5092 - Show a Snackbar with retry option if sharing to devices fails (#5158)
* For #5092 - Show a Snackbar with retry option if sharing to devices fails

ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.

* For #5092 - Refactor ShareControllerTest

* For #5092: Adds color theming of snackbars
5 years ago
ekager 24b3ed4384 For #5568 - Don't pass in Session for QuickActionSheetController 5 years ago
Emily Kager b0b60aa27d For #5281 - Use TrackerLog for reporting ETP categories (#5556) 5 years ago
Sawyer Blatz 856399e9e2
No issue: Fixes GleanMetricsService nits & broken UI test (#5539)
* No issue: Fixes GleanMetricsService nits

* No issue: fixes broken UI test
5 years ago
Alessio Placitelli 1ffdf1cf9b Add basic test coverage for Glean metrics in Fenix
This introduces test coverage, using the Glean SDK
testing API, for the metrics that are set at startup
by Fenix in the GleanMetricsService.

This additional adds a basic test for the translation
of the `app_opened` event.
5 years ago
Tiger Oakes 8c30200ced Only use Context.settings() function (not getter) (#5335)
Remove unused String extensions
5 years ago
Tiger Oakes 734d4031e2 Extract UriOpened observer from HomeActivity 5 years ago
Tiger Oakes e3c60faf24 Move BookmarkNode extensions to helper class (#4752) 5 years ago
Jonathan Almeida 612b0fc006 For #5406: Ignore intermittent failing test temporarily 5 years ago
Tiger Oakes cb7701584f No issue: Extract home fragment mode (#5343) 5 years ago
Christian Sadilek c866ae1a1e Closes #5444: IntentReceiverActivity: Add tests for intent processing 5 years ago
Tiger Oakes 6c30a94081 Move settings classes to packages 5 years ago
Tiger Oakes 699eacab39 For #778 - Rename CustomTabActivity 5 years ago
Tiger Oakes 172a9cf06c Extract and test crash reporter code 5 years ago