rxu
3ec2a3d971
[fenix] Add mozcn safebrowsing
2020-11-05 18:02:30 +01:00
Michael Comella
c481d0504b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 - review: set LazyMonitored to private.
2020-11-05 07:48:17 -08:00
Michael Comella
17b32070dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : add component init count to StartupExcessiveResourceUseTest.
2020-11-05 07:48:17 -08:00
Michael Comella
e0ee4f6d40
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : add MozillaUseLazyMonitored custom detekt rule.
2020-11-05 07:48:17 -08:00
Michael Comella
7ac4b40fa8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : remove redundant lazy wrapper from storage APIs.
...
They're currently lazy { lazy { value } }. Accessing `lazy.value`
directly allows us to make it lazy { value }. This should be more
performant and prevents us from double-counting these components.
2020-11-05 07:48:17 -08:00
Michael Comella
9e8fd7c6f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : LazyMonitored implement Lazy + update built-in API use.
...
By having LazyMonitored implement Lazy, we can continue to pass these
values directly into the ac APIs that require Lazy references. For some
reason, implementing `Lazy.value` can replace `operator fun getValue`
required for delegates.
2020-11-05 07:48:17 -08:00
Michael Comella
3879697c06
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : replace lazy with lazyMonitored in component groups.
...
By component groups, I mean I applied this to any class with the
class kdoc, "Component group for...".
There are a few instances of lazy we had to keep using the old API to
avoid having to update constructor arguments.
2020-11-05 07:48:17 -08:00
Michael Comella
07e69195f2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : add LazyMonitored and tests.
2020-11-05 07:48:17 -08:00
mozilla-l10n-automation-bot
83cf8baedf
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16380 )
2020-11-04 18:58:23 -08:00
MickeyMoz
4a2068dcda
[fenix] Update Android Components version to 66.0.20201104190117.
2020-11-04 18:30:59 -05:00
Kate Glazko
88375a2294
[fenix] For https://github.com/mozilla-mobile/fenix/issues/352 : Delete a download
2020-11-04 13:32:24 -08:00
ekager
5344dceead
[fenix] No issue: Update stable androidx and material versions
2020-11-04 12:00:32 -08:00
MickeyMoz
0a23fe6362
[fenix] Update Android Components version to 66.0.20201104143131.
2020-11-04 17:58:11 +01:00
Mugurell
f3d5862668
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6521 - Remove auto sigin onboarding card ( https://github.com/mozilla-mobile/fenix/pull/16315 )
...
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when https://github.com/mozilla-mobile/fenix/issues/15694 would add
to Fenix the ability to serve as a custom account provider.
2020-11-04 17:23:19 +02:00
Mugurell
0a8d8cfbf0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16323 - Use 10dp corner radius for the selected outer border of a grid item ( https://github.com/mozilla-mobile/fenix/pull/16364 )
...
This would ensure the corners of the inner and outer borders are aligned, with
no empty gap between them.
2020-11-04 10:03:43 -05:00
MickeyMoz
0e28b0c8fe
[fenix] Update Android Components version to 65.0.20201103190112
2020-11-04 11:27:13 +01:00
Mugurell
2f04b48e7c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14980 - Effectively disable tabs tray STATE_HALF_EXPANDED ( https://github.com/mozilla-mobile/fenix/pull/16052 )
...
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
2020-11-04 11:22:46 +02:00
Stefan Arentz
c7c56aa055
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/16348 - Increase Gradle daemon memory size ( https://github.com/mozilla-mobile/fenix/pull/16349 )
2020-11-03 15:57:53 -05:00
Mihai Adrian Carare
647117ca54
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13172 - Tab swipe order follows text direction from oldest to newest ( https://github.com/mozilla-mobile/fenix/pull/16178 )
2020-11-03 15:48:00 -05:00
Rafał Opiłowski
7dab7b2d53
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12971 - Show collection saved snackbar above FAB ( https://github.com/mozilla-mobile/fenix/pull/16311 )
2020-11-03 15:45:23 -05:00
Oana Horvath
24d2b31b74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15847 - Disables verifyAboutFirefoxPreview UI test ( https://github.com/mozilla-mobile/fenix/pull/16346 )
2020-11-03 15:31:36 -05:00
Mugurell
5311233fae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16339 - Initialize FxaAccountManager with also a CrashReporter ( https://github.com/mozilla-mobile/fenix/pull/16340 )
2020-11-03 14:46:08 +02:00
Sebastian Kaspari
03343e86ed
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16256 : Introduce build flag for "Mozilla Online" variant.
...
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).
At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
2020-11-03 10:34:25 +01:00
Oana Horvath
4fe05cc97c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13446 UI tests: wait for historyList to exist
2020-11-03 10:59:33 +02:00
Mozilla L10n Automation Bot
9007d8d33e
[fenix] Import l10n.
2020-11-02 19:44:47 -08:00
Gabriel Luong
ba18f60d64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14636 - Update preference section headers to use correct color, spacing and rulers ( https://github.com/mozilla-mobile/fenix/pull/16332 )
2020-11-02 19:56:41 -05:00
Michael Comella
b495ffee53
[fenix] No issue - review: clarify thread safety of suppressionCount.
2020-11-02 15:37:04 -08:00
Michael Comella
6fed5f3177
[fenix] No issue: make StrictMode suppression count thread safe.
2020-11-02 15:37:04 -08:00
Christian Sadilek
ecd79c4d6e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 : Switch to consumeFlow and add tests
2020-11-02 14:23:33 -08:00
ekager
5991d0996e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 - Remove activityViewModels workarounds
2020-11-02 11:30:37 -08:00
MarcLeclair
78850c7e3d
[fenix] 15278 detekt rule runblocking ( https://github.com/mozilla-mobile/fenix/pull/15942 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added CoroutineManager to count runBlocking calls
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added actual detekt rule for runblocking and its config to the yaml
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added unit test for RunblockingCounter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test
* Lint fix
* For https://github.com/mozilla-mobile/fenix/issues/15278 : made runblocking a Long to prevent overflow
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed MozRunblocking name, description and moved RunBlockingCounter to perf package
* For https://github.com/mozilla-mobile/fenix/issues/15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added setup for unit test, since it failed without restting counter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Fixed naming for RunBlocking lint check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : removed changes made to test to use runBlockingIncrement
* For https://github.com/mozilla-mobile/fenix/issues/15728 : added test exclusion for runBlocking check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : changed null check and added Synchronized to count setter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fix for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added StartupExcessiveResourceUseTest to CODEOWNERS
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Moved increment function to extension function and fixed indentation
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added tests for Atomic Integer extension and nit fix
2020-11-02 12:49:17 -05:00
ekager
e564dda990
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Remove unneeded delay in BrowserAnimator
2020-11-02 09:38:15 -08:00
Roger Yang
f60df4a976
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16268 - Allowing multiple task while sharing ( https://github.com/mozilla-mobile/fenix/pull/16275 )
2020-11-02 11:16:29 -05:00
Jocelyne Abi Haidar
3139337d7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15931 : Sort Downloads from newest to oldest ( https://github.com/mozilla-mobile/fenix/pull/15939 )
2020-11-02 11:06:30 -05:00
mcarare
e682cb55cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget voice search.
2020-11-02 15:50:12 +02:00
mcarare
c66ab231d5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget text search.
2020-11-02 15:50:12 +02:00
mcarare
87ce122d03
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14552 : Do not display back button when there is no tab history.
2020-11-02 14:25:49 +02:00
MickeyMoz
95d1497c25
[fenix] Update Android Components version to 65.0.20201101143039.
2020-11-02 00:19:08 -05:00
Mozilla L10n Automation Bot
a94eca1063
[fenix] Import l10n.
2020-11-02 00:12:21 -05:00
MickeyMoz
95d897d7c1
[fenix] Update Android Components version to 65.0.20201031143038.
2020-10-31 13:45:20 -04:00
Michael Comella
133965917c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 - post: add lint test dependencies to android-gradle-dependencies script.
...
`assemble` doesn't assemble the tests so we need to run `test`.
`testClasses` isn't good enough because, according to `--profile`, it
doesn't include dependencies for `testRuntimeClasspath`.
2020-10-30 18:23:35 -07:00
Michael Comella
7479db73fe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : run lint rules tests in CI.
...
This works but it's imperfect: when the tests fail, it links to the lint
failure artifacts rather than the test failure artifacts.
2020-10-30 18:23:35 -07:00
Michael Comella
62a0f6b088
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : add lint rules tests to pre-push hook.
2020-10-30 18:23:35 -07:00
Michael Comella
424af26340
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : add MozillaStrictModeSuppressionTest.
2020-10-30 18:23:35 -07:00
Michael Comella
5ed416405e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : correctly configure JUnit for mozilla-detekt-rules.
...
Without this, the tests would not run from the command line though they
could run in Android Studio.
2020-10-30 18:23:35 -07:00
Michael Comella
ce90102a75
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : add ConstraintLayoutPerfDetectorTest to code owners.
2020-10-30 18:23:35 -07:00
Michael Comella
9ddef29862
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : add ConstraintLayoutPerfDetectorTest.
...
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
2020-10-30 18:23:35 -07:00
Michael Comella
cb07bf265d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : remove super.visitElement for ConstraintLayout lint.
...
It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
2020-10-30 18:23:35 -07:00
Michael Comella
3f31e4cc1b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : clean up lint rules dependencies.
...
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.
mozilla-lint-rules worked but they were not clean.
2020-10-30 18:23:35 -07:00
Mugurell
b85522198c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15963 - Increase touch target for the close button in the tabs tray grid layout
...
We need to ensure it has at least 48dp while also not appearing too big.
2020-10-30 18:13:50 -04:00