Commit Graph

7344 Commits (2d8aceff32bb2fd2a98f63f768f5a7361a7a8e9a)
 

Author SHA1 Message Date
Michael Comella 365983d4b0 For #21294: suppress MaxLineLength in Fact.toEvent.
These double comparisons are easier to read and see the pattern of on one line
so I'd rather keep them on one line. Additionally, it's difficult to
test each change individually so I'd rather not make additional changes.
To do this, I suppressed the max line length warning.
3 years ago
Michael Comella c10f41164d For #21294: remove allocations in Fact.toEvent.
This commit was generated primarily by a macro that:
- appends `== component &&`
- appends `== item`
- (if applicable) Skips to the ending brace
- Go down one line and move cursor to the front of the line to prep for repeat

My only intervention was to skip extra lines to line it up to run again
and specify how many times in a row it should run.

---

The `to` in this code is an infix function that calls instantiates a
Pair under the hood. Subjectively observed, when this method is called
it generally hits the else case so 35 Pairs are instantiated each call -
that's 560 bytes. This method is called frequently - for example, an estimated
4 times each time a letter is typed on the homescreen and a measured 116 times
in a simple navigation (see the issue). The latter generates an estimated
63.4 KiB.

It was straightforward to remove these allocations so that's what this
change does.

The primary risk from this change is that it's difficult to test each
case to ensure it's working.
3 years ago
Michael Comella d33e38e020 For #21294: change `when (condition) {` `when {` in Fact.toEvent.
This will not compile. However, it enables the subsequent PR to remove
allocations from Fact.toEvent.
3 years ago
Michael Comella 4c33b1b75c For #21294: add partial test for existing factToEvent code.
When we refactor, this will help ensure we've done it correctly.
3 years ago
codrut.topliceanu 0e88c25df1 For #20762 - Adds grey border to inactive tabs 3 years ago
MickeyMoz 13663043ce Update Android Components version to 94.0.20210929224637. 3 years ago
Mozilla L10n Automation Bot f8edee649a Import l10n. 3 years ago
Elise Richards 02614eb889 For #21574: Move the homescreen onboarding card behind a feature flag 3 years ago
Mugurell e72b7f7cc8 For #21561 - Enable/Disable the feature from the customization menu 3 years ago
Mugurell 0c632dbbdb For #21391 - Final design composables
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
3 years ago
Andrei Joltan d30583e0e7
For #21442 fix flaky deleteMultipleSelectionTest UI test (#21563)
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Roger Yang ddd472d143 No issue: Improve rendering of jump back in 3 years ago
AndiAJ 37e342fd92 For #21478 fix flaky verifyOpenTopSiteNormalTab UI test 3 years ago
Oana Horvath 0ac23486c1 Fixed verifyAboutFirefoxPreview test according with new steps 3 years ago
Oana Horvath 1015072db6 Fixed disabled UI test openExternalLinksInPrivateTest 3 years ago
Roger Yang 53206df9b6 Close #21552: Remove Extra Subtitle In Jump Back In Item 3 years ago
Roger Yang 8193138015
Fix recent tabs intermittent tests (#21557)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
MickeyMoz da006c6cce Update Android Components version to 94.0.20210928190108. 3 years ago
Elise Richards 777f2d1f12
For #21339: update styles for homescreen show all buttons and jump back in spacing (#21342)
For #21339: Add ignores for intermittent ui tests

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Mugurell c1f0e5a611 For #21275 - Sort items by how many times they were actually shown 3 years ago
Christian Sadilek 4596d4f905
Do not capture search terms when user navigates away via app (#21527)
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
AndiAJ bf3b669151 Delete browsing data tests UI tests 3 years ago
AndiAJ 06292ac8d6 Fix disabled toggleSearchSuggestions UI Tets and refactoring work 3 years ago
Elise Richards ab13ae09f2
For #21313: renewing performance awesomebar metrics (#21315) 3 years ago
Roger Yang 8a15e8a681 Close #21451: Add active search term tab groups on home 3 years ago
Arturo Mejia f15291757b For #21493 show onboarding dialog for home sections 3 years ago
codrut.topliceanu f338d64a4c For #20762 - Fixes NPE crash with nullchecks for binding 3 years ago
MickeyMoz aa0ef8a726 Update Android Components version to 94.0.20210927143215. 3 years ago
AndiAJ 10f2074749 Fix disabled shortcutButtonTest UI test 3 years ago
Mugurell ba4c44afcf For #21045: Add categories support 3 years ago
Mugurell ccc0f17e4f For #21045: Cleanup
- stick to one naming scheme: rename articles to stories and use this all
throughout the app.
- add some spacing above the new section (as per the current design)
3 years ago
Mozilla L10n Automation Bot 27d319bc56 Import l10n. 3 years ago
MickeyMoz 83357c673d Update Android Components version to 94.0.20210926133629. 3 years ago
Mozilla L10n Automation Bot 009f2a97b8 Import l10n. 3 years ago
MickeyMoz 79ebdff63e Update Android Components version to 94.0.20210924143217. 3 years ago
Mozilla L10n Automation Bot 8426c399ad Import l10n. 3 years ago
codrut.topliceanu e8c332964d For #21087: Updates Recently Saved design 3 years ago
MickeyMoz 2ea5d30a58 Update Android Components version to 94.0.20210924002420. 3 years ago
Christian Sadilek 54549c49ec Fix mapping between history visits and groups to use createdAt
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
3 years ago
Aaron Train 1418d3f2bd Closes #21441: Fix changeAccessibiltySettings 3 years ago
Jonathan Almeida 26dc3ea47e Issue #21366: Speculative fix for failing test in TitleHeaderBindingTest 3 years ago
MickeyMoz 3b92f95373 Update Android Components version to 94.0.20210923143204. 3 years ago
Christian Sadilek d830006984 For #20893: Dedupe urls/site in history groups 3 years ago
Gabriel Luong 976dd6ebe1 For #21460 - Rename "Delete from history" to "Remove" for recent visit dropdown menu 3 years ago
Oana Horvath 43d1cb233e For #17847: adding back editCustomSearchEngineTest UI test 3 years ago
AndiAJ d534adc932 Improve coverage verifyEmptyBookmarksMenuTest and undoDeleteMultipleSelectionTest UI tests 3 years ago
AndiAJ 3ad0ec1302 Fix for disabled saveLoginFromPromptTest 3 years ago
Mozilla L10n Automation Bot 74989db239 Import l10n. 3 years ago
MickeyMoz 11cf4e367e Update Android Components version to 94.0.20210922143147. 3 years ago
Gabriel Luong 90d7927b2f Issue #21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs 3 years ago