2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-03 23:15:31 +00:00
Commit Graph

314 Commits

Author SHA1 Message Date
Michael Comella
18a639a64d [fenix] For https://github.com/mozilla-mobile/fenix/issues/9631: remove assertk dependency. 2020-04-06 16:56:40 -07:00
Michael Comella
74fbc518db [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: Add LintUnitTestRunner gradle task.
This will prevent us from regressing on adding older versions of the
unit test runner.
2020-04-03 09:27:49 -07:00
Sebastian Kaspari
548a18ba32 [fenix] Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds. 2020-04-01 17:51:32 -07:00
ekager
ccee01a230 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/8944 - Adds custom lint checks 2020-03-27 13:59:51 -07:00
Christian Sadilek
0c9b5ec2a9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9414: Make AMO collection configurable 2020-03-26 17:26:20 -04:00
Jonathan Almeida
ffe0b68182 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7661: Add deeplink schemas for fennec variants 2020-03-25 15:39:44 -04:00
Christian Sadilek
356df2cc0e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9333: Prevent compression of omni.ja to improve startup time
Co-authored-by: Markus Stange <mstange@themasta.com>
Co-authored-by: Agi Sferro <agi@sferro.dev>
2020-03-24 16:10:11 -07:00
Ryan Kelly
7d08e36843 [fenix] Add support for application-services autoPublish local dev workflow. 2020-03-19 10:51:08 +02:00
Jonathan Almeida
061af2c380 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7661: Add variant-specific schemas for deep links
In order to target specific variants of Fenix, we're adding schemas that
are specific that app in order to avoid collisions with the other
variants and with other forks of fenix that may have the same schemas.

The current schema for variants:
 - Fenix Nightly: `fenix-nightly://`
 - Fenix Beta: `fenix-beta://`
 - Everything else: `fenix://`
2020-03-17 17:21:09 -04:00
Sebastian Kaspari
4169924754 [fenix] Use pinned Android Components Nightly version instead of snapshots. 2020-03-17 12:09:36 +01:00
mcarare
d8cba93d1b [fenix] For https://github.com/mozilla-mobile/fenix/issues/8788 Use Flexbox instead of Grid manager for top sites 2020-03-09 11:01:14 -07:00
Michael Droettboom
b30f9b1970 [fenix] 1592947: Use the Glean Gradle plugin 2020-02-28 13:24:58 -08:00
Grisha Kruglov
32802e7fc8 [fenix] Remove direct A-S dependency; switch to using 'full' megazord
As far as I can tell, we never actually exercise the a-s libraries in Fenix tests currently (this was one of the presumed reasons for having a direct dependency).
In a different branch I've started work on adding end-to-end tests, but currently that's blocked on trying to figure out to load native libraries in tests (somehow, fenix's setup is different than what we have in A-C, not yet clear to me in what way).

Another reason for a direct dependency (i think) is that we needed it to configure a `fenix` megazord. This could be solved via a `support-megazord-fenix` a-c component that provides the correct transient dependencies,
but we can also just switch to use the `full` megazord instead, which is essentially what fenix megazord is at this point. A-S team wants to remove the fenix megazord, so this will help. This is what this patch does.
2020-02-25 17:30:57 -08:00
Mihai Branescu
4fe9033c0f [fenix] For https://github.com/mozilla-mobile/fenix/issues/4231
Added kapt plugin + dependencies in order to be able to use Room
Added recent apps to share fragment (top 6)
Extracted dimens of share_to_apps.xml in the dimens file
2020-02-19 10:36:58 -08:00
Jeff Boek
72618be169 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3869 - Uses RegionSearchLocalizationProvider in the search engine provider 2020-02-18 10:10:16 -08:00
Aaron Train
5bc087bd9b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/8316: Disable animations for instrumented tests (https://github.com/mozilla-mobile/fenix/pull/8317) 2020-02-11 15:24:10 -05:00
Alessio Placitelli
b0cd0692ed [fenix] Test that 'baseline' pings are sent by Fenix
This is an initial instrumented test for Fenix
that checks if a 'baseline' ping is generated when
going to background.
2020-02-05 19:06:46 +01:00
Gabriel Luong
aaf9c65f5d [fenix] Provide add-on support (https://github.com/mozilla-mobile/fenix/pull/8064)
Closes https://github.com/mozilla-mobile/fenix/issues/5630, https://github.com/mozilla-mobile/fenix/issues/6069, https://github.com/mozilla-mobile/fenix/issues/6092, https://github.com/mozilla-mobile/fenix/issues/6091, https://github.com/mozilla-mobile/fenix/issues/6124, and https://github.com/mozilla-mobile/fenix/issues/6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-02-04 01:41:51 -05:00
Jonathan Almeida
8e13b8bb98 [fenix] For https://github.com/mozilla-mobile/fenix/issues/373: Implement LeanPlum push messaging
Also closes https://github.com/mozilla-mobile/fenix/issues/6250, since we rely solely on the SDK itself to consume the
messages straight from FCM.
2020-02-04 00:13:56 +01:00
Gabriel Luong
bcc77834dd [fenix] For https://github.com/mozilla-mobile/fenix/issues/6758 - Part 2: Add AC dependencies for top sites feature 2020-01-24 15:18:25 -08:00
Jonathan Almeida
5c1dc2bbdc [fenix] For https://github.com/mozilla-mobile/fenix/issues/7092: Add initial Migration UI 2020-01-15 21:41:01 -08:00
Colin Lee
f5a7312763 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5182: Loading experiments on startup is slow, remove Fretboard (https://github.com/mozilla-mobile/fenix/pull/7510)
This removes Fretboard. The goal is to reduce cold startup costs associated with loading the experiments on the main thread. We currently have two experiments frameworks in use and should only require one.
2020-01-13 12:38:32 -06:00
Michael Comella
070d098012 [fenix] No issue: remove lint baseline file.
This will enable folks to see the existing warnings.
2020-01-06 18:27:51 +02:00
Mihai Branescu
bbd73acf60 [fenix] Feature/https://github.com/mozilla-mobile/fenix/issues/220 language menu (https://github.com/mozilla-mobile/fenix/pull/7070)
* For https://github.com/mozilla-mobile/fenix/issues/220
- Added advanced header + locale settings item in the settings fragment

* For https://github.com/mozilla-mobile/fenix/issues/220
- Added locale selection page with lib state + handling of locale changes

* For https://github.com/mozilla-mobile/fenix/issues/220
- Removed registering for locale changes in the manifest, allow system
to restart activity in that scenario

* For https://github.com/mozilla-mobile/fenix/issues/220
- Added unit tests for locale settings page

* For https://github.com/mozilla-mobile/fenix/issues/220: fixed an outdated unit test
ga-a

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2020-01-03 18:15:35 -08:00
Severin Rudie
8b746007fd [fenix] 7410 remove rxjava (https://github.com/mozilla-mobile/fenix/pull/7426)
* For https://github.com/mozilla-mobile/fenix/issues/7410: rewrite updateBookmarkFromObservableInput with coroutines

* For 7410: remove RxJava from project. :(

* For 7410: converted updateBookmarkFromTextChanges to Flow per review
2020-01-03 14:37:12 -08:00
Michael Comella
42ec15c095 [fenix] No issue: remove unused Anko dependencies. 2019-12-31 10:46:39 -05:00
Kadeem M
78a599b06e [fenix] Added UI tests for the About Settings page (https://github.com/mozilla-mobile/fenix/pull/6161) 2019-12-27 07:55:35 -08:00
Ryan Kelly
b806b4c5fa [fenix] Use feature-accounts-push, which replaces feature-sendtab. 2019-12-13 16:42:28 -08:00
Colin Lee
a9a3fdc1fd [fenix] For https://github.com/mozilla-mobile/fenix/issues/4064: Replace prerelease R8 with improved Kotlin coroutines library (https://github.com/mozilla-mobile/fenix/pull/7153) 2019-12-13 13:29:27 -06:00
isabelrios
4a62f38670 [fenix] Re-enable Screenshots tests (https://github.com/mozilla-mobile/fenix/pull/6617)
disabling setting test options due to different screen sizes

name screenshots according to robots

fix kotlin style

update settings tests with new Toolbar option

screenshots tests in different package than ui tests
2019-12-10 13:05:47 +02:00
Gabriel
9ed4f7f119 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5574 - Migrate SessionControl to LibState (https://github.com/mozilla-mobile/fenix/pull/6651)
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (https://github.com/mozilla-mobile/fenix/pull/6651)

- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (https://github.com/mozilla-mobile/fenix/pull/6651)

In https://github.com/mozilla-mobile/fenix/issues/2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

- Removes TabAction

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 15: Introduce a HomeFragmentStore (https://github.com/mozilla-mobile/fenix/pull/6651)

- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 20: Remove the architecture module. (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 17:  Remove duplicate subscribeToTabCollections in BrowserFragment.kt (https://github.com/mozilla-mobile/fenix/pull/6651)

There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (https://github.com/mozilla-mobile/fenix/pull/6651)

- Renames SessionControlUIView to SessionControlView

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 21: Fix white screen on home fragment (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (https://github.com/mozilla-mobile/fenix/pull/6651)

This ensures that the metrics.track will be called immediately before the tab is removed from the collection.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 24: Use the sessionManager getter in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Removes running CI against the architecture debug build varient
2019-12-04 22:06:05 -05:00
mawen7
bbfa8aadd4 [fenix] Run lint for app module and set baseline 2019-12-02 14:45:34 -08:00
Sebastian Kaspari
a126b92f9c [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/6622, https://github.com/mozilla-mobile/fenix/issues/6688: Create a "fennecBeta" and "fennecNightly" build types. 2019-11-27 10:28:22 -08:00
Johan Lorenzo
8eef026200 [fenix] Split UI test 2019-11-21 11:59:51 +01:00
Jeff Boek
daaaeef741 [fenix] Adds custom search engines (https://github.com/mozilla-mobile/fenix/pull/6551)
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds button to add a new search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds custom engine store

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Creates a custom SearchEngineProvider

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Gives the ability to delete search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the UI to add a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds form to create a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to add a custom search engine

*  For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to delete custom search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Selects the first element on the add custom search engine screen

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Prevents adding a search engine that already exists

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Styles the add search engine preference

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Makes the name check case-insensitive

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fix bug where home screen doesnt see new search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Moves Search URL validation to its own type

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes linting errors

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to edit a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Allows the user to edit a serach engine even when it is the last item in the list

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds an undo snackbar when deleting a search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Moves all of the strings to be translated

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes bug when deleting your default search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Puts adding search engines behind a feature flag

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Navigate to custom search engine SUMO article when tapping learn more

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes nits

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Uses concept-fetch to validate search string

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds string resources for the cannot reach error state
2019-11-19 16:30:56 -08:00
Roger Yang
f8b8249b3f [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6440 Integrate Web Notifications Feature 2019-11-18 13:44:39 -05:00
Tiger Oakes
037d35abd1 [fenix] Use ViewModel for share fragment 2019-11-14 16:25:50 -08:00
Emily Kager
f279306478 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5074 - Sync Logins, Uses KeySharedPreferences for Passwords Encryption Key 2019-11-14 16:05:20 -08:00
Emily Kager
fc7084a555 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5547 - Add top level auth when accessing passwords 2019-11-07 13:45:41 -08:00
Jonathan Almeida
e5f9064701 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/373 - Integrate leanplum-fcm"
This reverts commit b1ce8ffcb7710fd98b692358309db42690593e11.

We're choosing to revert LeanPlum push messaging integration since we believe
that this has introduced a crash in Firebase push messaging. To verify
this assumption we're reverting this change, and when confirmed, we can
re-introduce Leamplum in a safer manner.

See https://github.com/mozilla-mobile/fenix/issues/6250 and https://github.com/mozilla-mobile/fenix/issues/6251 for related info.
2019-10-25 10:24:40 -04:00
Denys M
f69e53c92d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2441. Update LeakCanary to 2.0-beta-3 version. 2019-10-24 11:19:09 -07:00
ekager
36de82bdc6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
Alessio Placitelli
9d544a27e8 [fenix] Pick up forUnitTest library for the Glean SDK test 2019-10-24 08:57:30 -07:00
Grisha Kruglov
3e5c5d9514 [fenix] Perform Fennec data migration within fennecProduction 2019-10-22 16:04:08 -04:00
Mitchell Hentges
cf0265e3b1 [fenix] Removes versionName check from gradle (https://github.com/mozilla-mobile/fenix/pull/5934) 2019-10-21 10:03:21 -07:00
MozLando
cd489f765a [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5933
5933: Removes legacy nightly automation r=johanlorenzo a=mitchhentges



Co-authored-by: Mitchell Hentges <mhentges@mozilla.com>
2019-10-11 18:28:31 +00:00
MozLando
66e7638fb7 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5633
5633: Add fxa/sync integration tests r=csadilek a=isabelrios

 Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [-] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [-] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

This PR tries to add new tests, sync integration tests, to check the sync process Desktop<->Fenix, first for Bookmarks and in the future for more.

Co-authored-by: Isabel Rios <isabelrios@mackbookirios.home>
Co-authored-by: isabelrios <isabelrios@gmail.com>
2019-10-11 14:43:39 +00:00
Mitchell Hentges
4bd3882edb [fenix] Removes legacy nightly automation 2019-10-10 11:13:23 -07:00
Jeff Boek
d09494613a [fenix] For https://github.com/mozilla-mobile/fenix/issues/373 - Integrate leanplum-fcm 2019-10-09 14:43:48 -07:00
Isabel Rios
339524226a [fenix] Add fxa/sync integration tests
fixing Jenkins path to tests and clean tests

commenting future tests and adding doc with info about the tests
2019-10-08 09:56:29 +02:00
Grisha Kruglov
6e6d2ec9c6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1022: Auto-publication workflow for android-component
This patch enabled support for an auto-publication workflow for android-components.

It automates a common pattern seen in local development:

Old way:
- after every change in a-c, publish it locally with a unique version (bumping it manually)
- manually modify Fenix to consume a custom version of a-c from a mavenLocal repository

New way:
- set a flag in fenix's local.properties to enable auto-publication
- run Fenix builds after making changes to a-c. Changes in a-c will be automatically picked up.

Note that no changes are necessary to any Fenix files other than a single flag in local.properties.
Manually bumping android-components version is also not necessary.
2019-10-07 14:13:33 -07:00
Colin Lee
a925cc246d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5599: Remove dependency on fetch_httpurlconnection (https://github.com/mozilla-mobile/fenix/pull/5716)
* For https://github.com/mozilla-mobile/fenix/issues/5599: Remove dependency on fetch_httpurlconnection

* For https://github.com/mozilla-mobile/fenix/issues/5599: Switch Glean to GeckoViewFetchClient

* Use existing Gecko client for Glean
2019-10-04 12:28:23 -05:00
Alessio Placitelli
c43b478447 [fenix] Add the workmanager dependency to enable testing with Glean 2019-09-24 12:33:14 -07:00
Johan Lorenzo
081d9ee296 [fenix] taskgraph: Speed up gradle calls 2019-09-24 11:05:22 -07:00
Dennis Schubert
ebee89cc0f [fenix] No bug - Add WebCompat feature. 2019-09-20 08:33:48 -07:00
Sawyer Blatz
d95e439bab [fenix] Reverts https://github.com/mozilla-mobile/fenix/issues/1151: Removes unused Flipper library 2019-09-20 08:05:14 -07:00
Jonathan Almeida
8d8adae0f1 [fenix] No issue: Add Digital Asset Links token for TWAs 2019-09-18 20:19:47 -07:00
Alessio Placitelli
2edc73ed3f [fenix] Automatically generate metrics docs using the Glean SDK (https://github.com/mozilla-mobile/fenix/pull/5101) 2019-09-12 14:49:49 -07:00
Sebastian Kaspari
509d3c5e20 [fenix] Unbreak Nightly: Get rid of fragment-testing dependency and create fragments in test manually. 2019-09-12 13:44:17 +02:00
Aaron Train
036b3d239b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5217 - fix androidx.test dep error (https://github.com/mozilla-mobile/fenix/pull/5219)
See https://github.com/mozilla-mobile/fenix/issues/5217
2019-09-11 12:55:22 -04:00
Emily Kager
3b0a3c1643 [fenix] Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
mihai-adrian
40108e53c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4877: Restored logic for closing tabs when not on browserFragment
Added base test for CreateCollectionFragment that we can build upon later
2019-09-10 21:42:16 -07:00
Colin Lee
736fb7fd7c [fenix] For https://github.com/mozilla-mobile/fenix/issues/3106: Granular options for clearing user data 2019-09-09 12:32:28 -07:00
Sebastian Kaspari
1ad6f0ea20 [fenix] Add browser-state component. 2019-09-05 13:38:15 +02:00
Petru Lingurar
2f4392c064 [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/5067 - Refactor ShareController to use SendTabUseCases
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
2019-09-03 12:01:26 -07:00
Sebastian Kaspari
61c2a0878f [fenix] Issue https://github.com/mozilla-mobile/fenix/pull/4907: Link to usage of sharedUserId in Fennec code. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
720589cbb0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Use manifest placeholder to inject sharedUserId. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
9a01bb2639 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Use Fennec version code mechanism for fennecProduction build type. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
b4b87eb165 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Only build fennecProduction build types with GeckoView Beta. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
c91a28030f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Reuse Firefox application id for fennecProduction build type. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
7061d22246 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Introduce "fennecProduction" build type. 2019-09-03 17:10:06 +02:00
Tiger Oakes
e4abe9cace [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/773 - Add shortcuts to homescreen (https://github.com/mozilla-mobile/fenix/pull/4925) 2019-08-29 14:45:11 -05:00
Colin Lee
cdc611fec5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4885: D8 Build failure on attempt to execute UI test (https://github.com/mozilla-mobile/fenix/pull/4903)
* For https://github.com/mozilla-mobile/fenix/issues/4885: D8 Build failure on attempt to execute UI test

* Disabled screengrab tests until AndroidX fix is available
2019-08-23 13:37:52 -07:00
Sebastian Kaspari
456cfb5bfb [fenix] Use version name/code override. (https://github.com/mozilla-mobile/fenix/pull/4895) 2019-08-23 07:08:37 -05:00
Nick Alexander
dbb115a551 [fenix] Consume new substitute-local-geckoview.gradle script from Bug 1533465. 2019-08-21 19:52:01 +02:00
Mitchell Hentges
e7ca5257b4 [fenix] Configure either geckoview beta or nightly at compile-time (https://github.com/mozilla-mobile/fenix/pull/4851)
* Remove "abi" product flavor and introduce "engine" product flavor.

This patch will allow us to build Fenix against GeckoView Nightly and GeckoView Beta by
introducing a new flavor dimension: engine = [geckoNightly, geckoBeta].

In addition to that it adds a "fenix"  prefix to the nightly, beta and production flavors
to reduce the ambiguity between fenix beta/nightly and GeckoView beta/nightly.

For now the build types have the following engine variants enabled:

**debug**: geckoNightly, geckoBeta
Both variants enabled for local development and testing.

**forPerformanceTest**: geckoNightly, geckoBeta
Both variants enabled unless the perf team only cares about Nightly (tbd)

**fenixNightlyLegacy**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). This release type will eventualyl be decommissioned once we switch to a separate
Nightly app on Google Play.

**fenixNightly**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). Changing this build to use GeckoView Nightly is currently being discussed.

**fenixBeta**: geckoBeta
Fenix Beta uses GeckoView Beta.

**fenixProduction**
Fenix Production uses GeckoView Beta (69) currently.

* gradle.py/variant.py: Replace "abi" with "engine".

* Disable enableUnitTestBinaryResources until we can switch to Android Gradle plugin 3.5.

* Fenix nightly should use both geckoview nightly and beta

* Updates automation to use apk splitting and support different engine
2019-08-21 08:32:01 -07:00
Sebastian Kaspari
c30700580c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4719: Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. (https://github.com/mozilla-mobile/fenix/pull/4722) 2019-08-14 09:10:24 -05:00
Colin Lee
2de56210e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4709: Fix Bugzilla issue 1573549 (https://github.com/mozilla-mobile/fenix/pull/4710) 2019-08-13 22:16:23 -05:00
Colin Lee
9124321227 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4652: Crash "Can not perform this action after onSaveInstanceState" (https://github.com/mozilla-mobile/fenix/pull/4654) 2019-08-09 14:46:40 -05:00
Jonathan Almeida
d544526692 [fenix] No issue: Disable failing ActivationPingTest 2019-08-09 15:22:38 -04:00
Colin Lee
952926509c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4507 Enable codecov (https://github.com/mozilla-mobile/fenix/pull/4520) 2019-08-08 19:09:54 -05:00
Emily Kager
527b52ed71 [fenix] No issue: Update testing dependencies 2019-08-08 11:37:16 -07:00
Emily Kager
03e8f5b054 [fenix] No issue: Update testing dependencies and deprecated method (https://github.com/mozilla-mobile/fenix/pull/4608) 2019-08-08 09:03:39 -07:00
Colin Lee
32ec775443 [fenix] No issue: Add OSS licenses link to About page 2019-08-07 12:40:10 -07:00
Travis Long
4d977e253e [fenix] Integrate service-experiments component (https://github.com/mozilla-mobile/fenix/pull/4098) 2019-08-05 11:14:42 -05:00
Thom Chiovoloni
dc7b4f682d [fenix] Update fenix for new megazord setup 2019-08-01 13:10:20 -07:00
Sebastian Kaspari
a4add1765d [fenix] Switch to GeckoView 69 Beta. 2019-07-30 18:53:27 +02:00
Sawyer Blatz
6906cb0f52 [fenix] No issue: Add more useful test output to TaskCluster (https://github.com/mozilla-mobile/fenix/pull/4165) 2019-07-26 08:56:13 -07:00
Richard Pappalardo
1531d6d6ad [fenix] Add taskcluster job for UI tests (https://github.com/mozilla-mobile/fenix/pull/4088) 2019-07-26 08:08:01 -07:00
Colin Lee
526c077529 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4128: Migrate Bookmarks to LibState (https://github.com/mozilla-mobile/fenix/pull/4254) 2019-07-25 21:55:51 -05:00
Michael Droettboom
897427326e [fenix] 1567988: Reduce likelihood of invalid URL loading Glean build script 2019-07-23 11:21:19 +02:00
Tiger Oakes
9e87335875 [fenix] Update to use Mozilla Android Components 5.0.0 2019-07-19 16:41:38 -04:00
Sawyer Blatz
1f301464fb [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/2464: Remove Glide dependency (https://github.com/mozilla-mobile/fenix/pull/4169) 2019-07-19 11:06:49 -07:00
Jonathan Almeida
892014a83e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4075: Add Feature Flag class (https://github.com/mozilla-mobile/fenix/pull/4077) 2019-07-18 17:20:12 -07:00
Johan Lorenzo
78c5a74a4a [fenix] Use Raptor release now that GV release is used (https://github.com/mozilla-mobile/fenix/pull/4070) 2019-07-18 16:47:18 +02:00
Sebastian Kaspari
d7da01235a [fenix] Use Mozilla Android Components 4.0.0. 2019-07-16 18:35:35 +02:00
Jonathan Almeida
d973f3aaed [fenix] No issue: Enable send tab in nightly legacy 2019-07-16 08:54:45 -04:00
Jonathan Almeida
01457f8490 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3015: Add push support for send tab 2019-07-15 16:38:49 -04:00
Sebastian Kaspari
30f9fdfa86 [fenix] After mege day: Switch from GV 68 beta to GV 68 release. 2019-07-15 16:29:41 +02:00
Grisha Kruglov
8729a8cc7f [fenix] Update FxA integration to new APIs 2019-07-11 13:19:37 +02:00
Colin Lee
e34a537230 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2683. Update Gradle to 5.5 (https://github.com/mozilla-mobile/fenix/pull/3929)
* Closes https://github.com/mozilla-mobile/fenix/issues/2683. Update Gradle to `5.4.1`

* Upgrade to Gradle 5.5
2019-07-08 11:14:13 -05:00
kglazko
e8acfc56b4 [fenix] Adding l10n screenshot tests for Fenix (https://github.com/mozilla-mobile/fenix/pull/3562)
* Adding l10n screenshot tests for Fenix

* fixing comments

* fix klint and detekt error and adding all tests

* better test name and doc added explaining tests
2019-07-08 11:00:29 -05:00
Richard Pappalardo
623407a92f [fenix] Update HomeScreenTest (https://github.com/mozilla-mobile/fenix/pull/3882) 2019-07-05 10:38:09 -07:00
Mitchell Hentges
9da8449e36 [fenix] Re-enables pushing nightly to org.mozilla.fenix (https://github.com/mozilla-mobile/fenix/pull/3823)
* Re-enables pushing nightly to org.mozilla.fenix

* Publishes org.mozilla.fenix.nightly releases on internal track
2019-07-02 11:34:04 -07:00
Mitchell Hentges
3fa6a6e7e6 [fenix] Nightly package name should be "org.mozilla.fenix.nightly" (https://github.com/mozilla-mobile/fenix/pull/3771) 2019-06-28 18:56:55 -05:00
Tiger Oakes
066e2fc6ea [fenix] Use lifecycleScope for collections fragments 2019-06-25 13:56:15 -07:00
Denys M
658ad81d70 [fenix] Add unit tests for Settings.
Add unit tests for `Settings`.
2019-06-24 16:02:34 -07:00
Tiger Oakes
515bb630e4 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/3539 - vectordrawablecompat for gradients (https://github.com/mozilla-mobile/fenix/pull/3541) 2019-06-18 16:38:56 -07:00
Grisha Kruglov
717d7f0424 [fenix] Disable send tab for non-nightly, non-debug builds (https://github.com/mozilla-mobile/fenix/pull/3542)
* Put deviceCapabilities list behind a SEND_TAB_ENABLED flag

* Disable SEND_TAB for non-debug, non-nightly builds
2019-06-18 16:37:50 -07:00
Colin Lee
8974d4a2e8 [fenix] For i18n testing: Enable pseudolocales (https://github.com/mozilla-mobile/fenix/pull/3391) 2019-06-14 13:44:36 -05:00
Johan Lorenzo
e7639388da [fenix] Let raptor use the geckoview builds 2019-06-14 14:59:42 +02:00
Jonathan Almeida
20fb449129 [fenix] No issue: Enable send tab for all builds 2019-06-11 18:02:39 -04:00
Thom Chiovoloni
84feb0bb79 [fenix] Don't substitute application-services packages which are not part of the megazord 2019-06-10 15:24:27 -07:00
Denys M
07b92e9295 [fenix] Use Drawable.toBitmap() from androidx-ktx. (https://github.com/mozilla-mobile/fenix/pull/3286) 2019-06-10 08:50:37 -04:00
Emily Kager
5dfb499b11 [fenix] No issue: Update dependencies 2019-06-05 16:30:01 -07:00
Mitchell Hentges
e3fe12a9f6 [fenix] Adds IDE documentation for gradle versionName error 2019-06-05 15:15:03 -04:00
Sebastian Kaspari
f8e47d7aab [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/2381: Add feature-media component and enable notification for recording devices. 2019-06-05 20:20:44 +02:00
Colin Lee
35ae44ced7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3129: Add a production build type to Fenix (https://github.com/mozilla-mobile/fenix/pull/3149) 2019-06-05 10:48:10 -05:00
Tiger Oakes
b297d8c4b8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3091 - Hide Pull to Refresh under flag (https://github.com/mozilla-mobile/fenix/pull/3092)
This was merged in after feature freeze so we're pulling it out for
now. Pull to refresh will continue to work in debug mode so that the
design can be iterated on easily.
2019-06-03 14:10:53 -05:00
Mitchell Hentges
4e17c26bed [fenix] Migrates "raptor" build type to work for chrome-perf-testing, too (https://github.com/mozilla-mobile/fenix/pull/2926) 2019-06-03 16:32:38 +02:00
James Hugman
ce4a686423 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1570 - Enable app-links feature 2019-05-31 10:39:47 -07:00
Colin Lee
94a94edca6 [fenix] Update flipper to make LeakCanary traces appear (https://github.com/mozilla-mobile/fenix/pull/2971) 2019-05-29 11:17:56 -05:00
Stefan Arentz
264f522b37 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/445 - Ship Fenix x86_64 builds (https://github.com/mozilla-mobile/fenix/pull/2856) 2019-05-29 09:19:17 -04:00
Mitchell Hentges
b8e5d35f19 [fenix] Passes variants without parsing (https://github.com/mozilla-mobile/fenix/pull/2408) 2019-05-27 15:00:44 +02:00
Emily Kager
346f0f5538 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2780 - Fix home screen attributes for API 21-22 (https://github.com/mozilla-mobile/fenix/pull/2844) 2019-05-24 14:03:59 -07:00
Jonathan Almeida
07f5b8b763 [fenix] Adds send tab functionality to UI (https://github.com/mozilla-mobile/fenix/pull/2790)
* Closes https://github.com/mozilla-mobile/fenix/issues/2782: Hide send tab when no devices available

* For https://github.com/mozilla-mobile/fenix/issues/2752: Enabled send tab for debug and nightly builds

* For https://github.com/mozilla-mobile/fenix/issues/2753: Add Send Tab functionality to UI
2019-05-23 18:38:03 -04:00
Jonathan Almeida
fb1ef670ba [fenix] Add custom share sheet and send tab support (https://github.com/mozilla-mobile/fenix/pull/2757)
* Closes https://github.com/mozilla-mobile/fenix/issues/2751: Add custom app share sheet

* Closes https://github.com/mozilla-mobile/fenix/issues/2753: Add send tab devices to share sheet

* Closes https://github.com/mozilla-mobile/fenix/issues/2752: Add build flag for send tab

* Replace Context.share with ShareFragment
2019-05-23 10:48:22 -07:00
Ryan Kelly
36686f3fd8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2555: Remove appservices gradle plugin, perform megazord substitution by hand. 2019-05-23 08:23:17 -07:00
Sebastian Kaspari
f1e94d09ea [fenix] Switch to browser-engine-gecko-beta (GeckoView 68.0). 2019-05-22 11:14:02 -07:00
Sawyer Blatz
f842693457 [fenix] No issue: Removes usage of COLLECTIONS_ENABLED flag 2019-05-21 10:34:30 -07:00
Sebastian Kaspari
72411cc622 [fenix] Remove feature-session-bundling component. 2019-05-16 22:23:23 -07:00
Sawyer Blatz
848fbe390c [fenix] For https://github.com/mozilla-mobile/fenix/issues/2205 & https://github.com/mozilla-mobile/fenix/issues/1578: Integrates tab collection storage (https://github.com/mozilla-mobile/fenix/pull/2478)
* For https://github.com/mozilla-mobile/fenix/issues/2205: Adds TabCollectionStorage

* For https://github.com/mozilla-mobile/fenix/issues/1578: Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
Colin Lee
ec9aae6358 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1994: Re-architect state handling code (https://github.com/mozilla-mobile/fenix/pull/2382) 2019-05-09 23:06:12 +00:00
Jeff Boek
018b182c7e [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1735 - adds the ability to write code against the build channel (https://github.com/mozilla-mobile/fenix/pull/2388) 2019-05-09 22:05:49 +00:00
Emily Kager
bb7e9e734c [fenix] No issue: Update constraintlayout and androidx dependencies (https://github.com/mozilla-mobile/fenix/pull/2396) 2019-05-09 16:19:44 -05:00
Colin Lee
0f756b8f1b [fenix] Fix build breakage over FragmentScenario integration 2019-05-08 10:27:24 -05:00
Colin Lee
28ee8089fd [fenix] For https://github.com/mozilla-mobile/fenix/issues/1710: Create scaffolding for Robolectric tests (https://github.com/mozilla-mobile/fenix/pull/2282) 2019-05-07 16:36:37 -05:00
Mitchell Hentges
9a50f00054 [fenix] Updates Fenix taskcluster tasks to support beta release (https://github.com/mozilla-mobile/fenix/pull/1893)
* Updates Fenix taskcluster tasks to support beta release

* Throw error if -PversionName isn't set for release builds

* Uses beta secrets for beta

* Improves nightly and beta treeherder symbols
2019-05-06 19:09:29 +02:00
Christian Sadilek
479a452f4a [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/910: Integrate feature-readerview component (https://github.com/mozilla-mobile/fenix/pull/2269)
Closes https://github.com/mozilla-mobile/fenix/issues/908, Closes https://github.com/mozilla-mobile/fenix/issues/910, Closes https://github.com/mozilla-mobile/fenix/issues/911, Closes https://github.com/mozilla-mobile/fenix/issues/912

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
2019-05-03 21:01:45 +00:00
Alessio Placitelli
d353bf344f [fenix] Generate the activation ping and send it with Glean (https://github.com/mozilla-mobile/fenix/pull/1707)
This fetches the Google Advertising ID, salts it and
then applies hashing before sending a ping with it,
at startup. Hashing and salting are used in order
to prevent ourselves to correlate advertising IDs
from the same user running different products we
own off a single device. We will never send the
client_id and the Google Advertising ID in the same
ping.
2019-05-03 09:40:21 -05:00
Mitchell Hentges
e70c6be55f [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/1566, https://github.com/mozilla-mobile/fenix/issues/2076 (https://github.com/mozilla-mobile/fenix/pull/2194) 2019-05-02 14:08:31 +00:00
Emily Kager
74eca9060e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2000 - Don't flash LeakCanary setting in release builds (https://github.com/mozilla-mobile/fenix/pull/2006) 2019-04-25 07:42:00 -07:00
Johan Lorenzo
0b895fb3c8 [fenix] Enable raptor tests on Fenix 2019-04-24 09:35:23 -04:00
Grisha Kruglov
95b60a0495 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1902: Remove direct appservices dependencies
Our main dependency - android-components - is tightly integrated
against a certain version of appservices. Having a direct dependency
at the Fenix level is a foot-gun: it allows Fenix to consume an API-incompatible
version of appservices, breaking parts of android-components. Due to
how gradle dependency resolution works, this breakage is "silent": there are
no compile time warnings. A recent example of this is broken history sync,
and buggy FxA experience in Fenix.

This patch removes a direct dependency, letting android-components dictate
which appservices version should be used Fenix builds.
2019-04-23 17:41:07 -05:00
Mitchell Hentges
d2ea8148c8 [fenix] Moves release flavour to build type (https://github.com/mozilla-mobile/fenix/pull/1693) 2019-04-22 11:02:39 -07:00
Jeff Boek
ed156888ab [fenix] Merge pull request https://github.com/mozilla-mobile/fenix/pull/1842 from boek/i1840-collections_featureflag
For https://github.com/mozilla-mobile/fenix/issues/1840 - Adds a save tab group button and puts it behind a feature  flag
2019-04-20 14:15:18 -07:00
Colin Lee
b98ca450d4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/113: QR Scan 2019-04-19 14:47:53 -07:00
Kevin Brosnan
3f181f63c9 [fenix] UI tests for the home screen 2019-04-16 13:38:06 -07:00
Colin Lee
3d4bb4b1c8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1139: Cold start has Dispatchers.Main 1/5th second delay 2019-04-11 14:24:18 -05:00
Colin Lee
c7b4a69ee7 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1312, https://github.com/mozilla-mobile/fenix/issues/1236, https://github.com/mozilla-mobile/fenix/issues/1237, https://github.com/mozilla-mobile/fenix/issues/1238, https://github.com/mozilla-mobile/fenix/issues/1239: Creating, Editing, and Deleting Bookmarks and Bookmark Folders 2019-04-08 14:48:36 -05:00