ae62eb26cb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24528 - Remove isPrivate conditional in getTheme in favor of inComposePreview
2 years ago
9e08ecfb89
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25764 - Prevent sponsored shortcut URLs from appearing as `frecent` shortcuts
2 years ago
0c972d3ae9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25401 - Record Pocket sponsored stories telemetry
2 years ago
82003c9071
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25401 - Improve how sponsored stories impressions are reported
...
While testing I observed that the Rect returned from `boundsInWindow()`
- will have the full height and width of the composable even if scrolled
offscreen vertically
- will only have the height and width of what part of the composable is shown
pn the screen.
Possibly because of the interactions of a vertically scrollable RecyclerView
and the LazyRow the composable is shown in.
To account for this the method calculating how much of the composable is shown
on screen will also now receive the real composable size as an argument.
2 years ago
374ce89abb
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/25545 : wait to draw Pocket until after first frame
2 years ago
32d204199c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25750 - Use Headline7 for the expandable list headers that appear in cards
2 years ago
0e5c90103c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23966 - Migrate MessageCardViewHolder to Compose
2 years ago
7cb57f1b9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25446 : Ensure for every message shown we have recordExposure
2 years ago
505fe654c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25490 - Remove PrimaryText and SecondaryText
2 years ago
b762e8dcdd
[fenix] Upgrade to Glean v50 and adopt new Glean APIs
2 years ago
8b7799a3fe
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/pull/24455 - Migrate NoCollectionsMessageViewHolder to Compose"
...
This reverts commit eb9d1a88
2 years ago
bf758fac0b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25437 : Fix label values for labeled counters.
2 years ago
e175c84def
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/25386 : turn task continuity on by default for nightly
2 years ago
ac6ba404c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25352 - Add a new FML feature to gate Pocket sponsored stories
2 years ago
300de19e05
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25281 - Improve stories impressions recording.
...
This fixes the following two scenarios resulting in improper recordings:
- sponsored stories were recorded as shown as part of the impressions recording
for all the stories (both recommended and sponsored). Separated the two.
- sponsored stories were not recorded as shown if the user doesn't scroll.
This could happen if just toggling categories which would result in a new list
of stories to show. Will recheck after the time to settle if the composable is
shown.
2 years ago
5f946b6b22
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25281 - Consider the toolbar when reporting stories visibility
...
The toolbar may appear over the Pocket stories causing our functionality for
reporting when a specific story is visible to misreport.
At the moment hardcoding the toolbar height in the visibility checks seems like
the best solution to ensure reliable data.
2 years ago
ce4bf5a766
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25281 - Allow the Pocket section to settle before reporting impressions
...
Currently just a hack that will ensure more reliable data.
This will have to be re-evaluated after the homescreen is migrated to compose.
2 years ago
364842f946
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25281 - Pace and rotate sponsored stories
...
A new way to be able to reliably record actual impressions of sponsored stories
was needed and based on this data we can ensure we are promoting fresh stories
(with fewer impressions) or the ones with a higher priority.
2 years ago
796da01ae6
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/23966 - Migrate MessageCardViewHolder to Compose"
...
This reverts commit b9e0a18233c0d30efd5f058eb3b7d24188ac5353.
2 years ago
4c02271ae0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Old imports cleanup.
...
Importing `R.string` does allow to avoid the `R` when using a String from
Resources but seems like a small gain to break app consistency.
2 years ago
0bfec6d6c7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Show sponsored stories on debug only
...
The design asks for a new row in between the primary and the secondary text so
I went with making "ListItemTabSurface" public allowing for customizing the
content it will show but keeping the same layout and general UX.
2 years ago
d5902b7a02
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Rename PocketStoriesChange to PocketStoriesClean
...
PocketStoriesChange was called only once - to clean the shown stories when the
user gets to the homescreen and the Pocket feature is disabled - useful for the
situations in which the user returns after disabling the feature in settings.
Populating the store with recommended stories to show was already happening
based on 'PocketStoriesCategoriesChange' and sponsored stories will be added by
using 'PocketSponsoredStoriesChange' so renaming 'PocketStoriesChange' will
help on reducing any confusion in the future.
Also added documentation for all Pocket related actions from AppStore and
removed the 'UndocumentedPublicClass' detekt suppressions.
2 years ago
67cc604dab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Download sponsored stories on debug only
2 years ago
f28fbf3240
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Use the `PocketStory` supertype
...
This prepares extending support from just `PocketRecommendedStory` to
`PocketSponsoredStory` also.
2 years ago
15677b59b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Hardcode showing at max 8 Pocket stories
...
The default was already 8. This is now being moved closer to the source from
where the stories to be shown are emitted.
With the addition of sponsored stories at fixed positions having to support a
variable number of stories being returned from AppState#getFilteredStories
means increased complexity with no benefit.
2 years ago
633377e903
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23966 - Migrate MessageCardViewHolder to Compose
2 years ago
7804a4ec12
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23670 - Update collection on tab removal
2 years ago
b04e075f51
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24991 - Refactor the HomeMenu creation from HomeFragment to HomeMenuBuilder
2 years ago
e62e502664
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25119 - Add Secondary, Tertiary and Destructive Button composable components
2 years ago
4c967a37ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25264 - Refactor toShortUrl extension function from TabSessionState to String
2 years ago
7d02d4cbf2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24316 - Migrate TabInCollectionViewHolder to Compose
2 years ago
e2aecb47b5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25176 - Refactor TabTitle and TabSubtitle
2 years ago
d31e8ae93d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24660 - Overrided contentsSameAs inside TabInCollectionItem class.
2 years ago
994fdaec0f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25145 : Unify behavior for opening systems setting for updating the default browser preference
2 years ago
7185eee3df
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24333 - Replace the xml based CollectionViewHolder with a composable
2 years ago
d92adcff12
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24333 - Move CollectionViewHolder to home/collections
...
Doing just a file move in a separate commit will ensure git history of the file
is kept when this will be later updated.
2 years ago
d2fa53ff1d
[fenix] For https://github.com/mozilla-mobile/fenix/pull/24455 - Migrate NoCollectionsMessageViewHolder to Compose
2 years ago
e78350b2ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24262 - Filter Amazon/eBay sponsored tiles when the respective search engine is set
2 years ago
d9f110ee24
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25115 - Remove showWallpapers feature flag
2 years ago
0138e26cfe
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24665 : show recent synced tab faster
2 years ago
969a5f0b0b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21292 : Remove unused MetricController parameters.
2 years ago
4e59514ef8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25044 - Remove the broken code for focusing the newly created collection
...
This functionality seems broken for a long time now.
It's importance and whether to reimplement it is to be re-assessed in
https://github.com/mozilla-mobile/fenix/issues/24389
2 years ago
3bc3ca9610
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24929 : remove locale restriction for remote firefox wallpapers
2 years ago
b495c724d9
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24665 : cache previous auth status and display placeholders accordingly
2 years ago
ae0542a0b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24836 - Remove Event.wrapper for RecentlyVisitedHomepage telemetry
2 years ago
1e918950c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24811 - Remove Event.wrapper for Messaging telemetry
2 years ago
e604e555c5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24841 : Remove unused events.
2 years ago
40d83423c8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24790 - Remove Event.wrapper for home screen related telemetry
2 years ago
81572369e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24809 - Remove Event.wrapper for RecentSearches telemetry
2 years ago
b5cb951ea4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24786 - Remove Event.wrapper for SearchTerms telemetry
2 years ago
ce2c88512e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24710 - Remove Event.wrapper for RecentBookmarks telemetry
2 years ago
fcd939e9a9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24711 : Remove wrapper from recent tabs metrics.
2 years ago
ca3242ee58
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24747 - Remove unused store property in SessionControlAdapter and SessionControlView
2 years ago
37f60284d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24211 : Remove wrapper from search related metrics.
...
Removes wrapper from search labeled counter and performed search event.
2 years ago
66ffdbdeed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24701 - Remove Event.wrapper for Pocket related telemetry
2 years ago
759fd90263
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24709 - Remove Event.wrapper for Wallpapers telemetry
2 years ago
52df5cd2f4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24596 - Only restore Pocket categories selections once
...
This fixes a regression from migrating from HomeStore to Appstore but
indirectly by ensuring that previous categories selections are only restored
once, not everytime user selects a new category and that change is persisted.
2 years ago
795f47ca2f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24642 - Remove Event.wrapper for TopSites metrics
2 years ago
439f25ddeb
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24549 : add telemetry for recent synced tab
2 years ago
44a432a9e8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24498 - Remove Event.wrapper for History metrics
2 years ago
690b04b572
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24177 : sync tabs when home is shown
2 years ago
8f093767a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from whats new tapped event.
2 years ago
cf9b6193ce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from "default browser" events.
2 years ago
d5016f5e9b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from "url entered" event.
2 years ago
b2935a866a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from "search bar tapped" event.
2 years ago
30e7c067ce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24576 - Record delete collection metric
2 years ago
1c34e0d4ef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24099 - Remove Event.wrapper for Collections telemetry
2 years ago
5602bfb92a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23971 - Migrate CollectionHeaderViewHolder to Compose
...
fix ktlint
2 years ago
f57be9751a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24147 - Remove Event.wrapper for Search widget telemetry
2 years ago
08931906b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24519 - Add Private theme to FirefoxTheme
2 years ago
7f73bfcd90
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24319 - Migrate PrivateBrowsingDescriptionViewHolder to Compose
2 years ago
8106fb3d15
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24203 - Remove Event.wrapper for Onboarding telemetry
2 years ago
55baf8333b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23968 - Migrate homescreen recent tabs to compose
...
For https://github.com/mozilla-mobile/fenix/issues/23968 - Migrate homescreen recent tabs to compose
2 years ago
2cfa2e92cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23969 - Migrate homescreen recent bookmarks to compose
2 years ago
2040233814
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23970 - Migrate homescreen recent visits header to compose
2 years ago
602887e5b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23046 - Align detekt config between Fenix and Android Components
...
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2 years ago
c77cf53ae5
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/24442 : refactor recent tabs to use common composables
2 years ago
09d6b80724
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24224 : Send telemetry events related to the messaging framework
2 years ago
70014e589a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24220 and https://github.com/mozilla-mobile/fenix/issues/24223 : Connect GleanPlumb messages with the new tab ui card.
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
2 years ago
dbdc477aba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Dispatch the current mode when the HomeFragment is created
2 years ago
ec1d6dfc7d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Check feature settings to show and hide home screen sections
2 years ago
269dc65be3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Refactor initial HomeFragmentState into AppState
2 years ago
fa71851b96
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Refactor HomeFragmentStore parameters to AppStore
2 years ago
18158aef72
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Refactor HomeFragmentState into AppState
2 years ago
33772a15aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24342 - Actually log when Pocket stories are shown
...
Based on this we'll send telemetry and rotate the stories shown to prioritize
fresh ones instead of the ones already shown.
2 years ago
da6d15fc81
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24177 : add ui wireframe for synced recent tab
2 years ago
13af68853e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24235 - Remove Tip from HomeFragmentStore
2 years ago
082705a3c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24235 - Remove MasterPasswordTipProvider
2 years ago
130fd3ec5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24252 - Rename destructive attribute to textWarning
2 years ago
0d21bd04e2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24252 - Rename above attribute to layer2
2 years ago
53dc0a74c4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24252 - Rename primaryText attribute to textPrimary
2 years ago
63d7796407
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24246 - Refactor Tab from HomeFragmentStore
2 years ago
86ab03ac93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24130 - Change Shortcuts setting to toggle the display of Top Sites
2 years ago
f55e88ce94
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22189 - Replace app name with 'Firefox' for Sync strings
2 years ago
a0f48f5533
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23893 - Add telemetry for Contile services
2 years ago
b0750c2980
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24069 - Use the correct design tokens for Powered by Pocket text
2 years ago
fe8cc1c410
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24051 - Remove showStartOnHomeSettings feature flag
2 years ago
0745934bdf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22189 : Replace placeholder with app name.
2 years ago
6a0128aafb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24006 - Return a null change payload if the new top sites list is larger than the old
2 years ago
87ee51d9fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24017 - Replace @color/foundation_private_theme with @color/fx_mobile_private_layer_color_1
2 years ago
910d13bbd1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23821 - Add telemtry for RecentlyVisted Homepage ( https://github.com/mozilla-mobile/fenix/pull/23909 )
...
Add test
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ryan VanderMeulen <rvandermeulen@mozilla.com>
2 years ago
64fefc222e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23905 - Update onboarding icons to use Icon Active color
2 years ago
ce058f1abf
[fenix] for https://github.com/mozilla-mobile/fenix/issues/23069 : add blocklist middleware for home
2 years ago
fc08df845f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22189 - Replace the 'Firefox' word in all strings with placeholder
2 years ago
1971f8984c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23551 - Change the spacing between Pocket header and content to 16dp
2 years ago
c9370ed807
[fenix] No issue: Renew/remove metrics set to expire in April 2022 ( https://github.com/mozilla-mobile/fenix/pull/23786 )
2 years ago
4c40cd09be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23456 ⁃ Use lifecycleScope in TopSiteItemViewHolder
2 years ago
bb85952d10
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22722 - Reacting to the crashed flag
...
Whenever the ".crashed" property of the currently displayed
TabSessionState -> EngineState is true we will show an in-app crash reporter
with the usual close tab / restore tab options and also the option to report
all current non-fatal crashes to Mozilla if the setting for sending the crash
reports is enabled in app settings.
This closely mimics the previous crash reporter UI but there might be some
subtle differences stemming from migrating to using a ComposeView.
Whenever the ".crashed" property of the currently displayed
TabSessionState -> EngineState is false we will set the in-app crash reporter
to have a View.GONE visibility effectively removing it from the layout.
The functionality for receiving the non-fatal crashes from the AC CrashReporter
through an Intent is still kept and these crashes will be persisted in memory
until the user closes / restores a tab and so also makes a decision about
sending or not these crashes.
Currently more tabs can crash following just one since more share the same
process and as such there is no way to differentiate between them or link a
certain Crash to a certain tab.
They will all be acted upon at once from any tab the user chooses to close or
restore.
2 years ago
bee88db440
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20634 remove some lint issues from baseline
2 years ago
19a695ec15
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23431 - Display the order of Contile Top Sites correctly
2 years ago
795683c6ef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21854 - Split the big ComposeView in 3 smaller ones
...
This would shorten the time needed to layout all Pocket recommended stories
content in one go, though it may lead to shorten hiccups over a bigger period
of time.
2 years ago
5458565097
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23526 - Add telemetry for Contile interactions
2 years ago
0541ba4fd9
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/23492 : Perf regression of calling isFirefoxDefault from main thread ( https://github.com/mozilla-mobile/fenix/pull/23556 )
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/23492 — Fixup perf regression of calling isFirefoxDefault from the main thread
* Tightening of near defunct default browser message
* Fixup early crash in debug build
* ktlint
2 years ago
fb462409a8
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/23540 : scale wallpaper and translate to bottom of image
2 years ago
ab9bc7c071
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23596 and https://github.com/mozilla-mobile/fenix/issues/23309 - Add deeplink to wallpaper settings
2 years ago
895b6396ba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23575 - Use design system colors for the Pocket filter and Customize homepage buttons
2 years ago
518eac14cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23558 - Update menu copy for What's new and Customize homepage
2 years ago
1931e5dd64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23498 add content description for wallpapers
2 years ago
98a540b81d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23350 - Revert changes from removing duplicate icons that already exists in ui-icons ( https://github.com/mozilla-mobile/fenix/pull/23527 )
...
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Override @color/mozac_ui_icons_fill with ?primaryText attribute"
This reverts commit 4c630eba96182254daa4cdd2bbfeac23ab04690d.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_share with @drawable/mozac_ic_share"
This reverts commit 072d3a3c9f87b77ed6381c36af7d9c812b8b371d.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_storage_enabled with @drawable/mozac_ic_storage"
This reverts commit 10dde2baa6fd320443690a49dd6551938a2d83db.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_notifications_enabled with @drawable/mozac_ic_notification"
This reverts commit 90943cfda427fd06d5e77b1e4fd0463bbe21e449.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_microphone_enabled with @drawable/mozac_ic_microphone"
This reverts commit 200fd14d288b4b21c1711995f63d548f58fb1dc8.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_location_enabled with @drawable/mozac_ic_location"
This reverts commit e85998bdc24dcdd17585581bd99aab35d5147f93.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_autoplay_disabled with @drawable/mozac_ic_autoplay_blocked"
This reverts commit 0e408dc26e069719c895ae5279d3c11df6677699.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_camera_enabled with @drawable/mozac_ic_video"
This reverts commit ceab2d77490b9b9b545ebbc14ee2a7b3811d3064.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/mozac_ic_extensions_black with @drawable/mozac_ic_extensions"
This reverts commit 7bc005927acee0481c8936d000737ba7f738e2ba.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_top_sites with @drawable/mozac_ic_pin"
This reverts commit f4d58ff722baa5dc9f7f811a758de75699bb8ccb.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_search with @drawable/mozac_ic_search"
This reverts commit ac8f8632557ac07c32d040fbb0ddfa3cf1a0e5f6.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_readermode with @drawable/mozac_ic_reader_mode"
This reverts commit d1953045b062a5b6fbedd990252834e9e1a6ca4f.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_menu with @drawable/mozac_ic_menu"
This reverts commit 682b02101aa7e5ce82868de81d9b034701629976.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_login with @drawable/mozac_ic_login"
This reverts commit 982c695260aaa10fc1f0ee7e6d2e271e9a214ce3.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_internet with @drawable/mozac_ic_globe"
This reverts commit d248bfc21fff644bdc2141c4e24ae5bc125a41d2.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_download with @drawable/mozac_ic_download"
This reverts commit 4cdceb393ac411a7b59d9c0e1164fddfb62bc494.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_lock with @drawable/mozac_ic_lock"
This reverts commit 3878a83e30f318293b099bc49c690f953c2f3def.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_desktop with @drawable/mozac_ic_device_desktop"
This reverts commit 8c4e6e23e0bf1ed762d9c3ab8566aff4df0a8eb1.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_close with @drawable/mozac_ic_close"
This reverts commit 7f61c95923600eeabb8046380a31c1eaa4968525.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_delete with @drawable/mozac_ic_delete"
This reverts commit b8814f62bffde0c192f078f8cd5e808d0f07af9d.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_chevron_up with @drawable/mozac_ic_arrowhead_up"
This reverts commit 265b0a47cae6bed39ce9e8cc9af465705d1a2363.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_chevron_down with @drawable/mozac_ic_arrowhead_down"
This reverts commit fe8a0b604941bbbb9dacff176cd17ce0485431ed.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_back_button with @drawable/mozac_ic_back"
This reverts commit fb236b1c6175c1f8b5e6b1bf6d9f02c6a7fff9b9.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_arrowhead_right with @drawable/mozac_ic_arrowhead_right"
This reverts commit ae2f768ac02aa6b161b0bcbba7922f5f12e31e80.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_new with @drawable/mozac_ic_new"
This reverts commit ce5bb35a7cdbd189bb177900ec19bc6cb5a9bfa7.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_addons_extensions with @drawable/mozac_ic_extensions"
This reverts commit 1006637673965ebf70ad5e18e9a3598cf736347b.
2 years ago
7dcf99911f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23433 - Align the provided top sites to the design spec
2 years ago
17f96e433c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23424 - Part 2: Add context menu for contile top sites
2 years ago
2533bf1431
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23424 - Part 1: Refactor TopSiteItemMenu into its own file
2 years ago
3f96c59777
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23450 - Rename design token Border Default to Border Primary
2 years ago
9b651a484b
[fenix] First use of Nimbus FML plugin ( https://github.com/mozilla-mobile/fenix/pull/23400 )
...
* Consume Nimbus FML plugin
* Convert Homescreen to use FML
* Convert nimbusValidation to use FML
* Convert legacy experiments to use the feature API and FML
Remove dead helper code and documentation
* Fixup failing test
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
60d9bcec18
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23432 - Use the imageUrl as the favicon for a provided top site
2 years ago
9de688d1c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22851 Add logo animation for wallpapers
2 years ago
07bc214d56
[fenix] replace WallpaperFeatureDiscovered probe with WallpaperSettingsOpened
2 years ago
00cc662e9f
[fenix] add events based on feedback
2 years ago
880c34528d
[fenix] update based on PR feedback and data review
2 years ago
c599f29c47
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/23381 : add telemetry for wallpapers feature
2 years ago
239716b632
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23409 - Specify fetchProvidedTopSites parameter for TopSitesConfig
2 years ago
29a2f15a29
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/23404 : add switch to wallpaper settings to disable tap-to-change
2 years ago
c04363f337
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22851 : Load wallpapers dynamically from the assets directory.
2 years ago
246758315b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_download with @drawable/mozac_ic_download
2 years ago
5a66fd7824
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_desktop with @drawable/mozac_ic_device_desktop
2 years ago
d9bec9ba36
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_close with @drawable/mozac_ic_close
2 years ago
17c7edb7ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_delete with @drawable/mozac_ic_delete
2 years ago
92992cbb64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_addons_extensions with @drawable/mozac_ic_extensions
2 years ago
94e5e66315
[fenix] Set a minimum number of sites a search group should contain.
2 years ago
235c026c38
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22727 - Add Contile to Top Sites
2 years ago
5a86929bf5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23138 - Close recently visited menu on orientation change
2 years ago
f9ca1a4e44
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/22851 : Add logo animation for wallpapers."
...
This reverts commit ad433967
2 years ago
6e0dfd9b8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22851 : Add logo animation for wallpapers.
2 years ago
dc560358e8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23144 Address regression in COLD start
2 years ago
e297e494c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22383 : Propagate ViewTreeLifecycleOwner to composable view holders.
2 years ago
1d3e76f885
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23086 - Update Border Divider to Border Default
3 years ago
7ef7a37e24
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23076 - Clean up unneeded FeatureFlags
3 years ago
9bb5e0a621
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22754 : Customize home button should work on fresh install
3 years ago
c367072d11
[fenix] Refactor History types to eliminate nullability
...
This introduces a separate HistoryDB type at the PagedHistoryProvider
layer, that doesn't need to deal with positions. Positioning logic in
HistoryDataSource becomes a type conversion between the new type and an
existing History type that UI and ItemKeyedDataSource API is written against.
With this refactor, we entirely eliminate nullability from these types.
3 years ago
9e15247269
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22931 Only enable wallpapers on normal mode
3 years ago
5143063813
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22851 toggle wallpapers when tap on the Firefox logo
3 years ago
de1e52a234
[fenix] Add default topsite MeiTuan for MozillaOnline builds
3 years ago
1c898c756c
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/22889 : add bottom spacer to onboarding adapter
3 years ago
0244f2156f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22508 - Increase menu height to avoid it become scrollable
...
Compose enforces a DropdownMenuItem having at least a 64dp height
(48 dp height + 8dp vertical padding) so we need to ensure the parent
doesn't hardcode a smaller height.
3 years ago
4cd7064540
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22450 : Replace quit icon with AC one.
3 years ago
803549e11f
[fenix] Modify strings for Privacy notice for MozillaOnline builds
3 years ago
817760d64c
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/20833 : move home recycler bottom margin into standalone item
3 years ago
a9a26965ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22836 - Replace primary_text_private_theme with fx_mobile_private_text_color_primary color token
3 years ago
e0d4f0b496
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22793 - Rename fx_mobile_icon_color_notice color token to fx_mobile_icon_color_information
3 years ago
bc4f92afd1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22445 - Improve the scrolling behavior for Recently visited
...
One important issue was that the items are smaller that the width of the
screen and so a bit of the next column would be showing also and user could
interact with this only peaking items and a long press would open a dropdown
menu with no place to anchor it.
To mitigate this:
- the items will now snap to the next position when scrolling so that we'll
always show at least one column in it's entirety.
- menus are enabled only if more than half of the item is visible effectively
disabling clicks on that peaking area of neighbour columns.
This patch also updates the divider for history groups which previously wasn't
showing.
3 years ago
e7f3dd478a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22701 - Replace whats_new_notification_color with fx_mobile_icon_color_notice color token
3 years ago
175a230b50
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22637 - Add new color tokens provided by the mobile styles to FirefoxTheme
3 years ago
33e5a1ee35
[fenix] Refactor: Move historymetadata classes in separate package
3 years ago
9534fa2356
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20701 : Dismiss keyboard when scrolling home screen
3 years ago
7b54536a7e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22592 - Refactor hideOnboardingIfNeeded() calls when the home menu items are tapped
3 years ago
f70dfb6ef9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22534 - Show history highlights and groups in "Recently visited" ( https://github.com/mozilla-mobile/fenix/pull/22535 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Update homescreen section name to "Recently visited"
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Show both history highlights and groups in Recently visited
For now the metadata groups don't support scoring so as an interim solution we
will show up to 9 items, evenly distributes, first favoring groups sorted by
date then history highlights pre-sorted by default.
Tapping a history highlight will switch to it's already open tab if available
or create a new one in which to load it if needed.
A "Remove" option will also be available for history highlights to remove it
from the screen and also from history.
Currently removing a group / highlight will not query new ones to again show up
to 9 items, this will be implemented separately.
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Rename and refactor historymetadata to recentvisits
The updated feature supports more than history metadata so updating the overall
naming scheme seems needed.
To signal that this is a homescreen feature the entire package is moved to home
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Update UI tests to account for the new items space on the screen
Saw failures about not finding the collection section on screen.
This is probably happening because w are now adding the recent visits to
homescreen above the collections section pushing it off screen.
Since the collections might be obstructed by the toolbar shown on top as a
quick solution we'll scroll to the next homescreen section so that the
collections will be shown above in their entirety.
* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
c7aea80bb2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22595 - Remove unused OnboardingAutomaticSignInViewHolder
3 years ago
5b069b2ece
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22211 - Use Hero images for Recent Bookmarks
3 years ago
4cc4e1c67d
[fenix] Improve loading URLs
3 years ago
3dea07855e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22442 - Don't display history group if already in Jump back in
3 years ago
100d5372ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22250 - Convert Recent Bookmarks to Jetpack Compose
3 years ago
86f80f2652
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22502 - Update "Jump back in" group's subtitle format
3 years ago
d61fd5de0e
[fenix] Update lastAccess timestamp of selected tab when launching to home
3 years ago
627bc919d1
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22402 : Add top placeholder for home
3 years ago
bfc035e0c2
[fenix] MR2 Telemetry: Homescreen view count ( https://github.com/mozilla-mobile/fenix/pull/22377 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22146 - Added counter for home screen views
* For https://github.com/mozilla-mobile/fenix/issues/22146 - Added PR number to metrics
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
cbfc23f8cc
[fenix] Recent bookmark count telemetry ( https://github.com/mozilla-mobile/fenix/pull/22293 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22075 - Added event to track the count of recent bookmarks
* For https://github.com/mozilla-mobile/fenix/issues/22075 - Added data review issue number
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
b1cb88fff7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22078 Selecting search group in Jump back in switches active tab
3 years ago
5e2853ea47
[fenix] MR2 Telemetry: Recent tabs section probe ( https://github.com/mozilla-mobile/fenix/pull/22166 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22107 - Added probe to track if the Recent tabs / jump back in section is visible
* For https://github.com/mozilla-mobile/fenix/issues/22107 - Fixed lint errors
* For https://github.com/mozilla-mobile/fenix/issues/22107 - added data review number to metric
* For https://github.com/mozilla-mobile/fenix/pull/22166 - fixed expiration date
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
ba7d325bb4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22057 : Add search term groups telemetry
3 years ago
c0fde2bebb
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22172 : Add Recent searches telemetry
3 years ago
46f9f1ae2c
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22103 : Add recent bookmarks telemetry
3 years ago
015be02422
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22175 : Telemetry event for deleting a search term group from the recent searches section on home
3 years ago
41ddc9226c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21888 - Use Hero images for Jump back in
3 years ago
45e9bf6693
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unused symbols
3 years ago
759194a625
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Class member can have 'private' visibility
3 years ago
853e159476
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - 'protected' visibility is effectively 'private' in a final class
3 years ago
5fbd63386d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove reductant SAM constructor
3 years ago
2defb17c08
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove val from constructor parameter that are never used as a property
3 years ago
6f4c47613a
[fenix] Update Kotlin and Jetpack Compose versions.
3 years ago
bf76a1871c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21771 - Show url when recent tab's title is not available
...
This is the same previously used approach and the same used for tabs tray.
3 years ago
9926c27e43
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21921 : add durations for some HomeFragment lifecycle markers.
3 years ago
18127e2f5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21841 - New telemetry for Google and Baidu top sites removal
3 years ago
2e7f52f63a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Composify Customize Home Button and update the background color
3 years ago
2c4ccea6cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21753 - Refactor Pocket out of sessioncontrol
3 years ago
eef2ad800a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21871 - Eagerly update UI state after search group removal
...
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.
This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).
This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.
After this patch, we:
- dispatch two actions (on browserstore, on homefragmentstore) which
remove the search groups from any relevant in-memory state; any UI bound to
this state will be automatically "refreshed"
- no longer navigate as part of the remove action, so the UI doesn't
move and removal happens "in-place"
3 years ago
897aa4b662
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21522 : Wrap section titles on home
3 years ago
ff62ffe70a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21809 - Adjust the padding between the Pocket section
3 years ago
822775eb9d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20992 - Speculative fix for TopSitesPagerAdapter crash
3 years ago
39a3aacc78
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21773 - Updated "customize homepage" button to go to the new Homepage submenu in Settings
3 years ago
e6a73b5118
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21623 - Pocket recommended stories telemetry
3 years ago
Alexandru2909
Mugurell
MatthewTighe
Gabriel Luong
sarah541
Arturo Mejia
Noah Bond
Jan-Erik Rediger
mcarare
dlp
Brais Gabín
Jonathan Almeida
sunil9211
Roger Yang
Rohan Maity
jhugman
Grisha Kruglov
rxu
Christian Sadilek
Noah Bond
Elise Richards
Sebastian Kaspari
Michael Comella
codrut.topliceanu