Commit Graph

1591 Commits (24f79b32633bff678e9ad4be7d416043ca5028ff)

Author SHA1 Message Date
Axel Hecht 5e444eccff Import strings from android-l10n
State: mozilla-l10n/android-l10n@413e05dba4
5 years ago
Tiger Oakes b8c93107c0 For #4744 - Extract TransitionPreDrawListener (#4812) 5 years ago
Tiger Oakes a632d8f1dc For #4744 - Move search bar icon padding to dimens (#4814) 5 years ago
Emily Kager fb1d655d96 Closes #4822 - Update Bookmark State in onResume (#4823) 5 years ago
Mihai Adrian bf42abb21c fixes #4179 removed control highlight from disconnect button (#4806)
set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.
5 years ago
Sawyer Blatz 0d4eceed56 For #2706: Refactor Glean to reduce errors (#4753)
* For #2706: Adds recording for untracked events

* For #2706: Adds key alignment to Metrics
5 years ago
Sawyer Blatz 4731977f5d
For #4421: Fixes issues with new glean events (#4816) 5 years ago
Sawyer Blatz 73e3db8fe0 For #4804: Resolves issue with crash reporter stack 5 years ago
Aaron Train ae05bf98e2
Closes #4618 - Stub Library UI tests (#4619)
See #4572
5 years ago
Arturo Mejia 210868f5bc Use Mozilla Android Components 9.0.0-SNAPSHOT. (#4750) 5 years ago
Suraj Shah 806961094b Fixes #4704 (#4728)
* Fixes #4704. Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.

* Updates CHANGELOG.md

* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
5 years ago
Mugurell 645674c9bd Closes #4396 - Add a Bookmarks Controller (#4593)
* For #4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For #4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For #4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
5 years ago
Tiger Oakes de14962e3f Extract quick action sheet observer code (#4368) 5 years ago
Emily Kager 7d02354f4f For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController (#4800) 5 years ago
Colin Lee d1aed157dd
For #4686: Fix potential security issue (#4764) 5 years ago
Yeon Taek Jeong 727457f0ed No issue: fixes click failures on search widget icon 5 years ago
Emily Kager c9598bc4d1 For #4688 - Try to use context instead of targetContext (#4765) 5 years ago
Yeon Taek Jeong d4c83f9668 For #4736: Display search shortcuts only from home or search widget 5 years ago
Emily Kager d07d74e8d3 For #4688 - Try slightly different Context class for MockWebServer (#4747) 5 years ago
Emily Kager 3f820366a6 Closes #4680 - Align collection creation text center vertical 5 years ago
Yeon Taek Jeong a680d733c8 For #4384: Hide mic icon if speech-to-text is unavailable (#4701) 5 years ago
Yeon Taek Jeong 2441592ef2 For #4516: Use full width for large search widgets (#4659) 5 years ago
Emily Kager f71106cb51 Closes #3860 - Update description text for collections 5 years ago
Sawyer Blatz b7ca520787 For #4421: Adds Leanplum events and attributes (#4626)
* For #4421: Adds Leanplum events and attributes

* For #4421: Adds Leanplum deep links
5 years ago
Yeon Taek Jeong 67f3b63ae5
For #4421: Add search widget attribute to Leanplum (#4694) 5 years ago
Yeon Taek Jeong f5ffe3734c
For #4457: Adds telemetry for search widget actions (#4714) 5 years ago
Yeon Taek Jeong 2f265eccbd
For #4732: Fix search engine display issue (#4735) 5 years ago
Mihai Adrian 1a4ef1535c For #4434 - made close button for collections more accessible. (#4443)
* fixes #4434 - made close button for collections more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for #4193 - close button for tabs

* fixes #4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button

set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
5 years ago
Michael Cooper 12371ca9c1 Add no-op experiment to test service-experiments integration (#4551)
* Add no-op experiment to test service-experiments integration

* Shorten metric name to meet schema

* Add active_experiment metric to docs

* Add approved data review
5 years ago
Tiger Oakes 3acabeb6c3 Use global navigation action for browser fragment (#4691) 5 years ago
isabelrios 7729cb63a7 Fix UI Screenshot TabMenuTest (#4730) 5 years ago
Colin Lee 5b4a441bcb For #1667: Screen reader can't reach other UI items when QAB expanded (#4695) 5 years ago
Emily Kager 1328d686aa No issue - Autoformatting (#4715) 5 years ago
Sebastian Kaspari b733fcdbd5 Closes #4719: Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. (#4722) 5 years ago
Colin Lee e6f9445d11
For #4709: Fix Bugzilla issue 1573549 (#4710) 5 years ago
Sourabh 42e3b2771e fix #4633: show toast only on first login (#4676)
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
5 years ago
(´⌣`ʃƪ) 5aac05859d Fix #4436: hide onboarding before navigating to settings (#4675)
* Fix #4436: hide onboarding before navigating to settings

* No issue: Rename emitAccountChanges to emitModeChanges
5 years ago
Sebastian Kaspari d03c15d15c Issue #4431: Integrate feature-media component (Nightly and debug builds only). (#4683) 5 years ago
Colin Lee 0c8bcd39be For #4652: HomeFragment Crash "Can not.. after onSaveInstanceState" 5 years ago
Jorge De Los Santos 337ad1e88e For #3424 - Make talkback ignore ImageButton in Collection Sele… (#3792)
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
5 years ago
Grisha Kruglov b38b94ed79 Closes #4671: Fix a potential NPE in BookmarkFragment 5 years ago
Grisha Kruglov 634ee184a6 No issue: add some BookmarkFragmentInteractor tests 5 years ago
Grisha Kruglov f323105163 No issue: reduce code duplication in BookmarkFragmentInteractor 5 years ago
Christian Sadilek 5fe05e919a For #4125: Suppress coroutine warning to fix release build 5 years ago
Sawyer Blatz 0ec92d716f
For #4123: Adds telemetry for quick action open in app (#4629) 5 years ago
Yeon Taek Jeong b24793d863 ktlint fix 5 years ago
Yeon Taek Jeong aac73a8fe2 Finish adding tests 5 years ago
Yeon Taek Jeong 6c9ce784b1 Fix, add some tests 5 years ago
Yeon Taek Jeong 2a6069bfb7 Fix rest of issues 5 years ago
Yeon Taek Jeong 69434a765f Fix most issues 5 years ago
Yeon Taek Jeong faf0ecbcc0 For #4125: Migrate Sign in to Sync to Libstate 5 years ago
Axel Hecht 65de521ccf Import strings from android-l10n (#4643)
State: mozilla-l10n/android-l10n@ab580f757c
5 years ago
Colin Lee 7f07eabbd8
For #4652: Crash "Can not perform this action after onSaveInstanceState" (#4654) 5 years ago
Jonathan Almeida 353ecab44e No issue: Disable failing ActivationPingTest 5 years ago
Tiger Oakes 52542708aa Consodilate private browsing code 5 years ago
Jonathan Almeida 23f5ac0fb9 For #4066: Create InflationAwareFeature for lazy inflation 5 years ago
Colin Lee 519c3bde5d For #4066: Provide lazy inflation of Find In Page View 5 years ago
Sawyer Blatz 167b2ef002 No issue: Removes deprecated usage of InstrumentationRegistry 5 years ago
Colin Lee 71c48692da
For #4507 Enable codecov (#4520) 5 years ago
Colin Lee c9c43260c9
For #4529: Handle crash initializing CreateCollectionViewModel late (#4628) 5 years ago
ValentinTimisica 63d50d9827 Fixes #4323: Modified UI of component_collection_creation.
To fix the overlapping issue I used Guideline and
layout_constraintWidth_default property. I also used the
layout_constraintHorizontal_bias property to make the back_button to
lean to the left and the select_all_button to lean to the right.
5 years ago
Christian Sadilek e26570054a Suppress warning in LeanplumMetricsService to fix release builds 5 years ago
Emily Kager e1f0c9f48b No issue: Update testing dependencies 5 years ago
Mathieu Leplatre 04daf21437 Fix #4612: Fetch experiments from Remote Settings CDN 5 years ago
Colin Lee ef97173cd9
For #4529, #4427: Resuming after restoring instance state breaks UI (#4571)
* For #4529, #4427: Resuming after restoring instance state breaks UI

* Clear up warnings
5 years ago
Emily Kager c21c91eac5 No issue: Update testing dependencies and deprecated method (#4608) 5 years ago
Sawyer Blatz ff6e9bccb7
For #4451: Adds tests for DefaultBrowserToolbarController (#4493)
* For #4451: Adds tests for DefaultBrowserToolbarController

* Continue working

* Large refactoring of test

* Mock analytics

* Fix merge conflicts
5 years ago
Hakkı Kaan Çalışkan 0ea595743d Fixes #4562: Add a-c git hash to about page 5 years ago
Emily Kager 0b98d43c23 Closes #4602 - Add back transitions 5 years ago
Sawyer Blatz 4566bd6fba Fixes feedback 5 years ago
Sawyer Blatz 4d14735935 For #3060: Adds Leanplum attributes for fxa syncing 5 years ago
Sawyer Blatz 9d65e665e5 No issue: Removes deprecated usage of ViewModelProviders 5 years ago
Yeon Taek Jeong ec4d62c895 Fix ktlint 5 years ago
Yeon Taek Jeong 00bd26abe3 Remove task flags 5 years ago
Yeon Taek Jeong f952234c57 Keep CLEAR_TASK 5 years ago
Yeon Taek Jeong c87468d031 Remove popBackStack 5 years ago
Yeon Taek Jeong a8526a0606 For #4438: Fix crash when opening any URL from URL bar w/ long press 5 years ago
Sawyer Blatz 969d17b4a9
For #969: Adds more telemetry for collections (#4539) 5 years ago
Tiger Oakes 8698ade699 Minify the fenix 5 years ago
Sawyer Blatz da06b0fb15
For #4508: Treats warnings as errors (#4543) 5 years ago
Grisha Kruglov f23f3b7489 Closes #4467: Use a-c version of FirefoxAccountsAuthFeature 5 years ago
ValentinTimisica 59c60ef189 Fixes #4354: Updated SearchFragment state after returning from SearchEngineFragment.
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
5 years ago
Colin Lee a514cb3f8c No issue: Add OSS licenses link to About page 5 years ago
Sawyer Blatz f9288c7fbd
For #969: Finalizes collections telemetry (#4592) 5 years ago
Richard Pappalardo 422818c917
Stub out tabs tests (#4573) 5 years ago
Emily Kager 8194e0778e For #4026 - Update BookmarkDiffUtil to update on Title or URL change 5 years ago
Jeff Boek cf169da2fc For #4557 #3860 - Add string for collection empty state 5 years ago
Emily Kager 0604e9858d Closes #3939 - Adds strings for delete browsing history 5 years ago
Emily Kager b20c381af9 For #1749 - Land ETP Strings 5 years ago
ValentinTimisica 71aedc79fe Fixes #3922: Added accessibility announcement for history empty state.
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
5 years ago
Tiger Oakes 631b7ba7cb Issue #1000 - Split out common browser functions 5 years ago
Emily Kager 23bc8f4320 Fro #4563 - Update delete button alpha when history mode changes 5 years ago
Tiger Oakes 3c1ce90f6f Fixes #2379 - Generic library selection 5 years ago
Emily Kager 4bbb291e8d No issue: Update UI tests with new engine shortcuts behavior (#4552) 5 years ago
ekager 0320efee84 No issue: Removes focusableInTouchMode from home searchbar view 5 years ago
Yeon Taek Jeong 6f962d3376
For #1744: Open search shortcuts when entering search mode (#4536) 5 years ago
Emily Kager 6f7ae227a8 Closes #4540 - Set correct tint for select bookmark folder icon (#4541) 5 years ago
Emily Kager ad448b37ae Closes #4537 - Adds description for onboarding placeholder string (#4542) 5 years ago
ekager 5edc9d0b4e For #2021 - Update custom preferences' views with email/account changes 5 years ago
Travis Long 51218bc93e Integrate service-experiments component (#4098) 5 years ago