Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-11 13:11:01 +00:00
Code Issues Releases Wiki Activity
3,314 Commits 67 Branches 115 Tags 1.2 GiB
21606bf94f
Commit Graph

2852 Commits

Author SHA1 Message Date
Alessio Placitelli
99d6dbfca4 Test that 'baseline' pings are sent by Fenix 
This is an initial instrumented test for Fenix
that checks if a 'baseline' ping is generated when
going to background.
 2020-02-05 19:06:46 +01:00
Mozilla L10n Automation Bot
858db3587a Import l10n. 2020-02-05 17:42:17 +01:00
Christian Sadilek
d10a30e356 Closes #4983: Fennec migration: Keep installed add-ons 2020-02-05 09:14:04 -05:00
Emily Kager
fb80754a4e No issue: Move bookmark delete string to be translated 2020-02-05 11:23:36 +01:00
Mugurell
ac39b420b4 Fix #7613 - Align radio buttons with the theme images 2020-02-05 10:21:23 +01:00
lyrjie
b25a5468ba Added the autoMirrored flag to arrowhead drawable 2020-02-05 09:14:45 +01:00
Arturo Mejia
6191fec0d8
No Issue: Close the web extension popup when we can't get the popup of the session. 2020-02-04 17:17:46 -05:00
Mozilla L10n Automation Bot
fa854f511b Import l10n. 2020-02-04 18:49:15 +01:00
Emily Kager
604ac83d0c For #7999 - Change fxa leanplum metrics to false by default 2020-02-04 09:17:55 +01:00
Gabriel Luong
64a4a7f422
Provide add-on support (#8064) 
Closes #5630, #6069, #6092, #6091, #6124, and #6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2020-02-04 01:41:51 -05:00
Mihai Adrian
4eb71ce235
For #6980: Update ETP onboarding card (#7958) 2020-02-03 21:03:15 -08:00
Jonathan Almeida
cbcc56bbba For #373: Implement LeanPlum push messaging 
Also closes #6250, since we rely solely on the SDK itself to consume the
messages straight from FCM.
 2020-02-04 00:13:56 +01:00
David Walsh
4e6215c0c1 Fix linting issue 2020-02-04 00:12:26 +01:00
Sawyer Blatz
9f342fca9e For #6820: Updates background, shadow, & snackbars of toolbar 2020-02-04 00:12:26 +01:00
David Walsh
4b3effdfab For #6820: Place address bar at top or bottom of the home screen based on user preference 2020-02-04 00:12:26 +01:00
Aaron Train
97915107eb Closes #8066: disable failing UI Bookmarks tests 2020-02-03 23:41:43 +01:00
ValentinTimisica
0a76fdaa58 For #7289: Adds telemetry for selecting dark theme 2020-02-03 23:20:42 +01:00
Kadeem
321251c49c Updates the hide and reveal password icons to use and tint the mozac version. 2020-02-03 23:11:41 +01:00
Mozilla L10n Automation Bot
6b2bf2acb8 Import l10n. 2020-02-03 22:56:11 +01:00
David Walsh
ae445abff3 Small improvements, lint fixes 2020-02-03 21:01:14 +01:00
Sawyer Blatz
030f75b4df For #5892 & #6380: Updates error page template and allows SSL bypassing 2020-02-03 21:01:14 +01:00
ValentinTimisica
2026c60136 For #6834: Adds telemetry for About page items 
Didn't change the existing probe for 'whats new' item because we're already
collecting that info.
 2020-02-03 19:28:56 +01:00
Mihai Branescu
7b9f74138c For #7559 - added unit test for same locale selected 2020-02-03 19:24:12 +01:00
Mihai Branescu
2a876d5e0f For #7559 - fixes 2 issues: 
- The same item now doesn't recreate the activity
- The app context now contains the right locale
 2020-02-03 19:24:12 +01:00
Mihai Branescu
1b7cb117ca For #7559 - allows changing locale even after setting theme with 
AppCompatDelegate.setDefaultNightMode(mode). The override is necessary because the uiMode needs
to be manually updated after changing theme
 2020-02-03 19:24:12 +01:00
Aaron Train
eb2eed1c9c
Closes #8015: fix UI test verifyContextCopyLink (#8026) 2020-01-31 14:58:02 -05:00
Sawyer Blatz
1372ed5837 For #7970: Updates snackbars for accessibility 2020-01-31 16:24:36 +01:00
David Walsh
82c698c818 Fix 5727 - History to browser navigation should go back to history 2020-01-31 16:02:18 +01:00
Aaron Train
89cc5657ce
Closes #8006: Add Close/Undo UI tests (#8007) 2020-01-30 16:15:40 -05:00
David Walsh
f728cdaf05
Bug 7189 - Provide page title in website information dialog (#7255) 
* Bug 7189 - Provide page title in website information dialog

* Update QSFS test

* Fix Tiger's nits
 2020-01-30 11:24:53 -08:00
Emily Kager
d272623c3d No issue: Add idle for create folder UI test 2020-01-30 16:54:25 +01:00
Sawyer Blatz
94447657c4 No issue: Fixes strings for data migration 2020-01-30 11:29:50 +01:00
Mihai Adrian
24396d174f
For #6980: Add What's new card (#7952) 2020-01-29 08:50:11 -08:00
Jonathan Almeida
202f2b8811 Closes #7788: Route search widget intents through IntentReceiverActivity 2020-01-29 14:27:14 +01:00
Mihai Branescu
b3d99c6bba
For #7679 - Replaced comparison by reference with value, added check for default in order to avoid double checkmark (example: default + English) (#7729) 2020-01-28 19:22:04 +02:00
mcarare
06169433b5 For #5905: Pre-land strings for Settings screen changes 2020-01-28 01:49:29 -08:00
Sören Hentzschel
8a7c7fd06f For #7730 - always show "Add private browsing shortcut" in sett… (#7943) 2020-01-27 08:44:28 -08:00
ValentinTimisica
154e11841a Fixes #7881: Send telemetry event when custom search engine is deleted 2020-01-27 12:04:28 +02:00
Sebastian Kaspari
18244cef51 Closes #7762: Initialize Glean later in Fennec builds. 2020-01-26 11:53:26 +01:00
Jonathan Almeida
40e72a7b28 For #7524: Remove DeviceConstellation polling from onResume (#7908) 2020-01-25 11:04:24 -08:00
Mihai Adrian
622fdadde8 For #7272: Show info when saved logins list is empty. (#7891) 
* For #7272: Show info when saved logins list is empty

* For #7272: Updated unit tests
 2020-01-24 18:13:44 -08:00
Sebastian Kaspari
10bf49918f Issue #7818: Use different target activities for launcher activity alias (fenix vs. fennec). (#7917) 
* With this patch fenix build variants will launch HomeActivity directly from the launcher.
  This will get rid of the performance regression outlined in #7818.

* Fennec build variants will launch into MigrationDecisionActivity which will show the
  migration UI or launch normally into the app. This is faster than going through
  IntentReceiverActivity (measured and perceived).
 2020-01-24 18:03:25 -08:00
Sebastian Kaspari
21f342be12 Issue #7890: Make migration screen scrollable. (#7914) 2020-01-24 18:03:02 -08:00
Suraj Shah
2d64cf8e4c Connectivity manager tests (#7317) 
* Fixes #7316
Adds tests for ConnectivityManager.isOnline

* Fixes detekt errors.

* Cleaning tests

* Cleaning tests to use boolean checks instead of object equals
 2020-01-24 17:43:28 -08:00
Michael Comella
fe105729ad No issue: don't export OssLicense*Activity. (#7909) 
afaik, these Activities are only intended to be shown internally and
have no reason to be accessible to other apps on the system.
 2020-01-24 17:41:23 -08:00
Jonathan Almeida
2b2ea9eb5e No issue: Update Firefox Logo in Migration UI (#7916) 2020-01-24 17:33:15 -08:00
Emma Malysz
5e9b753acb For #7473, delay inflation of toolbar 
Improve performance of HomeActivity.onCreate by delaying this inflation.
We use a ViewStub and inflate the first time the actionbar is accessed.
 2020-01-24 15:21:42 -08:00
Gabriel Luong
f93e141d52 For #7525 - Add telemetry for opening a top site in normal and private mode and removing a top site 2020-01-24 15:18:25 -08:00
Gabriel Luong
192eecdf5b For #6758 - Part 7: Add menu for opening a top site in private tab and removing a top site 2020-01-24 15:18:25 -08:00
Gabriel Luong
9ecb67e783 For #6758 - Part 6: Add top site view 2020-01-24 15:18:25 -08:00
Gabriel Luong
f68f89f2bf For #6758 - Part 5: Add top sites to the HomeFragmentStore 2020-01-24 15:18:25 -08:00
Gabriel Luong
e1863dd3c2 For #6758 - Part 4: Implement "Add to Firefox Home" browser menu item 
- The "Add to Firefox Home" browser menu item adds a top site to the top site storage.
- Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController
since there are multiple menu items that need to show a FenixSnackbar.
- Adds metrics for the new browser menu item.
 2020-01-24 15:18:25 -08:00
Gabriel Luong
9ddf93eb7d For #6758 - Part 3: Add TopSiteStorage wrapper around AC's TopSiteStorage 
This follows the existing pattern around TabCollectionStorage.
 2020-01-24 15:18:25 -08:00
Gabriel Luong
584b270aa4 For #6758 - Part 2: Add AC dependencies for top sites feature 2020-01-24 15:18:25 -08:00
Gabriel Luong
0a856d9413 For #6758 - Part 1: Add new strings for top sites feature 2020-01-24 15:18:25 -08:00
Aaron Train
0fa0a84887 Closes #7920 - Disable ETP UI test for investigation into failure in #7907 2020-01-24 12:51:25 -08:00
Sebastian Kaspari
9a15103a20 Issue #7762: Enable glean based on setting for non-fennec builds. 2020-01-23 16:32:15 +01:00
Severin Rudie
44e4d8e12c
No issue: clarify naming for showing a prompt to allow search suggestions (#7870) 2020-01-22 19:08:07 -08:00
Emily Kager
a39a9e5b4e No issue: Enable about:config in beta builds 2020-01-22 16:34:51 -08:00
David Walsh
1ee0243efa Fix 4021 - Provide tab title during share 2020-01-22 14:42:27 -08:00
ekager
c556e819bd For #5586 - Add telemetry for save logins setting 2020-01-22 14:19:12 -08:00
Emily Kager
7adb5b6084 For #6812 - Navigate via openToBrowser to selected session from search 2020-01-22 14:13:16 -08:00
Sawyer Blatz
e1722b95b3 No issue: Fixes ErrorResponse instantiation 2020-01-22 11:47:51 -08:00
Arturo Mejia
310da6c1ea No Issue: Add support for deleting individual tracking protection 
exceptions on nightly.
 2020-01-22 11:47:51 -08:00
Chenxia Liu
f726b03792 Fix breaking changes from new TrackingProtectionException 2020-01-22 11:47:51 -08:00
Michael Comella
847056b332 Issue #7423: remove redundant bottom_bar ConstraintLayout. 2020-01-22 11:20:47 -08:00
Michael Comella
91a557dc0a For #7423: remove unnecessary CoordinatorLayout in fragment_home. 
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
 2020-01-22 11:20:47 -08:00
Michael Comella
d7fd8e763a For #7423: remove unnecessary wordmark_spacer view. 
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
 2020-01-22 11:20:47 -08:00
Sawyer Blatz
20396f78a9
For #7698: Adds search back button animation (#7840) 
* For #7698: Adds search back button animation

* Refactor for searchController
 2020-01-22 11:15:30 -08:00
Josh Vocal
2372ee6b15 For #4212: Control text not translated 2020-01-22 10:27:46 -08:00
Emily Kager
0b1a67367e
Closes #7814 - Updates dark shield icons (#7838) 2020-01-22 07:42:08 -08:00
Michael Comella
e25ee98d7d No issue: fix typo in Performance.instrumentColdStartup... (#7848) 2020-01-22 02:36:16 -05:00
mozilla-l10n-automation-bot
cf63db20b4 Import l10n. (#7843) 2020-01-21 21:38:51 -08:00
Kaaira Gupta
08cce8cf58 for #7421 :removed collection from clear browsing history 2020-01-21 19:00:59 -08:00
Michael Comella
ffc441f12a For perf-frontend-issues#50: instrument imperfect reportFullyDrawn. 
We don't capture the second RV draw yet. Unfortunately, I don't know if
it's the best use of my time to capture that as well.
 2020-01-21 18:34:38 -08:00
Chenxia Liu
e5164e3670 For #6980 - Pre-land string changes to onboarding cards. 2020-01-21 16:28:36 -08:00
Mihai Carare
cd853d0d8f For #7029: Navigate to Search Fragment when pressing Start browsing 2020-01-21 16:26:43 -08:00
Kaaira Gupta
e291c6905c For #3813 - Create a save button for bookmark editing 2020-01-21 16:03:33 -08:00
Mozilla L10n Automation Bot
db875ac929 Import l10n. 2020-01-21 14:33:05 -08:00
Severin Rudie
2dc5b397b6
For #7506: show highlight on home 3-dot button (#7665) 2020-01-21 13:02:14 -08:00
mcarare
8274ff6f2b For #7714: Align engine name to viewStart to support RTL layouts 2020-01-21 12:27:19 -08:00
Mihai Adrian
355cb35cb6 For #7574: Send toolbar position metrics in English. (#7712) 2020-01-21 08:24:18 -08:00
Sebastian Kaspari
e5ba74711d MigratingFenixApplication: Pass MigrationStore to FennecMigrator. 2020-01-21 14:38:08 +02:00
mozilla-l10n-automation-bot
5a429b99e9 Import l10n. (#7744) 2020-01-20 11:07:18 -08:00
Jonathan Almeida
02b4582c8d No issue: Update Migration UI with new API 2020-01-20 18:08:38 +01:00
Sebastian Kaspari
af3726a505 Fennec home screen bookmarks: Select new tab. 2020-01-20 15:17:58 +01:00
Sebastian Kaspari
80eb19294b AboutFragment: Use SupportUtils.getWhatsNewUrl(). 2020-01-20 14:15:58 +01:00
Michael Comella
ffb2e72b97 For #7423: remove unnecessary CoordinatorLayout in fragment_home. 
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
 2020-01-17 16:59:03 -08:00
Michael Comella
a1cbbba4ea For #7423: remove unnecessary wordmark_spacer view. 
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
 2020-01-17 16:59:03 -08:00
ekager
053e5b8065 For #6396 For #6553 - Update sync engine checkboxes and send telemetry once 2020-01-17 16:39:24 -08:00
Kate Glazko
dbf711e112 For #4904: Pressing back external link doesn't go back 2020-01-17 16:08:58 -08:00
Sawyer Blatz
509fa112d0 For #6308: Remove unecessary telemetry & bump expiry date (#7793) 
* For #6308: Remove unecessary telemetry

* For #6308: Bump expiry date on telemetry
 2020-01-17 15:13:20 -08:00
liuche
904098387a
Issue #7093 - Pre-land strings for new onboarding cards. (#7747) 2020-01-16 18:20:41 -08:00
Jeff Boek
6789df55a5 For #220 - Puts language picker behind a feature flag 2020-01-16 15:45:05 -08:00
ekager
60e3bb3126 Closes #5080 - Move site permissions strings for l10n 2020-01-16 14:41:48 -08:00
Jeff Boek
ea22f6d69b For #1607 - Fixes SearchShortcutSelected to not leak any custom identifiers 2020-01-16 14:07:38 -08:00
Jonathan Almeida
f4b583fc0b For #ac-5601: Lock migration UI screen orientation 2020-01-16 13:46:01 -05:00
Jonathan Almeida
d29701d992 For #ac-5597: Fix unneeded dark theming in migration UI 2020-01-16 13:46:01 -05:00
Sebastian Kaspari
eeb5b7b3a1 Android manifest: Export shortcut target activity. 2020-01-16 19:29:15 +01:00
ValentinTimisica
c106d89285 For #7751: Remove 'SearchWithCustomEngine' telemetry event 2020-01-16 10:14:07 -08:00
Sebastian Kaspari
3a1292911d Update list of tabs after onboarding screen was dismissed. 2020-01-16 18:47:33 +01:00
Mihai Adrian
6b786ca8dc For #7417 Wait for deletion to finish and loading of new UI (#7572) 2020-01-16 11:03:59 -05:00
ValentinTimisica
981d19de13 For #6556: Adds Telemetry counts for Search Access Points 
Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and
'suggestion'. Also modified/fixed some tests.
 2020-01-16 10:23:48 +02:00
Grisha Kruglov
9c25d274d0 Enable firebase auto-init, force push renewal after migration 2020-01-16 01:11:21 -05:00
Jonathan Almeida
7f988a85d0 Disable failing intent handling unit tests 2020-01-15 21:41:01 -08:00
Jonathan Almeida
93850a2410 Add migration for telemetry identifiers to builder 2020-01-15 21:41:01 -08:00
Jonathan Almeida
914bce0b0a Fix general Fenix build 2020-01-15 21:41:01 -08:00
Jonathan Almeida
261a6162af Review comments, fix build failure and targetActivity 2020-01-15 21:41:01 -08:00
Jonathan Almeida
b89afe7b7c For #7092: Add initial Migration UI 2020-01-15 21:41:01 -08:00
Sebastian Kaspari
29d9ba472c Always initialize glean. Set upload flag after migration. (#7717) 2020-01-15 15:31:51 -08:00
ekager
0777fb3bbe For #5545 For #5542 Closes #6696 Integrate logins API, adds Settings for Autofilling/Saving Logins 2020-01-15 12:14:08 -08:00
Alessio Placitelli
f93437c509 Fix GleanMetricsService to use the new Glean APIs 2020-01-15 16:38:48 +02:00
Jonathan Almeida
61570b5238 Closes #7645: Disable push service when migrating 2020-01-15 02:10:56 -05:00
Mozilla L10n Automation Bot
ee7f16b2b4 Import l10n. 2020-01-14 18:53:13 -08:00
salvatorep
ceb155ec5c Added support for Intent.ACTION_SEARCH and Intent.ACTION_WEB_SEARCH actions 2020-01-14 16:50:45 -08:00
Christian Sadilek
56acf0c360 Issue #4893: Enable addon migration 2020-01-14 17:43:21 -05:00
Sebastian Kaspari
fe4a74799d Issue #7203: Move static_strings.xml to right directory. 2020-01-14 16:56:00 -05:00
Sebastian Kaspari
d08dc03861 Issue #7203: Add fennec icons for fennecNightly build type. 2020-01-14 16:56:00 -05:00
Aaron Train
5aac4506e1
Closes #7693: Temp disable UI test verifyContextMixedVariations (#7694) 2020-01-14 14:55:05 -05:00
Aaron Train
bebb69e046
Closes #7687: Temp disable UI test verifyContextCopyImageLocation and verifyContextSaveImage and verifyContextOpenImageNewTab 2020-01-14 14:07:53 -05:00
Marcin Wiącek
159644579e Doesn't allow for hint in URL bar on main page in two lines 2020-01-14 09:36:39 -08:00
daphliu
7034ad4be6 Modified onboarding card colors according to design 2020-01-14 09:18:45 -08:00
isabelrios
d25cbebe08 For #7563 - Sync integration logins (#7564) 
* sync-integration-logins-test

* improve checks for logins test

* fixing ktlint issues

* uncomment lines

* address reviewer comments

* fix ui tests after robot change

* fix lint
 2020-01-14 08:47:37 -08:00
Grisha Kruglov
fe92332ff1 Migrate 'settings' before app init 2020-01-14 17:27:41 +01:00
Kadeem M
fb2a68fdec Added BuildDate Assertion for About Preview Screen; Added verification for external links in About Preview Screen (#7413) 2020-01-13 13:53:35 -08:00
ValentinTimisica
a952d0858c For #5884: Fixed Unit tests. 2020-01-13 12:31:23 -08:00
ValentinTimisica
7c5c9355ce For #5884: Adds user-specified search engines telemetry 
Created events for adding and deleting a custom search engine and for searches
performed with a custom search engine.
 2020-01-13 12:31:23 -08:00
Colin Lee
cf220427d7
Fix #7649: Fix missing NOT in asFeatureWebChannelsDisabled check (#7650) 2020-01-13 13:37:13 -06:00
Colin Lee
7baf54f566
For #5182: Loading experiments on startup is slow, remove Fretboard (#7510) 
This removes Fretboard. The goal is to reduce cold startup costs associated with loading the experiments on the main thread. We currently have two experiments frameworks in use and should only require one.
 2020-01-13 12:38:32 -06:00
Aaron Train
399df17062
Closes #7611: Add UI tests for content context menus (#7631) 
Closes #7611: Add UI tests for content context menus
 2020-01-13 12:24:23 -05:00
Sebastian Kaspari
6419d0cf13 Open "migration FAQ" when selecting "What's new" in a Fennec build. 2020-01-13 17:08:48 +01:00
Mozilla L10n Automation Bot
4fb8398a3b Import l10n. 2020-01-13 12:14:20 +02:00
Tiger Oakes
55c1b01d7b For #7431: Remove extra share button 2020-01-11 11:48:51 -08:00
ekager
913c50b59f Remove unused labels from nav_graph 2020-01-10 16:45:21 -08:00
mcarare
92305a725b For #7593 Set AboutFragment title just in onCreate 2020-01-10 16:45:21 -08:00
mcarare
e9053fec57 For #7583 Align text in language title and subtitle to viewStart 2020-01-10 15:36:31 -08:00
Sebastian Kaspari
f1654baa77 Issue #7203: Use app name 'Firefox Nightly' for fennecNightly build. 2020-01-10 13:59:31 -08:00
ekager
cf05840c0f Move experiments initialization and fix ktlint errors 2020-01-10 13:57:12 -08:00
Kris Taeleman
43e8e3aab4 Bug 1605454 - Fixing typo 2020-01-10 13:57:12 -08:00
Kris Taeleman
16005c75ef Bug 1605454 - Kotlin linting improvement 2020-01-10 13:57:12 -08:00
Kris Taeleman
de5d44edd8 Bug 1605454 - Change experiment name and take branch into account 2020-01-10 13:57:12 -08:00
Kris Taeleman
2c4790de66 Bug 1605454 - Adding experiment code for disabling webrender. 2020-01-10 13:57:12 -08:00
Sebastian Kaspari
927bcc48a7 Closes #7587: Add shortcuts.xml for fennecNightly variant. 2020-01-10 13:50:47 -08:00
Sebastian Kaspari
1f5bfff025 Issue #6898: Allow empty adjust token for fennecNightly builds. 2020-01-10 13:48:20 -08:00
ekager
47c13136f7 No issue: Fix dynamic theming to accommodate lazily inflated readerview 2020-01-10 13:23:46 -08:00
mcarare
a72620ae07 For #7522 Catch IllegalArgumentException when validating search string 2020-01-10 11:26:11 -08:00
Sawyer Blatz
a58decd708 For #6304 & #7577: Persist private mode between app launches 2020-01-09 17:03:36 -08:00
Mihai Adrian
0a412a1a6a For #6992 Always hide toolbar when showing find in page bar (#7567) 2020-01-09 13:26:33 -08:00
Mihai Adrian
666b3d9627 For #7343: Handle sharing to multiple devices (#7409) 
* For #7343 Do not allow multiple share to same device

* For #7343 Check current destination before dismissing share
 2020-01-09 10:40:14 -08:00
Sawyer Blatz
718c211a86
For #1718: Sets accessibility users to top toolbar by default (#7486) 2020-01-09 09:15:02 -08:00
Severin Rudie
b23ee38082 For #7556: fix intermittent failure in BookmarkNodeTest 2020-01-09 16:54:50 +02:00
Mugurell
6d44ceceda For #6836 - Limit Leanplum depending on current locale. 2020-01-09 13:02:21 +02:00
Josh Vocal
9f30a7e6eb Replace fixed dp with defined dp dimension 2020-01-08 20:17:22 -08:00
Josh Vocal
9449cb4437 Fix truncated tracking protection info text 
* Allow tracking protection titles to wrap instead of being cut off
* Refactor view ids to match the layout
 2020-01-08 20:17:22 -08:00
Sebastian Kaspari
e3408b12b4 Update Mozilla Android Components to 28.0.0-SNAPSHOT. 2020-01-08 18:57:31 -05:00
Kaaira Gupta
109c13a126 Closes #7414 : changed AboutHeaderContentText color to primarytext color and removed futile code of aboutText color 2020-01-08 16:46:18 -07:00
Mihai Adrian
95d4de416d For #5722 Set adjustViewBounds to true to maintain original icon aspect (#7518) 2020-01-08 14:03:48 -08:00
Rushab Kumar
e6791b5c08 For #7154 - Fix crash when tapping on "Blocked" in the site info panel (#7404) 2020-01-08 13:51:45 -08:00
Mozilla L10n Automation Bot
1e00b88e78 Import l10n. 2020-01-08 14:43:07 -07:00
mcarare
2bdde48986 For #7522 Ensure correct protocol is used in search string 2020-01-08 11:13:49 -08:00
mcarare
3ff7d4af4d For #7313 Set actionBar background color according to mocks. 2020-01-08 12:12:30 -07:00
Severin Rudie
569b7670d3 For 6832: update implementation/comment to align w existing AC code 2020-01-08 12:04:14 -07:00
Severin Rudie
65f5ff6b36 For #6832: fix unattached context crash in HomeFragment 2020-01-08 12:04:14 -07:00
mcarare
b115a00589 For #7155 Align custom tabs overflow menu to original mocks 
Reverse menu items order when toolbar position is top
 2020-01-08 11:50:17 -07:00
mcarare
6aa8c98e00 For #7519 Navigate up from search fragment to handle all entry points 2020-01-08 11:49:17 -07:00
mawen7
a2e0af3194 Only close tab on back press if it has a parent tab 2020-01-08 11:33:49 -07:00
kglazko
8ed14ac062
Issue 5736 Improve pop behavior after deleting tabs in settings (#7478) 2020-01-08 10:27:14 -08:00
Emily Kager
7d613b72ae For #7181 - Adjust ETP onboarding for toolbar positions 2020-01-08 11:06:38 -07:00
Josh Vocal
31da69a311 For #7282 - Add more visibility to Turn On Sync card (#7284) 
* Change background of card to make elevation more visible
* Change icon white fill to become transparent
 2020-01-08 10:26:48 -05:00
Will Hawkins
9c28cb632c Issue #7425 (et al): Cache the list of installed browsers 
Cache the list of installed browsers. Calling `Browsers.all`
the application directly redundantly recalculates the list.
Accessing the list of installed browsers through this cache
will reduce that overhead.
 2020-01-07 18:40:07 -08:00
Mugurell
8454f208af For #4977: Migrate fennec shortcuts (#7251) 
* For #4977 - Support opening Fennec pinned website shortcuts in Fenix

Fennec's pinned website shortcuts are set to open the BrowserApp activity.
So we need a new activity alias to actually catch such Intents. Otherwise they
would open "org.mozilla.firefox/.App" without any way to inform that this is
the result of the user clicking on a pinned shortcut.
For actually checking if the newly received Intent is of a Fennec pinned
shortcut we introduce a new FennecBookmarkShortcutsIntentProcessor which will
prepare the Intent to open the shortcut's URL in a new tab.

* For #4977 - Don't keep IntentReceiverActivity on the back stack

For successive Fennec pinned shortcuts to create a new IntentReceiverActivity
and be processed as normal we need to not keep this as our task root.

* For #4977 - Test the FennecBookmarkShortcutsIntentProcessor
 2020-01-07 09:07:51 -08:00
Jeff Boek
fdb1f505cc For #5552 - Reverts temporary fix for #5552 2020-01-07 12:24:20 +02:00
Tiger Oakes
75b87334fa
Change type for OnboardingAutomaticSignIn (#7474) 2020-01-06 14:25:52 -08:00
Michael Comella
4bab493487 No issue: remove useless @MenuRes annotation in History Fragment. 
This annotation was not applied correctly and lint was unable to ensure
it was used properly: it declared an error in lint saying so but that
error was ignored. I did not know how to apply the annotation - and I
felt it had limited utility - so I removed it entirely in order to
permit the lint baseline file to be removed (it was the only error).
 2020-01-06 18:27:51 +02:00
Michael Comella
c0f689a68d No issue: remove lint baseline file. 
This will enable folks to see the existing warnings.
 2020-01-06 18:27:51 +02:00
mcarare
8aa04c048e For #6851 Update text copy of option to add custom search engine 2020-01-06 14:32:02 +02:00
Mihai Branescu
ea2411a88b Feature/#220 language menu (#7070) 
* For #220
- Added advanced header + locale settings item in the settings fragment

* For #220
- Added locale selection page with lib state + handling of locale changes

* For #220
- Removed registering for locale changes in the manifest, allow system
to restart activity in that scenario

* For #220
- Added unit tests for locale settings page

* For #220: fixed an outdated unit test
ga-a

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2020-01-03 18:15:35 -08:00
Severin Rudie
9cbc3f7a4a
7410 remove rxjava (#7426) 
* For #7410: rewrite updateBookmarkFromObservableInput with coroutines

* For 7410: remove RxJava from project. :(

* For 7410: converted updateBookmarkFromTextChanges to Flow per review
 2020-01-03 14:37:12 -08:00
mozilla-l10n-automation-bot
ab4f4bd4d8 Import l10n. (#7476) 2020-01-03 14:59:08 -05:00
Jonathan Almeida
0768fde945 No issue: Use SendTabFeature and FxaPushSupportFeature 2020-01-03 10:20:53 -05:00
Sawyer Blatz
c7c4ad051a
For #6413: Adds more snackbar positioning logic (#7444) 
* For #6413: Adds more snackbar positioning logic

* Refactor
 2020-01-02 14:31:52 -08:00
Roger Yang
f6e286fd9c
Closes #7346: Enable dynamic app links in Fenix (#7361) 2020-01-02 13:08:11 -05:00
Michael Comella
93e677e11b No issue: remove unused Anko dependencies. 2019-12-31 10:46:39 -05:00
Sawyer Blatz
3fb060f682
For #6413: Fixes snackbar positionining for bottom toolbar (#7415) 
* For #6413: Fixes snackbar positionining for bottom toolbar

* For #6413: Cleans up snackbar usage
 2019-12-30 14:43:15 -08:00
Emma Malysz
13f73c2d2c
For issue 7192: move unsetOpenLinksInAPrivateTabIfNecessary off main thread. (#7246) 
Move method to Settings. There are two instances when we want to call this method: either
processing an intent, or within DefaultBrowserPreference
 2019-12-30 14:42:13 -08:00
Michael Comella
cf143489e1 For #6464: Replace use of BuildConfig.DEBUG with ReleaseChannel.channel.isDebug. 
This fixes performance issues where StrictMode would greatly slow down
startup in the forPerformanceTest variants.
 2019-12-30 10:31:33 -08:00
Michael Comella
ac97dd72b1 For #6464: Set "forPerformanceTest" to ReleaseChannel.FenixProduction. 
This fixes a perf measurement issue where Sentry would capture an event when
using the forPerformanceTest variants.
 2019-12-30 10:31:33 -08:00
Michael Comella
37bafda602 For #6464: Add ReleaseChannel test to document assumptions. 2019-12-30 10:31:33 -08:00
Michael Comella
f11ddf8038 For #6464: Add ReleaseChannel.isDebug. 2019-12-30 10:31:33 -08:00
Severin Rudie
f562c81fb2 For 5334: test NotificationSessionObserver 2019-12-30 11:40:07 +02:00
Severin Rudie
a8c47c8805 For #5334: disable notification for private custom tabs 2019-12-30 11:40:07 +02:00
Richard Pappalardo
a441f55d7a
Temp disable UI test verifyAboutFirefoxPreview (#7390) 2019-12-27 15:46:55 -08:00
Sawyer Blatz
9a693f6c11
For #7000: Fix inverted media telemetry (#7368) 2019-12-27 13:46:47 -08:00
Severin Rudie
26b7909214
For #7352: integrate highlightable browser menu changes (#7353) 
* For #7352: integrate highlightable browser menu changes

* For 7352: invalidate menu when reader mode availability changes

* For 7352: removed highlight from reader mode appearance per UX
 2019-12-27 12:15:21 -08:00
Kadeem M
e22d092f5d Added UI tests for the About Settings page (#6161) 2019-12-27 07:55:35 -08:00
isabelrios
491a198fae For #5074 - Add UI tests for logins and passwords setting menu (#7291) 
* For #5074 - Add UI tests for logins and passwords setting menu

* fix detekt failure

* remove old file

* fix scroll small screens

* fix reviewer comments
 2019-12-26 14:22:40 -08:00
Sawyer Blatz
faa4136685 For #7347: Fixes background of search field 2019-12-23 10:07:54 -08:00
Sawyer Blatz
4fd3eb53d1 For #6666: Adds back button to search screen 2019-12-23 10:07:02 -08:00
Mihai Adrian
4fa6edc86e For #7122 Fix icons for saved logins screen (#7268) 2019-12-23 12:46:52 -05:00
Suraj Shah
6344a8892d For #7041 - Respect current mode when opening library items (#7311) 
* Fixes #7041
Consumes `browserMode` from home activity for tap method of bookmark

* Fixes spaces

* Cleaning tests

* Cleaning tests
 2019-12-23 12:26:47 -05:00
mozilla-l10n-automation-bot
a50d8552ac Import l10n. (#7009) 2019-12-20 14:01:18 -05:00
Roger Yang
dd1433733a
Closes #7156: Update app links feature usage to include app links interceptor (#7275) 2019-12-20 08:27:19 -05:00
Richard Pappalardo
f85961d9a9 Temp disable flaky UI testDownloadPrompt (#7304) 2019-12-20 10:31:43 +02:00
Josh
593981fa4b Fix parameterized message in search engine (#7302) 2019-12-20 10:27:05 +02:00
Jeff Boek
740572b6d9 For #5334 - Override custom tab styling in private mode (#7305) 2019-12-19 18:17:52 -08:00
Josh
a40af5b134 Closes #7254 - Replace Anko applyConstraintSet (#7286) 
* For #7254: Replace anko applyConstraintSet

* Anko has been deprecated and will not be continued

* Refactor ConstraintSet changes

* Replace applyConstraintSet in SearchLayouts

* Refactor HomeFragment ConstraintSet

* Define anonymous ConstraintSet
* Remove ConstraintSet prefix from PARENT_ID
 2019-12-19 18:16:50 -08:00
Mihai Adrian
c5a142aa14 For #6992, for #6897, for #6889: Disable multitouch in app (#6999) 2019-12-19 19:32:47 -05:00
Tiger Oakes
b85673acac Clean up settings fragments 2019-12-19 14:29:28 -08:00
Josh Vocal
43354489a1 For #7253 - Replace anko setters 2019-12-19 13:42:50 -08:00
Jeffrey Starke
59a021f3a3 Consolidate duplicate mock initialization in intent processor tests. (#6374) 
* Consolidate duplicate code in intent processor tests

* Resolve ktlint errors
 2019-12-19 12:33:59 -05:00
Mihai Adrian
33ac75d166 For #3574 Allow all screen readers to read onboarding items one-by one (#7292) 2019-12-19 09:53:53 -05:00
Tiger Oakes
76c83ba805
For #7085 - Remove anko px2dip (#7252) 2019-12-19 00:05:51 -08:00
Tiger Oakes
7c9a5c1f14
For #768 - Add PWA install option to menu (#6882) 2019-12-18 23:59:30 -08:00
mcarare
907d96e39f For #6709, for #6849 Handle default engine deletion and undo operation 
Uninstall engine immediately and allow reinstall in onCancel.
Set previous list with default engine in onCancel.
Keep default engine change in operation and remove now unnecessary view refresh.
 2019-12-18 23:00:42 -08:00
Tiger Oakes
f439c8110e For #7183 - Fix bottom margin in PWAs 2019-12-18 22:57:54 -08:00
Rushab Kumar
562eb89356 For #7250 - Replace anko.dimen 2019-12-18 15:39:14 -08:00
Sebastian Kaspari
e789d8ebe3 Issue #4978: Reuse widget package name of Fennec. 2019-12-18 15:23:43 -08:00
Emily Kager
5ac79f59a3 For #7219 - Polish Download Notification Dialog. (#7224) 
* For #7219 - Use accent color for downloads dialog positive button

* For #7219 - Fixes gap beneath download notification dialog

* switch to setimageresource
 2019-12-18 12:26:41 -05:00
Roger Yang
1a739db5b1 Closes #7260: Pass in GeckoView version information to MozillaSocorroservice 2019-12-18 10:45:57 +01:00
Grisha Kruglov
52334f9121 Closes #6937: Disable runStorageMaintenance during startup 
This call will acquire a "write" lock at the storage layer (sqlite's reserved+),
which may interfere with migrations that run during startup as well (they need to
write to storage, and so also need to acquire a lock). If these operations clash,
we get a SQLITE_BUSY crash. For now, just disable the maintenance operation.
 2019-12-17 14:24:30 -08:00
Tiger Oakes
ea486d7c66
Split out CustomTabToolbarIntegration (#7107) 2019-12-17 12:26:46 -08:00
David Walsh
b4e10965b7 Use localized strings in the quick settings panel (#7249) 2019-12-17 10:47:21 -08:00
Colin Lee
c0b9ad77be
For #4064: Update R8/ProGuard config for new Kotlin coroutines library (#7218) 2019-12-17 10:41:54 -06:00
Sebastian Kaspari
16b4680c06 Closes #4976: Use dynamic launcher entry in manifest. 2019-12-17 16:00:15 +01:00
Suraj Shah
6cb3879caf For #7048: Network info migration (#7091) 
* Fixes #7048.
Adds extension function to check if online or not based on capabilities
Modified `buildDeviceList`
Modifies tests

* Fixing lint error for max length
Fixing test in AppRequestInterceptorTest.kt

* Adds suppression for deprecation
Moving away from using anko for ConnectivityManager instance

* Creates ConnectivityManager extension component

* Fixes #7180
Refactors test cases to fix static mocks
 2019-12-16 22:03:11 -08:00
David Walsh
e727ae5d7e Fix 5366 - Use VectorDrawableCompat for all imagery (#7221) 
* Fix 5366 - Use VectorDrawableCompat for all imagery

* Fix detekt lint issues

* Restore previous comment contents
 2019-12-16 20:35:36 -08:00
Severin Rudie
cd53e9778a For 6795: expands toolbar whenever a new session is selected 
This ensures that the bar is expanded when opening a link in a new tab
 2019-12-16 14:09:29 -08:00
Jeff Boek
49f07554e7 No Issue - Removes some search engines 2019-12-16 14:09:14 -08:00
mcarare
90c77519a6 For #7194 Set snackbar anchor depending on browser toolbar position 2019-12-16 12:21:54 -08:00
Aaron Train
757c9577e0
No issue: Fixes breakage with unused import in 4a2cb91 (#7205) 2019-12-16 11:55:44 -05:00
Aaron Train
4a2cb91ad9
For #6697: Add Tracking Protection UI Tests (#6825) 
Add tests for verifying basic UI functionality of Enhanced Tracking Protection
 2019-12-16 10:12:43 -05:00
Patrick Martin
71880705df For #5711 - Onboarding colours have contrast issues 2019-12-13 17:52:55 -08:00
Afzal Najam
b9656a978e Hide add folder option when in Desktop Bookmarks folder 2019-12-13 17:51:15 -08:00
Ryan Kelly
31f2e80ab0 Use feature-accounts-push, which replaces feature-sendtab. 2019-12-13 16:42:28 -08:00
mcarare
bc6b7725e9 For #6968 Close response stream to allow use of caching 2019-12-13 12:35:25 -08:00
mcarare
d2abac78eb For #7075 Update passwords preference visibility and string 
Set visibility for feature flags before settings screen it's displayed.
Change string for preference to match existing header string.
Update UI Tests
 2019-12-13 12:19:14 -08:00
mcarare
ef53e1ff8e Reverts #6925: Make home screen full screen 2019-12-13 11:29:53 -08:00
Colin Lee
a8f895cb5c
For #4064: Replace prerelease R8 with improved Kotlin coroutines library (#7153) 2019-12-13 13:29:27 -06:00
Will Hawkins
116f7b3d65 No Issue: Create a method to "finish onboarding" in CI 
If the intent that starts the HomeActivity includes an extra
boolean flag named finishonboarding and it is set to true,
Fenix will "finish onboarding".
 2019-12-13 11:28:57 -08:00
Emily Kager
686facffc6 For #6946 - Get engine margins without assuming top/bottom toolbar 2019-12-13 11:09:30 -08:00
Emily Kager
dcb39b0a44 For #7124 - Match toolbar location for ETP/security panel gravity 2019-12-13 11:09:30 -08:00
Vlad Filippov
a3f2f55548 Closes #5913: Add new sessionToken scope (#6155) 2019-12-12 12:00:20 -08:00
Emily Kager
558f90da00 No issue: Scroll to remote debugging text in UI Tests (#7117) 2019-12-12 12:00:02 -08:00
Tiger Oakes
32985af882 For #6830 - Fix "Open in" text size for custom tab (#7010) 2019-12-12 11:49:54 +02:00
ValentinTimisica
8b8f3d1b56 For #4776: Refactored UI tests. 
After removing the 'Privacy notice' and 'Help' items from the Settings screen
the UI tests for them became unneeded.
 2019-12-12 11:34:10 +02:00
ValentinTimisica
b819cb11c9 For #4776: Added Unit tests for About Page. 2019-12-12 11:34:10 +02:00
ValentinTimisica
c6c827f693 For #4776: Redesign and refactor the About Page 
Added new items to be displayed.
 2019-12-12 11:34:10 +02:00
Grisha Kruglov
72d8dfb976 Enable Fennec settings (telemetry) migration 2019-12-11 19:16:55 -08:00
mcarare
1c9c8f590a For #7066 Increase space below checkbox preference 2019-12-11 11:23:14 -08:00
Mihai Adrian
bfc65e0614 For #6710 Update custom search engine images with better resolution (#7084) 2019-12-11 16:09:32 +02:00
Sawyer Blatz
de6469e198 For #7073: Makes logo on about page not important for accessibi… (#7074) 2019-12-10 12:15:11 -08:00
Mihai Branescu
c46bf84ac9 For #6330 Collections Numbering (#6453) 
* For #6330 - Added logic for getting the recommended default collection name

* For #6330 - Added unit test for default collection number method
 2019-12-10 12:10:01 -08:00
Tiger Oakes
fe034226a3
For #5783 - Web Share with Fenix share sheet (#6883) 2019-12-10 10:57:06 -08:00
Mihai Adrian
6e9769a81b For #7031 - Hide progress bar when leaving DeleteBrowsingDataFragment (#7056) 2019-12-10 11:17:45 -05:00
isabelrios
1d04736884 Re-enable Screenshots tests (#6617) 
disabling setting test options due to different screen sizes

name screenshots according to robots

fix kotlin style

update settings tests with new Toolbar option

screenshots tests in different package than ui tests
 2019-12-10 13:05:47 +02:00
Sebastian Kaspari
a83717dd7b Run migration in background service. 
In order to avoid a half done migration we are moving the migration to a background service (that is
running in the "foreground").

This is the Fenix part of:
https://github.com/mozilla-mobile/android-components/issues/4879
 2019-12-10 11:31:32 +01:00
Tiger Oakes
3f7205e3cb
Extract IntentProcessorType to its own file and add tests (#7012) 2019-12-10 00:02:23 -08:00
Severin Rudie
7477de83e9 For #4844: fix file prefix url shortening 2019-12-10 05:07:53 +01:00
Severin Rudie
957ed8aa88 For #5334: fix ETP shield coloring on custom private tabs 2019-12-10 03:22:55 +01:00
Mihai Adrian
45ae8cb35a For #6997 Avoid overwriting empty_search_string error (#6998) 
Setting error twice also clips error message
 2019-12-09 18:10:24 -08:00
Emily Kager
76e9200304 For #6922 - Check current destination is logins fragment before navigation (#6924) 2019-12-09 15:42:40 -08:00
Michael Comella
2a4aa24195 For perf-frontend-issues#33: Clarify VERBOSE logging motivation. 2019-12-09 15:11:52 -08:00
Michael Comella
eef080a46c For perf-frontend-issues#33: Add HotStartPerformanceMonitorTest. 
We really don't want our startup tests to subtlely change so I thought
it was worth writing some quick tests.
 2019-12-09 15:11:52 -08:00
Michael Comella
e60141e98d For perf-frontend-issues#33: Add HotStartPerformanceMonitor. 
As mentioned in the class comment, we could use an alternative
implementation to measure perf from outside the application however
it's more complicated to set up and less consistent with our cold
startup methodology so we'll start with this.
 2019-12-09 15:11:52 -08:00
ekager
1647e07481 For #5771 - Don't force landscape mode on fullscreen 2019-12-09 23:47:57 +01:00
mcarare
b6ba1a1611 For #4107 Make home screen fullscreen. 
Add/Remove fullscreen flags in home fragment's onResume / onPause
Change homeLayout padding to include system bars height (status&navigation).
Change homeMenu orientation to UP to properly display menu.
Change home bottomBar background to transparent.
 2019-12-09 23:45:02 +01:00
mcarare
17731620e6 For #7026 Dispatch ModeChange on hideOnboarding 2019-12-09 23:44:33 +01:00
ekager
e6d4c5b417 No issue: Remove unnecessary back slashes from curly apostrophe strings 2019-12-09 23:16:00 +01:00
Grisha Kruglov
42d6915699 Fennec migration: enable logins migration 2019-12-09 13:35:22 -08:00
Jeff Boek
45c6e3a784 For #1607 - Passes "custom" as the search engine identifier for custom engines 2019-12-09 11:47:05 -08:00
Severin Rudie
dfea877fb7 No issue: small installedSearchEngineIdentifiers readability refactor 2019-12-09 10:58:19 -08:00
Severin Rudie
2aa80eff95 No issue: tests installedSearchEngineIdentifiers 2019-12-09 10:58:19 -08:00
Severin Rudie
d3ff98816d No issue: begin moving FenixSearchEngineProvider into a testing harness 2019-12-09 10:58:19 -08:00
Oana Horvath
46439930c0
Fixed flaky History UI tests by adding an extra verification step that (#6894) 
the page is loaded.

Enabled all tests
 2019-12-09 11:52:55 +02:00
Aaron Train
e1fd53c718
Closes #6873: Support many more Content-Type in MockWebServer (UI tests) (#7001) 
Ensure our MockResponse can handle different Content-Type e.g, images, to help support other tests
 2019-12-06 14:53:18 -05:00
Severin Rudie
5f393bd5d4
For #5334: added private custom tab processor (#6845) 
* For #5334: added private custom tab processor

* For #5334 - Fixes up IntentReceiverActivity for handling intents

* For 5334: update styling for private custom tabbs

* For 5334: update tests to account for new processors

Note that two are still failing. These appear to be true failures, and will be corrected in a later commit.

* For 5334: fixes bug introduced by changes to IntentReceiverActivity

RCA: intent className and extra were previously set based on which processors matched, not which successfully processed. This patch reintroduces that behavior.

* For 5334: add tests for custom tabs processing
 2019-12-06 10:57:54 -08:00
Jeff Boek
4fb26a0601 For #4664 - Updates search_with string. (#6909) 2019-12-06 10:36:19 -08:00
Mozilla L10n Automation Bot
9feb0480bf Import l10n. 2019-12-06 08:53:22 -08:00
kglazko
300d8317e1
Issue 5366 Vector Drawable Compat (#6904) 2019-12-05 19:54:32 -08:00
Richard Pappalardo
2225b7154a
Disable flaky testDownloadNotification - API28 (#6982) 2019-12-05 18:00:21 -08:00
Mihai Adrian
6998fc1cf8 Temporarily fix lint issues with bad translation of string (#6963) 2019-12-05 13:57:57 -08:00
mcarare
45b9ffd66e For #6917 Emit mode change only when new mode is different from current 2019-12-05 11:10:14 -08:00
Mihai Adrian
3283d6ed0b For #6910 Align shortcuts in private onboarding panel style to… (#6950) 
Divider only shows when both panel and "Search with" are visible
 2019-12-05 09:37:20 -08:00
Mihai Adrian
cbdf83c12a For #6943 Hide supportActionBar in onResume, not onCreate (#6978) 2019-12-05 09:36:39 -08:00
Mozilla L10n Automation Bot
561ec5088b Import l10n. 2019-12-04 19:59:25 -08:00
Gabriel
56b21426eb
For #5574 - Migrate SessionControl to LibState (#6651) 
* For #5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (#6651)

- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.

* For #5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (#6651)

In #2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.

* For #5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (#6651)

* For #5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (#6651)

- Removes TabAction

* For #5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 15: Introduce a HomeFragmentStore (#6651)

- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.

* For #5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (#6651)

- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.

* For #5574 - Part 20: Remove the architecture module. (#6651)

* For #5574 - Part 17:  Remove duplicate subscribeToTabCollections in BrowserFragment.kt (#6651)

There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.

* For #5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (#6651)

* For #5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (#6651)

- Renames SessionControlUIView to SessionControlView

* For #5574 - Part 21: Fix white screen on home fragment (#6651)

* For #5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (#6651)

* For #5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (#6651)

This ensures that the metrics.track will be called immediately before the tab is removed from the collection.

* For #5574 - Part 24: Use the sessionManager getter in SessionControlController (#6651)

* For #5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (#6651)

* For #5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (#6651)

* For #5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (#6651)

* For #5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (#6651)

* For #5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (#6651)

* For #5574 - Removes running CI against the architecture debug build varient
 2019-12-04 22:06:05 -05:00
Jeff Boek
d4e3a2037f For #6855 - Filter out duplicated bundled search engines 
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2019-12-04 17:10:02 -08:00
mcarare
c3389dcdb5 For #6070 Adds telemetry for enabling search suggestions in private 2019-12-04 16:44:01 -08:00
Jeff Boek
781b141bc7 For #6849 - Properly select a new default search engine when you delete the current one 
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2019-12-04 16:10:26 -08:00
Jeff Boek
eb6e6b774f For #6848 - Sorts the search engine list without case sensitivity 
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2019-12-04 16:10:26 -08:00
Jeff Boek
1cc496a683 For #6847 - Properly rebuilds the SearchEngineList on undo 
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2019-12-04 16:10:26 -08:00
Emily Kager
d1b134c2ff For #6908 - Set null anchors for snackbars with top toolbar (#6911) 2019-12-04 15:01:04 -08:00
Jeff Boek
e8972bb47d For #6795 - Auto shows toolbar when loading a new URL (#6955) 
Co-authored-by: Severin <Baron-Severin@users.noreply.github.com>
 2019-12-04 15:00:51 -08:00
Sebastian Kaspari
aa49ab1dfb Closes #4976: Reuse Fennec launcher entry in manifest. 
With this patch Fennec users, who upgrade to Fenix, will not lose Firefox launcher icons they
have added to their home screen.

A side effect of this change is that the launcher entry for existing Fenix users may disappear
from the home screen for existing Firefox Preview users and they will have to re-add it.
Since the Preview audience is more accepting of breaking changes and since that group is
way smaller than the millions of Fennec users, I think that this is an acceptable breaking
change. I looked into supporting multiple launcher entries in parallel, but that got quite
complex with multiple build types and multiple manifest files. Especially if we decide
to keep a Firefox Preview build around (e.g. org.mozilla.fenix) then it would be good to
unify on a single launcher and do that as early as possible.
 2019-12-04 12:51:48 -08:00
Oana Horvath
85dd56e12d
Added multi-selection tests for bookmarks (#6475) 
Updated bookmarking method

Fixed flaky tests

Added wait to create bookmark
 2019-12-03 12:44:54 +02:00
mawen7
7208ce95a5 Run lint for app module and set baseline 2019-12-02 14:45:34 -08:00
Aaron Train
35f136b14b
Closes #6363 - Add Downloads UI tests (#6574) 
- Initiates a download
- Verifies prompt
- Verifies notification in notification shade
 2019-12-02 17:15:00 -05:00
ekager
3df32edff0 No issue: Fix search suggestions strings 2019-12-02 21:39:10 +00:00
ekager
f227acc9f0 For #6791 - Inflate SavedLoginsListItemViewHolder layout explicitly 2019-12-02 10:40:58 -08:00
ekager
d8babadf7f For #6889 - Check current destination before navigating from settings 2019-12-02 10:40:21 -08:00
ekager
f5cf0b7e2a For #6890 - Don't crash with no connection when adding custom search engine 2019-12-02 10:37:31 -08:00
Severin Rudie
2a95a82e32
For #5540: updates error page copy when no internet is available (#6803) 2019-12-02 10:26:06 -08:00
cesar
63cf034bfb test fixed 2019-12-02 16:18:48 +00:00
cesar
6cda430cdd nested loop removed 2019-12-02 16:18:48 +00:00
cesar
5b86c403b0 klint clean up and previous nit fixed 2019-12-02 16:18:48 +00:00
cesar
4422e3ed39 Closes #6731 - fixed BookmarkNode minus operator and deleteOperation 2019-12-02 16:18:48 +00:00
cesar
d955eae4e2 Test for 6731 2019-12-02 16:18:48 +00:00
mcarare
05321dc504 For #6835 Align Home and Browser toolbar elements to perfectly overlap 2019-12-02 16:17:07 +00:00
mcarare
8257b145ad For #6401 Set false as default value for Open links in a private tab 2019-12-02 16:16:26 +00:00
mcarare
41ccb02933 For #6516 On browsing mode change empty tab list before displaying new list 2019-12-02 16:15:54 +00:00
Tiger Oakes
a16aedb680 For #6827, #6811 - Cast layoutParams to MarginLayoutParams 2019-12-02 14:52:31 +00:00
mcarare
22879b533e For #6881 Choose visible view when multiple views have same label text 2019-12-02 14:02:51 +00:00
Oana Horvath
715a79de71 Disable UI history tests again for more investigation (#6837) 2019-12-01 19:53:55 -05:00
Tiger Oakes
d5e01384d8
Suppress upcoming deprecation (#6765) 2019-11-28 16:17:56 -08:00
Gabriel Luong
85111f538a For #6857 - Replace BackHandler with UserInteractionHandler in InflationAwareFeature and InflationAwareFeatureTest 2019-11-28 15:58:07 -05:00
Jeff Boek
1b1f9348dc No Issue - Fixes warnings / compiler errors with A-C update 2019-11-28 12:45:45 +01:00
mcarare
c5f18e0f96 For #6629 Align Private Browsing mode to UX specs 2019-11-27 11:13:20 -08:00
ekager
7cd1d55e00 For #5586 - Track all login copy events 2019-11-27 10:59:36 -08:00
Mozilla L10n Automation Bot
a1376ebade Import l10n. 2019-11-27 10:52:38 -08:00
Will Hawkins
a69253cf22 Issue #5183: Initialize megazord asynchronously 
Thanks to the work of the team at application-services, it is possible
to asynchronously initialize the Http client and logger used by megazord
Use that power to hide the time necessary to complete this initialization
within the time that it takes to warmup the gecko runtime.
 2019-11-27 10:51:57 -08:00
cesar
9127505cc9 For #6769 - EditText moved to be above the gradient view 2019-11-27 10:48:38 -08:00
Sebastian Kaspari
bb59ac6423 Issue #6622, #6688: Create a "fennecBeta" and "fennecNightly" build types. 2019-11-27 10:28:22 -08:00
mcarare
f69eb83141 For #4219 Set url view not important for accessibility 
Talkback rectangle for url view selection will include parent view
 2019-11-27 10:11:16 -08:00
mcarare
bf20275a1a For #6470 Change notification icon 
Used private browsing icon with compulsory white color for notifications
 2019-11-27 10:08:00 -08:00
mcarare
373bd63c40 For #6470 Remove actions from notification, keep just close private tabs 
Removed NotificationsIntentProcessor because notifications no longer open app
Added new strings
 2019-11-27 10:08:00 -08:00
Mihai Branescu
7cf71c8ef3
For #6396 - Added metrics for tracking history/bookmarks account sync toggles (#6601) 2019-11-27 11:16:23 +02:00
Mihai Adrian
cc216d0a6f
For #6748 Move Add search engine to search engine preference category. (#6749) 2019-11-27 10:45:05 +02:00
Mihai Adrian
4fd3aa8649
For #2570: Hide 3-dots menu for all library items when in select mode. (#6736) 
notifyDataSetChanged to avoid not displayed but created items not being redrawn
 2019-11-27 10:40:38 +02:00
Mihai Adrian
531f7e7a67
For #5497 Align text to viewStart to keep consistency in RTL (#6778) 2019-11-27 10:35:49 +02:00
Jeff Boek
5f7b3bd4d7
For #5972 - Fixes bugs when launching in private mode on Android 5 (#6702) 2019-11-26 14:53:03 -08:00
Sawyer Blatz
db02fc6ef8
For #6821: Fixes issues with custom tabs and dynamic toolbar (#6822) 2019-11-26 13:02:52 -08:00
Mihai Adrian
33b49ff7fd For #6430 Private browsing hint width should not exceed screen dimensions (#6786) 
Renamed ambiguous pop-up window name.
Adjusted code to match max line length.
 2019-11-26 10:07:31 -08:00
Sawyer Blatz
769c1e422d For #5694 & #6054: Allows users to change toolbar position (#6608) 
* For #5694 & #6054: Adds preference screen for toolbar

* For #5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For #6054: Adds toolbar position to core ping
 2019-11-25 16:43:32 -08:00
Tiger Oakes
422faaf7c0 Add toolbar helpers (#6531) 2019-11-25 15:36:47 -05:00
Tiger Oakes
7e8f079269
Use ShareData with ShareFragment (#6698) 2019-11-25 11:07:21 -08:00
Christian Sadilek
8271f0f55a Fix for A-C 23.0.0: onDownloadCompleted renamed to onDownloadStopped 2019-11-23 20:25:21 -05:00
Tiger Oakes
cd3e077bc9 For #6763 - Fix early view access 2019-11-23 10:55:29 -05:00
Daphne Liu
4cfbaf2dc4 Switched to AC string extensions (#6258) 
* Switched to AC string extensions

* Clean up imports
 2019-11-22 23:15:51 -08:00
ekager
77334b6108 For #6628 - Remove required for biometric manifest 2019-11-22 14:17:26 -08:00
ekager
45071d6fc1 For #6573 - Fixes anchor view for tab switching snackbar 2019-11-22 14:15:17 -08:00
Sawyer Blatz
bcf80d0e0b
For #6436: Adds snackbar for failed download (#6648) 2019-11-22 12:46:57 -08:00
Mozilla L10n Automation Bot
5cc1ea951c Import l10n. 2019-11-22 11:14:22 -08:00
David Walsh
bc56ae194a Fix 6048 - Improve alignment in Edit Bookmark screen 2019-11-22 10:14:00 -08:00
Tiger Oakes
a5e9439c6e Clean up tracking protection fragment (#6532) 
* Clean up exceptions fragment

* Clean up tracking protection fragment

* Move saved logins to list adapter
 2019-11-22 10:38:13 -05:00
Sebastian Kaspari
8a330d413c Closes #4982: Migrate Gecko files before initializing engine. (#6738) 2019-11-22 08:18:50 -05:00
Mozilla L10n Automation Bot
c5d496a35d Import l10n. 2019-11-22 14:00:39 +01:00
Stephen Tsimicalis
9869408fb4 For #4824 - Fixes onboarding telemetry events from being sent a… (#6659) 2019-11-21 17:51:55 -08:00
Mozilla L10n Automation Bot
f6cc5b9387 Import l10n. 2019-11-21 16:45:05 -08:00
Pawel Obarzanek
667602f02a Closes mozilla-mobile#5458 Tests for IntentReceiverActivity to verify outcoming intent (#6130) 2019-11-21 16:44:08 -08:00
Pawel Obarzanek
ee0ec6a8f8 Closes mozilla-mobile#4828 Initial tests for FragmentPreDrawMan… (#6134) 
* Closes mozilla-mobile#4828 Initial tests for FragmentPreDrawManager

* Closes mozilla-mobile#4828 verify if addOnPreDrawListener was called
 2019-11-21 16:23:59 -08:00
Mihai Adrian
e07d09afb8 Update app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt 
Co-Authored-By: Tiger Oakes <contact@tigeroakes.com>
 2019-11-21 15:34:01 -08:00
mcarare
9258df2c69 For #3523 Add Firefox Sync error states also to Settings in Home menu 2019-11-21 15:34:01 -08:00
isabelrios
3fc263d547 fix reviewer comments 2019-11-21 15:32:26 -08:00
isabelrios
6b7f89433a For #6322 - UI tests for Account Settings View 
removing sleeps

fix ktlint errors
 2019-11-21 15:32:26 -08:00
Matt McKenna
c71fa11d45 Add Mozilla licensing header to gradient 2019-11-21 15:27:50 -08:00
Matt McKenna
d1f70e908e Add a simple gradient to collection creation 2019-11-21 15:27:50 -08:00
matthewcmckenna
afac413c98 Add ETP accessibility labels 2019-11-21 15:27:35 -08:00
Tiger Oakes
0a86676563 For #6523 - Remove close button in library 2019-11-21 15:27:18 -08:00
Patrick Martin
3e436f59e2 For #2294 - History URL is cut with a large font set (#6724) 
* For #2294 - History URL is cut with a large font se

* Update HistoryRobot.kt
 2019-11-21 15:05:59 -08:00
mcarare
f18c047132 For #1019 Update unit tests and UI tests 2019-11-21 14:36:14 -08:00
mcarare
1d36098878 For #1019 Add onboarding search suggestion hint panel 2019-11-21 14:36:14 -08:00
mcarare
5543f3272d For #1019 Add option to enable search suggestions in private mode 2019-11-21 14:36:14 -08:00
mcarare
ef3c3de8a1 For #6625 Fix back navigation in search mode from browser 2019-11-21 14:35:12 -08:00
Tiger Oakes
bd475d54e5 Extract TP onboarding popup (#6700) 2019-11-21 17:23:35 -05:00
Arturo Mejia
0d6ea08de7
No issue: Remove download file provider. (#6699) 2019-11-21 14:31:03 -05:00
Johan Lorenzo
de8bc2f8a5 Split UI test 2019-11-21 11:59:51 +01:00
Grisha Kruglov
f099552ae3 Enable encryption of persisted FxA account state 2019-11-20 15:32:56 -08:00
Jeff Boek
54773afb68
For #2477 - Removes the feature flag for Force Enable Zoom (#6646) 
* For #2477 - Removes the feature flag for Force Enable Zoom

* For #2477 - Fixes bug where zoom preference doesnt persist between launches
 2019-11-20 10:32:38 -08:00
ekager
dba2186e86 Add scroll to item 2019-11-20 10:23:48 -08:00
ekager
81ab082c1c For #6707 #6708 - Fix UI Tests for new Search Engine Behavior 2019-11-20 10:23:48 -08:00
Jeff Boek
607c3d4c87
Adds custom search engines (#6551) 
* For #5577 - Adds button to add a new search engine

* For #5577 - Adds custom engine store

* For #5577 - Creates a custom SearchEngineProvider

* For #5577 - Gives the ability to delete search engines

* For #5577 - Adds the UI to add a custom search engine

* For #5577 - Adds form to create a custom search engine

* For #5577 - Adds the ability to add a custom search engine

*  For #5577 - Adds the ability to delete custom search engines

* For #5577 - Selects the first element on the add custom search engine screen

* For #5577 - Prevents adding a search engine that already exists

* For #5577 - Styles the add search engine preference

* For #5577 - Makes the name check case-insensitive

* For #5577 - Fix bug where home screen doesnt see new search engines

* For #5577 - Moves Search URL validation to its own type

* For #5577 - Fixes linting errors

* For #5577 - Adds the ability to edit a custom search engine

* For #5577 - Allows the user to edit a serach engine even when it is the last item in the list

* For #5577 - Adds an undo snackbar when deleting a search engine

* For #5577 - Moves all of the strings to be translated

* For #5577 - Fixes bug when deleting your default search engine

* For #5577 - Puts adding search engines behind a feature flag

* For #5577 - Navigate to custom search engine SUMO article when tapping learn more

* For #5577 - Fixes nits

* For #5577 - Uses concept-fetch to validate search string

* For #5577 - Adds string resources for the cannot reach error state
 2019-11-19 16:30:56 -08:00
Patrick Martin
8abf580579 For #2294 - History URL is cut with a large font se 2019-11-19 10:50:17 -08:00
Oana Horvath
c9e4303fa0
Fixed History flaky tests (#6592) 
Ignoring some tests for now and left some to run
 2019-11-19 11:29:35 +02:00
Mozilla L10n Automation Bot
ce74a49a22 Import l10n. 2019-11-18 23:08:32 -08:00
mawen7
1e813a9609 Jump to tab overview if closed tab has no parent session 2019-11-18 22:56:42 -08:00
cesar
984d8c7b13 ktlint clean up 2019-11-18 20:07:22 -08:00
cesar
808740e4c9 Fixed Typo 2019-11-18 20:07:22 -08:00
cesar
560fa7a5b5 For #6594 - Trigger keyboard automatically when creating a bookmark folder 2019-11-18 20:07:22 -08:00
cesar
d69ead201b Test for 6594 2019-11-18 20:07:22 -08:00
cesar
063115b215 For #6593 - Hide keyboard when quitting add bookmark folder flow 2019-11-18 20:07:22 -08:00
cesar
d9ded1f715 Test for 6593 2019-11-18 20:07:22 -08:00
ekager
ab93779369 For #6621 - Add Secure Flag to Window in Logins Fragments 2019-11-18 14:32:10 -08:00
Jeff Boek
871604f37d For #2271 - Fixes colors on dark theme 2019-11-18 14:23:54 -08:00
David Walsh
8016eb56aa Provide top padding to URL 2019-11-18 14:01:40 -08:00
David Walsh
6bd6e3035d Implement a more dynamic layout height 2019-11-18 14:01:40 -08:00
David Walsh
c69e72bdba Fix 3809 - Show entire URL in security info view 2019-11-18 14:01:40 -08:00
Mozilla L10n Automation Bot
ee7ea8cebf Import l10n. 2019-11-18 13:30:59 -08:00
Sawyer Blatz
6f4de48428 For #6434: Fixes downloadCompleted for paused downloads 2019-11-18 11:49:01 -08:00
Jeff Boek
77667bf724
No Issue - Fixes NPE in tests (#6673) 2019-11-18 11:29:49 -08:00
Roger Yang
f3fc532e0e Closes #6440 Integrate Web Notifications Feature 2019-11-18 13:44:39 -05:00
Jeff Boek
ac95510bb6
No Issue - Adds proguard rules for Lifecycle component (#6632) 
This is a potential fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1596302
 2019-11-15 17:10:38 -08:00
Mihai Adrian
55a200907a For #2570: Hide 3-dots menu for all library items when in select mode. (#6321) 
Used notifyItemRangeChanged to redraw already drawn items.
 2019-11-15 15:48:48 -08:00
Severin Rudie
8d68317388
4844 fix url elision (#6588) 
* For #4844: add test cases for url elision

* For 4844: implement toShortUrl to pass test cases

* For 4844: update plumbing to use toShortUrl

* For 4844: adds/handles suggested url elision test case
 2019-11-15 14:25:50 -08:00
Gabriel Luong
c6562bff98 For #5583 - Adds telemetry for download notification (#6554) 2019-11-15 16:50:11 -05:00
Patrick Martin
5eb5cdf361 For #1695 - Detect HTML mime type for clipboard URL (#6612) 
* For #1695 - Detect HTML mime type for clipboard URL
 2019-11-15 12:23:52 -08:00
MozLando
204ead0827 Merge #6513 
6513: For #5295 [A11y] Unable to tap snackbar r=kglazko a=kglazko



Co-authored-by: Kate Glazko <katglazko@gmail.com>
 2019-11-15 18:43:54 +00:00
Will Hawkins
7173bdf0b1 Issue #6196: Make initialization of Glean metrics faster 
setStartupMetrics is very expensive and does not need to be
done synchronously at the time the Glean Metrics Service is
initialized.
 2019-11-15 10:38:08 -05:00
Emily Kager
ddd484387d No issue: Check destination before popping logins fragments 2019-11-14 18:20:44 -08:00
Tiger Oakes
fdd7400ccc Use ViewModel for share fragment 2019-11-14 16:25:50 -08:00
Tiger Oakes
333ff8c941 Fixes #4528 - Prevent share menu from jumping 
Plus a bunch of docs and refactoring
 2019-11-14 16:25:50 -08:00