Michael Comella
3a77569d98
[fenix] No issue: remove performance codeowners.
2022-05-17 17:07:16 +00:00
Andrew Halberstadt
bc6d20094e
[fenix] No issue: remove 'mozilla-mobile/releng' as CODEOWNER of /automation and /.github
...
These directories are specific to Fenix. After a quick scan and chat
with Releng, we don't have knowledge / motivation to be maintainers
here.
Releng will continue to be CODEOWNERS of core taskcluster files though.
2022-02-24 20:20:22 +00:00
Michael Comella
94f2c824e5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19901 : add benchmark.gradle to CODEOWNERS.
2021-07-22 15:24:35 +00:00
Michael Comella
3d04b3dbf5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19436 : rm Application and FeatureFlags from perf code owners.
2021-05-10 15:58:33 -07:00
Michael Comella
159b13bb8f
[fenix] No issue: move TestStrictModeManager to perf sub package.
2020-11-13 16:07:59 -08:00
Michael Comella
4493b90366
[fenix] No issue: move relevant files in :mozilla-lint-rules to perf pkg.
2020-11-13 16:07:59 -08:00
Michael Comella
c8ec1542fe
[fenix] No issue: move relevant :mozilla-detekt-rules to perf/ pkg.
2020-11-13 16:07:59 -08:00
Michael Comella
1b6891dbc0
[fenix] No issue: perf code owner all /perf/ src dir.
...
Our previous strategy was to code owner all the specific files we should
own but that's fragile and unreasonable. This is simpler. We expect
there will still be edge cases that live outside these directories (e.g.
*Application*kt).
2020-11-13 16:07:59 -08:00
Michael Comella
39384786dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16376 : move Startup*Test to perf pkg under code owners.
...
Instead of listing many different files here, we should just put them in
/perf/ packages and code owner them.
2020-11-13 15:39:06 -08:00
MarcLeclair
78850c7e3d
[fenix] 15278 detekt rule runblocking ( https://github.com/mozilla-mobile/fenix/pull/15942 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added CoroutineManager to count runBlocking calls
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added actual detekt rule for runblocking and its config to the yaml
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added unit test for RunblockingCounter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test
* Lint fix
* For https://github.com/mozilla-mobile/fenix/issues/15278 : made runblocking a Long to prevent overflow
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed MozRunblocking name, description and moved RunBlockingCounter to perf package
* For https://github.com/mozilla-mobile/fenix/issues/15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added setup for unit test, since it failed without restting counter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Fixed naming for RunBlocking lint check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : removed changes made to test to use runBlockingIncrement
* For https://github.com/mozilla-mobile/fenix/issues/15728 : added test exclusion for runBlocking check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : changed null check and added Synchronized to count setter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fix for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added StartupExcessiveResourceUseTest to CODEOWNERS
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Moved increment function to extension function and fixed indentation
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added tests for Atomic Integer extension and nit fix
2020-11-02 12:49:17 -05:00
Michael Comella
ce90102a75
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : add ConstraintLayoutPerfDetectorTest to code owners.
2020-10-30 18:23:35 -07:00
Michael Comella
169a87a1fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : add new lint rule to CODE OWNERS.
2020-10-14 15:20:28 -07:00
Michael Comella
d253b9060e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add test to prevent increasing StrictMode suppression count.
2020-10-06 14:11:53 -07:00
Roger Yang
15cab56493
[fenix] Revert "No issue: remove * ac from codeowners." ( https://github.com/mozilla-mobile/fenix/pull/15638 )
...
This reverts commit 112510aab50b141f910de211e2363c6b81882431.
2020-10-02 13:08:15 -04:00
Michael Comella
1d7eaed3ba
[fenix] No issue: remove * ac from codeowners.
...
rocketsroger and I agreed this may be undesireable due to the increased
notifications. If we remove it and someone complains, we can re-add it.
2020-10-01 17:09:39 -07:00
Michael Comella
4ac309f013
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15273 : add warnings about codeowners; add perf team as CODEOWNERS owner.
2020-09-24 08:33:18 -07:00
Michael Comella
e78c0aad23
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15273 : fix suspected syntax errors in code owners.
...
I validated the paths used using a technique in this blog post:
http://www.benjaminoakes.com/git/2018/08/10/Testing-changes-to-GitHub-CODEOWNERS/
So the syntax error(s) are likely within the names, such as this
example.
2020-09-24 08:33:18 -07:00
Michael Comella
bc36b1ea02
[fenix] No issue: monitor performance via CODEOWNERS.
2020-08-26 15:48:54 -07:00
Johan Lorenzo
2d80b7ac11
[fenix] Add Releng and Fenix as code owners of taskcluster/, .taskcluster.yml, .cron.yml
2019-09-26 09:36:06 -07:00
Colin Lee
09aedb3c86
[fenix] Updated CODEOWNERS file to let A-C review Fenix PRs ( https://github.com/mozilla-mobile/fenix/pull/5013 )
2019-08-29 14:26:16 -05:00
Mitchell Hentges
147e137e62
[fenix] Ensures that fenix team is also notified of automation changes
2019-02-15 14:10:39 -08:00
Mitchell Hentges
53fbc72f32
[fenix] Changes global code owner to mozilla-mobile/fenix
2019-02-15 12:51:44 -08:00
Mitchell Hentges
1aef3e2272
[fenix] Sets up CODEOWNERS file
2019-02-15 12:51:44 -08:00
