10 Commits (1f633edd7d4436f20ead4ba657b1284b94cca0c6)

Author	SHA1	Message	Date
Grisha Kruglov	0b5b1a738a	Do less work while navigating Logins views ... Fetching a set of logins from the store is quite expensive. This commit avoids doing that while navigating back and forth between the list and detail views: - retain processes logins state when navigating into detail view - use the `get` storage api to obtain specific login, instead of `list().filter {...}` - avoid re-sorting retained logins when navigating back into the list view	3 years ago
Ben Dean-Kawamura	34ec442961	Updating Fenix to work with the new logins API ... Switched to always using `Login` instead of the `SavedPassword` alias. Made `MasterPasswordTipProvider.saveLogins()` call `importLoginsAsync()`. This is needed because it's the only method that inputs a `Login` rather than a `LoginEntry`. Moved the `SavedLoginsStorageController.kt.syncAndUpdateList` call to inside `add()` and `update()`. This simplifies the error handling a bit. Refactored dupe-checking code to use findLoginToUpdate() Refactored `AddLoginFragment` / `EditLoginFragment` to put the username error handling code all in 1 method. I think it's easier to follow the logic of showing/hiding the error labels when it's all in one place. This fixes issues #24103 and #24104. I would love to address #24102, but I'm not sure what the correct behavior is there so I just kept that the same.	3 years ago
Mugurell	cb32b1437e	For #17917 - Remove the `kotlin-android-extensions` plugin ... This means no code will be generated by Kotlin Android Extensions for caching views and also for @Parcelize annotated classes. As recommended in the official documentation https://developer.android.com/topic/libraries/view-binding/migration#gradle we need to switch on using `kotlinx.parcelize.Parcelize` instead of `import kotlinx.android.parcel.Parcelize` For #17917 - Remove the `kotlin-android-extensions` plugin This means no code will be generated by Kotlin Android Extensions for caching views and also for @Parcelize annotated classes. As recommended in the official documentation https://developer.android.com/topic/libraries/view-binding/migration#gradle we need to switch on using `kotlinx.parcelize.Parcelize` instead of `import kotlinx.android.parcel.Parcelize`	3 years ago
Tiger Oakes	acbad66f45	Add test for initial logins list state	4 years ago
Elise Richards	023a4983fa	For #10173: login duplicates and save (#11208) ... * Extract controller into it's own class. Implement find dupes and filter based on username. Create edit login controller. Add text watchers and check for duplicates. Edit controller test * Find duplicates and save to store * Retrieve duplicates from AC and check list on username text changed Move duplicates logic into the controller * Add glean pings for delete and edit. Move logic for login manipulation into the datastore. * Use correct threads in controller. Enable save button when applicable. Save enabled in datastore. Move login data to datastore Rebase with password error states Update metrics to be more specific for edit * Create logins controller for AC calls * Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation. Inflate view in edit fragment. Double layout showing up. Edit view Controller tests Controller tests passing Interactor tests Lint and detekt cleanup * Remove datastore and use storage controller for all logins calls to password storage. Addressed comments Lint : Rebase - 1	4 years ago
Mugurell	e1fc0cc038	Ensure logins deletion (#12507) ... * For #11227 - Cleanup saved logins list when one is selected Selecting a saved login will open a detail screen for it from where users can change details or even delete that particular login. After the change is made the user is brought back to the list of saved logins where for a brief moment (< 1s) until we get a new response from passwordsStorage.list() the user can see and even interact with the old list of items, which may still contain the just deleted one. To avoid users seeing obsolete logins or even interacting with them (selecting a previosuly deleted item will result in a crash) we will clean the list of logins just before the selected login is opened in the detailed view. When returning for a brief moment the users may see the "loading" UX until passwordsStorage.list() returns the up-to-date list of logins to display. * For #11227 - Refactor SavedLoginsView to be closer to MVI - Interactors should only get passed other Interactors or Controllers as dependencies to which they should delegate user actions. - Controllers should hold most of the business logic and get passed all final dependencies they need to do their job.	4 years ago
Tiger Oakes	294f29768d	Test logins settings	4 years ago
Elise Richards	137d66a511	For 10172: Set edit text listeners (#11196) ... * Set edit text listeners * Set clearable icons and change with error states * Clear text buttons show and hide * Move error checks to afterTextChanged. Refactor. Remove unused color.	4 years ago
ValentinTimisica	7974a5c77c	Fixes #10815: Sort login items on initial load	4 years ago
Elise Richards	edc75c3ad0	Fixes #9504: Edit logins (#9693) ... * Create editable view and fragment. Update login info page to display options menu with edit and delete. * Create feature flag for edit. Check flag in the login detail fragment and default to just delete. * Add three-dot kebab options menu in login detail fragment. Add title to the login item. * Nav to and from edit view on save and back pressed. * Save login through AC login manager. Clear text in editable field on button click. * Match colors, fonts, dimens to UX specs for edit logins. Enable password reveal/hide and clearing text fields. * Refactoring logins fragments. Using component Login object for consistency. Fetch login list when saved logins are opened. Fetch login details when detail view is opened. Revert "Fetch login list when saved logins are opened. Fetch login details when detail view is opened." This reverts commit 44fe17166c3332b330229258b2e8982832672e3b. * Using parcelable login and Login component class to pass ids and items between fragments * Retrieve login from storage when viewing login details. Rename login logic for consistency. Ktlint cleanup Fix nits and naming consistency. * UX consistency for login detail and edit login pages * Rebasing with logins sort - updating logins store. * Rebasing with logins sort - merging fragments and controllers. * Lint and removing unused files. * UX cleanup. * Update string description	4 years ago