Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-17 15:26:23 +00:00
Code Issues Releases Wiki Activity
5,005 Commits 67 Branches 116 Tags 1.2 GiB
1f004aff8c
Commit Graph

2935 Commits

Author SHA1 Message Date
ekager
bceb07a05b For #12312 - Disable settings that navigate while authenticating 2020-07-07 16:46:14 -04:00
Michael Comella
3e617245b5 For #12345: catch SecurityException when calling reportFullyDrawn. 
That's amazing! I've got the same combination on my luggage.
 2020-07-07 13:44:09 -07:00
Tiger Oakes
65637e9e2b
Use A-C version of Resources.getSpanned (#12358) 2020-07-07 13:36:29 -07:00
Mihai Eduard Badea
eeb8719fa1 For issue #12126 - Tab counter consumeFrom update 
Added a direct call to the updateTabCounter method to account for changes made to the BrowserState while the tabCounter view is not visible.
 2020-07-07 11:12:55 -04:00
Tiger Oakes
8e8e5aea36
Extract radio group logic into helper (#11493) 2020-07-06 17:09:42 -07:00
ValentinTimisica
e39d5b6de7 For #11763: Shows confirmation dialog when deleting last tab from collection 2020-07-06 17:06:10 -04:00
ValentinTimisica
c3acde438a For #11889: Changes collection creation confirmation snackbar strings 
Also I changed the adding tabs to collection confirmation string from
tabtray to take into account the number of tabs.
Example: 1 tab-"Tab saved!"; multiple tabs-"Tabs saved!"
 2020-07-06 17:02:02 -04:00
Tiger Oakes
1ab5fe3eb9
Add method to test fragments in roboletric (#12261) 2020-07-06 13:04:43 -07:00
Hakkı Kaan Çalışkan
331090d1e6 For #12007: Fix add search engine items using wrap content for height 2020-07-06 15:37:28 -04:00
MickeyMoz
da39a7e671 Update Android Components version to 49.0.20200705130154. 2020-07-06 15:21:40 -04:00
mcarare
94273bc274 For #12125: Handle visibility updates for add to collection button. 2020-07-06 14:37:39 -04:00
Tiger Oakes
fd18687ac9 Switch to any calls 2020-07-06 20:38:08 +03:00
Tiger Oakes
41452e945b Move SearchProviderModel extension to class 2020-07-06 20:38:08 +03:00
Mugurell
0fb6bbc175 For #10401 - Hide Shortcuts if just one search engine is installed 
Otherwise, the Shortcuts option which allows to choose with what search engines
to search would be redundant.
 2020-07-06 14:36:04 +03:00
Sebastian Kaspari
388c144a62 SearchFragmentStore: Remove Session reference from state and read values from BrowserStore. 2020-07-03 21:01:59 +02:00
ekager
f863c341e8 Updates AC to 49.0.20200702190156 and fixes breaking changes 2020-07-03 06:40:06 -04:00
ekager
8533d96ee2 For #11320 - Expose login autofill setting to beta dimension 2020-07-03 06:40:06 -04:00
liuche
6ec0aeb843
Issue #12207 - Update "new nightly" link to point to org.mozilla.fenix (#12209) 2020-07-02 12:39:44 -07:00
Sawyer Blatz
8583cac8f8 Revert "For #11183: Redirect user to homescreen after widget added" 
This reverts commit a8ed913654.
 2020-07-02 11:22:18 -07:00
Sawyer Blatz
3cbab45566 For #12157: Don't show two search widget dialogs 2020-07-02 11:22:18 -07:00
Mihai Adrian Carare
daecbd348b
For #11996: Open all links from add-on details in Fenix. (#12080) 
* For #11996: Open add-on homepage link in Fenix.

* For #11996: Open add-on details links in Fenix.
 2020-07-01 19:13:23 -07:00
Sawyer Blatz
306505fee0
No issue: Remove feature flag for tips (#12172) 2020-07-01 14:47:40 -07:00
Johan Lorenzo
4bc1cb94c5
Bug 1649400 - part 1: ship org.mozilla.fenix as a nightly product (#12127) 2020-07-01 11:03:10 +02:00
Jeff Boek
fb4822498f For #12081 - Properly installs searchengines when MLS completes 2020-06-30 13:35:08 -07:00
ekager
70f90e71e8 For #11991 - Show tab count during onboarding 2020-06-29 17:59:19 -04:00
Tiger Oakes
6bde0378a2
Add tests for StrictModeManager (#12013) 2020-06-29 08:17:07 -07:00
ekager
60069395eb Update AC to 48.0.20200627130132 and fix breaking changes 2020-06-27 20:11:31 -04:00
Tiger Oakes
ed334788e8 For #11903: Enforce private theme in custom tabs 2020-06-26 22:59:43 -04:00
Jeff Boek
b1a8c0f483 For #9935 - Use the searchengine deferred 2020-06-26 19:07:36 -07:00
Jeff Boek
40977a93a0 For #9935 - Fallback region selection on first load 2020-06-26 19:07:36 -07:00
Michael Comella
5ef6b49aa1
For #8795: remove redundant ConstraintLayout around BrowserToolbar. (#12014) 
This is functionally equivalent to the code before this patch but should
be slightly more performant in theory because ConstraintLayout is
expensive to inflate.

The elevation and layoutParams set dynamically appeared to have no effect
with the wrapping view but broke the view when used by itself so I had
to remove them. I also updated a few other unnecessary params.

Theoretically this may have some perf benefits but I didn't see anything
outside noise levels after I took the numbers (but I didn't try very
hard).
 2020-06-26 21:31:02 -04:00
David Walsh
c4a4beb6b9 For 11468 - Show tab tray after opening links from history and bookmarks 2020-06-26 18:28:31 -07:00
Kate Glazko
2ac8496315 For #12025: Set Search Shortcuts Off By Default 2020-06-26 18:21:58 -07:00
Jeff Boek
a18c1befd1
For #11044 - Sets the anchorView of the snackbar to be the new tab fab (#11930) 2020-06-26 17:56:56 -07:00
Sachin
4b9cc954fa
for #11830 added new metric for collecting startup method from all startup phases (#11940) 
* for #11830 added new metric for collecting startup method

move all source startup telemetry into its own logic and added an UNKOWN state

* switched back to onNewIntent solution

* renamed the metric
 2020-06-26 17:38:08 -07:00
Sawyer Blatz
61b1b5a895
No issue: update experiments when experiments updated (#12032) 2020-06-26 17:19:58 -07:00
Sawyer Blatz
8a08cb941e
For #11479: Record open tabs count in metrics ping (#12024) 2020-06-26 17:15:43 -07:00
Jonathan Almeida
b7d989a588 Fix breaking API in WebNotificationFeature 2020-06-26 19:59:57 -04:00
Marc Leclair
ff5d00362b Added A-C version 48.0.20200626213814 2020-06-26 19:59:57 -04:00
Sawyer Blatz
101ecfbf66
For #11273: Add tabs tray telemetry (#12036) 2020-06-26 16:37:07 -07:00
Tiger Oakes
7287b5579f
Test settings about/advanced (#12023) 2020-06-26 15:53:30 -07:00
Tiger Oakes
4f6f0785c5
For #11943: Fix intermittent coroutine failure (#12027) 2020-06-26 15:42:53 -07:00
ekager
df49db6adb For #11294 - Enable Synced Tabs for all builds 2020-06-26 18:36:37 -04:00
Gabriel Luong
e6a56aec36
For #12026 - Update default top sites for new users (#12028) 2020-06-26 17:51:18 -04:00
Grisha Kruglov
f8cb1d6b48 Closes #11909: Metrics for recording number of recently used PWAs 2020-06-26 14:13:41 -07:00
Elise Richards
eeabcb10ff
Fix illegal arguments for onboarding keys (#12033) 2020-06-26 16:12:18 -05:00
Tiger Oakes
bcb2ef10ac
Add tests for PhoneFeature (#12021) 2020-06-26 12:12:52 -07:00
MarcLeclair
f3b44c06e4
For #11841: Removed topsite bug on private browsing (#12020) 2020-06-26 14:54:20 -04:00
Gabriel Luong
005ad6ff2a
Update Android Components version to 48.0.20200626130049. (#12006) 
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2020-06-26 14:16:57 -04:00
Tiger Oakes
80de3851f3
Add tests for OnSharedPreferenceChangeListener (#12019) 2020-06-26 11:04:46 -07:00
ValentinTimisica
9f5c8819d3 For #11892: Remove dynamic calls to setupNavigationToolbar 
This is a speculative fix for 11892 crash.
The side effect is that the back button will be visible in bookmarks root.
 2020-06-26 07:54:11 -04:00
Mihai Branescu
93247e0b2f For #9425 - SearchFragment now reacts to undo operation for base engines 2020-06-26 13:21:00 +03:00
Mihai Branescu
e6e3166d2d For #9425 - SearchFragment now reacts to undo operation for custom engines 
When you remove a search engine from our list, an undo snackbar that outlives the fragment is shown. If you go back to the search fragment and press undo, now the shortcut list gets updated
 2020-06-26 13:21:00 +03:00
Mihai Branescu
46c1c130da For #9425 - Handle undo for custom search engines 
On undo, get the template that the user entered for that engine and then
re-add it to the `CustomSearchEngineStore`
 2020-06-26 13:21:00 +03:00
Sawyer Blatz
c5034fa770 No issue: Allow us to run experiments on nightly if needed 2020-06-26 09:16:38 +03:00
mcarare
216da0c64b For #10285: Add a custom TextView for links with a11y improvements. 2020-06-26 09:15:44 +03:00
Kainalu Hagiwara
b84f55c980 For #11677 - Adjust tab counter menu item order. 2020-06-25 15:48:10 -07:00
person808
ad90625b48 For #2165 - Add swipe to refresh gesture to bookmarks view. 2020-06-25 14:50:24 -07:00
Christian Sadilek
64440409b0 For #9100: Follow-up to fix memory leak in NotificationSessionObserver 
The observer was moved and is now bound to the activity and its
context. If the activity is re-created we leak the observer and
therefore the activity itself.

With this we make sure to stop the observer and also don't use
the activity context to begin with.
 2020-06-25 16:17:38 -04:00
ekager
c77ddd8d26 For #11866 - Update back press logic for SearchFragment 2020-06-25 14:40:31 -04:00
Christian Sadilek
7be56ce4fa For #11798: Allow sharing of reader view pages 2020-06-25 14:39:21 -04:00
Sawyer Blatz
04aee11d82
For #9625: Add telemetry for Tracking Protection CFR (#11923) 2020-06-25 11:24:55 -07:00
Elise Richards
665fb8d60c
#10824: Onboarding telemetry (#11867) 
* Onboarding events and tracking

* Rename metrics for consistency

* Add reference to PR for the data review

* Add default values to onboarding events
 2020-06-25 13:21:31 -05:00
Sawyer Blatz
2d65faf232
For #11392: Rename Installation ping to FirstSession (#11869) 2020-06-25 10:06:26 -07:00
ekager
d3de9e517e Remove ThumbnailsUseCases 2020-06-25 12:51:18 -04:00
Tiger Oakes
c958cc048a Update customtabs service 2020-06-24 23:26:49 -04:00
Sawyer Blatz
13c8abe3dc For #11613: Expand toolbar onUrlChanged 2020-06-24 21:50:06 -04:00
Mihai Branescu
be5213e944 For #11727 - added content description 2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan
9068c96ab3 don't animate unnecessarily 
Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily

don't animate unnecessarily

Fixes #11739: Fix flicker

Update TabCounter.kt

squash commits

don't animate unnecessarily

Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily
 2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan
3dc6c438f4 Fixes #11739: Fix flicker 2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan
b95804c33b Fixes #11672, #11727: Empty default tab text and add padding to infinite character 2020-06-24 21:42:38 -04:00
Sawyer Blatz
a8ed913654 For #11183: Redirect user to homescreen after widget added 
Co-authored-by:  hakkikaancaliskan <caliskanhkaan@gmail.com>
 2020-06-24 21:41:42 -04:00
David Walsh
77ed670558 For #11860 - Conditionally show add to collection button on Home screen 2020-06-24 21:41:19 -04:00
Sawyer Blatz
872c179cf4 For #11825: Removing the last pretty animation 😞 
Goodbye, sweet summer child.
 2020-06-24 21:38:28 -04:00
mcarare
a056e86e4f For #8080: Dismiss menu when swiping away from its anchor. 2020-06-24 21:37:57 -04:00
mcarare
b961fdcf02 For #11901: Use safe call for collection item info. 2020-06-24 21:37:24 -04:00
Mihai Branescu
49b617c999
For #9100 - Private browsing notification fixes 
Co-authored-by: Seef <Saif Dara>
 2020-06-24 21:35:11 -04:00
Mihai Branescu
632b64971f For #10467 - removed unused tests and resources related to blue dot notification 2020-06-24 21:33:32 -04:00
Mihai Branescu
3c2c7f705c For #10467 - blue dot doesn't disappear on menu dismiss 2020-06-24 21:33:32 -04:00
Tiger Oakes
0b781ae3b7 Add tests for collection creation controller 2020-06-24 21:21:02 -04:00
Jeff Boek
177e7a400f For #11406 - Scrolls to selected tab when switching modes 2020-06-24 21:16:48 -04:00
Tiger Oakes
4415702fa8 Add tests for share sheet 2020-06-24 20:33:47 -04:00
Tiger Oakes
183ba1bce0 For #11903: fix custom tab private gradient 2020-06-24 20:33:16 -04:00
ekager
f39313d908 For #8374 - On external session removed, handle back press 2020-06-24 20:17:26 -04:00
person808
5f7e0e4dd6 Followup for #11442 - Add tab counter menu metrics to home fragment. 2020-06-24 10:20:51 -07:00
Tiger Oakes
9a8b800a76 For #8621 - fix intermittent test failures 2020-06-23 17:43:24 -04:00
Jeff Boek
621da0c4c1
For #9935 - Adds fallback searchengine provider for long MLS lookups (#11863) 2020-06-23 14:00:18 -07:00
mcarare
fe97dc9d2e For #11542: Update tabs positions in tab tray reported by screen readers 2020-06-23 11:28:24 -07:00
ekager
06e6cfa696 For #5636 - Unregisters wifiConnectedListener when setting changes, sets default blocked 2020-06-23 12:28:52 -04:00
Jeff Boek
8ce7cf59c8
For #11261 - Dismisses menu when rotating to landscape (#11845) 2020-06-23 10:50:20 -05:00
Jeff Boek
2861421312 For #11112 - Adds save tabs to collection button to the no collections message 2020-06-23 08:17:55 -07:00
Tiger Oakes
ccb532bb77
For #11534 - Don't check lastUsed mode for screenshots (#11827) 2020-06-22 17:38:58 -07:00
Jeff Boek
c7b1f215c8
No Issue - Fixes flash when toggling tab tray (#11826) 2020-06-22 16:49:07 -05:00
Tiger Oakes
18cc4c95c1
Add tests for ContextKt (#11824) 
Migrated from an old branch by Kate

Co-authored-by: Kate Glazko <katglazko@gmail.com>
 2020-06-22 14:00:43 -07:00
Hakkı Kaan Çalışkan
c8d36ddc36 For #8649: No bookmarks here strings are close to the top 2020-06-22 16:04:20 -04:00
ekager
88765c348b Update A-C version, add synced tabs empty state 2020-06-22 15:13:13 -04:00
mcarare
721e290734 For #10049: Provide correct seek bar value to screen readers. 2020-06-22 13:58:33 -04:00
ValentinTimisica
c75ab3f720
For #10462: Removes back button from bookmarks and history fragments (#11721) 2020-06-22 13:15:33 -04:00
ekager
635c30510d No issue: refactor tabs tray to use interactor/controller, add tests 2020-06-22 13:01:35 -04:00
Mugurell
0ba1d266b3 For #9144 - Ignore previous Intent if activity is started from Recents 
We'll now clearly differentiate between cold / hot starts of HomeActivity.kt.
This is needed because Android will resend the original Intent which initially
started the Activity whenever it is restarted from the Recents Screen if the
activity is already destroyed at that time. So in the event that the activity
was before started with an Intent to open a webpage for example whenever the
activity is restarted from Recents it will receive the same Intent to open a
webpage even though that Intent has already been consumed.

Activity's onCreate() will only use the intent processors when the activity is
cold started so that we'll only initially act upon Intents configured for
different behaviors inside the app.
If the activity is destroyed while in background and opened from Recents it
will not act upon the original Intent which is now resent by Android.

Activity's onNewIntent() will be called to act upon a new Intent if the
activity is hot started since we are declared as singleTask and it now has the
responsibility to delegate various intent processors to consume that Intent.
 2020-06-22 12:08:24 -04:00
ValentinTimisica
0b57f5e71b Fixes #10551: Removes the increased touch target for learn more link 2020-06-22 16:40:15 +03:00
Mihai Eduard Badea
eb45b37207 For issue #10727 - Hide saved logins details 
Removed the clearFlags call from the HomeActivity that was causing this issue and removed the now redundant call to update the flag from the redirectToReAuth method
 2020-06-22 13:19:02 +03:00
ValentinTimisica
e9bb11e22d Fixes #9205: Changes add-ons and 'Open links in apps' icons from menus 2020-06-22 12:09:19 +03:00
Sachin
988513aa89
for #10568 moved awesomebar and toolbar into fragment_search (#11744) 2020-06-21 14:56:49 -07:00
Sachin
9269a53b21
for #11615 allowed strictMode disk read for violations made by the OS. (#11658) 2020-06-21 14:54:49 -07:00
Antti Vainikka
cb129231ae Closes #11500: Remove wrong activity title 2020-06-19 18:17:35 +03:00
mcarare
a0fe1a452a For #11756: Fix bottom toolbar preference reference. 2020-06-19 11:20:08 +03:00
mcarare
4bebc56c50 For #9229: Remember options for delete browsing data. 2020-06-19 09:32:37 +03:00
MarcLeclair
b52091ed34
For #11660: added prefetch for topsites and update in onCreateView() (#11668) 
* For #11660:added prefetch for topsites

TopSites will be prefetched with observerOnce (wrapper around observerForever).
Also, the SessionControlView.update() is called right away instead of waiting from consumeFrom
in the HomeFragment.onCreateView() which will allow the UI to render all at once on its first
perform traversal

* Removed the submitList(null) since it retriggered a drawing on lower end device
 2020-06-18 19:43:20 -04:00
Emily Kager
44ff29bdc0 Revert "For issue #9949 - Bookmarks/History deletion inconsistencies" 
This reverts commit 3feab90b19.
 2020-06-18 19:31:49 -04:00
ekager
df63c5a4bc For #11708 - Remove setMargins in CustomTabsIntegration 2020-06-18 17:02:34 -04:00
Jeff Boek
82cbafabaf
For #11625 - Fixes tab tray staying open when opening from another app (#11740) 2020-06-18 12:32:14 -05:00
mcarare
5f1c9449f3 For #8114: Restore normal UI when a library fragment is detached. 2020-06-18 17:42:06 +03:00
Tiger Oakes
c503798cd6 Replace PhoneFeature.getPreferenceKey 2020-06-18 09:02:58 -04:00
Tiger Oakes
596c579bbb Replace nullable findPreference 2020-06-18 09:02:58 -04:00
Tiger Oakes
45ef88f6b9 Replace requireNotNull(findPreference()) 2020-06-18 09:02:58 -04:00
Tiger Oakes
3e03439259 Add requirePreference helper 2020-06-18 09:02:58 -04:00
codrut.topliceanu
0eb2f328dc For #11371 - Fix for Dynamic Download Dialog 2020-06-18 09:00:55 -04:00
David Walsh
3feab90b19 For issue #9949 - Bookmarks/History deletion inconsistencies 
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648.
 2020-06-17 14:42:51 -04:00
Tiger Oakes
f6efb386d6 Add tests for addon details 2020-06-17 14:38:50 -04:00
Hakkı Kaan Çalışkan
8cbdce58e6 Update FxaServer.kt 2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan
670e03c3b2 Update app/src/main/java/org/mozilla/fenix/components/FxaServer.kt 
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
 2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan
bd85a9c399 remove suppress and unnecessary otherwise = private 2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan
87a65d2445 For #9782: Clean up unused FeatureFlags 
I've currently found out this ones unused.
webPushIntegration removed because looks like all fatal bugs solved as it said from note.
 2020-06-16 23:30:57 -04:00
Sören Hentzschel
396cd61efa For #9712 - show "AC: " before AC version on "About" screen 2020-06-16 15:29:00 -04:00
Sachin
36b1c710e7
for #11617 added a resetPoliciesAfter ext function for StrictMode, and replaced all existing calls to "resetAfter" with "resetPoliciesAfter" (#11619) 2020-06-16 11:12:18 -07:00
Tiger Oakes
d81aa62683 Fix PIP toolbar 2020-06-15 15:34:06 -04:00
Tiger Oakes
d3d5c8934f Cleanup tests for toolbar controller 2020-06-15 15:25:33 -04:00
person808
9e3e95e351 For #11442 - Telemetry for tab counter menu. 2020-06-15 11:48:12 -07:00
Mihai Branescu
4f870e9251 For #6126 - moved the sessionObserver init to the onCreate 
This helps because we will always need the observer to be initiated, not only when the `openToBrowser` method gets called. Example: Opening a tab from the tab tray had it's own method for opening the browser, causing this to not be called.
 2020-06-15 08:01:32 +03:00
Jonathan Almeida
e6da2bd910 Fix breaking APIs in TabsAdapter and ViewHolder 2020-06-13 16:02:31 -04:00
Tiger Oakes
704fc6f983 Use updated webapphidetoolbarfeature 2020-06-12 19:21:34 -04:00
Tiger Oakes
fc96e188ab Convert flow from AC to livedata 2020-06-12 19:21:34 -04:00
David Walsh
149efc1683
For 9640 - Focus on last selected tab in tab tray with a11y turned on (#11487) 2020-06-12 18:15:13 -05:00
David Walsh
8b24cdec42
For 11428 - Focus on home screen address bar when tab tray new tab is tapped (#11429) 2020-06-12 17:55:07 -05:00
David Walsh
063cf457ba
For #11291 - Provide New Tab button when accessibility enabled (#11441) 2020-06-12 17:52:06 -05:00
liuche
35fa445165
Issue #11112 - Update empty collections string + tests. (#11538) 2020-06-12 18:01:38 -04:00
Arturo Mejia
a36ec7279e No issue: Decrease the frequency for checking for new supported add-ons 2020-06-12 17:19:07 -04:00
Tiger Oakes
294f29768d Test logins settings 2020-06-12 15:30:50 -04:00
Sawyer Blatz
0a9afbed42 For #11380: Update migration tip text 2020-06-12 15:17:53 -04:00
Sawyer Blatz
fffbadbfca
For #11118: Add browsing history suggestion in metrics (#11525) 2020-06-12 11:40:04 -07:00
Sawyer Blatz
13d077eb66
For #11269: Telemetry for new reader mode position (#11385) 2020-06-12 11:39:35 -07:00
Sawyer Blatz
d1cd877374 For #11118: Add missing telemetry 2020-06-12 10:29:05 -07:00
mcarare
0ebfa4f947 For #11497: Disable pull to refresh in error states. 2020-06-12 14:09:16 +03:00
Jeff Boek
1639b1d3a1 For #11342 - Fixes missing space for the FAB 2020-06-11 18:25:57 -04:00
Tiger Oakes
651b2831fe Fix tests in toolbar controller 2020-06-11 18:15:09 -04:00
Sachin
cd26ba9a9c
for #11364 added a exception list for manufacturers violating strict mode policies on startup (#11407) 
for #11364 changed blackList -> exceptionList, added one plus to the list

change magic strings into const Val
 2020-06-11 11:50:07 -07:00
person808
d14b39a56e For #2165 - Implement pull-to-refresh gesture to sync history. 2020-06-11 10:23:27 -07:00
mcarare
4b04a140fc For #11229: Update etp strict option title content description. 2020-06-11 10:20:01 +03:00
Sawyer Blatz
932a2f3703 For #11063: Update telemetry for etp settings 2020-06-10 22:51:21 -04:00
Tiger Oakes
f0295048fa Remove Mockito 2020-06-10 21:19:50 -04:00
Jeff Boek
cd3b6181b3 For #10374 - Adds quick contextual menu to tab switcher 
Co-authored-by: person808 <kainaluh808@gmail.com>
 2020-06-10 16:50:28 -07:00
Elise Richards
137d66a511
For 10172: Set edit text listeners (#11196) 
* Set edit text listeners

* Set clearable icons and change with error states

* Clear text buttons show and hide

* Move error checks to afterTextChanged. Refactor. Remove unused color.
 2020-06-10 16:52:47 -05:00
Tiger Oakes
31edbc924c
Fixes #9056 - Start Fenix activity on search in external app (#10932) 2020-06-10 10:25:53 -07:00
Tiger Oakes
4b064afb81
Add tests for ext package (#11334) 2020-06-10 09:14:18 -07:00
Christian Sadilek
d16c70d8be Wire up UI to make add-on installation cancelable 2020-06-10 18:52:06 +03:00
ValentinTimisica
bc53296603 For #11365: Reorganizes 'SettingsFragment' items 
Moved all the functionality form 'DefaultBrowserSettingsFragment' to
'SettingsFragment'.
 2020-06-10 11:09:03 +03:00
ekager
11697c1363 For #11390 - Removes redundant session observer init for ETP overlay 2020-06-10 08:37:49 +03:00
Sawyer Blatz
27c7ef5ad4 For #8775: Removes feature flag for dynamic bottom toolbar 2020-06-09 20:58:17 -07:00
ValentinTimisica
f937c96c12 For #5148: Switch to the correct tab on media notification clicked 
Processing the intent in OpenSpecificTabIntentProcessor to be able to switch
to the tab where audio/video is playing
 2020-06-09 22:39:39 -04:00
David Walsh
1356b3e426 For 11271 - Provide useful tab counter message for accessibility 2020-06-09 22:37:46 -04:00
Tiger Oakes
96d2307df0 Add tests for widget 2020-06-09 22:31:12 -04:00
ValentinTimisica
3a28704fa6 For #11132: Replaces wrong icons from menus 2020-06-09 22:19:43 -04:00
ValentinTimisica
dc37baff0b For #11132: Rearranges home menu items 2020-06-09 22:19:43 -04:00
Jeff Boek
f41ca2f424 No Issue - Moves from being a tabstray observer to overriding tab use cases 2020-06-09 19:13:08 -07:00
Christian Sadilek
05496faa66 Clear speculative session on engine settings change 2020-06-09 18:55:43 -04:00
Sawyer Blatz
5445d34ac4 For #11357: Use AppCompatResources for reader mode icon 2020-06-09 18:04:13 -04:00
Jeff Boek
4ee1cd6716 For #11361 - Nulls out tabsFeature in the correct spot 2020-06-09 15:34:00 -04:00
Jeff Boek
d8ef0722e3 For #11175 - Moves tab tray strings to be translated, fixes description of the fab string 2020-06-09 13:06:02 -04:00
ekager
6d4a673c6f For #8967 - Expose autofill logins setting in nightly 2020-06-09 12:21:48 -04:00
Mozilla L10n Automation Bot
5373a75f57 For #10502 - Show snackbar after adding tabs to collection from tab tray 2020-06-09 08:29:06 -07:00
Grisha Kruglov
8769d98e71 Pass crashReporter instance to RustLog 2020-06-08 17:38:30 -07:00
Sachin
8fdc28010d
for #10839 added IO coroutine to check onboarding stat from sharedpref (#11338) 
changed coroutine scope to fragments lifecycle
 2020-06-08 15:52:10 -07:00
Jeff Boek
e4e7cc5108 For #11260 - Fixes lifecycle issues with the tabs tray 
- Also check to make sure the fragment manager is still valid before trying to show the tabs tray

Co-authored-by: Emily Kager <emilykager@gmail.com>
 2020-06-08 18:42:46 -04:00
Sawyer Blatz
e9189dc089 For #11045: Add reader mode to urlView 2020-06-08 15:12:03 -07:00
Tiger Oakes
1a19b06227
Simplify PhoneFeature code (#10810) 2020-06-08 13:02:42 -07:00
Sachin
74948cb3f1
for #7225, Changed strictMode thread penalty to dialog on startup and back to logs after startup is done. (#10831) 
for #7225, refactored and cleanup the branch.

for #7225, change strict mode policy only on main process.

for #7225, setting thread policy inside a seperate thread to keep it from getting overridden in activities.

for #7225 removed Handler().postAtFrontOfQueue as a solution due to unknown side effects. moved the enableStrictMode function to be static so we can reuse it.

for #7225 lint check

for #7225 created strict mode manager and moved enabledStrictMode function inside it.

for #7225 removed penalty death on network

for #7225 added allow disk access on thread for already existing violation


strict mode running in main process to see if it passes the gitlab check, will revert it if it doesnt

allowed diskread for super.onCreate for home activity

added comments for disk violation oncreate homeactivity

added fragment manager inside strictmode manager

allowed disk read for onboarding

allowed disk read for cachedTopSites
 2020-06-08 10:45:33 -07:00
David Walsh
d33080571b
For #11267 - Announce "Your open tabs will be shown here (#11272) 2020-06-05 17:27:45 -05:00
mcarare
512aa46224 For #11229: Update ETP cfr string and behaviour. 2020-06-05 14:18:25 -04:00
mcarare
91c27a023e For #11229: Update settings ETP copy. 2020-06-05 14:18:25 -04:00
mcarare
a0d9189321 For #11229: Update onboarding ETP copy. 2020-06-05 14:18:25 -04:00
Jeff Boek
52c2fdb310
Remove tab tray feature flag (#11176) 
* For #11171 - Removes feature flag for the new tab tray

* For #11171 - Removes all tab references from homeFragment

* For #11171 - Fixes unit tests

* For #11171 - Gets UI tests to compile and HomeScreenTest to pass

* For #11171 - Fixes `deleteMultipleSelectionTest`

* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`

* For #11171 - Fixes `openHistoryInPrivateTabTest`

* For #11171 - Fixes `openHistoryInNewTabTest`

* For #11171 - Fixes `openNewPrivateTabTest`

* For #11171 - Fixes tabbedBrowsingTests

* For #11171 - Fixes SettingsPrivacyTest

* For #11171 - Fixes TopSitesTest

* For #11171 - Fixes lint errors

* Ignore
 2020-06-05 12:59:08 -05:00
mcarare
2d24369362 For #7725: Increase info button touch target while keeping size. 
Also removed unnecessary touch delegate.
 2020-06-05 11:57:17 +03:00
person808
8c47b988b8 For #10525 - Remove tab tray item dividers. 2020-06-04 23:17:16 -07:00
Jeff Boek
bc53b94feb For #10989 - Fixes memory leak caused by retaining the TabTrayView and TabsFeature 2020-06-04 23:29:14 -04:00
Sawyer Blatz
1be2ec2cbf For #9488: Init widgetExperiment after Experimenter init 2020-06-04 16:22:52 -07:00
mcarare
886c1882c5 For #11230: Set default to false for allow screenshots in private setting 2020-06-04 18:24:26 -04:00
Dennis Schubert
e41fc7841a Bug 1643132 - Add WebCompat Reporter feature. 2020-06-04 18:23:11 -04:00
Dennis Schubert
d046d908fc Bug 1643132 - Remove native "Report site issue" functionality. 
This will be replaced by the WebCompat team's system extension that ships as an android-component.
 2020-06-04 18:23:11 -04:00
Sawyer Blatz
42f58a1984 For #9488: Add experimentation support 2020-06-04 14:10:22 -07:00
ekager
54df729fb3 For #8374 - Don't recreate ExternalAppBrowserActivity or finishing activities 2020-06-04 16:44:07 -04:00
Sawyer Blatz
9302d07d13 For #11118: Add toggle states to metrics ping 2020-06-04 10:08:23 -07:00
mcarare
5a23fb33f8 For #11182: Fix back button text update according to save step. 2020-06-04 11:50:29 -04:00
mcarare
a910698007 For #11182: Set click listener also to icon button. 2020-06-04 11:50:29 -04:00
Gabriel Luong
9520c9dd32 For #8920 - [Telemetry] Send add-on ids in a metrics ping 2020-06-04 08:15:39 -07:00
mcarare
29f1800021 For #11182: Explicitly clone select tabs on updating SaveCollectionStep. 2020-06-03 23:01:44 -04:00
mcarare
68286d263a For #11182: Set click listener to full layout instead of just icon. 2020-06-03 23:01:44 -04:00
person808
9272026b7e For #10193 - Remove page title when sharing links 2020-06-03 15:54:23 -07:00
Tiger Oakes
a7e74e308b
Migrate some SessionManager usage to BrowserStore (#10789) 2020-06-03 11:18:44 -07:00
mcarare
138c12696f For #11153:Add FLAG_SECURE on pause and clear on resume for private session. 2020-06-03 08:56:16 -04:00
David Walsh
d862d58051 Scroll to the top of home when using the tab tray 2020-06-02 23:08:20 -07:00
mcarare
2090b11c97 For #10434: Handle cases when proc/$pid/stat is not accessible. 2020-06-02 17:57:39 -07:00
ekager
ead3194d86 For #8759 - Allow recently used in share fragment to scroll 2020-06-02 16:46:08 -04:00
Jeff Boek
2dd0a3cb9e
Implement tab tray design improvements and fix close functionality. 2020-06-02 15:03:58 -05:00
Tiger Oakes
6317eea690 Add tests for some of collection creation 2020-06-02 10:06:17 -04:00
ValentinTimisica
591e2c9a6f Fixes #9696: Adds Add-ons menu item to the home menu 2020-06-02 09:32:30 -04:00
mcarare
c4f7a32eae For #9583: Increase touch targets for onboarding elements. 2020-06-02 09:26:38 -04:00
Tiger Oakes
50441e28f1 Tests and cleanup for tracking protection 2020-06-01 22:08:52 -04:00
ekager
9ef4d9bdae For #10968 - Don't show ETP CFR if toolbar doesn't have window focus 2020-06-01 15:35:00 -07:00
Vishwa Patel
4da22c605a For #10834 - Adding Sync Tabs Feature in Fenix 2020-06-01 16:52:40 -04:00
Gabriel Luong
0300f15df1
Fix crash from TabThumbnailView where drawable is null (#11121) 2020-06-01 16:08:35 -04:00
Gabriel Luong
60b68a265a
For #10921 - Integrate BrowserThumbnails feature into the tabs tray (#11093) 2020-06-01 14:36:44 -04:00
Sawyer Blatz
82facbfa00 For #1216: Remove feature flag for voice search 2020-06-01 13:53:52 -04:00
David Walsh
84d9e5b1fb
For 11031 - Fix landscape mode for tab tray (#11084) 2020-05-30 19:27:59 -05:00
Jeff Boek
a6e77e3e8f For #10848 - Fixes unit tests 2020-05-30 10:38:48 -07:00
Jeff Boek
c8e8566668 For #10848 - Fixes navigationbar colors on tab dialog fragment 2020-05-30 10:38:48 -07:00
Jeff Boek
f05890efec For #10848 - Fixes bug where selected index wouldnt be properly calculated in private mode 2020-05-30 10:38:48 -07:00
Jeff Boek
d5c20bc0d0 For #10848 - Fixes menu background color 2020-05-30 10:38:48 -07:00
Jeff Boek
19a709a04d For #10848 - Fixes tab tray colors 2020-05-30 10:38:48 -07:00
Jonathan Almeida
ce15763cc4 Use new AuotPushFeature.getSubscription API 2020-05-29 22:21:31 -04:00
Tiger Oakes
221792c074
Add tests for FenixOnboarding (#11057) 2020-05-29 17:26:07 -07:00
Gabriel Luong
63e529ac2b Added BrowserThumbnails dependencies 2020-05-29 18:19:06 -04:00
Jeff Boek
8662164b8a
Refactors the TabTrayDialogFragment to ditch that weird interactor (#11061) 
* For #11056 - Removes unused argument when navigating to the collection creation fragment

* For #11056 - Moved the collection creation navigation logic to the TabTrayDialogFragment

* For #11056 - Moves navigating to the share screen from home/browser to the TabTrayDialogFragment

* For #11056 - We moved tab selection logic from home/browser to the tab tray dialog

* For #11056 - Moved new tab tapped logic to the tab tray dialog fragment

* For #11056 - Removes all interactor logic for the TabTrayDialogFragment

* For #11056 - Migrates the presentation / navigation around the TabTrayDialog to the androidx navigation library
 2020-05-29 17:17:56 -05:00
Jeff Boek
3946ec11de
Polish homescreen (#11065) 
* For #10505 - Adjusts wordmark margins

* For #10505 - Removes topsite header, fixes collections header size and removes divider

* For #10505 - Restyle the top site items on the homescreen
 2020-05-29 17:09:12 -05:00
ekager
20e358228e For #11015 - Switch Default ETP Setting to Standard 2020-05-29 16:39:47 -04:00
Tiger Oakes
749c95e0f0
Add tests for ReaderModeController (#11049) 2020-05-29 11:46:31 -07:00
Mihai Eduard Badea
11df3aaca1 For issue#10727 - Logins auth redirect 
Added an extension function that pops the backstack of the fragment so the user is redirected to the Logins and passwords screen.
This is done to force the user to re-authenticate if he wants to re-enter the saved logins flow.

Additionally, some UI elements are being hidden on each Fragment since they were remained visible on the Logins and passwords screen's UI.
 2020-05-29 12:57:28 -04:00
Jeff Boek
58a42828a1 For #10496 - Fully expand bottom sheet when loaded 2020-05-29 08:31:32 -07:00
Jeff Boek
0566790257 For #10496 - Automatically scroll to the selected tab when you open the tab tray 2020-05-29 08:31:32 -07:00
ValentinTimisica
9f265fd62f Fixes #10064: Open help articles in normal tab instead of custom tab 2020-05-29 09:26:46 +03:00
David Walsh
267cf35edb For 11001 - Show close all tabs above tab tray 2020-05-28 19:39:56 -07:00
David Walsh
a70ba76cc9 Provided unique no tabs message per mode 2020-05-28 19:38:41 -07:00
apoorv9990
3469eeed9e removed auto play permissions while determining isVisible for WebsitePermissionsState 2020-05-28 16:08:07 -07:00
apoorv9990
97704bfdbd Closes #9529: changed styling for permissions dialog to set proper padding 
- Changed the visibility check to check just for the permissions shown instead of all the permissions in WebsitePermissionsState
- Added bottom padding to the permissions root view so there is balanced padding on top and bottom
 2020-05-28 16:08:07 -07:00
Sawyer Blatz
b06be1fcde For #9488 Add telemetry for search widget CFR 2020-05-28 15:15:25 -07:00
Sawyer Blatz
94d741864e For #9488: Add search widget CFR 2020-05-28 15:15:25 -07:00
Sawyer Blatz
27a85d86dc
For #10803: Hide voice icon in search if not available (#11005) 2020-05-28 14:34:44 -07:00
Christian Sadilek
7b5661ed10 Update Android Components version to 44.0.20200528190114 
Pass store to download manager and service to address API changes.
 2020-05-28 17:26:38 -04:00
Jonathan Almeida
63b4fcd4c4 For #11004: Fix invisible text on migration UI 
For some text and colors, we were using the default styling where
possible. These styles contain references that react to theme changes
like dark mode. Since the migration UI does not respect these changes,
we should not use them.
 2020-05-28 15:48:42 -04:00
David Walsh
c0c895af33
For 10665 - Show the most recent tabs at the top of the tab tray (#10687) 2020-05-28 11:17:52 -05:00
ValentinTimisica
03284e2da0 Fixes #10674: Add SignInView only once 2020-05-28 08:38:24 -07:00
David Walsh
4fdac4d608
For 10734 - Open tab tray when collection is opened from Home (#10751) 
* For 10734 - Open tab tray when collection is opened from Home

* Update to work with tab tray drawer
 2020-05-28 10:22:12 -05:00
David Walsh
ea4c342797
For #10877 - Show 'no tabs' message when no tabs are open (#10960) 2020-05-28 10:17:55 -05:00
Roger Yang
6cef0edd5e
Closes #10980: Stop sending native crashes to Sentry (#10982) 2020-05-28 10:42:05 -04:00
ValentinTimisica
7974a5c77c Fixes #10815: Sort login items on initial load 2020-05-28 13:42:50 +03:00
mcarare
9ec6ebc92a For #10969: Fix and clarify logic for checking showing PWA dialog. 2020-05-28 13:18:25 +03:00
David Walsh
248237290e
For #10865 - Implement 3 dot menu for tab tray (#10869) 2020-05-27 13:07:03 -05:00
David Walsh
54cb8f0194 Remove unused import 2020-05-27 08:45:15 -07:00
David Walsh
5e4fd460f8 Remove onTabClosed from interactor 2020-05-27 08:45:15 -07:00
David Walsh
8b843ac9e5 Fix elevation for snackbar and fab 2020-05-27 08:45:15 -07:00
David Walsh
e9bcc9bb1e Move snackbar to TabTrayDialogFragment 2020-05-27 08:45:15 -07:00
David Walsh
f653964ee1 For #10864 - Display snack bar to undo closing tabs 2020-05-27 08:45:15 -07:00
mcarare
a59917cdc0 For #9626: Swap margin for padding and remove use of touch delegate. 
Also remove text margin to maintain visual appearance.
 2020-05-27 08:43:43 -07:00
mcarare
d706b085a9 For #9626: Delay cloning ConstraintSet to only when needed for updating. 2020-05-27 08:43:43 -07:00
Mugurell
d0e2d02b34 For #10948 - Avoid PWA onboarding if user already has them on screen 
It is possible that after migration users would already have Firefox PWAs on
their screen.
Since they already know about this functionality, we should not promote it to
them with the one-off `FirstTimePwaFragment`.

To query installed PWAs we'll use an API available only on Android >= 26 which
means that we will probably have half of users with PWAs still see the
onboarding but half which will not.
 2020-05-27 08:42:56 -07:00
Sebastian Kaspari
21bd379438 Issue #9815: Allow Intents to set HomeActivity.OPEN_TO_BROWSER. 2020-05-27 10:55:44 +02:00
Roger Yang
538a7917e4
Closes #10906: Add Open in app option in custom tab (#10929) 2020-05-26 14:37:53 -04:00
Tiger Oakes
2397695fe5
For #10596 - Redirect moz://a URL (#10688) 2020-05-26 11:06:01 -07:00
Simon Chae
422cf74731 For #8319: Integrate nest WebExtensionBrowserMenu support 2020-05-26 14:02:22 -04:00
mcarare
6e325d6242 For #6198: Update copy and position of pair QR code scan message. 2020-05-25 17:53:20 -04:00
Sebastian Kaspari
b666fbe3fe CrashReporter: Set release channel specific sentry project URL. 2020-05-25 16:13:54 +03:00
Mugurell
2dfd833941 For #10844 - Fennec page shortcuts will open in normal tabs 
This comes to resolve a small regression in which they were opened in new
custom tab.
 2020-05-25 14:37:00 +03:00
Grisha Kruglov
b26ac51e90 For #10494: Process HomeMenu builder changes on the main thread 
Problem was that we were trying to process menu changes (in response to account manager events) on some background thread as that's what account manager emits them on, so some code internally in PopupWindow's dismiss handling (i think, didn't dig very deeply here) was silently giving up and we'd get into a bad state.

The reason this seemingly only happened if you quickly opened a menu on startup is because account manager isn't initialized until sometime after the startup finished. So the trick was to open the menu (and register account manager state callbacks) before it got initialized, so that the callbacks are invoked.

This should also reproduce in other, much more obscure ways, e.g. if you open the menu right before sync is scheduled to run in the background, change FxA password on another connected client, and then eventually receive a onAuthenticationProblem callback.
 2020-05-22 13:50:57 -07:00
Sawyer Blatz
7067e5c000
For #8125: Add default top site telemetry (#10752) 2020-05-22 13:10:09 -07:00
sraturi
29d1893430 for #7032 add scroll listener to make the keyboard disappear on scroll. 
touch listener was blocking the scroll
 2020-05-21 18:54:50 -07:00
sraturi
4ee65755dc for #7032 fixed issue where pressing back button exited the application 2020-05-21 18:54:50 -07:00
sraturi
2c85a62a5e for #7032 removed recyclerview scroll listener from Awesomebarview 2020-05-21 18:54:50 -07:00
sraturi
c8ec25fde9 fixed lint issues 2020-05-21 18:54:50 -07:00
sraturi
703a8ed565 added a onTouch listener to scrollview in search fragment to make it disappear on scroll 2020-05-21 18:54:50 -07:00
Jeff Boek
601aedda46 For #10504 - Removes "old" TabTrayFragment 2020-05-21 15:17:20 -07:00
Jeff Boek
c32904a1d0 For #10504 - opens the tab tray and filters the tab based on the browser mode 2020-05-21 15:17:20 -07:00
Jeff Boek
a674c5dfe7 For #10504 - cleans up tabLayout colors 2020-05-21 15:17:20 -07:00
Jeff Boek
4e499e7a48 For #10504 - Adds tabTrayDialogInteractor to browserfragment 2020-05-21 15:17:20 -07:00
Jeff Boek
cc6a380d45 For #10504 - Show tab dialog on browserfragment 2020-05-21 15:17:20 -07:00
Jeff Boek
90cef752b0 For #10504 - Fixes up tab tray dialog styles 2020-05-21 15:17:20 -07:00
Jeff Boek
0b9484a172 For #10504 - Adds padding fto account for navigation bar in landscape 2020-05-21 15:17:20 -07:00
Jeff Boek
dd2a26fc7c For #10504 - Added the tab tray to the TabTrayDialogFragment and wired up dismiss actions 2020-05-21 15:17:20 -07:00
Jeff Boek
34ac9df481 For 10504 - Adds dialog style and fab 2020-05-21 15:17:20 -07:00
Jeff Boek
97d66cce56 For #10504 - Creates the TabTrayDialogFragment 2020-05-21 15:17:20 -07:00
ekager
516a6fe9f7 For #6832 - Only emit session changes if fragment is attached 2020-05-21 10:11:50 -07:00
ekager
83ab7646c1 For #7602 - Integrate media fullscreen orientation feature 2020-05-21 10:11:39 -07:00
Christian Sadilek
4e25f41a41 For #1824: Prevent extremely long URLs from locking up HomeFragment 2020-05-21 13:11:07 -04:00
codrut.topliceanu
7feae98944 For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view 
- Renamed DownloadNotification and removed DownloadState.dismissed dependency
- Improved DynamicDownloadDialog behaviour when scrolling
- DynamicDownloadDialog remains attached to tab until dismissed
- Fixed onTryAgain not working for resumed DownloadDialogs
 2020-05-21 10:02:51 -04:00
David Walsh
346b4aa3fd
For #10321: Wire up play and pause buttons in tab tray (#10422) 2020-05-20 16:50:58 -05:00
Sawyer Blatz
477493e197
For #10465: Add telemetry for voice search (#10785) 2020-05-20 14:35:57 -07:00
David Walsh
2795a34b0b For 10731 - Don't show tab tray menu if there are no tabs 2020-05-19 13:30:18 -07:00
Sawyer Blatz
535e020683 For #1216: Put voice search behind a nightly & debug flag 2020-05-19 13:04:11 -07:00
Sawyer Blatz
d33edd8841 No issue: Clean up SearchFragment a bit 2020-05-19 13:04:11 -07:00
Sawyer Blatz
011a9e7d96 For #1216: Add voice search 2020-05-19 13:04:11 -07:00
ekager
d46369696f For #10718 - Finish activity after removing external session 2020-05-18 15:32:29 -07:00
Tiger Oakes
cd64647a4d For #9286 - Add isDefault to topsites 2020-05-18 14:04:10 -07:00
Juan Goncalves
ee62297b4c For #7854 - Update the views only if the bookmark node has changed 
As the bookmark node data is loaded from storage every time the fragment's view is created, when the user navigates to the SelectFolderFragment and returns, the bookmark is loaded once again from storage, replacing the EditText's content (title and URL) which causes the loss of user input.

Validating that the loaded bookmark is different from the one that is already referenced in the fragment avoids unnecessarily replacing the `EditText`s values.
 2020-05-18 13:05:12 -07:00
Emily Kager
32e74aae61 Revert "For #6313 - On first load, hides engineView until firstContentfulPaint" 
This reverts commit d66762910f.
 2020-05-18 10:33:11 -07:00
Emily Kager
9b16017d1d Revert "For #7032: Add scroll to dismiss keyboard in search fragment" 
This reverts commit 536921bcea.
 2020-05-15 21:14:55 -07:00
ekager
d66762910f For #6313 - On first load, hides engineView until firstContentfulPaint 2020-05-15 10:55:38 -07:00
Sachin
536921bcea
For #7032: Add scroll to dismiss keyboard in search fragment 
* added a onTouch listener to scrollview in search fragment to make it disappear on scroll

* fixed lint issues
 2020-05-15 10:30:00 -07:00
Grisha Kruglov
d37529e416 Perf telemetry for awesomebar suggestion provider durations 
See mozilla-mobile/android-components#6802 for details; requires that PR.
 2020-05-14 14:13:53 -07:00
Mihai Branescu
750ae4a340 For #10393 and #10469 - browser fragment now observes collection changes 
Useful for links from other apps + adding a page to multiple collections
 2020-05-14 10:14:06 +03:00
Christian Sadilek
7993f1017d Migrate feature-accounts to browser-state 2020-05-13 14:24:56 -04:00
sraturi
372bb421cc created kotlin doc for FenixApplication 2020-05-13 11:01:12 -07:00
Simon Chae
7cc4816618
For #10398: Add AddonInstallationDialogFragment support (#10608) 2020-05-13 12:25:34 -04:00
Elise Richards
edc75c3ad0
Fixes #9504: Edit logins (#9693) 
* Create editable view and fragment. Update login info page to display options menu with edit and delete.

* Create feature flag for edit. Check flag in the login detail fragment and default to just delete.

* Add three-dot kebab options menu in login detail fragment. Add title to the login item.

* Nav to and from edit view on save and back pressed.

* Save login through AC login manager. Clear text in editable field on button click.

* Match colors, fonts, dimens to UX specs for edit logins. Enable password reveal/hide and clearing text fields.

* Refactoring logins fragments. Using component Login object for consistency.

Fetch login list when saved logins are opened. Fetch login details when detail view is opened.

Revert "Fetch login list when saved logins are opened. Fetch login details when detail view is opened."

This reverts commit 44fe17166c3332b330229258b2e8982832672e3b.

* Using parcelable login and Login component class to pass ids and items between fragments

* Retrieve login from storage when viewing login details.

Rename login logic for consistency.

Ktlint cleanup

Fix nits and naming consistency.

* UX consistency for login detail and edit login pages

* Rebasing with logins sort - updating logins store.

* Rebasing with logins sort - merging fragments and controllers.

* Lint and removing unused files.

* UX cleanup.

* Update string description
 2020-05-12 17:32:01 -05:00
Tiger Oakes
f7b4f1c959
Cache findViewById calls in session control (#10575) 2020-05-12 14:05:08 -07:00
David Walsh
86dabe09c8
For 10503 - Update save to collection flow in tab tray (#10523) 2020-05-12 10:02:29 -05:00
mcarare
58df38105b For #10453: Use TabsTray API to set divider, avoiding related crashes. 2020-05-12 17:21:26 +03:00
Sebastian Kaspari
d58c022619 Integrate activity for showing past crashes. 2020-05-12 09:14:20 +02:00
Jeff Boek
a249334976
🎲 For #10332 - Adds undo snackbar when closing tabs in the tab tray (#10456) 2020-05-11 17:18:09 -05:00
Simon Chae
5ba9cc6ec9
For #10253: Add disableFirstTimePWAPopup for performance testing (#10442) 2020-05-11 16:31:31 -04:00
ValentinTimisica
15dfe0811d For #10343: Updates metrics accordingly to 'Library' removal 2020-05-11 10:22:19 -07:00
ValentinTimisica
b2e5820364 For #10343: Remove 'Library' functionality from the app 
Also adds Bookmarks and History items to browser menu.
 2020-05-11 10:22:19 -07:00
Simon Chae
ca7695854a
For #10552: Set initial add-on details fragment visibility to false (#10565) 2020-05-11 12:44:18 -04:00
Sawyer Blatz
17fb7c1df7
For #10426: Removes installation ping GAID (#10532) 2020-05-09 10:35:57 -07:00
Simon Chae
d58e7d3138 For #10473: Fetch the addon from addon manager instead of the store 2020-05-08 16:03:22 -07:00
Sawyer Blatz
b87c40d42f
For #10426: Sends GAID to Installation instead of Activation ping. (#10529) 2020-05-08 12:04:15 -07:00
codrut.topliceanu
d1005dd236 For #8589 - Fix for accessibility navigation in ETP panel 2020-05-08 09:57:59 -07:00
Arturo Mejia
ca01965f90 Fix PictureInPictureFeature breaking change 2020-05-08 11:42:06 -04:00
ekager
7fe6f68e00 For #10485 - Restore block video/audio on cellular data radio button 2020-05-08 14:00:09 +03:00
ValentinTimisica
f63cb4e09f For #10244: Creates drawable for add-ons private browsing label. 
The drawable is sent to AddonsManagerAdapter.Style constructor and is displayed
near the add-on name if it is allowed to run in private browsing
 2020-05-07 17:27:46 -07:00
Jeff Boek
58ca5d0e3a For #10341 - Always show collections placeholder with new tab tray enabled 2020-05-07 15:38:17 -07:00
Mihai Branescu
eef5cf3469 For #10482 - made SVG gradient compatible with API < 22 2020-05-07 10:39:58 -07:00
ekager
138d8e647d No issue - Use ViewLifecycleOwner lifecycleScope for Bookmark deletion scope 2020-05-07 10:17:42 -07:00
Sawyer Blatz
02f6e6868e
For #10426: Adds identifier to Glean for 24 hours (#10446) 2020-05-07 08:57:20 -07:00
Jonathan Almeida
57eb2b9549 For #10453: Do not set item decoration when creating ViewHolder 2020-05-07 11:44:19 -04:00
ValentinTimisica
24ba9f2fc8 For #9505: Adds possibility to sort saved logins 
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
 2020-05-07 08:43:59 -07:00
mcarare
9177871edc For #10408: Check current destination before navigating. 2020-05-07 09:35:10 +03:00
ekager
9fd835de0f For #10433 - Pass in viewLifecycleScope to BrowserAnimator 2020-05-06 23:24:46 -07:00
ekager
9ec1f8e2d8 For #8981 - Sort devices in share list by last access time 2020-05-07 09:20:49 +03:00
Michael Comella
4cf7280916 No issue: add clarifying kdoc for BookmarkFragment. 2020-05-06 17:27:58 -07:00
David Walsh
8b27a48635 For #10329 - Implement tab tray divider 2020-05-06 14:13:39 -07:00
Simon Chae
609936d632
For #10196: Remove clickable locks for enable and private-browsing UI (#10445) 2020-05-06 13:58:42 -04:00
Simon Chae
a851b76ea3
Update Android Components version to 41.0.20200506130132 (#10443) 2020-05-06 13:17:17 -04:00
Mihai Branescu
6f97e75579 For #8643 and #7606 - illustrations are now connected to their radio buttons 2020-05-06 09:18:27 +03:00
Mihai Branescu
cde31cf785 For #8643 and #7606 - Changed toolbar picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu
16b7a9399b For #8643 and #7606 - Changed theme picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu
4c0af91b7b For #8643 and #7606 - Changed tint for onboarding icons 2020-05-06 09:18:27 +03:00
Arturo Mejia
398b516fb7 No issue: Add Fingerprinters to the standard trancking protection policy 2020-05-05 17:33:42 -07:00
Christian Sadilek
fee09c3092 No issue: Show article/page url instead of reader extension url 2020-05-05 17:52:27 -04:00
Jeff Boek
d72e455c0d No Issue - Update to AC 41.0.20200505190119 2020-05-05 17:52:27 -04:00
Mihai Adrian
43d30793f5
For #9794: Announce installing state for screen readers (#10111) 2020-05-05 11:22:15 -07:00
Mihai Adrian
5106134786
For #10408: Dismiss menu when navigating away. (#10415) 
The menu is dismissed when toolbar view is detached from window.
 2020-05-05 11:15:30 -07:00
David Walsh
542f31f970
For #10392 - Don't provide a "Save to collection" button in private mode for the tabs tray (#10399) 2020-05-04 22:51:07 -04:00
Sören Hentzschel
10d07912da no issue - removed unused feature flag 2020-05-01 15:14:46 -07:00
Jeff Boek
94cd195dc7
Adds swipe to delete tab (#10355) 
* No Issue - Increases tap area of close button

* For #10331 - Adds swipe to delete to the tab tray
 2020-05-01 15:45:51 -05:00
Simon Chae
3dcd52ef7a For #10195, #10196: Allow private browsing mode switch to sync with enable state 2020-05-01 15:14:08 -04:00
Jeff Boek
5c7e9b98cd
Fix home navigation (#10350) 2020-05-01 12:46:02 -05:00
Jeff Boek
a8a90bd4d6
For #1063: Put tab tray behind a feature flag and hidden pref (#10313) 
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
 2020-04-30 15:53:10 -05:00
Chenxia Liu
390c5a0189 Issue #7996: fix lint issues 2020-04-30 13:38:52 +03:00
Jovan Gerodetti
4a12f1b6aa For #7996: Private mode doesn't play nicely with sites added to home screen 
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
 2020-04-30 13:38:52 +03:00
Arturo Mejia
56bb3e38ec For issue #10142 Update sitePermissions state when toggling its value 2020-04-29 18:33:34 -07:00
ekager
2e27bbd15d No issue - Remove unused data class TopSiteItem 2020-04-29 18:06:02 -07:00
Sawyer Blatz
38e9b34659
For #10071: Fixes PWA showing toolbar onPause (#10306) 2020-04-29 14:03:59 -07:00
mcarare
4006501d41 For #9728: Add actionbar search for language list. 2020-04-29 11:20:18 -07:00
ekager
52d09930a6 No issue - Update new strings for quarantine 2020-04-29 11:15:21 -07:00
Mihai Eduard Badea
02bd0cc203 For issue #8648 2020-04-29 09:48:42 -07:00
Jonathan Almeida
76002c5987 Fix breaking API changes in CrashReporter 2020-04-28 15:20:12 -04:00
Falaye Iyanuoluwa
c86209ff98 Closes #9694 Bug when user denies permission 2020-04-27 22:42:02 -07:00
mcarare
3c5d8d31ea For #10083: Adjust thumb offset to thumb circumference to avoid cutoff 2020-04-27 21:19:44 -07:00
David Walsh
6afcd2cee6 For #10201 - Provide proper button padding and no tabs message visibility in tabs tray 2020-04-27 20:36:08 -07:00
Arturo Mejia
e55a4fd274 No issue: Partially update the add-on manager list 2020-04-27 16:43:05 -04:00
mcarare
1aa473b112 For #9913, For #9914: Remove touch delegate when button is disabled. 2020-04-27 11:57:51 -07:00
ekager
a9692d9bce For #10204 - Address viewLifecycleOwner IllegalStateException crashes 2020-04-24 17:12:08 -07:00
Mihai Branescu
a16bfb27ef For #6557 - added unit tests 2020-04-24 15:47:48 -07:00
Mihai Branescu
0c2d22f595 For #6557 - add in_content telemetry class 2020-04-24 15:47:48 -07:00
Mihai Branescu
28496fecc0 For #6557 - split base extension functionality from ads 2020-04-24 15:47:48 -07:00
Mihai Branescu
f09bc4566c For #6557 - added metric for in_content 2020-04-24 15:47:48 -07:00
mcarare
e830da59b7 For #10180: Remove touch delegate when button is disabled. 
Also refactored multiple if's into a when.
 2020-04-24 13:28:29 -07:00
mcarare
3e13927c25 For #10180: Add extension to remove touch delegate from parent. 2020-04-24 13:28:29 -07:00
Mihai Branescu
c4d76dce5a For #6558 - cleanup + added unit tests 2020-04-24 09:28:40 -07:00
Mihai Branescu
f03d65b13d For #6558 - added logic for ad_clicked metric 2020-04-24 09:28:40 -07:00
Mihai Branescu
93ca1f6d9f For #6558 - added handling of web extension + sending metric for has_ads 2020-04-24 09:28:40 -07:00
Simon Chae
f1559ed2da
For #10162: Set switch back to prev state when failed to enable/disable addon (#10164) 2020-04-24 11:54:16 -04:00
mcarare
2edd4b39a4 For #9913, For #9914: Remove button when disabling it. 
Setting visibility to GONE allows clicks to parent view in that space.
 2020-04-24 16:42:47 +03:00
Arturo Mejia
956bf01cd5 For issue #9493: Reload after cleaning individual site permissions exceptions 2020-04-24 06:16:32 -04:00
David Walsh
6f5f48c30e
For #10148 - Add basic tab tray implementation without exposing to rest of app (#9934) 2020-04-23 15:38:35 -05:00
Vlad Filippov
e51e1c878b Add 'useEmail' and 'useEmailProblem' metrics event 
Fixes #9834
 2020-04-23 10:33:36 -07:00
Simon Chae
b3248ec769 For #6123: Expose WebExtensions in private browsing control 2020-04-23 12:28:57 -04:00
mcarare
cc67de29bf For #10091 Also disable play/pause button when hiding it. 2020-04-23 09:22:01 -07:00
mcarare
9dd8314d14 For #10091 Add extension to remove and disable button 2020-04-23 09:22:01 -07:00
mcarare
932fd44823 For #7387: Change ETP onboarding from popup to a dialog. 
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
 2020-04-23 08:17:42 -07:00
mcarare
72fe52fcb8 For #9987: Set FLAG_SECURE to dialog when flag set in activity. 2020-04-23 08:16:25 -07:00
ValentinTimisica
da3fca0f29 Fixes #10109: Adds content description for browse privately card content 2020-04-23 16:59:42 +03:00
mcarare
e11f1b62dc For #10027: Make toolbar context menu popup dismissible on SDK<23 2020-04-22 22:47:46 -07:00
ekager
c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 2020-04-22 20:56:35 -07:00
ekager
6457a02a82 For #2818 - Enable PiP for all builds 2020-04-22 20:55:00 -07:00
Roger Yang
0227e953ae Close #9760: Add external app links context menu candidate 2020-04-22 14:45:49 -07:00
Sawyer Blatz
dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 2020-04-22 14:29:43 -07:00
Arturo Mejia
0a23d66756 For issue #7566 Handle deny & don't ask again for site permissions 2020-04-22 11:33:32 -04:00
Arturo Mejia
995da59fa8 For issue #9493: Reload after cleaning all site permissions exceptions 2020-04-22 08:53:07 -04:00
ekager
70755adf6e For #10036 - Workaround for System Theme changes with config change 2020-04-22 00:01:54 -07:00
Michael
1f8b7ff962 Closes #8541: Hide find bar when entering fullscreen 2020-04-22 00:01:35 -07:00
Jeff Boek
164e6cd079 For #9816 - Adds SessionObserver to session on selection 2020-04-21 14:08:58 -07:00
Jonathan Almeida
6ad046714d Close #9338: Enable WebPush engine integration in all builds 2020-04-21 09:38:13 -04:00
ekager
f3847d0d7c For #8735 - Adjust fontInflation engine setting when toggling useAutoSize 2020-04-21 09:05:25 +03:00
ekager
66d9a24b28 Closes #9928 - Updates private browsing text description 2020-04-21 09:00:06 +03:00
ekager
5d51c4f059 Don't use ProcessLifecycleOwner for view-tied consume 2020-04-20 12:07:37 -07:00
ekager
f801f32027 No issue: Fix leaks in BookmarkFragment 2020-04-20 12:07:37 -07:00
ekager
5014cd78ec No issue: Fix leaking sessionControlInteractor 2020-04-20 12:07:37 -07:00
Grisha Kruglov
853a0acab4 Closes #4046: Always display 'Desktop' bookmarks folder 
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.

In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
 2020-04-17 23:57:43 -07:00
Jonathan Almeida
c16283a923 For #9932: Fix navigation icon theme missing from migration UI 
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
 2020-04-17 22:45:30 -07:00
Sawyer Blatz
a8e624959e
For #6940: Fixes top dynamic toolbar behavior (#9900) 2020-04-17 13:32:20 -07:00
Roger Yang
40550e88de
Close #9960: Launch URI in Fenix if failed to launch in custom tab (#9964) 2020-04-17 16:24:20 -04:00
Christian Sadilek
ec1d4e8fca For #8399: Hide keyboard to prevent content resizes 
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
 2020-04-17 12:07:44 -07:00
Michael Comella
f3ed207bdb For #8803 - review: Add clarifying comments to onAppInit capture methods. 2020-04-17 09:11:58 -07:00
Michael Comella
f49fc6dad2 For #8803: hook up frameworkStart metric. 2020-04-17 09:11:58 -07:00
Michael Comella
dbf733d70a For #8803: add StartupFrameworkStartMeasurement. 
This class controls the central logic around the metrics we want to
record.
 2020-04-17 09:11:58 -07:00
Michael Comella
7f618a6a7c For #8803: add Stat and test. 
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
 2020-04-17 09:11:58 -07:00
Emily Kager
39107b4036
For #9703 - Exit fullscreen in onPause and onSessionSelected (#10016) 
* For #9703 - Call fullScreenChanged in onPause

* For #10015 - Exit full screen if new session selected
 2020-04-17 08:57:36 -07:00
ekager
6f77ec5951 Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver 2020-04-16 21:00:27 -07:00
Grisha Kruglov
0ec6d266e8 Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry 
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
 2020-04-16 21:00:27 -07:00
Mihai Adrian
72fe9fad0c
For #9987: Set FLAG_SECURE to dialog when flag set in activity. (#9998) 
* For #9987: Add extension to secures dialog if parent activity is secured

* For #9987: Set FLAG_SECURE to dialog when flag set in activity
 2020-04-16 20:33:57 -07:00
Mihai Eduard Badea
725ba1e856 For #9951 - Removed the extra empty spaces that were causing the spacing issue 2020-04-16 20:12:18 -07:00
mcarare
83d2208c6b For #9536: Open report issue tab depending on current browsing mode. 
Checking if session is private uses the new browser state API.
 2020-04-16 19:50:25 -07:00
Sawyer Blatz
1f8f69548a For #7158: Fixes browser to search animation fade 2020-04-16 14:03:26 -07:00
Jonathan Almeida
25d5b0d31c For #8422: Add spacing between migration items 2020-04-16 12:02:02 -07:00
ekager
4a06a228f3 For #9981 - Make Bookmark Menu UI respond to session selection 2020-04-16 10:49:16 -07:00
mcarare
25e12e2f77 For #9984: Update addon before settings visibility check 2020-04-16 10:25:37 -04:00
Sawyer Blatz
8185ba793e
For #9857: Create button style (#9858) 
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
 2020-04-15 15:49:02 -07:00
Jonathan Almeida
997f6c72d6 For #9409: Add app icon to Leanplum push notifications 2020-04-15 17:55:12 -04:00
Jonathan Almeida
e97904662c Remove duplicate FirebasePushService 
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
 2020-04-15 17:55:12 -04:00
Mihai Branescu
bded28a017
For #9420 - relaxed custom engine rules (#9967) 
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
 2020-04-15 13:20:06 -07:00
ekager
aef827e607 For #9887 - Respect screenshot setting when resetting window flags in logins 2020-04-15 09:03:26 -07:00
Arturo Mejia
37a277febb For issue #9930 Do not assume all add-ons have a settings page 2020-04-15 06:20:34 -04:00
Arturo Mejia
8872baef39 Update Android Components version 2020-04-14 11:34:55 -07:00
Arturo Mejia
7c279b6e1f No issue: Fix add-on translate() breaking change 2020-04-14 11:34:55 -07:00
ekager
5b1cdbd8bf For #3194 - Pause media while undo snackbar appears 2020-04-14 09:55:39 +03:00
ekager
9c56a8b387 For #204 - Remove PWA Feature Flag 2020-04-14 09:55:14 +03:00
Jeff Boek
4cbb9aebaf
Cleans up nav_graph.xml (#9829) 
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
 2020-04-13 21:43:45 -07:00
Arturo Mejia
eace991859 For issue #8520: Improve add-ons UI 2020-04-13 19:01:58 -04:00
ekager
b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 2020-04-13 14:56:51 -07:00
ekager
ac3a557ddf For #9703 - Exit full screen on pause if pip not entered 2020-04-13 14:31:57 -07:00
Sawyer Blatz
7c3394ea7c
For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (#9893) 2020-04-13 13:08:08 -07:00
ekager
8c238402e2 For #9692 - Fix "Install" PWA menu item labeling 2020-04-13 10:09:37 -07:00
ekager
5039546dc5 For #7208 For #7212 - Update parameterized strings 2020-04-13 09:40:47 -07:00
mcarare
a214f04b4a For #9698: Use extension to ensure fallback to English and avoid crash 2020-04-13 09:40:00 +03:00
mcarare
4a1a875233 For #9698: Add Context extension to avoid format IllegalArgumentException 2020-04-13 09:40:00 +03:00
mcarare
177baf58a8 For #9798: Disable buttons on hiding and enable on showing. 
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
 2020-04-09 16:06:11 -07:00
Simon Chae
de311aef85
Update not yet unavailable add-on string (#9677) 2020-04-09 15:25:08 -04:00
Roger Yang
c9141c9ae5 Close #9827: Support display cutouts 2020-04-09 10:13:37 -07:00
Christian Sadilek
7f1ef17d8b No issue: Re-use existing usecases for addons 2020-04-09 12:53:47 -04:00
ekager
56eb2ec1d7 For #2818 - Adds Picture-in-Picture feature 2020-04-09 08:56:48 -07:00
Michael Comella
4437ddd536 No issue: Move Do and OpenClass to utils pkg. 
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
 2020-04-08 12:39:22 -07:00
mcarare
413af92bc5 For #9797: Set min height of dialog edit text to 48dp. 2020-04-08 10:12:20 -04:00
Abhay Agarwal
1c65bb8255 Closes #9495: Dismiss the ShareFragment in onPause() 2020-04-08 13:10:37 +03:00
Christian Sadilek
0f1bff7402 No issue: Refactor readerview to use browser-state 2020-04-07 16:31:03 -04:00
Sawyer Blatz
e94af334fc
No issue: Add more settings animations (#9750) 2020-04-07 10:44:23 -07:00
Mihai Eduard Badea
d66da53c9a For #2768 - Prevent screenshots in private mode 
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
 2020-04-07 17:23:06 +03:00
Mugurell
29539c458e For #9770 - Disable pull to refresh pending changes 2020-04-07 17:06:43 +03:00
Jeff Boek
c632b93ee7
For #220 - Removes feature flag for language picker (#9191) 
* For #220 - Removes feature flag for language picker

* For #220 - Updates Android Components
 2020-04-06 14:29:52 -07:00
Mihai Adrian
dfded8e69c
For #9687: Refactor onboarding cards to follow app architecture (#9743) 
* For #9687: Refactor onboarding cards to follow app architecture

* For #9687: Update unit test to new controller parameters
 2020-04-06 11:00:47 -07:00
Arturo Mejia
025656d8fd For issue #9647 Crash when tapping settings after quickly 
enabling/disabling add-on
 2020-04-06 13:47:21 -04:00