Commit Graph

192 Commits (1b2c0bd7999f68c0e981338a3fd4b61073ad10a1)

Author SHA1 Message Date
Michael Comella 070d098012 [fenix] No issue: remove lint baseline file.
This will enable folks to see the existing warnings.
5 years ago
Mihai Branescu bbd73acf60 [fenix] Feature/https://github.com/mozilla-mobile/fenix/issues/220 language menu (https://github.com/mozilla-mobile/fenix/pull/7070)
* For https://github.com/mozilla-mobile/fenix/issues/220
- Added advanced header + locale settings item in the settings fragment

* For https://github.com/mozilla-mobile/fenix/issues/220
- Added locale selection page with lib state + handling of locale changes

* For https://github.com/mozilla-mobile/fenix/issues/220
- Removed registering for locale changes in the manifest, allow system
to restart activity in that scenario

* For https://github.com/mozilla-mobile/fenix/issues/220
- Added unit tests for locale settings page

* For https://github.com/mozilla-mobile/fenix/issues/220: fixed an outdated unit test
ga-a

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
5 years ago
Severin Rudie 8b746007fd [fenix] 7410 remove rxjava (https://github.com/mozilla-mobile/fenix/pull/7426)
* For https://github.com/mozilla-mobile/fenix/issues/7410: rewrite updateBookmarkFromObservableInput with coroutines

* For 7410: remove RxJava from project. :(

* For 7410: converted updateBookmarkFromTextChanges to Flow per review
5 years ago
Michael Comella 42ec15c095 [fenix] No issue: remove unused Anko dependencies. 5 years ago
Kadeem M 78a599b06e [fenix] Added UI tests for the About Settings page (https://github.com/mozilla-mobile/fenix/pull/6161) 5 years ago
Ryan Kelly b806b4c5fa [fenix] Use feature-accounts-push, which replaces feature-sendtab. 5 years ago
Colin Lee a9a3fdc1fd [fenix] For https://github.com/mozilla-mobile/fenix/issues/4064: Replace prerelease R8 with improved Kotlin coroutines library (https://github.com/mozilla-mobile/fenix/pull/7153) 5 years ago
isabelrios 4a62f38670 [fenix] Re-enable Screenshots tests (https://github.com/mozilla-mobile/fenix/pull/6617)
disabling setting test options due to different screen sizes

name screenshots according to robots

fix kotlin style

update settings tests with new Toolbar option

screenshots tests in different package than ui tests
5 years ago
Gabriel 9ed4f7f119 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5574 - Migrate SessionControl to LibState (https://github.com/mozilla-mobile/fenix/pull/6651)
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (https://github.com/mozilla-mobile/fenix/pull/6651)

- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (https://github.com/mozilla-mobile/fenix/pull/6651)

In https://github.com/mozilla-mobile/fenix/issues/2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

- Removes TabAction

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 15: Introduce a HomeFragmentStore (https://github.com/mozilla-mobile/fenix/pull/6651)

- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 20: Remove the architecture module. (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 17:  Remove duplicate subscribeToTabCollections in BrowserFragment.kt (https://github.com/mozilla-mobile/fenix/pull/6651)

There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (https://github.com/mozilla-mobile/fenix/pull/6651)

- Renames SessionControlUIView to SessionControlView

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 21: Fix white screen on home fragment (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (https://github.com/mozilla-mobile/fenix/pull/6651)

This ensures that the metrics.track will be called immediately before the tab is removed from the collection.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 24: Use the sessionManager getter in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Removes running CI against the architecture debug build varient
5 years ago
mawen7 bbfa8aadd4 [fenix] Run lint for app module and set baseline 5 years ago
Sebastian Kaspari a126b92f9c [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/6622, https://github.com/mozilla-mobile/fenix/issues/6688: Create a "fennecBeta" and "fennecNightly" build types. 5 years ago
Johan Lorenzo 8eef026200 [fenix] Split UI test 5 years ago
Jeff Boek daaaeef741 [fenix] Adds custom search engines (https://github.com/mozilla-mobile/fenix/pull/6551)
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds button to add a new search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds custom engine store

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Creates a custom SearchEngineProvider

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Gives the ability to delete search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the UI to add a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds form to create a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to add a custom search engine

*  For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to delete custom search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Selects the first element on the add custom search engine screen

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Prevents adding a search engine that already exists

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Styles the add search engine preference

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Makes the name check case-insensitive

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fix bug where home screen doesnt see new search engines

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Moves Search URL validation to its own type

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes linting errors

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to edit a custom search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Allows the user to edit a serach engine even when it is the last item in the list

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds an undo snackbar when deleting a search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Moves all of the strings to be translated

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes bug when deleting your default search engine

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Puts adding search engines behind a feature flag

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Navigate to custom search engine SUMO article when tapping learn more

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes nits

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Uses concept-fetch to validate search string

* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds string resources for the cannot reach error state
5 years ago
Roger Yang f8b8249b3f [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6440 Integrate Web Notifications Feature 5 years ago
Tiger Oakes 037d35abd1 [fenix] Use ViewModel for share fragment 5 years ago
Emily Kager f279306478 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5074 - Sync Logins, Uses KeySharedPreferences for Passwords Encryption Key 5 years ago
Emily Kager fc7084a555 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5547 - Add top level auth when accessing passwords 5 years ago
Jonathan Almeida e5f9064701 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/373 - Integrate leanplum-fcm"
This reverts commit b1ce8ffcb7710fd98b692358309db42690593e11.

We're choosing to revert LeanPlum push messaging integration since we believe
that this has introduced a crash in Firebase push messaging. To verify
this assumption we're reverting this change, and when confirmed, we can
re-introduce Leamplum in a safer manner.

See https://github.com/mozilla-mobile/fenix/issues/6250 and https://github.com/mozilla-mobile/fenix/issues/6251 for related info.
5 years ago
Denys M f69e53c92d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2441. Update LeakCanary to `2.0-beta-3` version. 5 years ago
ekager 36de82bdc6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5544: Bare Minimum Logins UI 5 years ago
Alessio Placitelli 9d544a27e8 [fenix] Pick up forUnitTest library for the Glean SDK test 5 years ago
Grisha Kruglov 3e5c5d9514 [fenix] Perform Fennec data migration within fennecProduction 5 years ago
Mitchell Hentges cf0265e3b1 [fenix] Removes versionName check from gradle (https://github.com/mozilla-mobile/fenix/pull/5934) 5 years ago
MozLando cd489f765a [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5933
5933: Removes legacy nightly automation r=johanlorenzo a=mitchhentges



Co-authored-by: Mitchell Hentges <mhentges@mozilla.com>
5 years ago
MozLando 66e7638fb7 [fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5633
5633: Add fxa/sync integration tests r=csadilek a=isabelrios

 Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [-] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [-] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

This PR tries to add new tests, sync integration tests, to check the sync process Desktop<->Fenix, first for Bookmarks and in the future for more.

Co-authored-by: Isabel Rios <isabelrios@mackbookirios.home>
Co-authored-by: isabelrios <isabelrios@gmail.com>
5 years ago
Mitchell Hentges 4bd3882edb [fenix] Removes legacy nightly automation 5 years ago
Jeff Boek d09494613a [fenix] For https://github.com/mozilla-mobile/fenix/issues/373 - Integrate leanplum-fcm 5 years ago
Isabel Rios 339524226a [fenix] Add fxa/sync integration tests
fixing Jenkins path to tests and clean tests

commenting future tests and adding doc with info about the tests
5 years ago
Grisha Kruglov 6e6d2ec9c6 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1022: Auto-publication workflow for android-component
This patch enabled support for an auto-publication workflow for android-components.

It automates a common pattern seen in local development:

Old way:
- after every change in a-c, publish it locally with a unique version (bumping it manually)
- manually modify Fenix to consume a custom version of a-c from a mavenLocal repository

New way:
- set a flag in fenix's local.properties to enable auto-publication
- run Fenix builds after making changes to a-c. Changes in a-c will be automatically picked up.

Note that no changes are necessary to any Fenix files other than a single flag in local.properties.
Manually bumping android-components version is also not necessary.
5 years ago
Colin Lee a925cc246d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5599: Remove dependency on fetch_httpurlconnection (https://github.com/mozilla-mobile/fenix/pull/5716)
* For https://github.com/mozilla-mobile/fenix/issues/5599: Remove dependency on fetch_httpurlconnection

* For https://github.com/mozilla-mobile/fenix/issues/5599: Switch Glean to GeckoViewFetchClient

* Use existing Gecko client for Glean
5 years ago
Alessio Placitelli c43b478447 [fenix] Add the workmanager dependency to enable testing with Glean 5 years ago
Johan Lorenzo 081d9ee296 [fenix] taskgraph: Speed up gradle calls 5 years ago
Dennis Schubert ebee89cc0f [fenix] No bug - Add WebCompat feature. 5 years ago
Sawyer Blatz d95e439bab [fenix] Reverts https://github.com/mozilla-mobile/fenix/issues/1151: Removes unused Flipper library 5 years ago
Jonathan Almeida 8d8adae0f1 [fenix] No issue: Add Digital Asset Links token for TWAs 5 years ago
Alessio Placitelli 2edc73ed3f [fenix] Automatically generate metrics docs using the Glean SDK (https://github.com/mozilla-mobile/fenix/pull/5101) 5 years ago
Sebastian Kaspari 509d3c5e20 [fenix] Unbreak Nightly: Get rid of fragment-testing dependency and create fragments in test manually. 5 years ago
Aaron Train 036b3d239b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5217 - fix androidx.test dep error (https://github.com/mozilla-mobile/fenix/pull/5219)
See https://github.com/mozilla-mobile/fenix/issues/5217
5 years ago
Emily Kager 3b0a3c1643 [fenix] Add Tracking Protection Info Panel 5 years ago
mihai-adrian 40108e53c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4877: Restored logic for closing tabs when not on browserFragment
Added base test for CreateCollectionFragment that we can build upon later
5 years ago
Colin Lee 736fb7fd7c [fenix] For https://github.com/mozilla-mobile/fenix/issues/3106: Granular options for clearing user data 5 years ago
Sebastian Kaspari 1ad6f0ea20 [fenix] Add browser-state component. 5 years ago
Petru Lingurar 2f4392c064 [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/5067 - Refactor ShareController to use SendTabUseCases
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
5 years ago
Sebastian Kaspari 61c2a0878f [fenix] Issue https://github.com/mozilla-mobile/fenix/pull/4907: Link to usage of sharedUserId in Fennec code. 5 years ago
Sebastian Kaspari 720589cbb0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Use manifest placeholder to inject sharedUserId. 5 years ago
Sebastian Kaspari 9a01bb2639 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Use Fennec version code mechanism for fennecProduction build type. 5 years ago
Sebastian Kaspari b4b87eb165 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Only build fennecProduction build types with GeckoView Beta. 5 years ago
Sebastian Kaspari c91a28030f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Reuse Firefox application id for fennecProduction build type. 5 years ago
Sebastian Kaspari 7061d22246 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Introduce "fennecProduction" build type. 5 years ago
Tiger Oakes e4abe9cace [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/773 - Add shortcuts to homescreen (https://github.com/mozilla-mobile/fenix/pull/4925) 5 years ago