fc46ab2804
Close #19731 : Track metrics before we dismiss the tabs tray
3 years ago
e69bf4e26a
For #19564 : Explicitly update switch state for a11y event announcements. ( #19589 )
3 years ago
d30ebf86f9
For #19693 - Display a biometric prompt when a credit card is selected to autofill ( #19697 )
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
daba5595f6
Enable addresses sync for nightly/debug builds
3 years ago
e891139db9
Minor cleanup of the account settings
3 years ago
e0b410efdf
For #18711 : Telemetry for credit card autofill ( #19548 )
3 years ago
89a1b0016c
For #19492 - Provide the correct CreditCardNumber type to UpdatableCreditCardFields when updating a credit card ( #19692 )
...
We were crashing because we were specifying the wrong `CreditCardNumber` type when constructing the `UpdatableCreditCardFields`.
We only had the plaintext card number from the user input, but was placing it off as an encrypted card number, which resulted in the crash.
3 years ago
9d1e51dfff
Fix breaking change in MetricController
3 years ago
3a57188c35
Fix lint/detekt issues
3 years ago
ab678a21ff
Add an experiment to demontrate the Feature API
...
This is not visible in production, but only debug. It shows three variables
being used to change the settings screen (title, icon and title-punctuation).
3 years ago
279d59897c
For #18264 - Add biometric prompt to credit card settings ( #19505 )
3 years ago
758700cbb0
Issue #19647 : Navigate to browser from home via Synced Tabs page
3 years ago
338c488fae
For #19680 - Show the card number when editing a credit card ( #19681 )
3 years ago
c11335fafc
For #18271 - [Saved cards] Display the credit card provider icon and report the correct card type ( #19652 )
3 years ago
bd8facb025
For #18263 - Allow dynamically toggling credit cards autofill
3 years ago
ac71b47c61
For #19653 - Address 19643 PR comments
...
Rename handleAddCreditCard to handleAddCreditCardClicked
Rename onClickAddCreditCard to onAddCreditCardClick
Format layout_add_credit_card.xml
3 years ago
3fb40e1f40
For #19475 - Introduce a DefaultTabsTrayInteractor
...
Refactored the TabsTrayFragment to not implement the TabsTrayInteractor which
among other advantages allowed for easier testing.
3 years ago
dc26272381
For #19475 - Cleanup - respect naming scheme in TabsTrayController
...
In our current MVI implementation the View Interactors are first called in
response to a direct user action and contain methods following the
"onXXHappened" naming scheme and then delegate other Interactors / Controllers
for specific actions.
Controllers contain the business logic for actually updating the app's state
and offer methods following the "handleXXAction" naming scheme.
3 years ago
84f4ff0d86
Issue #17819 : Update detekt to 1.17.1
3 years ago
0a226962bb
For #18881 - Create a new layout for 'Add credit card' button
...
Add functionality for 'Add credit card' button
Add unit tests for 'Add credit card' functionality
3 years ago
5f2b3fec38
For #18270 - Adds ellipses+last 4 digits to CC display ( #19420 )
...
* For #18270 - Adds ellipses+last 4 digits to CC display
3 years ago
0141d96465
For #19554 : Add SyncEngine.CreditCards to sync supportedEngines.
3 years ago
9400f58e2a
For #17538 : Perform autofill storage warm-up after visual completeness.
3 years ago
a862824697
For #19600 : Change manage cards preference UI dynamically.
3 years ago
bcf6b901ee
For #19600 : Change manage cards preference UI dynamically.
3 years ago
bbc25e430e
For #19590 - Enable credit card autofill in Debug and Nightly ( #19601 )
3 years ago
761752e382
AutofillConfiguration: Correctly specify autofill confirm activity.
3 years ago
d96415111b
For #19054 - Navigate to the Credit card screen when deleting last card. ( #19451 )
3 years ago
11efbaacc4
For #18507 - Prevent screenshots on credit card screens. ( #19560 )
3 years ago
888b45b079
For #8370 : Remove extra characters from name mapping.
3 years ago
52587753a5
Remove feature flag for proton icons re-design #18132
3 years ago
75fc116043
For #18287 - Display a credit card autofill prompt ( #19477 )
3 years ago
bf42a1786e
For issue AC#10231 update proton icons third batch
3 years ago
6459a859b9
For #17537 : Add preferences for syncing credit cards and addresses ( #19471 )
...
* Add preferences for enable/disable sync for cc and addresses
* Set pref visibility based on feature flags
* Helper function for pin warning preferences and set default values for cc and addresses to false.
* Kdocs for relevant sync functions in account settings
* Default visibility to false for credit cards and addresses in account settings
3 years ago
ede909e858
Issue #19176 : Exit select mode when removing tab ( #19486 )
3 years ago
4dd4e35982
For #19258 : Replace default Android back button with a custom icon.
3 years ago
d08b00717a
For #19091 - Fix Undo of close multiple tabs ( #19466 )
...
Fixes the issue where closing multiple selected tabs and then pressing Undo would only restore one of the tabs.
3 years ago
f13560ae52
Issue #19147 : Move set startup metrics off main thread
3 years ago
f0d352f47e
Issue #19002 : Correct naming of pager viewholders
3 years ago
a95a26b2c6
Issue #19002 : Use a single BrowserTrayList for normal/private list
...
We now have a BrowserTrayList.
- Renamed from `BaseBrowserTrayList`.
- Removed the abstract `configuration` and used a `lateinit var`
instead.
- Removed `NormalBrowserTrayList` and `PrivateBrowserTrayList`.
3 years ago
bd753d3f94
Issue #19002 : Correct browser viewholder naming
3 years ago
809c82a9f9
Issue #19002 : Move TabsTrayViewHolder to browser package
3 years ago
78af3d80b3
Issue #19002 : Remove unused TrayItem interface
3 years ago
e66983d093
Issue #19002 : Use AbstractBinding from lib-state
3 years ago
551031eee3
For #18672 - Renaming a TopSite changes just the title
...
Previously renaming a TopSite would bind that as a new item and in such update
the entire list. This could potentially leading changes in the list and then
it's ViewPager parent's layout.
This patch switches the code to use the existing TopSitePayload and so do a
partial update of an on-screen TopSite instead of rebind it as a new item.
If a layout is requested while showing <=4 TopSites on the second page, by
having "offscreenPageLimit = 1" the biggest height of ViewPager pages is used
preventing an edgecase where the ViewPager would hide half of the items from
the first page.
3 years ago
9e30833506
For #18672 - Rename TopSites even on the second page
...
Index calculation for notifying changes while renaming a top site in the second
page was being wrongly calculated. Since it is page 2, we would need to take a
mod with the number of top sites per page to get the actual index of the top
site that was being renamed.
3 years ago
392ace67d6
Issue #19175 : Fix SyncTabs list not updating on changes
...
The main cause for this is that the `LifecycleProvider` needs to be set
to `State.RESUMED` to avoid the account manager's internal
`ObserverRegistry` from putting the UI observers into the paused state.
The rest of the changes is to rely the internal (safe) logic to
correctly sync and then update the tabs list.
3 years ago
93c6403882
For #19357 : Remove bookmarks experiment and keep star-with-line icon.
3 years ago
cf9a84eed5
Move locale restoration on startup to the visual completeness queue to prevent perf impact ( #19315 )
3 years ago
6cbc35b7d8
Fixed mozilla-mobile#18641: [Bug] Fill link from clipboard overlaps search engines ( #18657 )
3 years ago
d83c9d1e72
For #18993 - Nimbus: Allow internal tooling to opt into specific branches of an experiment ( #19333 )
3 years ago
a9e0557d83
Closes #3728 : Add secret menu switch for allowing third party root certificates ( #19398 )
3 years ago
9bfb31519a
For issue #19290 update to proton icons second batch
3 years ago
516d52997d
For #18266 : Validate credit card entry info.
3 years ago
3428dd67ed
For #18266 : Refactor fragment and view to remove duplicate code.
3 years ago
277034546f
For #18262 - [Credit cards] Turn the "Sync cards across devices" button into a "Sync cards" toggle ( #19207 )
...
* For #18262 - Turns "Sync cards/logins" into toggle
3 years ago
74047cdceb
Closes #19147 : Move startup metrics to right after Glean initialization ( #19252 )
3 years ago
0c74756d39
For #19132 - Fix navigation on disconnect started from tabsTray
...
- Added checks to popBackStack from the Disconnect Logged-in User Dialog, either back to settings, browserFragment or homeFragment.
3 years ago
f421f82f2c
Close #19259 : Pass CoroutineContext to nav interactor constructor
3 years ago
79cf3fc765
Closes #18253 : Bookmark and History open new tabs in the background ( #19275 )
3 years ago
5b5e7ebf47
Turn on feature flag for three-dot menu redesign for beta. ( #19111 )
3 years ago
5f4a590418
Issue #19040 - Update marketing data setting description
3 years ago
59de530a9c
Closes #18253 : Remove spaces from Addons telemetry comma-separated list ( #19292 )
3 years ago
21cf0b31a4
For issue #18132 update to proton icons first batch
3 years ago
8c0f86bd96
For #19213 : Adjust synced tabs to properly show in RTL.
3 years ago
d495d84208
For #11819 - Show the mic in widget only if setting is enabled
...
If "Show voice search" is disabled under Settings, the mic icon should not be
shown in the search widget.
3 years ago
c725493bea
Fix openFile breaking changes
3 years ago
7d690219ea
Issue #19040 : Remove Leanplum (Nightly)
3 years ago
4e16c46b27
Fix breaking changes introduced by credit card encryption APIs
3 years ago
6a1b5875b0
Use new SearchSuggestionProvider flag.
3 years ago
e952513569
For #19065 - Add extension functions to be used with credit cards. ( #19187 )
3 years ago
dc51cd47b5
For #18591 - Make the navbar sticky in the new menu
3 years ago
cd37f398f1
Closes #18816 : Disable TabsTray FAB on accessibility enabled ( #19170 )
3 years ago
ded686d533
For #19125 : Move top site pin net to title.
3 years ago
cf4847dc17
Remove browser-search references.
3 years ago
00744fa9e5
For #18267 : Updates preferences visibility depending on creditCardsStore
3 years ago
db76b8fe21
For #19114 : check state of sync account when navigating from sync sign in menu item ( #19118 )
3 years ago
8f1b3e03f1
For #18608 : Also add default browser item in new menu.
3 years ago
acb24396e5
Address WebExtensionBrowserMenuBuilder breaking change
3 years ago
a126f0913a
Update to Mozilla Android Components 90.0
3 years ago
8b3a878062
No issue: Rename Event for naming consistency.
3 years ago
f693375270
For #18852 : Add metrics for default browser settings experiment.
3 years ago
59c94e447c
For #19005 : new tab three-dot menu sync sign in ( #19037 )
...
* Show synced tabs or sync account in new tab menu
* Sync sign in item navigates to account settings
* Check account auth and get sync item title
* Look for sync sign in item on home menu for UI test
* Sync sign in menu item UI test
3 years ago
69efd3a089
Close #19094 : Open sign-in flow if no account is created for tabs tray
3 years ago
cfaaf82541
No issue: Allow tabstray rewrite to ride the trains
3 years ago
46cec3d658
No issue: Fix regression in last tab deleted
...
When we allow the homescreen to handle undo for the last tab, we no
longer need to handle this ourselves with our own binding.
In the future, we should re-think this logic to be more robust and less
spread out across multiple screens.
3 years ago
1e09d50fd7
No issue: Fix the initial select mode check
3 years ago
ad483903ed
No issue: Do not create a new instance of TabsTrayStore
...
We only need one. :)
3 years ago
053453cc7f
No issue: Enable tabs tray re-write by default in nightly
3 years ago
f94f8531f6
For #18496 : Set activity theme in onCreate before call to super.
3 years ago
8b6d06e551
Close #19064 : Focus on tab page with the BrowsingModeManager
3 years ago
cba68faac6
Closes #18946 : Add undo toast for tabstray
3 years ago
cbc5df3c63
For #18836 : address onCreate method length detekt issue.
3 years ago
d6999234b0
For #18836 : add & integrate StartupTypeTelemetry.
3 years ago
a64540bd06
For #18836 : add StartupPathProvider + tests.
3 years ago
ec65737cbb
For #18836 : address lint errors for StartupStateProvider*.
3 years ago
ea1d569837
For #18836 : add getStartupStateForStartedActivity method.
3 years ago
18507ec24c
For #18836 : add isHotStartForStartedActivity and tests.
3 years ago
e803cc61a2
For #18836 : add isWarmStartForStartedActivity, tests.
3 years ago
ed1f38611f
For #18836 : shorten isColdStart... and rm questionable test.
...
The test failed with the rewrite of the code because it violates
one of our assumptions that only one Activity will be started. However,
since it doesn't rely on observed behavior and we made up the events,
it's value is questionable so it seems okay to remove, especially for
the gain of conciseness in the code.
3 years ago
Jonathan Almeida
Mihai Adrian Carare
Gabriel Luong
Grisha Kruglov
Elise Richards
Christian Sadilek
James Hugman
Mugurell
Ionut Cristian Bedregeanu
Sebastian Kaspari
Codrut Topliceanu
mcarare
Arturo Mejia
Roger Yang
kanish671
Dharan Aditya
codrut.topliceanu
Michael Comella