Commit Graph

6149 Commits (18a87888122c641f196f67ff37e87ff4ceaae675)

Author SHA1 Message Date
Jonathan Almeida 18a8788812 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21707: Correct search grouping logic in extensions
At this moment, we have two extension methods that have duplicate
functionality to construct search term groupings. One on `List<Tab>` and
one on `List<TabSessionState>`. The former is used for everything
related to tabs piped through the `TabsFeature` and the latter is for
consumers of `BrowserState` directly.

The bug occurs because our implementation of search groupings was
updated only on the former extension, but the `HeaderBinding`, that
observes the BrowserState and updates the title visibility, was using
the latter.

Ideally, we remove this duplication when we no longer have separate data
classes for consumers of `TabsFeature`, but this intermediary fix should
suffice.
3 years ago
Gabriel Luong cb7cc7a7eb [fenix] For https://github.com/mozilla-mobile/fenix/issues/21760 - Remove some unused resources 3 years ago
Grisha Kruglov 7efdddcaeb [fenix] Fix up HistoryMetadataController tests 3 years ago
Grisha Kruglov eef2ad800a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21871 - Eagerly update UI state after search group removal
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.

This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).

This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.

After this patch, we:
 - dispatch two actions (on browserstore, on homefragmentstore) which
   remove the search groups from any relevant in-memory state; any UI bound to
   this state will be automatically "refreshed"
 - no longer navigate as part of the remove action, so the UI doesn't
   move and removal happens "in-place"
3 years ago
Christian Sadilek 0751190582 [fenix] Handle new OptimizedLoadUrlAction in history metadata middleware
Upgrades to A-C 95.0.20211013154351
3 years ago
Jonathan Almeida 4fee8036a0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794: Remove rotation; rely on state activated
It seems like we no longer need to use rotation for the chevron, since
we are now using two different icons within the `ic_chevon` that change
depending on the `state_activated`.
3 years ago
sunil9211 45330287b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17393: Dead code removed around Delete downloads 3 years ago
AndiAJ 7638040a3a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix and re-enable editCustomSearchEngineTest 3 years ago
Arturo Mejia 0658de464f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21791 Adds tab auto-close prompt 3 years ago
AndiAJ 1bb5f1479d [fenix] Disable editCustomSearchEngineTest UI test 3 years ago
Arturo Mejia d6ae910c74 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21838 wait until experiments have been completely opt-out on the nimbus SDK. 3 years ago
AndiAJ 6a7c42a398 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21620 fix for disabled toggleSearchSuggestions UI test 3 years ago
AndiAJ f0091a768c [fenix] For https://github.com/mozilla-mobile/fenix/issues/19016 re-enable changeThemeSetting Ui test 3 years ago
Mugurell ec442f575f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21861 - Ignore the UnusedResources lint check for localized strings 3 years ago
AndiAJ 7f9dab5654 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21540 fix disabled editCustomSearchEngineTest 3 years ago
Oana Horvath 3ea7755592 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21006 & https://github.com/mozilla-mobile/fenix/issues/21005: fixed ETP status info display 3 years ago
Elise Richards 897aa4b662 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21522: Wrap section titles on home 3 years ago
Elise Richards 86029b181c [fenix] For https://github.com/mozilla-mobile/fenix/issues/21313: Renew fission metrics expiring in December 3 years ago
Roger Yang c7232a0bdb [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686: Stop using internally stored tabs list in adapters 3 years ago
Mugurell f10d226f92 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21806 - Set 1dp elevation for ListItemTabLarge
To get smaller shadows.
3 years ago
Mugurell cde1c3b911 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Simplify test to not depend on store updates. 3 years ago
Mugurell e22e33c3c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Replace mock of an interface with mock of a fake. 3 years ago
Christian Sadilek b916fc4a85 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21437: Fix default of start_on_home setting in UI 3 years ago
Gabriel Luong ff62ffe70a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21809 - Adjust the padding between the Pocket section 3 years ago
Jonathan Almeida d13f0ef797 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21794: Reverse chevron for inactive tabs 3 years ago
MickeyMoz 16ed26781d [fenix] Update Android Components version to 95.0.20211008105820. 3 years ago
AndiAJ aa6387809d [fenix] Remove openNewTabAndEnterToBrowser() and replace it with enterURLAndEnterToBrowser() in the UI tests 3 years ago
AndiAJ 153bfcce38 [fenix] Remove closeTabViaXButton() and replace it with closeTab() in the UI tests 3 years ago
AndiAJ 3317d98b34 [fenix] Fix for ambiguous mozac_browser_tabstray_close and with content description 3 years ago
AndiAJ 7dd7b2e5b2 [fenix] Fix for ambiguous tabstray_title and with text 3 years ago
AndiAJ d6755b5580 [fenix] Fix for ambiguous tabstray_close 3 years ago
AndiAJ 75606a8786 [fenix] Fix for ambiguous tab_item 3 years ago
codrut.topliceanu 822775eb9d [fenix] For https://github.com/mozilla-mobile/fenix/issues/20992 - Speculative fix for TopSitesPagerAdapter crash 3 years ago
Jonathan Almeida 363e563fc7 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686: Move submitList calls into TabsAdapter
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
Noah Bond 39a3aacc78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21773 - Updated "customize homepage" button to go to the new Homepage submenu in Settings 3 years ago
Christian Sadilek d73ea2cf98 [fenix] Enable pocket stories in CA 3 years ago
Arturo Mejia 185121606c [fenix] Prepare nimbus features default values for release 95 3 years ago
Rohan Maity 2fc70778a9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20579: Fix the normal browing tab re-used unexpectedly when open links in private tab enabled or same tab is already avaialble in normal browsing mode 3 years ago
Arturo Mejia a4fcc93d0a [fenix] For https://github.com/mozilla-mobile/fenix/issues/21765 only activate pocket by default for the right audience 3 years ago
Mugurell e6a73b5118 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21623 - Pocket recommended stories telemetry 3 years ago
Michael Comella 257ae4b118 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21424: add marker for StrictMode.resetAfter.
This helps identify file IO. Unfortunately, with this marker, it's
difficult to separate code we own from code we don't own. However, I
wasn't sure what the best implementation would be to address that
(e.g. ideally, we would ignore violations in code we don't own rather than
annotate the markers) so I thought we can land it this simple way and
improve it incrementally.
3 years ago
Gabriel Luong e3b2309ac2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21756 - Refactor TopSites out of home.sessioncontrol 3 years ago
Noah Bond b772f6d080 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen (https://github.com/mozilla-mobile/fenix/pull/21722)
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen

* For https://github.com/mozilla-mobile/fenix/issues/21437 - Updated show top sites toggle text

* PR: Fixed lint warning. Reverted preference keys

* PR: added ignore for UI test

* PR: Added ignore for UI test
3 years ago
Roger Yang 259b2e5d30 [fenix] No issue: Update Pocket categories spacing to 16dp. 3 years ago
Sebastian Kaspari a4e21f4fbb [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21102: Set compileSdkVersion to 31. 3 years ago
Roger Yang c9d8e826ca [fenix] No issue: Small layout update for Pocket Stories 3 years ago
Gabriel Luong 398bdac5aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/21729 - Refactor SectionHeader to use the right font size 3 years ago
Sebastian Kaspari e487bc6f59 [fenix] SearchDialogFragment: Start to split consumeFrom() into independent observers that trigger less often 3 years ago
Arturo Mejia 3e01e9df25 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21611: Show the jump back in Contextual Hints independently of the home onboarding dialog. 3 years ago
Arturo Mejia f4f7c1b0e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21574: disabled the homescreen onboarding dialog. 3 years ago