Michael Comella
3556b5a10f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 : add StartupTimeline ping type and framework_start metrics.
2020-04-17 09:11:58 -07:00
Emily Kager
04af2a59e8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9703 - Exit fullscreen in onPause and onSessionSelected ( https://github.com/mozilla-mobile/fenix/pull/10016 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9703 - Call fullScreenChanged in onPause
* For https://github.com/mozilla-mobile/fenix/issues/10015 - Exit full screen if new session selected
2020-04-17 08:57:36 -07:00
ekager
94515941cf
[fenix] Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver
2020-04-16 21:00:27 -07:00
Grisha Kruglov
2a4ad0e4eb
[fenix] Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
...
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
2020-04-16 21:00:27 -07:00
Mihai Adrian
b510210dce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9987 : Set FLAG_SECURE to dialog when flag set in activity. ( https://github.com/mozilla-mobile/fenix/pull/9998 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9987 : Add extension to secures dialog if parent activity is secured
* For https://github.com/mozilla-mobile/fenix/issues/9987 : Set FLAG_SECURE to dialog when flag set in activity
2020-04-16 20:33:57 -07:00
mozilla-l10n-automation-bot
a384ea16d0
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/10011 )
2020-04-16 20:32:21 -07:00
Emily Kager
e68491d737
[fenix] Fix: Set correct height for EditText ( https://github.com/mozilla-mobile/fenix/pull/10014 )
...
Created a dimension for the correct height that the EditText in the
fragment_edit_bookmark.xml has to have.
Co-authored-by: DrCesar <josuejacobstercero@gmail.com>
2020-04-16 20:31:25 -07:00
Mihai Eduard Badea
590a65a894
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9951 - Removed the extra empty spaces that were causing the spacing issue
2020-04-16 20:12:18 -07:00
mcarare
4010e9b64e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9565 : Adjust padding and height to allow longer text
2020-04-16 20:10:45 -07:00
mcarare
a697247aae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9536 : Update tests to check opened tab is in same browsing mode
2020-04-16 19:50:25 -07:00
mcarare
b5255177fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9536 : Open report issue tab depending on current browsing mode.
...
Checking if session is private uses the new browser state API.
2020-04-16 19:50:25 -07:00
mcarare
86677b3bf3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9989 : Add start & end margin to button.
2020-04-16 19:43:34 -07:00
Sawyer Blatz
fba1e732ef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7158 : Fixes browser to search animation fade
2020-04-16 14:03:26 -07:00
ekager
053f2017e6
[fenix] No issue: Uses NeutralButton for Migration Activity
2020-04-16 13:14:34 -07:00
Jonathan Almeida
1ce8e8383c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8422 : Add misc migration UI fixes
2020-04-16 12:02:02 -07:00
Jonathan Almeida
154ade7d64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8422 : Add spacing between migration items
2020-04-16 12:02:02 -07:00
ekager
7f3ca10103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9981 - Make Bookmark Menu UI respond to session selection
2020-04-16 10:49:16 -07:00
mcarare
880722de99
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9984 : Update addon before settings visibility check
2020-04-16 10:25:37 -04:00
Mozilla L10n Automation Bot
e3712155f9
[fenix] Import l10n.
2020-04-16 10:13:30 +03:00
ekager
e4136c64d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9516 - Adds selectable background to dialog and snackbar buttons
2020-04-16 10:13:08 +03:00
Sawyer Blatz
e33e84bcbc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9857 : Create button style ( https://github.com/mozilla-mobile/fenix/pull/9858 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9857 : Creates text button style
* Adds lint check
* Fixes onboarding cards
2020-04-15 15:49:02 -07:00
Jonathan Almeida
9a162480c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9409 : Add app icon to Leanplum push notifications
2020-04-15 17:55:12 -04:00
Jonathan Almeida
8ea49eb36a
[fenix] Remove duplicate FirebasePushService
...
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
2020-04-15 17:55:12 -04:00
Mihai Branescu
d2b9f203b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9420 - relaxed custom engine rules ( https://github.com/mozilla-mobile/fenix/pull/9967 )
...
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
2020-04-15 13:20:06 -07:00
Michael Comella
de6bbb791a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9644 : restrict deps to specific repositories ( https://github.com/mozilla-mobile/fenix/pull/9649 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9644 : remove unnecessary leanplum maven repository.
The docs say it is [1] "only needed for Android SDK versions below 4.3.0".
That is API 18 and our min SDK is 21.
[1]: https://docs.leanplum.com/reference#android-setup
* For https://github.com/mozilla-mobile/fenix/issues/9644 : move buildscript block from :app to root project.
This will reduce the amount of duplication we need in specifying
restricted dependencies and centralize repository definitions. Since
we're a one project app, it shouldn't have a significant impact on
performance.
* For https://github.com/mozilla-mobile/fenix/issues/9644 : restrict dependencies following FFTV config.
However, there is a resolution error to be fixed in the next commit.
This is verbatim from FFTV except I removed the no-op "improve security
if code is refactored incorrectly" lines: these lines rarely changed and
I'm not that concerned. It might be better to simplify the
configuration.
Source:
62a2fa680c/buildSrc/src/main/java/org/mozilla/gradle/Dependencies.kt (L7)
62a2fa680c/build.gradle (L31)
* For https://github.com/mozilla-mobile/fenix/issues/9644 : restrict firebase deps to google repo.
This fixes the resolution error from the previous PR.
2020-04-15 10:54:36 -07:00
ValentinTimisica
5504208fcd
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9710 : Vertically aligns users_count with rating ( https://github.com/mozilla-mobile/fenix/pull/9950 )
2020-04-15 10:51:55 -07:00
ekager
6b4334b699
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9887 - Respect screenshot setting when resetting window flags in logins
2020-04-15 09:03:26 -07:00
Jeff Boek
f35e5f3526
[fenix] No Issue - Fixes nav_graph issues ( https://github.com/mozilla-mobile/fenix/pull/9926 )
2020-04-15 08:34:45 -07:00
Arturo Mejia
bda6aa50f3
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9930 Do not assume all add-ons have a settings page
2020-04-15 06:20:34 -04:00
Mozilla L10n Automation Bot
d96a6b206c
[fenix] Import l10n.
2020-04-15 03:50:48 +03:00
ekager
4b5c454de7
[fenix] Update UI test to match Support Page title
2020-04-14 11:34:55 -07:00
ekager
e0a4a63d52
[fenix] Update Server.dev to Server.stage to fix A-S upgrade breaking change
2020-04-14 11:34:55 -07:00
Arturo Mejia
e5041e2fd8
[fenix] Update Android Components version
2020-04-14 11:34:55 -07:00
Arturo Mejia
f38165ad6d
[fenix] No issue: Fix add-on translate() breaking change
2020-04-14 11:34:55 -07:00
ekager
3b980dadad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3194 - Pause media while undo snackbar appears
2020-04-14 09:55:39 +03:00
ekager
c33ac4edc0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/204 - Remove PWA Feature Flag
2020-04-14 09:55:14 +03:00
Mozilla L10n Automation Bot
21dde5fe0b
[fenix] Import l10n.
2020-04-14 09:54:30 +03:00
Jeff Boek
6308049167
[fenix] Cleans up nav_graph.xml ( https://github.com/mozilla-mobile/fenix/pull/9829 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up homeFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Uses global actions for fragments not owned by homeFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up SearchFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes settings action from DeleteBrowsingDataFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes browser action from SettingsFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Adds ManagePhoneFeature global action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Clean up unused deletebrowsingfragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans Up HistoryFragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes Home -> Search action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes the Bookmark -> Browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up bookmark fragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up actions from ShareController
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes defaultBrowserFragment to browserFragment action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes about -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Adds global action to TrackingProtectionFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes exception -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes login -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Fixes LoginFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes ExternalAppBrowser directions
* for https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Fixes unit tests
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Addresses nits in PR
2020-04-13 21:43:45 -07:00
Arturo Mejia
fa157d252b
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520 : Improve add-ons UI
2020-04-13 19:01:58 -04:00
ekager
101d815231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9890 - Do not display full screen snackbar with toolbar padding
2020-04-13 14:56:51 -07:00
ekager
cf3f14b795
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9703 - Exit full screen on pause if pip not entered
2020-04-13 14:31:57 -07:00
Sawyer Blatz
92ea1cc5b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9892 : Set dynamicToolbarMaxHeigtht to 0 for PWAs ( https://github.com/mozilla-mobile/fenix/pull/9893 )
2020-04-13 13:08:08 -07:00
ekager
27adb232c7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9692 - Fix "Install" PWA menu item labeling
2020-04-13 10:09:37 -07:00
ekager
089e2db827
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7208 For https://github.com/mozilla-mobile/fenix/issues/7212 - Update parameterized strings
2020-04-13 09:40:47 -07:00
Christian Sadilek
7ca7557c17
[fenix] Configure M2 AMO collection for Nightly/Debug
2020-04-13 10:42:39 -04:00
Oana Horvath
acc46c960b
[fenix] fix https://github.com/mozilla-mobile/fenix/issues/9670 intermittent tests ( https://github.com/mozilla-mobile/fenix/pull/9767 )
...
also disabled intermittent closePrivateTabsNotification
2020-04-13 13:17:35 +03:00
mcarare
682b6db6a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9698 : Add unit tests for Context extension getStringWithArgSafe
2020-04-13 09:40:00 +03:00
mcarare
fca63c72d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9698 : Use extension to ensure fallback to English and avoid crash
2020-04-13 09:40:00 +03:00
mcarare
79e3a1c328
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9698 : Add Context extension to avoid format IllegalArgumentException
2020-04-13 09:40:00 +03:00
Mozilla L10n Automation Bot
b1aebe96de
[fenix] Import l10n.
2020-04-13 09:38:41 +03:00
Mugurell
83063d66f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7157 - Set BrowserMenu width to be max 314 dp ( https://github.com/mozilla-mobile/fenix/pull/9731 )
...
Instead of having a fixed width of 250dp the BrowserMenu will now have a
dynamic width between 250dp and 314dp allowing for a better fit for the menu
items it could display.
2020-04-10 10:17:07 -07:00
mcarare
c3a5be128f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9793 : Adjust relative positions to provide correct a11y traversal
2020-04-10 14:35:58 +03:00
Mozilla L10n Automation Bot
9baa18640c
[fenix] Import l10n.
2020-04-09 17:38:37 -07:00
mcarare
290141865c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9798 : Disable buttons on hiding and enable on showing.
...
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
2020-04-09 16:06:11 -07:00
Simon Chae
fdd629b61f
[fenix] Update not yet unavailable add-on string ( https://github.com/mozilla-mobile/fenix/pull/9677 )
2020-04-09 15:25:08 -04:00
Roger Yang
cc81201934
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/9827 : Support display cutouts
2020-04-09 10:13:37 -07:00
Christian Sadilek
07b1f84ec6
[fenix] No issue: Re-use existing usecases for addons
2020-04-09 12:53:47 -04:00
ekager
b57314cc8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2818 - Adds Picture-in-Picture feature
2020-04-09 08:56:48 -07:00
Mozilla L10n Automation Bot
a1cf9f7780
[fenix] Import l10n.
2020-04-09 08:20:41 +03:00
Michael Comella
b9fe826cef
[fenix] No issue: Move Do and OpenClass to utils pkg.
...
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
2020-04-08 12:39:22 -07:00
mcarare
c579e388d3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9797 : Set min height of dialog edit text to 48dp.
2020-04-08 10:12:20 -04:00
Abhay Agarwal
bcd9f52607
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9495 : Dismiss the ShareFragment in onPause()
2020-04-08 13:10:37 +03:00
Sawyer Blatz
7001260885
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9682 : Reduces size of branding ( https://github.com/mozilla-mobile/fenix/pull/9784 )
2020-04-07 14:05:07 -07:00
Christian Sadilek
7df242c354
[fenix] No issue: Refactor readerview to use browser-state
2020-04-07 16:31:03 -04:00
Sawyer Blatz
42a823fe24
[fenix] No issue: Add more settings animations ( https://github.com/mozilla-mobile/fenix/pull/9750 )
2020-04-07 10:44:23 -07:00
Mihai Eduard Badea
68a5b44663
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2768 - Prevent screenshots in private mode
...
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.
This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.
The setting is by default set to true (screenshots are allowed to be taken)
2020-04-07 17:23:06 +03:00
Mugurell
8fd1b5ef87
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9770 - Disable pull to refresh pending changes
2020-04-07 17:06:43 +03:00
Mozilla L10n Automation Bot
8f65dd9856
[fenix] Import l10n.
2020-04-07 10:30:26 +03:00
Michael Comella
18a639a64d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9631 : remove assertk dependency.
2020-04-06 16:56:40 -07:00
Michael Comella
f2dbaf24d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9631 : replace assertk assertions with junit.
...
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
2020-04-06 16:56:40 -07:00
Jeff Boek
4371996382
[fenix] For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker ( https://github.com/mozilla-mobile/fenix/pull/9191 )
...
* For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker
* For https://github.com/mozilla-mobile/fenix/issues/220 - Updates Android Components
2020-04-06 14:29:52 -07:00
Mihai Adrian
8f1876407b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture ( https://github.com/mozilla-mobile/fenix/pull/9743 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Update unit test to new controller parameters
2020-04-06 11:00:47 -07:00
Arturo Mejia
174af614f4
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9647 Crash when tapping settings after quickly
...
enabling/disabling add-on
2020-04-06 13:47:21 -04:00
Michael Droettboom
461853e252
[fenix] Fix errors in top_sites_count metric
...
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.
[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
2020-04-06 10:34:52 -07:00
Mozilla L10n Automation Bot
ff708e4ff1
[fenix] Import l10n.
2020-04-06 12:20:41 +03:00
mcarare
3647494de3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9663 : Allow more than one line for onboarding card header
2020-04-03 17:47:11 -07:00
Mozilla L10n Automation Bot
50bb5be4db
[fenix] Import l10n.
2020-04-03 17:38:26 -07:00
Aaron Train
4d216e26ea
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9688 : Disable ReaderViewTest for intermittent investigation in detection issues
2020-04-03 22:04:43 +03:00
Oana Horvath
47366000e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9670 : Disabled intermittent tabMediaControlButton test ( https://github.com/mozilla-mobile/fenix/pull/9679 )
...
and removed file created by mistake -e
added reason for disabled tests
2020-04-03 20:39:33 +03:00
Mugurell
dca4c74a30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3262 - Enable pull down to refresh in Nightly
2020-04-03 19:40:08 +03:00
Michael Comella
09253e7566
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 - review: clarify comments in new test runner.
2020-04-03 09:27:49 -07:00
Michael Comella
74fbc518db
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : Add LintUnitTestRunner gradle task.
...
This will prevent us from regressing on adding older versions of the
unit test runner.
2020-04-03 09:27:49 -07:00
Michael Comella
5d2c577c64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : TestApplication -> FenixRobolectricTestApplication.
...
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
2020-04-03 09:27:49 -07:00
Michael Comella
dff3a69dc3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : move TestApplication to the helpers package.
...
The helpers/ package is created to separate the test support code from
the code under test.
2020-04-03 09:27:49 -07:00
Michael Comella
f11bb37121
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : replace unit test runners with FenixRobolectricTestRunner.
...
This is how we can apply the new test runner to remove duplication.
This commit was generated programmatically with the following commands:
```
// Replace test runners with new one.
find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
// Replace imports of old test runners with new one
find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
// Remove unused imports
find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```
Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
2020-04-03 09:27:49 -07:00
Michael Comella
b401d400b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : add FenixRobolectricTestRunner.
...
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.
This class is adapted from Firefox for Fire TV:
https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
2020-04-03 09:27:49 -07:00
Michael Comella
774a07d5f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : remove unnecessary @RunWith(Robolectric in unit tests.
...
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.
Between this change and the last one, the unit test runtime was reduced
by ~10s.
2020-04-03 09:27:49 -07:00
Michael Comella
b9ffb3ddcc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : remove unnecessary @RunWith(AndroidJUnit4) in unit tests.
...
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
2020-04-03 09:27:49 -07:00
Aaron Train
3489fe1e22
[fenix] No issue: re-enable libraryMenuItemsTest and backButtonTest ( https://github.com/mozilla-mobile/fenix/pull/9639 )
2020-04-03 10:37:03 -04:00
MickeyMoz
0487e0ad62
[fenix] Update Android Components version to 38.0.20200403130109.
2020-04-03 16:15:31 +02:00
Mozilla L10n Automation Bot
caded80288
[fenix] Import l10n.
2020-04-03 16:19:33 +03:00
Michael Comella
cb29b33e21
[fenix] No issue: add kdoc to HomeActivity.
...
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
2020-04-02 16:27:00 -07:00
Sawyer Blatz
9e5e780a9a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9128 & https://github.com/mozilla-mobile/fenix/issues/9222 & https://github.com/mozilla-mobile/fenix/issues/9499 : Refactors snackbar creation and fixes placement ( https://github.com/mozilla-mobile/fenix/pull/9628 )
2020-04-02 12:30:13 -07:00
Codrut Topliceanu
b2d81076f9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7978 - Put views above button in scrollView ( https://github.com/mozilla-mobile/fenix/pull/8819 )
2020-04-02 10:13:32 -07:00
Gabriel Luong
e754578cef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6174 - Add telemetry for WebExtensions ( https://github.com/mozilla-mobile/fenix/pull/8318 )
2020-04-02 10:12:31 -07:00
Mihai Adrian
2f02eeb972
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9604 : Swap and adjust margin with padding to avoid text being cut ( https://github.com/mozilla-mobile/fenix/pull/9617 )
2020-04-02 09:40:29 -07:00
Michael Comella
006e32c454
[fenix] No issue: remove unused FirefoxTestRunner.
...
It would be used for on device tests but it doesn't seem to hooked up
currently.
2020-04-02 07:57:09 -07:00
Mozilla L10n Automation Bot
f7f452367d
[fenix] Import l10n.
2020-04-02 13:42:58 +03:00
mcarare
7e54f731db
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9422 : Nit: Fix xml indenting
2020-04-02 09:11:31 +03:00
mcarare
34394af021
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9422 : Align widget text to viewStart to support RTL layouts
2020-04-02 09:11:31 +03:00