2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-17 15:26:23 +00:00
Commit Graph

16 Commits

Author SHA1 Message Date
Sebastian Kaspari
d50140272a [fenix] Integrate new search code from Android Components into Fenix. 2020-11-20 17:45:45 +01:00
Michael Comella
c8ec1542fe [fenix] No issue: move relevant :mozilla-detekt-rules to perf/ pkg. 2020-11-13 16:07:59 -08:00
Michael Comella
e0ee4f6d40 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15279: add MozillaUseLazyMonitored custom detekt rule. 2020-11-05 07:48:17 -08:00
MarcLeclair
78850c7e3d [fenix] 15278 detekt rule runblocking (https://github.com/mozilla-mobile/fenix/pull/15942)
* For https://github.com/mozilla-mobile/fenix/issues/15278: added CoroutineManager to count runBlocking calls

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added actual detekt rule for runblocking and its config to the yaml

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added unit test for RunblockingCounter

* For https://github.com/mozilla-mobile/fenix/issues/15278: renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test

* Lint fix

* For https://github.com/mozilla-mobile/fenix/issues/15278: made runblocking a Long to prevent overflow

* For https://github.com/mozilla-mobile/fenix/issues/15278: fixed MozRunblocking name, description and moved RunBlockingCounter to perf package

* For https://github.com/mozilla-mobile/fenix/issues/15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added setup for unit test, since it failed without restting counter

* For https://github.com/mozilla-mobile/fenix/issues/15278: Fixed naming for RunBlocking lint check

* For https://github.com/mozilla-mobile/fenix/issues/15278: removed changes made to test to use runBlockingIncrement

* For https://github.com/mozilla-mobile/fenix/issues/15728: added test exclusion for runBlocking check

* For https://github.com/mozilla-mobile/fenix/issues/15278: changed null check and added Synchronized to count setter

* For https://github.com/mozilla-mobile/fenix/issues/15278: fix for nits

* For https://github.com/mozilla-mobile/fenix/issues/15278: added StartupExcessiveResourceUseTest to CODEOWNERS

* For https://github.com/mozilla-mobile/fenix/issues/15278: fixed for nits

* For https://github.com/mozilla-mobile/fenix/issues/15278: Moved increment function to extension function and fixed indentation

* For https://github.com/mozilla-mobile/fenix/issues/15278: Added tests for Atomic Integer extension and nit fix
2020-11-02 12:49:17 -05:00
Michael Comella
424af26340 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15707: add MozillaStrictModeSuppressionTest. 2020-10-30 18:23:35 -07:00
Michael Comella
5ed416405e [fenix] For https://github.com/mozilla-mobile/fenix/issues/15707: correctly configure JUnit for mozilla-detekt-rules.
Without this, the tests would not run from the command line though they
could run in Android Studio.
2020-10-30 18:23:35 -07:00
Michael Comella
3f31e4cc1b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15707: clean up lint rules dependencies.
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.

mozilla-lint-rules worked but they were not clean.
2020-10-30 18:23:35 -07:00
Michael Comella
0934b7fe93 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - review: add clarifying comments. 2020-10-06 14:11:53 -07:00
Michael Comella
19904397b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add MozillaStrictModeSuppression detekt check. 2020-10-06 14:11:53 -07:00
Michael Comella
7a4230df00 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: improve custom detekt violation output.
Before it used to output the violations all one one line. Now it looks
like:
```
MozillaStrictModeSuppression:
    'import mozilla.components.support.ktx.android.os.resetAfter' at
(17,1) in /StrictModeManager.kt
    Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.

MozillaStrictModeSuppression:
    'setThreadPolicy(threadPolicy.build())' at (56,24) in
/StrictModeManager.kt
    Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.

MozillaStrictModeSuppression:
    'setVmPolicy(builder.build())' at (71,24) in /StrictModeManager.kt
    NOT YET IMPLEMENTED: please consult the perf team about
implementing`StrictModeManager.resetAfter`: we want to understand the
performance implications of suppressing setVmPolicy before allowing it.
```
2020-10-06 14:11:53 -07:00
Michael Comella
e1ffe1108f [fenix] No issue: replace LintUnitTestRunner with detekt implementation.
This should be more performant and easier to maintain.
2020-10-01 16:06:53 -07:00
Tiger Oakes
5de89421d7 [fenix] Suppress YamlConfig deprecation 2020-07-27 13:56:03 -04:00
Michael Comella
aba1c4cb5a [fenix] No issue: remove assertJ.
It was only used for 3 checks so it's not worth having a dependency on
it.
2020-04-02 07:57:19 -07:00
Emily Kager
522aca44f4 [fenix] Upgrade to detekt 1.6.0 (https://github.com/mozilla-mobile/fenix/pull/9306)
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes https://github.com/mozilla-mobile/fenix/issues/7360.  Also use more exact test glob.

Co-authored-by: Andrew Gaul <andrew@gaul.org>
2020-04-01 15:42:46 -07:00
Sawyer Blatz
17e74ecd6b [fenix] For https://github.com/mozilla-mobile/fenix/issues/7698: Adds search back button animation (https://github.com/mozilla-mobile/fenix/pull/7840)
* For https://github.com/mozilla-mobile/fenix/issues/7698: Adds search back button animation

* Refactor for searchController
2020-01-22 11:15:30 -08:00
Will Hawkins
78e86d8f2b [fenix] No Issue: Add custom detekt rule to blacklist certain properties
Add a custom detekt rule to blacklist certain properties. This is
immediately useful for making sure that developers do not configure
runtime behavior using the `BuildConfig.DEBUG` property but it is
useful in a wider context.
2020-01-17 15:46:32 -08:00