2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-10-27 15:46:27 +00:00
Commit Graph

3029 Commits

Author SHA1 Message Date
ekager
101d815231 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9890 - Do not display full screen snackbar with toolbar padding 2020-04-13 14:56:51 -07:00
ekager
cf3f14b795 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9703 - Exit full screen on pause if pip not entered 2020-04-13 14:31:57 -07:00
Sawyer Blatz
92ea1cc5b3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (https://github.com/mozilla-mobile/fenix/pull/9893) 2020-04-13 13:08:08 -07:00
ekager
27adb232c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9692 - Fix "Install" PWA menu item labeling 2020-04-13 10:09:37 -07:00
ekager
089e2db827 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7208 For https://github.com/mozilla-mobile/fenix/issues/7212 - Update parameterized strings 2020-04-13 09:40:47 -07:00
Christian Sadilek
7ca7557c17 [fenix] Configure M2 AMO collection for Nightly/Debug 2020-04-13 10:42:39 -04:00
Oana Horvath
acc46c960b [fenix] fix https://github.com/mozilla-mobile/fenix/issues/9670 intermittent tests (https://github.com/mozilla-mobile/fenix/pull/9767)
also disabled intermittent closePrivateTabsNotification
2020-04-13 13:17:35 +03:00
mcarare
682b6db6a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9698: Add unit tests for Context extension getStringWithArgSafe 2020-04-13 09:40:00 +03:00
mcarare
fca63c72d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9698: Use extension to ensure fallback to English and avoid crash 2020-04-13 09:40:00 +03:00
mcarare
79e3a1c328 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9698: Add Context extension to avoid format IllegalArgumentException 2020-04-13 09:40:00 +03:00
Mozilla L10n Automation Bot
b1aebe96de [fenix] Import l10n. 2020-04-13 09:38:41 +03:00
Mugurell
83063d66f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7157 - Set BrowserMenu width to be max 314 dp (https://github.com/mozilla-mobile/fenix/pull/9731)
Instead of having a fixed width of 250dp the BrowserMenu will now have a
dynamic width between 250dp and 314dp allowing for a better fit for the menu
items it could display.
2020-04-10 10:17:07 -07:00
mcarare
c3a5be128f [fenix] For https://github.com/mozilla-mobile/fenix/issues/9793: Adjust relative positions to provide correct a11y traversal 2020-04-10 14:35:58 +03:00
Mozilla L10n Automation Bot
9baa18640c [fenix] Import l10n. 2020-04-09 17:38:37 -07:00
mcarare
290141865c [fenix] For https://github.com/mozilla-mobile/fenix/issues/9798: Disable buttons on hiding and enable on showing.
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
2020-04-09 16:06:11 -07:00
Simon Chae
fdd629b61f [fenix] Update not yet unavailable add-on string (https://github.com/mozilla-mobile/fenix/pull/9677) 2020-04-09 15:25:08 -04:00
Roger Yang
cc81201934 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/9827: Support display cutouts 2020-04-09 10:13:37 -07:00
Christian Sadilek
07b1f84ec6 [fenix] No issue: Re-use existing usecases for addons 2020-04-09 12:53:47 -04:00
ekager
b57314cc8e [fenix] For https://github.com/mozilla-mobile/fenix/issues/2818 - Adds Picture-in-Picture feature 2020-04-09 08:56:48 -07:00
Mozilla L10n Automation Bot
a1cf9f7780 [fenix] Import l10n. 2020-04-09 08:20:41 +03:00
Michael Comella
b9fe826cef [fenix] No issue: Move Do and OpenClass to utils pkg.
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
2020-04-08 12:39:22 -07:00
mcarare
c579e388d3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9797: Set min height of dialog edit text to 48dp. 2020-04-08 10:12:20 -04:00
Abhay Agarwal
bcd9f52607 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9495: Dismiss the ShareFragment in onPause() 2020-04-08 13:10:37 +03:00
Sawyer Blatz
7001260885 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9682: Reduces size of branding (https://github.com/mozilla-mobile/fenix/pull/9784) 2020-04-07 14:05:07 -07:00
Christian Sadilek
7df242c354 [fenix] No issue: Refactor readerview to use browser-state 2020-04-07 16:31:03 -04:00
Sawyer Blatz
42a823fe24 [fenix] No issue: Add more settings animations (https://github.com/mozilla-mobile/fenix/pull/9750) 2020-04-07 10:44:23 -07:00
Mihai Eduard Badea
68a5b44663 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2768 - Prevent screenshots in private mode
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
2020-04-07 17:23:06 +03:00
Mugurell
8fd1b5ef87 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9770 - Disable pull to refresh pending changes 2020-04-07 17:06:43 +03:00
Mozilla L10n Automation Bot
8f65dd9856 [fenix] Import l10n. 2020-04-07 10:30:26 +03:00
Michael Comella
18a639a64d [fenix] For https://github.com/mozilla-mobile/fenix/issues/9631: remove assertk dependency. 2020-04-06 16:56:40 -07:00
Michael Comella
f2dbaf24d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9631: replace assertk assertions with junit.
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
2020-04-06 16:56:40 -07:00
Jeff Boek
4371996382 [fenix] For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker (https://github.com/mozilla-mobile/fenix/pull/9191)
* For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker

* For https://github.com/mozilla-mobile/fenix/issues/220 - Updates Android Components
2020-04-06 14:29:52 -07:00
Mihai Adrian
8f1876407b [fenix] For https://github.com/mozilla-mobile/fenix/issues/9687: Refactor onboarding cards to follow app architecture (https://github.com/mozilla-mobile/fenix/pull/9743)
* For https://github.com/mozilla-mobile/fenix/issues/9687: Refactor onboarding cards to follow app architecture

* For https://github.com/mozilla-mobile/fenix/issues/9687: Update unit test to new controller parameters
2020-04-06 11:00:47 -07:00
Arturo Mejia
174af614f4 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9647 Crash when tapping settings after quickly
enabling/disabling add-on
2020-04-06 13:47:21 -04:00
Michael Droettboom
461853e252 [fenix] Fix errors in top_sites_count metric
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.

[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
2020-04-06 10:34:52 -07:00
Mozilla L10n Automation Bot
ff708e4ff1 [fenix] Import l10n. 2020-04-06 12:20:41 +03:00
mcarare
3647494de3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9663: Allow more than one line for onboarding card header 2020-04-03 17:47:11 -07:00
Mozilla L10n Automation Bot
50bb5be4db [fenix] Import l10n. 2020-04-03 17:38:26 -07:00
Aaron Train
4d216e26ea [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9688: Disable ReaderViewTest for intermittent investigation in detection issues 2020-04-03 22:04:43 +03:00
Oana Horvath
47366000e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9670: Disabled intermittent tabMediaControlButton test (https://github.com/mozilla-mobile/fenix/pull/9679)
and removed file created by mistake -e

added reason for disabled tests
2020-04-03 20:39:33 +03:00
Mugurell
dca4c74a30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3262 - Enable pull down to refresh in Nightly 2020-04-03 19:40:08 +03:00
Michael Comella
09253e7566 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 - review: clarify comments in new test runner. 2020-04-03 09:27:49 -07:00
Michael Comella
74fbc518db [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: Add LintUnitTestRunner gradle task.
This will prevent us from regressing on adding older versions of the
unit test runner.
2020-04-03 09:27:49 -07:00
Michael Comella
5d2c577c64 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: TestApplication -> FenixRobolectricTestApplication.
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
2020-04-03 09:27:49 -07:00
Michael Comella
dff3a69dc3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: move TestApplication to the helpers package.
The helpers/ package is created to separate the test support code from
the code under test.
2020-04-03 09:27:49 -07:00
Michael Comella
f11bb37121 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: replace unit test runners with FenixRobolectricTestRunner.
This is how we can apply the new test runner to remove duplication.

This commit was generated programmatically with the following commands:
```
  // Replace test runners with new one.
  find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
  find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +

  // Replace imports of old test runners with new one
  find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
  find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +

  // Remove unused imports
  find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```

Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
2020-04-03 09:27:49 -07:00
Michael Comella
b401d400b3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: add FenixRobolectricTestRunner.
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.

This class is adapted from Firefox for Fire TV:
  https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
2020-04-03 09:27:49 -07:00
Michael Comella
774a07d5f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: remove unnecessary @RunWith(Robolectric in unit tests.
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.

Between this change and the last one, the unit test runtime was reduced
by ~10s.
2020-04-03 09:27:49 -07:00
Michael Comella
b9ffb3ddcc [fenix] For https://github.com/mozilla-mobile/fenix/issues/9605: remove unnecessary @RunWith(AndroidJUnit4) in unit tests.
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
2020-04-03 09:27:49 -07:00
Aaron Train
3489fe1e22 [fenix] No issue: re-enable libraryMenuItemsTest and backButtonTest (https://github.com/mozilla-mobile/fenix/pull/9639) 2020-04-03 10:37:03 -04:00