a1dc04f22b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25401 - Add the PocketIntegration Glean annotation tag to all Pocket telemetry
2 years ago
29747b2095
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25658 : Update metrics test.
2 years ago
961e6ad5d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25538 - Add the "Wallpapers" tag to the new telemetry
...
By using a feature tag we can avoid having to define new tags in the Glean
annotations repository.
The list of available tags needed to be regenerated to be able to reference the
new "Wallpapers" tag.
Because the tags regeneration also brought a change in tags from "TopSites" to
"Shortcuts" all previous telemetry using "TopSites" had to be migrated to use
the new "Shortcuts" tag.
2 years ago
8c48cca825
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25538 - Add a simple way to check if the default wallpaper is to be shown
...
A previous check for whether the persisted name of the current wallpaper is
empty made checking whether the default wallpaper is to be shown brittle.
Instead of duplicating such a check in multiple places it is now extracted in
one method that can be used in multiple places including the new telemetry.
2 years ago
4fe2ec1188
[fenix] Fixed PR review
2 years ago
c80ac7102a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21894 : Move Tabs Tray to compose: Individual tab viewholders: ListViewHolder.
2 years ago
0ab70f4511
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24857 : Add metrics for addresses autofill.
2 years ago
4921a85a24
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25658 - Track the site permissions prompt and user actions
...
Track when the prompt is shown and when the permissions are allowed/denied.
2 years ago
56d367f4fd
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24740 : Use unified search bar in bookmark search
2 years ago
143d60ebac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25491 - Refactor InactiveTabs interactors and controllers
2 years ago
81d31cfac8
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24740 : Use unified search bar in history search
2 years ago
7cb57f1b9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25446 : Ensure for every message shown we have recordExposure
2 years ago
773326121e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25381 - Add a setting allowing to toggle Pocket sponsored stories
2 years ago
7565361ae6
[fenix] Adjust all telemetry tests to follow new Glean APIs
...
These are mostly mechanical changes to replace usage of `testHasValue`
with `testGetValue`.
`testGetValue` will now return `null` instead of throwing an exception
if no data is available.
2 years ago
91153193ac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24744 - Observe and update selector icon while the View is attached
...
This avoids having to pass another LifecycleOwner from outside and will ensure
the View is update only in the bounds of it being attached.
The observe-update code is moved to bind(..) as that seems like a more
idiomatic callback for updating an already constructed View rather than
createView() which should only create and return a View.
2 years ago
d1c8951434
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24522 : Add telemetry for unified search
2 years ago
80f38dba6f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25455 : Let A-C handle toolbar expanding when URL changes
...
This fix allows the toolbar to be visible after the user clicks on a link and scrolls
Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
2 years ago
8b7799a3fe
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/pull/24455 - Migrate NoCollectionsMessageViewHolder to Compose"
...
This reverts commit eb9d1a88
2 years ago
71c77e3e6d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21897 - Convert inactive tabs to compose
2 years ago
08b668cc1f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25459 - Show Pocket sponsored stories irrespective of topics selections
2 years ago
bf758fac0b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25437 : Fix label values for labeled counters.
2 years ago
c46d478500
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/25449 : Use "Enter search terms" as hint when using application search engine
2 years ago
d081128be7
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/24918 : add subregion dropdown to address editor
2 years ago
397f1ffbb2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24300 - Add Tabs to the search engine menu
2 years ago
9bdc88cfb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25397 - Telemetry for credit card save and update ( https://github.com/mozilla-mobile/fenix/pull/25411 )
...
* For https://github.com/mozilla-mobile/fenix/issues/25397 - Telemetry for credit card save and update
* Use Fenix Issue fro Bugs
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: Roger Yang <royang@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
bd2263d32d
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24301 : Add Bookmarks to the search engine menu
2 years ago
364842f946
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25281 - Pace and rotate sponsored stories
...
A new way to be able to reliably record actual impressions of sponsored stories
was needed and based on this data we can ensure we are promoting fresh stories
(with fewer impressions) or the ones with a higher priority.
2 years ago
a61c3a778a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24299 : Sort unified search selector menu items based on user settings
2 years ago
fc40fd435b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25374 : Skip action validation for control messages
2 years ago
d5902b7a02
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Rename PocketStoriesChange to PocketStoriesClean
...
PocketStoriesChange was called only once - to clean the shown stories when the
user gets to the homescreen and the Pocket feature is disabled - useful for the
situations in which the user returns after disabling the feature in settings.
Populating the store with recommended stories to show was already happening
based on 'PocketStoriesCategoriesChange' and sponsored stories will be added by
using 'PocketSponsoredStoriesChange' so renaming 'PocketStoriesChange' will
help on reducing any confusion in the future.
Also added documentation for all Pocket related actions from AppStore and
removed the 'UndocumentedPublicClass' detekt suppressions.
2 years ago
67cc604dab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Download sponsored stories on debug only
2 years ago
f28fbf3240
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Use the `PocketStory` supertype
...
This prepares extending support from just `PocketRecommendedStory` to
`PocketSponsoredStory` also.
2 years ago
15677b59b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Hardcode showing at max 8 Pocket stories
...
The default was already 8. This is now being moved closer to the source from
where the stories to be shown are emitted.
With the addition of sponsored stories at fixed positions having to support a
variable number of stories being returned from AppState#getFilteredStories
means increased complexity with no benefit.
2 years ago
a59f065051
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23173 - CheckChanged use a single variable instead of two for checked status
2 years ago
f12935a278
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24968 : Add preference for enabling/disabling addresses autofill.
...
For https://github.com/mozilla-mobile/fenix/issues/24968 : Add preference for enabling/disabling addresses autofill.
2 years ago
348f43b2bd
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/25170 : Fix flaky search fragment store tests
2 years ago
5106048974
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/25288 : Disable autocomplete for unified history search
2 years ago
b04e075f51
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24991 - Refactor the HomeMenu creation from HomeFragment to HomeMenuBuilder
2 years ago
2e29b9ef7c
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/24917 : add country dropdown to address editor
2 years ago
7db1b80fb3
[fenix] Fixup tests
2 years ago
bab0149d64
[fenix] Filter messaging experiments from the Studies screen
2 years ago
2609047630
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/24299 : Add history to the search engine menu
2 years ago
df4ea50387
[fenix] Change FxNimbus/Nimbus startup sequence ( https://github.com/mozilla-mobile/fenix/pull/25266 )
...
* Change FxNimbus initialization sequence
Add cache invalidation
* Change ordering of message restoration and Nimbus initialization
* Address reviewer comments
2 years ago
fa8deb452c
[fenix] for https://github.com/mozilla-mobile/fenix/issues/25167 : ignore handleDeleteSingle and handleDeleteMultiple tests due to intermittent failures with coroutines
2 years ago
82a0a4f1f0
[fenix] Revert "Change FxNimbus initialization sequence ( https://github.com/mozilla-mobile/fenix/pull/25089 )"
...
This reverts commit b7427874e73ebaad5f8553b7a8614a7babdc8baa.
2 years ago
5beb1da884
[fenix] Change FxNimbus initialization sequence ( https://github.com/mozilla-mobile/fenix/pull/25089 )
...
* Change FxNimbus initialization sequence
* Add cache invalidation
2 years ago
d2fa53ff1d
[fenix] For https://github.com/mozilla-mobile/fenix/pull/24455 - Migrate NoCollectionsMessageViewHolder to Compose
2 years ago
d75322cbaf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25167 - Disable "handleDeleteAbnormal" as intermittently failing.
2 years ago
a5643471f2
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24931 : create address label and description based on available data
2 years ago
c6bb6c247e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23876 - Update kotlinx-coroutines to 1.6.1. Refactor runBlocking in tests.
...
After the update `TestCoroutineDispatcher`, `TestCoroutineScope` and
`runBlockingTest` are deprecated.
Instead of these new `TestDispatcher`, `TestScope` and `runTest` APIs are used.
Took the oportunity to also replace most of the `runBlocking` calls with the
new `runTest` specially designed for running coroutines in tests API.
2 years ago
adc764ca0a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24854 : Add ability to delete an existing address.
2 years ago
02fb70abf9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24855 : Allow updating info for an existing address.
2 years ago
81e4534da1
[fenix] Application services 93.0.1 ( https://github.com/mozilla-mobile/fenix/pull/24904 )
...
* Fixup breaking changes from AppServices upgrade to 93.0.0
* android-components RemoteTabsStorage now requires a Context param
* Update Android Components version to 102.0.20220509214046
Co-authored-by: James Hugman <james@hugman.tv>
Co-authored-by: Mark Hammond <mhammond@skippinet.com.au>
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
a567877e46
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25110 : Enable the messaging framework feature
2 years ago
e78350b2ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24262 - Filter Amazon/eBay sponsored tiles when the respective search engine is set
2 years ago
0138e26cfe
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24665 : show recent synced tab faster
2 years ago
969a5f0b0b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21292 : Remove unused MetricController parameters.
2 years ago
4e59514ef8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25044 - Remove the broken code for focusing the newly created collection
...
This functionality seems broken for a long time now.
It's importance and whether to reimplement it is to be re-assessed in
https://github.com/mozilla-mobile/fenix/issues/24389
2 years ago
5075a2345c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24514 - Remove Fact.toEvent from MetricController
2 years ago
3507b9edd1
[fenix] No issue: Renew/Remove metrics set to expire in v102
...
No issue: Renew/Remove metrics set to expire in v102
2 years ago
721a17416e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24707 : Remove unused metrics parameter.
2 years ago
caa53eb6e9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/24513 : add undo snackbar to history group screen
2 years ago
427b57e2df
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24949 : Remove malformed message when evaluating it.
2 years ago
0782aba4b0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24850 - Display an address list for managing existing addresses
2 years ago
3bc3ca9610
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24929 : remove locale restriction for remote firefox wallpapers
2 years ago
358e475609
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24849 - Add an address editor screen
2 years ago
b495c724d9
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24665 : cache previous auth status and display placeholders accordingly
2 years ago
7387644bac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23665 - Make the undo snackbar for the library screens work globally ( https://github.com/mozilla-mobile/fenix/pull/24398 )
...
* Closes https://github.com/mozilla-mobile/fenix/issues/23665 : make snackbar work after leaving the fragment it was initiated from
* Closes https://github.com/mozilla-mobile/fenix/issues/23665 : bring back the removed bookmark navigation test, sort imports alphabetically
Co-authored-by: mike a <mavduevskiy@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
3afee842ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24758 : Remove wrapper from browser search metrics.
2 years ago
32b0f3014e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24603 - Remove forEach from MediaNotification telemetry test
2 years ago
34afc2a3f8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23813 - Clear error message for nameOnCardLayout when valid name is submitted
2 years ago
4b66a440b7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24856 - Toggle the "Manage addresses" and "Add address" preference label depending on whether there are saved addresses
2 years ago
b4d52ce51b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24759 - Remove forEach from ContextualMenu telemetry test
2 years ago
683844bde8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24208 - Remove forEach from LoginDialogFacts test
2 years ago
7e939ba135
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24836 - Remove GleanMetricsServiceTest
2 years ago
ae0542a0b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24836 - Remove Event.wrapper for RecentlyVisitedHomepage telemetry
2 years ago
1e918950c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24811 - Remove Event.wrapper for Messaging telemetry
2 years ago
61210a14d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24847 - Part 2: Refactor AutofillFragmentStore into the autofill package
2 years ago
8ab524c2eb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24847 - Part 1: Refactor CreditCardsFragmentStore to AutofillFragmentStore
2 years ago
e604e555c5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24841 : Remove unused events.
2 years ago
6a23d2c9a5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24760 - Remove Event.wrapper for suggestions telemetry
2 years ago
d5feb23bd1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24780 - Part 4: Refactor AutofillSettingFragment to its own package
2 years ago
86c4a691c7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24780 - Part 2: RenameCreditCardsSettingFragment to AutofillSettingFragment in nav_graph.xml
2 years ago
a8353c5b4e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24780 - Part 1: Rename CreditCardsSettingFragment to AutofillSettingFragment
2 years ago
40d83423c8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24790 - Remove Event.wrapper for home screen related telemetry
2 years ago
63e93963c4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24789 : Remove wrapper from PWA metrics.
2 years ago
81572369e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24809 - Remove Event.wrapper for RecentSearches telemetry
2 years ago
b5cb951ea4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24786 - Remove Event.wrapper for SearchTerms telemetry
2 years ago
a6d2621840
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24759 - Remove Event.wrapper for text selection context menu telemetry
2 years ago
ce2c88512e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24710 - Remove Event.wrapper for RecentBookmarks telemetry
2 years ago
38db7db00c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24707 - Remove Event.wrapper for CreditCards telemetry
2 years ago
fcd939e9a9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24711 : Remove wrapper from recent tabs metrics.
2 years ago
ca3242ee58
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24747 - Remove unused store property in SessionControlAdapter and SessionControlView
2 years ago
06fb7601a1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24706 - Remove Event.wrapper for Autofill related telemetry
2 years ago
976ce08079
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24297 - Add a search engine menu that shows the search engine and search settings
2 years ago
37f60284d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24211 : Remove wrapper from search related metrics.
...
Removes wrapper from search labeled counter and performed search event.
2 years ago
46a58b4220
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24211 : Remove wrapper from "has open tabs" boolean metric.
2 years ago
66ffdbdeed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24701 - Remove Event.wrapper for Pocket related telemetry
2 years ago
07c88fb1c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24205 : Remove wrapper from set default browser toolbar menu.
...
This metric is recorded in the context of the default browser experiment.
2 years ago
ebb6647c37
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24715 : Remove wrapper from addons metrics.
2 years ago
795f47ca2f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24642 - Remove Event.wrapper for TopSites metrics
2 years ago
439f25ddeb
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24549 : add telemetry for recent synced tab
2 years ago
83363f9228
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24703 - Replace Mockito mocks with Mockk mocks
2 years ago
0ac1168120
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24618 - Replace a Mockito mock with a Mockk mock
...
And in such fix seemingly intermittently failing tests preventing the merge.
2 years ago
f2b6af4f6a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24618 - Add WebNotificationIntentProcessor to IntentReceiverActivity
...
The processor from Android-Components will know how to handle the intent
specific to web notifications clicks.
2 years ago
501829083d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24618 - Add Fenix own ServiceWorkerSupport
...
This replaces the default implementation from Android-Components to add the
functionality to first navigate to the browser fragment before responding to
service workers' requests of opening new tabs.
This will register itself when the main activity is created and unregister
itself when that activity is destroyed to support requests even when the
activity is in background but prevent any leaks.
2 years ago
322dabb092
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24638 - Remove Event.wrapper for Logins telemetry
2 years ago
1486f490bd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24599 - Remove Event.wrapper for Tab telemetry
2 years ago
f41a3ffbc3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24215 - Remove Event.wrapper for CustomTab metrics
2 years ago
2c1605effa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24591 - Remove Event.wrapper for ReaderMode telemetry
2 years ago
acaf9de949
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24603 - Remove Event.wrapper for MediaNotification telemetry
2 years ago
44a432a9e8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24498 - Remove Event.wrapper for History metrics
2 years ago
690b04b572
[fenix] for https://github.com/mozilla-mobile/fenix/issues/24177 : sync tabs when home is shown
2 years ago
17350d9339
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24649 - Fix spelling of shortcuts in @string/snackbar_added_to_shortcuts
2 years ago
8128c95710
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from opened link event.
2 years ago
40e36bb228
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from opened synced tab event.
2 years ago
b33c9f2a70
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from recently closed tabs opened event.
2 years ago
a333a1765e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from home button clicked event.
2 years ago
92cca361d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from uri opened count.
2 years ago
cf9b6193ce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from "default browser" events.
2 years ago
692f15b64c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from "browser menu item tapped" event.
2 years ago
d5016f5e9b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from "url entered" event.
2 years ago
b2935a866a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from "search bar tapped" event.
2 years ago
bc31bd179f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210 : Remove wrapper from "app opened" event.
2 years ago
3c680ee9bb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24616 - Update all the strings that references "top site" to "shortcut"
2 years ago
30e7c067ce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24576 - Record delete collection metric
2 years ago
abb02bd596
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24461 - Increase touch target for scan, search engine & voice search button
2 years ago
ed086b6f71
[fenix] Add defaults to FML, add control behaviour
2 years ago
075094b4b9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24454 - Remove Event.wrapper for SyncAccount metrics
2 years ago
ec74b43e2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24512 - Remove Event.wrapper for RecentlyClosedTabs metrics
2 years ago
624dc9baa3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24452 - Remove MetricController checks from BackgroundServicesTest
2 years ago
f2a0ca62b9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24452 - Remove Event.wrapper for SyncAuth metrics
2 years ago
3f083beeb4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24214 - Move bookmark removal events to BookmarkController
2 years ago
6ae9599a2f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24214 - Remove Event.wrapper for BookmarksManagement metrics
2 years ago
1c34e0d4ef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24099 - Remove Event.wrapper for Collections telemetry
2 years ago
f57be9751a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24147 - Remove Event.wrapper for Search widget telemetry
2 years ago
f205037644
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24450 - Remove Event.wrapper for ErrorPage metrics
2 years ago
b5a1813316
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24208 - Remove Event.wrapper for LoginDialogFacts telemetry
2 years ago
36eeae0c0f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24222 : Persist user interactions with nimbus messages
2 years ago
7f73bfcd90
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24319 - Migrate PrivateBrowsingDescriptionViewHolder to Compose
2 years ago
9ee3dc8264
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24467 - Enable Contile setting telemetry
2 years ago
0ff07369de
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24204 - Remove Event.wrapper for Search_shortcuts telemetry
2 years ago
2b2cfabcb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16952 - Https-only mode support.
...
Default will be disabled with users having the possibility to enable this from
a new setting in the `Privacy and security` section.
If enabled then by default this force https for all tabs with the option for
users to switch to forcing https only on private tabs.
2 years ago
6ebb87fc4e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24212 - Remove Event.wrapper for Preferences metrics
2 years ago
e076435191
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/24276 : moved getHistory() to suspend
2 years ago
b9eef2be49
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/24276 : updated tests
2 years ago
8106fb3d15
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24203 - Remove Event.wrapper for Onboarding telemetry
2 years ago
55baf8333b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23968 - Migrate homescreen recent tabs to compose
...
For https://github.com/mozilla-mobile/fenix/issues/23968 - Migrate homescreen recent tabs to compose
2 years ago
2cfa2e92cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23969 - Migrate homescreen recent bookmarks to compose
2 years ago
2040233814
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23970 - Migrate homescreen recent visits header to compose
2 years ago
602887e5b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23046 - Align detekt config between Fenix and Android Components
...
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2 years ago
09d6b80724
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24224 : Send telemetry events related to the messaging framework
2 years ago
e37d371ce4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24148 : Update tests for tracking protection metrics.
2 years ago
09fa5135e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24098 : Update tests for tabs tray metrics.
2 years ago
51f88636e9
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22489 : Remove "Fennec to Fenix" migration code
2 years ago
70014e589a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24220 and https://github.com/mozilla-mobile/fenix/issues/24223 : Connect GleanPlumb messages with the new tab ui card.
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
2 years ago
c181d526d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23503 : Respect studies and telemetry prefs when manually opting in to studies ( https://github.com/mozilla-mobile/fenix/pull/23955 )
...
* For https://github.com/mozilla-mobile/fenix/issues/23503 : Respect studies pref and telemetry enabled pref when manually opting in to studies
* Add button to snackbar in nimbus secret settings that allows user to go directly to their data collection prefs
* Remove refactoring
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
f841fa6f20
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/23517 : add a check to handleDeleteAbnormal() test to also verify
...
removal of items inside abnormal list
2 years ago
01f8b34f1e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/23517 : updated the tests
2 years ago
a0651401f7
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/23517 : history items are not being removed after deletion
2 years ago
f08392bd19
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/24407 : Allow query parameters in AMO installation URLs
2 years ago
ec1d6dfc7d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Check feature settings to show and hide home screen sections
2 years ago
9d4c556699
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Refactor ext/HomeFragmentStateTest to ext/AppStateTest
2 years ago
e5b6421d16
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Change all HomeFragment[Store|State|Action] usage to App[Store|State|Action] in existing tests
2 years ago
134fb611b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Refactor HomeFragmenStoreTest to AppStoreTest
2 years ago
3008a5337c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/24305 : Remove false wallpaper NPE Sentry report
2 years ago
6dede6ff6f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23697 : Treat text/x-moz-url mime type clipboard text as url
...
It seems like this is the MIME type we're getting from the clipboard in
certain scenarios, e.g. after copying a link from Chrome or Gmail on
some devices.
2 years ago
ff598e99fa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24286 - Create new test for synced tabs error mapping
2 years ago
c150e4c96f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19929 : Use AC extension functions for window insets compat.
2 years ago
2ca16e15cf
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/12717 : Add bookmark search
2 years ago
13af68853e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24235 - Remove Tip from HomeFragmentStore
2 years ago
e7ecd285a6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24229 - Remove unused MigrationTipProvider
2 years ago
130fd3ec5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24252 - Rename destructive attribute to textWarning
2 years ago
63d7796407
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24246 - Refactor Tab from HomeFragmentStore
2 years ago
094630c613
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/14313 : Always add copy to clipboard action in share actions
2 years ago
86ab03ac93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24130 - Change Shortcuts setting to toggle the display of Top Sites
2 years ago
f55e88ce94
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22189 - Replace app name with 'Firefox' for Sync strings
2 years ago
1adf409b19
[fenix] Bump Android-Components version to 100.0.20220309001717
2 years ago
a0f48f5533
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23893 - Add telemetry for Contile services
2 years ago
fd8596ea80
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23399 : Add tabs tray multi-select telemetry.
2 years ago
9ce5a7dd27
[fenix] Add remote wallpapers
2 years ago
96bda01189
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23936 - Show dialog on credit card delete
2 years ago
cb362b1685
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21743 : Use isNumericAddress to validate Ipv4 and Ipv6 for SDK>=29.
2 years ago
6a0128aafb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24006 - Return a null change payload if the new top sites list is larger than the old
2 years ago
8468ef9c13
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/23981 : open download function and override for test
2 years ago
910d13bbd1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23821 - Add telemtry for RecentlyVisted Homepage ( https://github.com/mozilla-mobile/fenix/pull/23909 )
...
Add test
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ryan VanderMeulen <rvandermeulen@mozilla.com>
2 years ago
ba3bf788e3
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/13336 : Open bookmark in current tab if browsing mode is not private or previous fragment is not home
2 years ago
0289b38806
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23888 - Replace @color/white_color with @color/fx_mobile_[icon|text]_color_oncolor
...
@color/white_color and @color/fx_mobile_[icon|text]_color_oncolor are equivalent
2 years ago
d1a94de89e
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/13336 : Open bookmarks in current tab ( https://github.com/mozilla-mobile/fenix/pull/23169 )"
...
This reverts commit 52157add58e5ed6accc64e1e4fae69e655432d91.
2 years ago
ce058f1abf
[fenix] for https://github.com/mozilla-mobile/fenix/issues/23069 : add blocklist middleware for home
2 years ago
1a4e821c92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23808 - Add secret setting for enabling Task Continuity feature
2 years ago
fc08df845f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22189 - Replace the 'Firefox' word in all strings with placeholder
2 years ago
948e9c4e85
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23771 - Set correct destructive text color for card editor error messages ( https://github.com/mozilla-mobile/fenix/pull/23803 )
...
Co-authored-by: tristan-jea <>
Co-authored-by: Tristan <99796140+tristan-jea@users.noreply.github.com>
2 years ago
b8d7a53f49
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19942 - Add support for sticky headers to the synced tabs list
2 years ago
924ad2e229
[fenix] No issue: Renew/remove metrics set to expire in March 2022
2 years ago
4c40cd09be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23456 ⁃ Use lifecycleScope in TopSiteItemViewHolder
2 years ago
ac81ce5b8f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/23694 : Add telemetry for history search
2 years ago
dc56238b4c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22722 - Rename CrashReporterFragment to CrashContentView
...
Rename in a separate patch for git to not merge this to previous changes and in
such think that the the old file was deleted and a new one was created.
2 years ago
bb85952d10
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22722 - Reacting to the crashed flag
...
Whenever the ".crashed" property of the currently displayed
TabSessionState -> EngineState is true we will show an in-app crash reporter
with the usual close tab / restore tab options and also the option to report
all current non-fatal crashes to Mozilla if the setting for sending the crash
reports is enabled in app settings.
This closely mimics the previous crash reporter UI but there might be some
subtle differences stemming from migrating to using a ComposeView.
Whenever the ".crashed" property of the currently displayed
TabSessionState -> EngineState is false we will set the in-app crash reporter
to have a View.GONE visibility effectively removing it from the layout.
The functionality for receiving the non-fatal crashes from the AC CrashReporter
through an Intent is still kept and these crashes will be persisted in memory
until the user closes / restores a tab and so also makes a decision about
sending or not these crashes.
Currently more tabs can crash following just one since more share the same
process and as such there is no way to differentiate between them or link a
certain Crash to a certain tab.
They will all be acted upon at once from any tab the user chooses to close or
restore.
2 years ago
bd54134349
[fenix] Convert recently closed tabs code to use light-weight TabState
...
To lighten-up our memory usage and startup performance, all of the RecentlyClosed
machinery was converted to use a light-weight TabState - specifically, it's missing
EngineSessionState, which is expensive to obtain during startup, and potentially
very costly to keep in-memory.
When we actually need EngineSessionState (at the point of restoration of a tab), we
read and rehydrate it using provided storage implementation.
2 years ago
25817127da
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21900 - Delete files from Synced Tabs XML implementation
2 years ago
71f539bf4e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21900 - Delete files from Synced Tabs XML implementation
2 years ago
bee88db440
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20634 remove some lint issues from baseline
2 years ago
19a695ec15
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23431 - Display the order of Contile Top Sites correctly
2 years ago
795683c6ef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21854 - Split the big ComposeView in 3 smaller ones
...
This would shorten the time needed to layout all Pocket recommended stories
content in one go, though it may lead to shorten hiccups over a bigger period
of time.
2 years ago
5458565097
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23526 - Add telemetry for Contile interactions
2 years ago
4f2899d299
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/23619 : use well-defined name for fetching remote wallpaper assets
2 years ago
ab9bc7c071
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23596 and https://github.com/mozilla-mobile/fenix/issues/23309 - Add deeplink to wallpaper settings
2 years ago
2066f6731e
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/10046 : Add history search
2 years ago
d7cce03106
[fenix] Add VisitInfo.isRemote parameter.
2 years ago
72a0985403
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/23565 : expire remote wallpapers but let users keep selected
2 years ago
a0dd1ee6e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21009 - New Recently closed tabs telemetry
...
This adds a new `recently_closed_tabs` category with then events for all user
interactions on the screen.
The already existent `events.recently_closed_tabs_opened` is still kept for a
bit more time to still have this data available while the new telemetry ride
the trains but can later be removed in favor of this newly added events.
2 years ago
d2e016eac9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13336 : Open bookmarks in current tab ( https://github.com/mozilla-mobile/fenix/pull/23169 )
...
* For https://github.com/mozilla-mobile/fenix/issues/13336 : Open bookmarks in current tab
* For https://github.com/mozilla-mobile/fenix/issues/13336 : Fix tests to verify bookmark opening in current tab
* Change test name for handleBookmarkTapped
2 years ago
06238447a6
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/23514 : add firefox wallpapers
2 years ago
98a540b81d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23350 - Revert changes from removing duplicate icons that already exists in ui-icons ( https://github.com/mozilla-mobile/fenix/pull/23527 )
...
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Override @color/mozac_ui_icons_fill with ?primaryText attribute"
This reverts commit 4c630eba96182254daa4cdd2bbfeac23ab04690d.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_share with @drawable/mozac_ic_share"
This reverts commit 072d3a3c9f87b77ed6381c36af7d9c812b8b371d.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_storage_enabled with @drawable/mozac_ic_storage"
This reverts commit 10dde2baa6fd320443690a49dd6551938a2d83db.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_notifications_enabled with @drawable/mozac_ic_notification"
This reverts commit 90943cfda427fd06d5e77b1e4fd0463bbe21e449.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_microphone_enabled with @drawable/mozac_ic_microphone"
This reverts commit 200fd14d288b4b21c1711995f63d548f58fb1dc8.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_location_enabled with @drawable/mozac_ic_location"
This reverts commit e85998bdc24dcdd17585581bd99aab35d5147f93.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_autoplay_disabled with @drawable/mozac_ic_autoplay_blocked"
This reverts commit 0e408dc26e069719c895ae5279d3c11df6677699.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_camera_enabled with @drawable/mozac_ic_video"
This reverts commit ceab2d77490b9b9b545ebbc14ee2a7b3811d3064.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/mozac_ic_extensions_black with @drawable/mozac_ic_extensions"
This reverts commit 7bc005927acee0481c8936d000737ba7f738e2ba.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_top_sites with @drawable/mozac_ic_pin"
This reverts commit f4d58ff722baa5dc9f7f811a758de75699bb8ccb.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_search with @drawable/mozac_ic_search"
This reverts commit ac8f8632557ac07c32d040fbb0ddfa3cf1a0e5f6.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_readermode with @drawable/mozac_ic_reader_mode"
This reverts commit d1953045b062a5b6fbedd990252834e9e1a6ca4f.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_menu with @drawable/mozac_ic_menu"
This reverts commit 682b02101aa7e5ce82868de81d9b034701629976.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_login with @drawable/mozac_ic_login"
This reverts commit 982c695260aaa10fc1f0ee7e6d2e271e9a214ce3.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_internet with @drawable/mozac_ic_globe"
This reverts commit d248bfc21fff644bdc2141c4e24ae5bc125a41d2.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_download with @drawable/mozac_ic_download"
This reverts commit 4cdceb393ac411a7b59d9c0e1164fddfb62bc494.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_lock with @drawable/mozac_ic_lock"
This reverts commit 3878a83e30f318293b099bc49c690f953c2f3def.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_desktop with @drawable/mozac_ic_device_desktop"
This reverts commit 8c4e6e23e0bf1ed762d9c3ab8566aff4df0a8eb1.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_close with @drawable/mozac_ic_close"
This reverts commit 7f61c95923600eeabb8046380a31c1eaa4968525.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_delete with @drawable/mozac_ic_delete"
This reverts commit b8814f62bffde0c192f078f8cd5e808d0f07af9d.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_chevron_up with @drawable/mozac_ic_arrowhead_up"
This reverts commit 265b0a47cae6bed39ce9e8cc9af465705d1a2363.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_chevron_down with @drawable/mozac_ic_arrowhead_down"
This reverts commit fe8a0b604941bbbb9dacff176cd17ce0485431ed.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_back_button with @drawable/mozac_ic_back"
This reverts commit fb236b1c6175c1f8b5e6b1bf6d9f02c6a7fff9b9.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_arrowhead_right with @drawable/mozac_ic_arrowhead_right"
This reverts commit ae2f768ac02aa6b161b0bcbba7922f5f12e31e80.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_new with @drawable/mozac_ic_new"
This reverts commit ce5bb35a7cdbd189bb177900ec19bc6cb5a9bfa7.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_addons_extensions with @drawable/mozac_ic_extensions"
This reverts commit 1006637673965ebf70ad5e18e9a3598cf736347b.
2 years ago
05d80bd9aa
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/23504 : download focus wallpapers at runtime ( https://github.com/mozilla-mobile/fenix/pull/23505 )
...
* closes https://github.com/mozilla-mobile/fenix/issues/23504 : download focus wallpapers at runtime
* address pr feedback
* only download wallpapers if feature flag is set
2 years ago
17f96e433c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23424 - Part 2: Add context menu for contile top sites
2 years ago
9b651a484b
[fenix] First use of Nimbus FML plugin ( https://github.com/mozilla-mobile/fenix/pull/23400 )
...
* Consume Nimbus FML plugin
* Convert Homescreen to use FML
* Convert nimbusValidation to use FML
* Convert legacy experiments to use the feature API and FML
Remove dead helper code and documentation
* Fixup failing test
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
00cc662e9f
[fenix] add events based on feedback
2 years ago
880c34528d
[fenix] update based on PR feedback and data review
2 years ago
c599f29c47
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/23381 : add telemetry for wallpapers feature
2 years ago
5185773477
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22576 - Indicate mutability flag for PendingIntent
...
* For https://github.com/mozilla-mobile/fenix/issues/22576 - Indicate mutability flag for PendingIntent
* Fix lint issues
* Make Analytics Pending Intent flag mutable
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
8cfc336a55
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22314 - Reuse existing tab for search group items
2 years ago
abcf8f0fb1
[fenix] Account for Int->UInt changes in bookmarks API
3 years ago
d84bdb1d93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_search with @drawable/mozac_ic_search
3 years ago
37b4cfaa35
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_new with @drawable/mozac_ic_new
3 years ago
96d0dfae36
[fenix] No issue: Remove showHistorySearchGroups feature flag
3 years ago
94e5e66315
[fenix] Set a minimum number of sites a search group should contain.
3 years ago
d6e29fb1c4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23256 : Close quick settings sheet when displaying clear dialog.
3 years ago
59beaaa609
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23256 : Pass navController instance instead of lambda.
3 years ago
1b420ea198
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/23250 : Remove duplicate sites within a time period in history
3 years ago
235c026c38
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22727 - Add Contile to Top Sites
3 years ago
47424e8f00
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22477 : Ignore null and empty values for share data title.
3 years ago
ff881bd417
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/22943 : update androidx.lifecycle to 2.4.0
3 years ago
e683694d05
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20524 - Remove redundant coroutine dispatchers from tests
3 years ago
68be05d051
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8108 - Add BrowserToolbar option to remove url from TopSites
3 years ago
5cc5b50595
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22550 : Refactor search term tab grouping logic to rely on middleware
3 years ago
364f558857
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22795 : Stop trimming login origins on sorting
...
Due to the async nature (??) of the trimming code, this is causing severe performance issues
during search.
Looking back through commits, doesn't seem like there's a particularly good reason we were trimming here. All I could find is https://github.com/mozilla-mobile/fenix/pull/9986 (comment) which is lacking explanation of why this is actually useful.
And currently, we're dealing with an origin (not a full url when this was initially written, I think), i.e. https://accounts.firefox.com vs https://accounts.firefox.com/signin . So, the suffix stripping isn't even doing much beyond removing com in vast majority of cases.
So, seems like all of this trimming stuff can be cleaned up.
3 years ago
26a4ec05d3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23142 - Fix license formatting in tests
3 years ago
1facaaf775
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22879 : Filter default engines when sending telemetry.
...
Filter out custom engines that are not well known search domains.
3 years ago
e88bda15df
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18160 : Show a prompt when trying to leave private browsing with active downloads ( https://github.com/mozilla-mobile/fenix/pull/22912 )
...
Co-authored-by: mike a <mavduevskiy@gmail.com>
3 years ago
c367072d11
[fenix] Refactor History types to eliminate nullability
...
This introduces a separate HistoryDB type at the PagedHistoryProvider
layer, that doesn't need to deal with positions. Positioning logic in
HistoryDataSource becomes a type conversion between the new type and an
existing History type that UI and ItemKeyedDataSource API is written against.
With this refactor, we entirely eliminate nullability from these types.
3 years ago
b13e149900
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22764 : Convert History.id to an Int position
...
We were converting Long timestamps into Ints (and getting negative
numbers back), and treating that as, basically, a position for the
paging API; the paging API would pass us back the obscure negative
number back as an offset, and we'll mishandle it resulting in an
infinite loop.
This patch removes all of the Long -> Int conversions, and introduces an
explicit 'position' that is calculated once we have a full page of
results completed.
3 years ago
ae7909671e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22852 - Add a new "Storage access" permission
3 years ago
4e6406e15e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20513 : Use UrlMetricType for search engine submission url.
3 years ago
11417996c8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22671 : Show correct time groups header in history
3 years ago
6b7cdce783
[fenix] Fix breaking change in KeyProvider
...
`key` was renamed to `getOrGenerateKey` and is now a `suspend`.
3 years ago
4ad2c1c592
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22569 : Remove allopen plugin and Mockable annotations
3 years ago
817760d64c
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/20833 : move home recycler bottom margin into standalone item
3 years ago
4b6a1d2256
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/22688 : remove inactive_tabs_recently_closed probe
3 years ago
01c4bf049a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17130 : Replace hardcoded strings with string resources.
3 years ago
37ec88478e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9294 : Add option to clear current site data in quick settings dialog.
3 years ago
4b3e25dcf6
[fenix] Update Android Components version to 97.0.20211208143435.
3 years ago
6b9dc4c958
[fenix] Introduce timeout for capturing thumbnail in BrowserAnimator
3 years ago
9150d8061b
[fenix] Prevent flash when navigating to home
3 years ago
33e5a1ee35
[fenix] Refactor: Move historymetadata classes in separate package
3 years ago
f70dfb6ef9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22534 - Show history highlights and groups in "Recently visited" ( https://github.com/mozilla-mobile/fenix/pull/22535 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Update homescreen section name to "Recently visited"
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Show both history highlights and groups in Recently visited
For now the metadata groups don't support scoring so as an interim solution we
will show up to 9 items, evenly distributes, first favoring groups sorted by
date then history highlights pre-sorted by default.
Tapping a history highlight will switch to it's already open tab if available
or create a new one in which to load it if needed.
A "Remove" option will also be available for history highlights to remove it
from the screen and also from history.
Currently removing a group / highlight will not query new ones to again show up
to 9 items, this will be implemented separately.
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Rename and refactor historymetadata to recentvisits
The updated feature supports more than history metadata so updating the overall
naming scheme seems needed.
To signal that this is a homescreen feature the entire package is moved to home
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Update UI tests to account for the new items space on the screen
Saw failures about not finding the collection section on screen.
This is probably happening because w are now adding the recent visits to
homescreen above the collections section pushing it off screen.
Since the collections might be obstructed by the toolbar shown on top as a
quick solution we'll scroll to the next homescreen section so that the
collections will be shown above in their entirety.
* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
97e59a9717
[fenix] Tab group count telemetry ( https://github.com/mozilla-mobile/fenix/pull/22479 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Refactored tab sorter metrics into a middleware
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Created distribution metric for tab group sizes
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Created tests for tabs tray middleware
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Merge fixes
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Added PR number to metric
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Fixed unit tests post merge. Added waitUntilIdle to new tests.
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Added missing line to middleware to have the Store process actions
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Updated metric expiration to December
* For https://github.com/mozilla-mobile/fenix/issues/22410 - PR Feedback
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Removed else from middleware when
3 years ago
c7aea80bb2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22595 - Remove unused OnboardingAutomaticSignInViewHolder
3 years ago
5b069b2ece
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22211 - Use Hero images for Recent Bookmarks
3 years ago
72a0b5703c
[fenix] Update Android Components version to 96.0.20211125162700.
3 years ago
4cc4e1c67d
[fenix] Improve loading URLs
3 years ago
e665397890
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22442 - Don't display individual tab if part of the Jump back in tabs group
...
We'll show as a recent tab the next most recent tab not part of the last active
search group.
3 years ago
3dea07855e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22442 - Don't display history group if already in Jump back in
3 years ago
6b5ce4d387
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22488 - Fix intermittent test failure with InactiveTabsControllerTest
3 years ago
100d5372ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22250 - Convert Recent Bookmarks to Jetpack Compose
3 years ago
5737a5533c
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/5298 the same page appears in the History section multiple times
3 years ago
78e85949cf
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22484 - Track direct loads per tab; fix search term lookup
...
This patch fixes two problems:
1) We were treating "direct tab load" as an event which applies
uniformally to all tabs, even though it's actually an event which
happens for a specific tab. This lead to background tabs (pages opened as new tab)
setting the direct load flag, and then a simultaneously loading
parent tab would incorrectly interpret that flag for itself.
The patch switches this tracking from a simple boolean (are we direct
loading?) to a set of tab IDs that are currently direct loading.
2) In a case when a background tab was loading with a parent who's
search terms were cleared by a direct load, we were not trying to
lookup search terms on the background tab's historyMetadata key,
which exists to capture search terms for this exact scenario.
The patch adds an additional fallback lookup for that path.
3 years ago
fc7e707538
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22472 : Filter out redirects from History search groups
3 years ago
627bc919d1
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22402 : Add top placeholder for home
3 years ago
ba3138ccf9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - Store inactive tabs count telemetry when user opens tabs tray
...
Setting this value in FenixApplication.onCreate was buggy because of a race
with restoring BrowserState.
Setting it here would ensure a better granularity of the events and so to more
accurate reporting.
3 years ago
31f98688a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22147 - New search term groups telemetry
3 years ago
ad8f060cec
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22271 Improve URL accessing from the clipboard for Android 12 and above.
3 years ago
a08fcc9a9d
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22223 : Move to the selected page when switching modes
3 years ago
6f1ba6ca6b
[fenix] No issue: clean up code duplication in PagedHistoryProvider
3 years ago
7222c0220c
[fenix] No issue: Correct TabsTrayAction naming
3 years ago
199547f94f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22305 : Use TabsTrayStore for populating adapters
3 years ago
35556e4cc2
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22305 : Add tab state into the TabsTrayStore
3 years ago
b95234f9d5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - The inactiveTabsCount probe reports actualInactiveTabs number
3 years ago
f40c19f406
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - New BrowserState.actualInactiveTabs public method
...
This allows querying from all throughout the app which of the current tabs are
inactive while taking into consideration whether the feature is enabled or not
such that when the feature is disabled it will always return an empty result.
3 years ago
6aa2f0c4fa
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21695 : ThreadPenaltyDeathWithIgnoresListener: Ignore stack traces containing InstrumentationHooks class
3 years ago
ad076dd1c2
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22299 : Add history search term group telemetry
3 years ago
31c2c7bf12
[fenix] No issue: history view search group missing
...
Our boundary conditions for matching search groups to visits was wrong.
This change switches the boundary buffer to only be applied to history
items, not the metadata items.
In other words, when checking if any of the metadata items match the
current "page" of history, we'll be looking to see if the item falls
within this time window:
buffer - oldest history item <= metadata item <= newest history item +
buffer
There's a separate problem with buffer though: it's reset to 0 when requested
offset is >0, but that requires a larger refactor of this code, for a
separate PR.
3 years ago
6ed1cb0c8b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : Remove expiring/unused metrics for December ( https://github.com/mozilla-mobile/fenix/pull/21789 )
...
* Remove crash reporter metrics
* Remove tab counter menu item probe
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
dbceb279f4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21659 : Add SERPs to history search groups
3 years ago
cbfc23f8cc
[fenix] Recent bookmark count telemetry ( https://github.com/mozilla-mobile/fenix/pull/22293 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22075 - Added event to track the count of recent bookmarks
* For https://github.com/mozilla-mobile/fenix/issues/22075 - Added data review issue number
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
b1cb88fff7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22078 Selecting search group in Jump back in switches active tab
3 years ago
9fb7471f61
[fenix] No issue: Address tracking protection exceptions breaking changes
3 years ago
5e2853ea47
[fenix] MR2 Telemetry: Recent tabs section probe ( https://github.com/mozilla-mobile/fenix/pull/22166 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22107 - Added probe to track if the Recent tabs / jump back in section is visible
* For https://github.com/mozilla-mobile/fenix/issues/22107 - Fixed lint errors
* For https://github.com/mozilla-mobile/fenix/issues/22107 - added data review number to metric
* For https://github.com/mozilla-mobile/fenix/pull/22166 - fixed expiration date
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
8393fac307
[fenix] No issue: Merge our inactive tab interactor/controllers
3 years ago
3342f4a54a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - Inactive tabs count telemetry
...
A quantity probe in the metrics ping means we'll loose the granularity events
provided but it will be easier to extract the values.
For reporting whether the inactive tabs feature is enabled or not we already
have the "preferences.inactive_tabs_enabled" probe so I didn't duplicate this.
3 years ago
ba7d325bb4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22057 : Add search term groups telemetry
3 years ago
517f789958
[fenix] Introduce test rule to work around intermittent mockk failures
3 years ago
d116c95205
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22138 - Install source metrics probe
3 years ago
c0fde2bebb
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22172 : Add Recent searches telemetry
3 years ago
46f9f1ae2c
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22103 : Add recent bookmarks telemetry
3 years ago
015be02422
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22175 : Telemetry event for deleting a search term group from the recent searches section on home
3 years ago
5d8a920b5f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20704 : Add AppStore to Components
3 years ago
d201f02bfb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22192 add telemetry for studies
3 years ago
0732718e1c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21355 : Fix intermittent test failures in BookmarkItemMenuTest
3 years ago
bf2a718701
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21952 : Ignore intermittently failing FenixSnackbarKtTest
3 years ago
d03598c9a1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21438 : Ignore intermittently failing ExceptionsListItemViewHolderTest
3 years ago
3b686cec7b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22081 : Ignore intermittently failing DefaultBrowsingModeManagerTest
3 years ago
243a456c1b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21332 : Ignore intermittently failing WebPushEngineIntegrationTest
3 years ago
dc552d78c6
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21952 : Ignore intermittently failing FenixSnackbarDelegateTest
3 years ago
ecb13fa173
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22170 : Add telemetry for the auto-close prompt
3 years ago
ef375069eb
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22083 - Match history groups to history pages by all items within the group
...
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.
This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.
That's all correct, but the assumption around group matching to history is now incorrect.
This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
a68de609c2
[fenix] Update Android Components version to 95.0.20211026143215.
...
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
45e9bf6693
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unused symbols
3 years ago
71bfe46ac2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Local 'var' is never modified and can be declared as 'val'
3 years ago
29dfb8ee7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unnecessary type argument
3 years ago
314d61d21e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unnecessary parentheses from function call with lambda
3 years ago
cd77dbce96
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove redundant qualifier name
3 years ago
a6d7128c7e
[fenix] No issue: Replace TabsTray.Tab with TabSessionState
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
a672d27ca6
[fenix] No issue: Disable FenixSnackbarDelegateTest intermittents
3 years ago
6f4c47613a
[fenix] Update Kotlin and Jetpack Compose versions.
3 years ago
fe8c112513
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22070 - Prevent crash for when a selected topic does not exist anymore
...
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
3 years ago
593b08780f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22061 : Let TabSorter decide if title header should be shown in tabs tray
3 years ago
ad1bcec0d9
[fenix] No issue - post: fix ProfilerMarkerFactProcessor tests.
3 years ago
2e7f52f63a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Composify Customize Home Button and update the background color
3 years ago
2c4ccea6cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21753 - Refactor Pocket out of sessioncontrol
3 years ago
1c21e2face
[fenix] MR2 Inactive tabs telemetry ( https://github.com/mozilla-mobile/fenix/pull/21908 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added telemetry for interacting with inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added missing inactive tab delete count event to delete all event
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added PR numbers to metrics
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated broken unit tests. Resolved critical lint warning.
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Fixed inactive tabs setting toggle metric
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated FenixApp unit test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.
* PR: addendum for last commit that missed a file
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Changed logic check for reporting inactive tab count
* PR: fixed merge conflict
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed tab close tracking when the user closes ALL inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed individual tab close metric verify from CLOSE ALL test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
9d3d9b3421
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21723 Align the default value of the custom cookie setting with the UI
3 years ago
1647e4f613
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21893 : Keep search group when second to last search term tab is removed
3 years ago
c380d1e622
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21910 : Fix intermittent failures in SelectTabUseCaseWrapperTest
3 years ago
997fd9ba64
[fenix] Do less work while navigating Logins views
...
Fetching a set of logins from the store is quite expensive. This commit
avoids doing that while navigating back and forth between the list and
detail views:
- retain processes logins state when navigating into detail view
- use the `get` storage api to obtain specific login, instead of
`list().filter {...}`
- avoid re-sorting retained logins when navigating back into the list
view
3 years ago
5372f1bcca
[fenix] Make linters happy
3 years ago
204ad8834d
[fenix] Updating Fenix to work with the new logins API
...
Switched to always using `Login` instead of the `SavedPassword` alias.
Made `MasterPasswordTipProvider.saveLogins()` call
`importLoginsAsync()`. This is needed because it's the only method that
inputs a `Login` rather than a `LoginEntry`.
Moved the `SavedLoginsStorageController.kt.syncAndUpdateList` call
to inside `add()` and `update()`. This simplifies the error handling a
bit.
Refactored dupe-checking code to use findLoginToUpdate()
Refactored `AddLoginFragment` / `EditLoginFragment` to put the username
error handling code all in 1 method. I think it's easier to follow the
logic of showing/hiding the error labels when it's all in one place.
This fixes issues https://github.com/mozilla-mobile/fenix/pull/24103 and https://github.com/mozilla-mobile/fenix/pull/24104 . I would love to address https://github.com/mozilla-mobile/fenix/issues/24102 ,
but I'm not sure what the correct behavior is there so I just kept that
the same.
3 years ago
7efdddcaeb
[fenix] Fix up HistoryMetadataController tests
3 years ago
eef2ad800a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21871 - Eagerly update UI state after search group removal
...
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.
This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).
This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.
After this patch, we:
- dispatch two actions (on browserstore, on homefragmentstore) which
remove the search groups from any relevant in-memory state; any UI bound to
this state will be automatically "refreshed"
- no longer navigate as part of the remove action, so the UI doesn't
move and removal happens "in-place"
3 years ago
0751190582
[fenix] Handle new OptimizedLoadUrlAction in history metadata middleware
...
Upgrades to A-C 95.0.20211013154351
3 years ago
45330287b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17393 : Dead code removed around Delete downloads
3 years ago
0658de464f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21791 Adds tab auto-close prompt
3 years ago
cde1c3b911
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Simplify test to not depend on store updates.
3 years ago
e22e33c3c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Replace mock of an interface with mock of a fake.
3 years ago
363e563fc7
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686 : Move submitList calls into TabsAdapter
...
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
39a3aacc78
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21773 - Updated "customize homepage" button to go to the new Homepage submenu in Settings
3 years ago
e6a73b5118
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21623 - Pocket recommended stories telemetry
3 years ago
e3b2309ac2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21756 - Refactor TopSites out of home.sessioncontrol
3 years ago
b772f6d080
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen ( https://github.com/mozilla-mobile/fenix/pull/21722 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Updated show top sites toggle text
* PR: Fixed lint warning. Reverted preference keys
* PR: added ignore for UI test
* PR: Added ignore for UI test
3 years ago
f4f7c1b0e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21574 : disabled the homescreen onboarding dialog.
3 years ago
33cf85203a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21642 : Remove in-progress media tab from homescreen
3 years ago
5385b96abe
[fenix] Move tabs out of search group if direct load occurs
...
This regressed in our previous fix that made sure child tabs don't
mistakenly get moved out of the group if their parent is navigated
away, or in case the child tabs are redirected.
However, when a subsequent load occurs in any tab in the group the
search terms need to be cleared and the tab removed from the group
to prevent false positives.
3 years ago
7e65b07930
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor the coroutine from PocketStoriesShown to outside the middleware
...
In so this code will no longer have access to the MiddlewareContext which only
makes sense in the thread of the Middleware itself.
3 years ago
6261e570c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Persist stories categories selections in a Proto DataStore
...
A fast and easy solution with all the ACID requirements.
Also supports easy migrations if later the data we need persisted changes.
3 years ago
4f4586d85f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor out "isSelected" from PocketRecommendedStoriesCategory
...
Having the list of categories and the list of selected categories separate in
State allows updating them independently.
3 years ago
884c8c2224
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21576 : Hide 'Other' title when there are no search groups
3 years ago
8a4bb26526
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21618 : Integrate Nimbus with MR2 Home Page to enable experimentation
3 years ago
c1f2c33a76
[fenix] Make search term grouping tolerant to (parent tab) navigation
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
4f07d1a40f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups ( https://github.com/mozilla-mobile/fenix/pull/21615 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Lint cleanup
* PR: Added missing licenses and possibly fixed UI test
* PR: Added a "scrollTo" to potentially fix a UI test
* PR: Added potential fix for alwaysStartOnHomeTest
* PR: Added temporary ignore to alwaysStartOnHomeTest
* PR: added missing ignore comment
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added missing feature flag driven visibility logic
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
1d537cb332
[fenix] Allow opening pocket stories when search dialog is active
3 years ago
1f11b81bc4
[fenix] No issue: Make sure jump back in group always have more than one tab
3 years ago
4d23db624f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21551 - Add delete history metadata in the History view
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
dc1e5e640e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21287 : long press menu on recently visited homescreen groups
3 years ago
485ca898f2
[fenix] Do not show home screen behind search if we have search terms
...
Home screen isn't actually visible in case we're displaying awesomebar
search results. The navigation is thus unnecessary and actually causes visual
jankiness as we display home for a moment before covering it up with
search results.
3 years ago
f2b7eea088
[fenix] Inactive tabs changes ( https://github.com/mozilla-mobile/fenix/pull/21524 )
...
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Moved inactive tabs to the top of the normal tabs tray.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Added a delete icon to delete ALL inactive tabs.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Changed default inactive time period to 14 days
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Hooked inactive tabs setting to UI code
Inactive tabs setting is also disabled when the user has selected the one day or week auto-close tab setting.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - File and Lint cleanup
* PR: Fixed bug causing grouped tabs to also show in "Other" when marked as inactive but inactive is OFF in Settings
* PR: Fixed lint warnings
* PR: Removed redundant feature check
* PR - Ignore test until search term tab groups switch is done
3 years ago
4fac910adf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21592 - Don't topup with general stories
3 years ago
32c8709148
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : add partial test for existing factToEvent code.
...
When we refactor, this will help ensure we've done it correctly.
3 years ago
ad0f428f39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21561 - Enable/Disable the feature from the customization menu
3 years ago
08a71a5366
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21391 - Final design composables
...
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
3 years ago
219561d304
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21275 - Sort items by how many times they were actually shown
3 years ago
4702a66203
[fenix] Do not capture search terms when user navigates away via app ( https://github.com/mozilla-mobile/fenix/pull/21527 )
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
f65770a34f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21451 : Add active search term tab groups on home
3 years ago
c4eb7ea28b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21493 show onboarding dialog for home sections
3 years ago
d701a81103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21045 : Add categories support
3 years ago
7ea5cdbe39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21087 : Updates Recently Saved design
3 years ago
c9e1bfe3dc
[fenix] Fix mapping between history visits and groups to use createdAt
...
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
3 years ago
d7c1238dac
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21366 : Speculative fix for failing test in TitleHeaderBindingTest
3 years ago
a6a6b6f257
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 : Dedupe urls/site in history groups
3 years ago
e3bc494414
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs
3 years ago
450055a729
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21413 - Remove unused OnboardingPrivateBrowsingViewHolder and OnboardingWhatsNewViewHolder
3 years ago
bc30e53e5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21408 - Pass the corresponding HistoryMetadataKey to openToBrowserAndLoad and addTab use case
3 years ago
793ceb8e28
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 - Search term groups in history
3 years ago
c3df9a26d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 add telemetry for Allow users to customize their home screen
3 years ago
e18fbdfbfc
[fenix] Make sure to only record view time once for a given tab access
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
6297f2cce9
[fenix] Use UpdateUrlAction to record viewTime observations
...
We discovered that in a tab restore scenario we were recording view time
observations that were wrong - we'd record time deltas as-if user was
looking at the page while the browser wasn't running.
This happens because when we record a viewTime observation, we compare
current time with lastAccess time of the tab. In a restore scenario,
that lastAccess time happens to be from when the browser was last
running - which could be days ago.
The simplest solution was to not record a viewTime observation if the
url for a tab didn't change during a load event. To achieve this, we
needed to change which action we were using as a proxy for "navigation
events" - UpdateUrlAction contains the new url, allowing us to compare
against the current tab url.
Alternative solutions would be to keep using loading actions, but
dispatch a lastAccess event before performing a metadata update. This
would have worked, but would result in two lastAccess events being
dispatched for each navigation event instead of just one.
3 years ago
48c0d7faee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21337 : rename recently saved section on home
3 years ago
9d6367a607
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21366 : Fix intermittent test failure in TitleHeaderBindingTest
3 years ago
8d5a7606f4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21335 : return self instead of mock in FenixSnackbarKtTest.
...
This is a speculative fix for the intermittent issue. Typically, these
intermittents are caused by mocked lambdas but there is no mocked lambda
here. If this doesn't work, one `any()` argument fills in for a lambda:
it's possible that's causing the failure.
Unfortunately, I can't verify this fix easily because the "run test until
failure" option was removed from Android Studio.
See d396c9eb41298cc07fbf136f1de971010bc45d97 for a prior attempt to
address the intermittents in this class.
3 years ago
c2d385f142
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21236 : Fixes empty tray visibility logic
...
This is a bug we noticed after landing search term grouping.
An adapter can submit an empty list of items to the `ConcatAdapter`
early. This has the side-effect of triggering our `observeFirstInsert`
too soon and therefore updating the visibility to show the empty tray
placeholder and never switches back.
Our solution is to keep a constant observer on the adapter so we can
perform the visibility check on every insert/remove.
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
b239d7d934
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21291 : SearchDialogFragment: Get URL from clipboard once and not for every state update
3 years ago
02cbf2953f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21236 : Separate tabs with the same search term into a different section ( https://github.com/mozilla-mobile/fenix/pull/21177 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21236 : Separate tabs with the same search term into a different section in tabs tray
* Issue https://github.com/mozilla-mobile/fenix/issues/21236 : Scroll to selected tab + various tab fixes for groupings
* Issue https://github.com/mozilla-mobile/fenix/issues/21236 : Fix failing test
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
2dc9cfec20
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18102 : remove intermittent failing App onCreate duration measurement test.
...
The test as it exists relies on the robolectric lifecycle, which is hard
to predict, so it doesn't seem worth fixing the test. Writing the test
any other way would require excessive mocking, which also seems
impractical.
3 years ago
5ce4a31be5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21095 add customize home button on the home screen.
3 years ago
b057d6a76f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21099 - Update items under "Jump back in" section to the latest designs
3 years ago
d4a454442b
[fenix] Sort history metadata on home and allow limiting results
3 years ago
1e1a52e6f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20654 : Handle private mode switching from home behind search dialog.
...
Add tests for controller and interactor to handle private mode switches
3 years ago
9a78d339b5
[fenix] Fix history metadata API breakage in unit tests
3 years ago
fc42d08c06
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18629 : add support for SmartBlock exceptions
3 years ago
5d55e07dd3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21226 only show the "Customize Home" menu on home screen.
3 years ago
739d93372e
[fenix] Handle breaking changes from a-s 83.0.0 ( https://github.com/mozilla-mobile/fenix/pull/21215 )
3 years ago
42a5fcc880
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21095 allow users to configure their home screen.
3 years ago
d0757d386a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19947 : manually add login ( https://github.com/mozilla-mobile/fenix/pull/21199 )
...
* [WIP] New Layout for adding login and 'add login' button in 'SavedLoginsListView' to launch it.
Fixed bindings.
* [WIP] Removed "reveal password" button
* [WIP] Added interactor for the add login screen
* [WIP] Trying to check for duplicates
* [WIP] Renaming "addNew..." with "add..."
* [WIP] Check for duplicates
* [WIP] Fixes after merge
* Cleaning up the layout and making edit text for hostname selectable
* Error handling on add login screen. Tests for interactors and controllers
Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
88f34d654e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21183 : remove lazyMonitored wrapper functionality.
...
We're not using the functionality so there's no sense in doing the work.
However, we keep the wrapper: see the code comments for details.
3 years ago
c42b4d7481
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20892 update connection panel strings
3 years ago
691fe57943
[fenix] Issue mozilla-mobile https://github.com/mozilla-mobile/fenix/issues/21140 - Updated recent tab logic to show media tab and second-to-last tab, if the media tab was the last active tab. ( https://github.com/mozilla-mobile/fenix/pull/21141 )
...
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21140 - Updated recent tab logic to show media tab and second-to-last tab, if the media tab was the last active tab.
* Fixed RecentTabsListFeatureTest unit test
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
e7c3145fec
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18711 : Telemetry for credit card autofill
3 years ago
193016b662
[fenix] Remove mocked lambdas from AccountSettingsInteractorTest
3 years ago
dccc1133b1
[fenix] Update Android Components version ( https://github.com/mozilla-mobile/fenix/pull/21109 )
...
* Update Android Components version to 93.0.20210901143120.
* For https://github.com/mozilla-mobile/fenix/issues/21043 - Integrate AC changes
* Fix breaking API changes of RestoreAction
Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
2d433166a8
[fenix] Remove banner open in app telemetry
3 years ago
17ad77ea02
[fenix] Remove private browsing shortcut telemetry
3 years ago
1e05446283
[fenix] Remove tip telemetry
3 years ago
61d95c4967
[fenix] Remove find in page telemetry
3 years ago
9c5bb84cb1
[fenix] Remove total uri count telemetry
3 years ago
9a432d9f64
[fenix] Remove downloads misc telemetry.
3 years ago
054f6b5626
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21035 - Refactor HistoryViewInteractor from HistoryView into HistoryInteractor
3 years ago
690f3e72f5
[fenix] Dedupe history metadata in groups based on url
3 years ago
d105e8bc19
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19931 : Add telemetry probes for recent bookmarks on home screen ( https://github.com/mozilla-mobile/fenix/pull/20316 )
...
* Add telemetry probes for recent bookmarks on home screen. Tests for controller.
* Make the events into counters in the metrics ping
Update tests to reflect new metrics
Add data review link for new metrics
Mock new settings for startup metrics tests
Update metrics
Add test for recent bookmark glean events
* Recent bookmarks controller tests
3 years ago
7b7a252ecf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20507 - Inactive tabs telemetry
...
Two new events are added:
- "inactive_tabs_expanded" for when the inactive tabs section is expanded
- "inactive_tabs_collapsed" for when the inactive tabs section is collapsed
For tracking when an inactive tab is opened / closed I've repurposed the
existing tabs tray telemetry (since the functionality uses the same code)
- tabs_tray.opened_existing_tab
- tabs_tray.closed_existing_tab
to support an extra "source" key indicating the feature from which a tab was
opened or closed. The current values for this new key are:
- "Tabs tray" for when a tab was opened/closed from tabs tray
- "Inactive tabs" for when a tab was openes/closed from the Inactive tabs
section of the tabs tray.
3 years ago
9959334a26
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Finish migrating all synthetics usages
3 years ago
ecae7a61be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20328 - Adds telemetry for recentlyClosed button
...
...from tabsTray, inactiveTabs section.
3 years ago
48eff4f831
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in add-ons
3 years ago
2adea3fd40
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20927 : Replace icons with AC icons.
3 years ago
7ffaefd3fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove startup timeline probes
3 years ago
d2b9962319
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20945 : Fix failing test in AccountSettingsInteractorTest
3 years ago
eae779d231
[fenix] Speculative fixes intermittent test in DeleteAndQuitTest
3 years ago
b50ecb92b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20919 quit the after removing a study.
3 years ago
4e917c5eac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in tabs tray
3 years ago
5b99139048
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Migrate `home` from Kotlin synthetics to View Binding.
3 years ago
b38f717c4b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Migrate `browser` from Kotlin synthetics to View Binding.
3 years ago
c0d03b3d1e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in Login Exceptions
3 years ago
a82a02a9e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20890 when TP is off globally hide TP section on quick settings.
3 years ago
0a2cdff945
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/2783 : Add snackbar to collection deletion
3 years ago
aded72af41
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20864 : Speculative fix for HomeFragmentTest failures
3 years ago
5e0b094e4f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in tracking protection(2)
3 years ago
a4a1f6ddaf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in Share views
3 years ago
179dd793ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in Onboarding Tests
3 years ago
591d6744df
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796 : Additional fixes for intermittent failing test
...
Fixes for TrackingProtectionExceptionsInteractorTest to remove the lamba
mocking and test actual BrowserState changes instead (where possible).
3 years ago
93f23aa750
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 integrate view binding.
3 years ago
2d6dcb814c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add a back navigation to the Global Quick Settings from the Tracking Protection dialog
3 years ago
39dc0701a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Improve quick setting dialogs navigation
3 years ago
c9575d0d62
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove tracking protection overlay CFR
3 years ago
ab1e4228c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add connection sub-menu.
3 years ago
7d8ca1ec98
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add favicon to website info view
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
9bb39fe7b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Handle toggling tracking protection in quick settings
3 years ago
70d55f4746
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove the tracking protection indicator
3 years ago
8c5bccf445
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20853 : Fix intermittent failing test in HomeFragmentStoreTest
3 years ago
632311b1ea
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/15168 : Remove intermittent failing test in ToolbarViewTest
...
This test seems to be hacking at the binding between Fenix and the
BrowserToolbar to simulate toolbar events passing to the Fenix
interactor.
This is rather clumsy test that relies on the magic working of mockk
instead of following a general unit testing strategy that would commonly
require the class to be re-written to allow for better testing instead.
It is far safer to remove this test since we are not guaranteeing
anything in it and instead we see intermittent failures that make us
lose more time.
So therefore.. 🔥
3 years ago
d32727eff9
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796 : Fix intermittent test failure in TrackingProtectionExceptionsInteractorTest
3 years ago
14735a61ae
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20795 : Speculative fix for intermittent test failures in HomeFragmentTest
...
The expectation is that replacing `return` with `answers` will compute
the return value for the extension function again in order to avoid the
error, "no answer found for: Settings".
3 years ago
a590fd2b74
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20797 : Fix intermittent test failures in ShortcutsSuggestionProviderTest
3 years ago
9b20f9c1c0
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20792 : Fix intermittent test failures in QuickSettingsFragmentReducerTest
3 years ago
620d034134
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove perf.startup probes
3 years ago
d4a2d1ac83
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 add screen for opting out of experiments
3 years ago
be0f7d9dcc
[fenix] Disable intermittent tests.
3 years ago
21fedbf45f
[fenix] Dismisses search dialog if active in (RecentTabsHeaderViewHolder, RecentBookmarksViewHolderTest) and adapts test for the changes.
3 years ago
b8f673380f
[fenix] No issue: remove unnecessary robolectric annotations.
...
Theoretically, this should marginally decrease the duration of our unit
test suite. In my testing, for 1 iteration each (i.e. noise is very
possible), the duration changed from 9m 32s to 8m 21s – a 71s
improvement.
---
To identify tests that were running with robolectric that didn't need to
be, I removed the @RunWith(FenixRobo... from all relevant files:
sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt
I ran the tests and discovered which ones failed from the Classes tab of
the index.html test result file. Something like:
tests = document.querySelectorAll('table')[3].querySelectorAll('tr');
failureElements = tests.querySelectorAll('.failures');
// TODO: extract the test names
Then I copied these results to a text file and compared them to all the
files that had robolectric test runners to figure out which ones still
pass:
comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt
And undid the changes to the failing files:
for i in $(cat robolectric_not_needed.txt); do git checkout $i; done
Then I removed the import statements on those files:
for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done
for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done
3 years ago
7273536742
[fenix] For FNXV2-17067: always show home in background behind search dialog ( https://github.com/mozilla-mobile/fenix/pull/20573 )
...
* Navigate to home on toolbar click. Handle back press from search dialog
Update tests to show home behind search dialog. Remove unused test.
Jump back in show all button is clickable behind search dialog
Recently saved bookmarks show all button is clickable behind search dialog
* Add feature flag
* Past explorations show all button is clickable behind search dialog
Handle keyboard in controllers instead of viewholders. Update tests.
Allow collections to be visible behind search dialog
Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard
Verify navigateUp in tests
Adding ignore for flaky UI test
Only resize home behind search dialog
Add ignore for collection intermittent test
Cleanup
3 years ago
dcbd978c73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20425 : Re-add tests for class BookmarksUseCaseTest.
3 years ago
feb8f5e363
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20726 : Fix intermittent failure in AddonsManagementViewTest
3 years ago
Mugurell
mcarare
Marc Leclair
Arturo Mejia
Roger Yang
Noah Bond
Jan-Erik Rediger
indu
MatthewTighe
Gabriel Luong
Alexandru Putanu
Alexandru2909
James Hugman
jhugman
sarah541
bendk
mike a
mavduevskiy
tristan-jea
jknair
Brais Gabín
Sebastian Kaspari
Jonathan Almeida
Elise Richards
Christian Sadilek
Grigory Kruglov
Rohan Maity
Lucius C
Grisha Kruglov
aime Soriano Pastor
MickeyMoz
Noah Bond
Jonathan Almeida
Michael Comella
Ben Dean-Kawamura
sunil9211
codrut.topliceanu
Mickey Moz
Rohan Maity
Vitaly V. Pinchuk