Commit Graph

3936 Commits (08a71a5366908f3ba3f63895202094e2a78686de)

Author SHA1 Message Date
Mugurell 08a71a5366 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21391 - Final design composables
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
3 years ago
Roger Yang c0c59f266b [fenix] No issue: Improve rendering of jump back in 3 years ago
Roger Yang 55da682e79 [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21552: Remove Extra Subtitle In Jump Back In Item 3 years ago
Roger Yang f90fd65ccd [fenix] Fix recent tabs intermittent tests (https://github.com/mozilla-mobile/fenix/pull/21557)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Mugurell 219561d304 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21275 - Sort items by how many times they were actually shown 3 years ago
Christian Sadilek 4702a66203 [fenix] Do not capture search terms when user navigates away via app (https://github.com/mozilla-mobile/fenix/pull/21527)
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
Roger Yang f65770a34f [fenix] Close https://github.com/mozilla-mobile/fenix/issues/21451: Add active search term tab groups on home 3 years ago
Arturo Mejia c4eb7ea28b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21493 show onboarding dialog for home sections 3 years ago
codrut.topliceanu 6da619deb7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20762 - Fixes NPE crash with nullchecks for binding 3 years ago
Mugurell d701a81103 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21045: Add categories support 3 years ago
Mugurell c37f1e550b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21045: Cleanup
- stick to one naming scheme: rename articles to stories and use this all
throughout the app.
- add some spacing above the new section (as per the current design)
3 years ago
codrut.topliceanu 7ea5cdbe39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21087: Updates Recently Saved design 3 years ago
Christian Sadilek c9e1bfe3dc [fenix] Fix mapping between history visits and groups to use createdAt
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
3 years ago
Christian Sadilek a6a6b6f257 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20893: Dedupe urls/site in history groups 3 years ago
Gabriel Luong cb4b5fc613 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21460 - Rename "Delete from history" to "Remove" for recent visit dropdown menu 3 years ago
Gabriel Luong e3bc494414 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs 3 years ago
Arturo Mejia e87af643cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 improve telemetry values for Allow users to customize their home screen 3 years ago
Travis Long 023612b87d [fenix] Fix logic so `isFirstRun` can be called multiple times on first run 3 years ago
Travis Long b4886fe546 [fenix] [SDK-344] Pass in first-run information to Nimbus for targeting 3 years ago
Gabriel Luong 450055a729 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21413 - Remove unused OnboardingPrivateBrowsingViewHolder and OnboardingWhatsNewViewHolder 3 years ago
Sebastian Kaspari 10f5aa228b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172: Refactor UI tests accessing awesomebar suggestions. 3 years ago
Sebastian Kaspari 74500adfb5 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21172: Replace BrowserAwesomeBar view with AwesomeBar() composable. 3 years ago
Gabriel Luong bc30e53e5d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21408 - Pass the corresponding HistoryMetadataKey to openToBrowserAndLoad and addTab use case 3 years ago
Gabriel Luong 793ceb8e28 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 - Search term groups in history 3 years ago
Michael Comella 275ac7ad5b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21126: process performancetest intent for AC too. 3 years ago
Arturo Mejia c3df9a26d2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 add telemetry for Allow users to customize their home screen 3 years ago
Christian Sadilek e18fbdfbfc [fenix] Make sure to only record view time once for a given tab access
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
Grisha Kruglov 6297f2cce9 [fenix] Use UpdateUrlAction to record viewTime observations
We discovered that in a tab restore scenario we were recording view time
observations that were wrong - we'd record time deltas as-if user was
looking at the page while the browser wasn't running.

This happens because when we record a viewTime observation, we compare
current time with lastAccess time of the tab. In a restore scenario,
that lastAccess time happens to be from when the browser was last
running - which could be days ago.

The simplest solution was to not record a viewTime observation if the
url for a tab didn't change during a load event. To achieve this, we
needed to change which action we were using as a proxy for "navigation
events" - UpdateUrlAction contains the new url, allowing us to compare
against the current tab url.

Alternative solutions would be to keep using loading actions, but
dispatch a lastAccess event before performing a metadata update. This
would have worked, but would result in two lastAccess events being
dispatched for each navigation event instead of just one.
3 years ago
Christian Sadilek 473f671f1c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21388: Only parse clipboard content when search fragment is attached 3 years ago
Michael Comella 9c2e6eee78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21296: add ProfilerMarkers.addForDispatchTouchEvent. 3 years ago
Michael Comella 49294996e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21299: add duration markers for HomeActivity Create/Start.
We only instrument these methods because they're the only ones that
noticeably long running in the current implementation.
3 years ago
Michael Comella 4a132b958b [fenix] For https://github.com/mozilla-mobile/fenix/issues/21299: add duration marker for IntentReceiverActivity.onCreate.
We only instrument onCreate because it's the only one with an
implementation.

While declaring this as a function that accepts a lambda is less
fragile, we've previously had issues with it such as suspected memory
leaks when used for telemetry. Therefore, we go with the simpler
approach.
3 years ago
Michael Comella f53adc5b12 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21299: add markers for all activity lifecycle callbacks.
We implement these all in the same track because between it'd create a
lot noise between this and fragment lifecycle callbacks.
3 years ago
Jonathan Almeida c2d385f142 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21236: Fixes empty tray visibility logic
This is a bug we noticed after landing search term grouping.

An adapter can submit an empty list of items to the `ConcatAdapter`
early. This has the side-effect of triggering our `observeFirstInsert`
too soon and therefore updating the visibility to show the empty tray
placeholder and never switches back.

Our solution is to keep a constant observer on the adapter so we can
perform the visibility check on every insert/remove.

Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
Sebastian Kaspari b239d7d934 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21291: SearchDialogFragment: Get URL from clipboard once and not for every state update 3 years ago
Roger Yang 02cbf2953f [fenix] For https://github.com/mozilla-mobile/fenix/issues/21236: Separate tabs with the same search term into a different section (https://github.com/mozilla-mobile/fenix/pull/21177)
* For https://github.com/mozilla-mobile/fenix/issues/21236: Separate tabs with the same search term into a different section in tabs tray

* Issue https://github.com/mozilla-mobile/fenix/issues/21236: Scroll to selected tab + various tab fixes for groupings

* Issue https://github.com/mozilla-mobile/fenix/issues/21236: Fix failing test

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Michael Comella 336d681451 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21309: add profiler markers on global layout. 3 years ago
Michael Comella 595a81aec2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21309: set up HomeActivityBinding the recommended way.
The recommended way is here:
https://developer.android.com/topic/libraries/view-binding

I was concerned with the existing implementation that binding was being
set conditionally.
3 years ago
rxu e78754d598 [fenix] Add default topsite 58 for MozillaOnline builds 3 years ago
Arturo Mejia 5ce4a31be5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21095 add customize home button on the home screen. 3 years ago
Gabriel Luong b057d6a76f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21099 - Update items under "Jump back in" section to the latest designs 3 years ago
Christian Sadilek d4a454442b [fenix] Sort history metadata on home and allow limiting results 3 years ago
Mugurell b0957a77ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/21120 - ImageLoader with a shimmer effect placeholder 3 years ago
Elise Richards 1e1a52e6f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/20654: Handle private mode switching from home behind search dialog.
Add tests for controller and interactor to handle private mode switches
3 years ago
Arturo Mejia fc42d08c06 [fenix] For https://github.com/mozilla-mobile/fenix/issues/18629: add support for SmartBlock exceptions 3 years ago
Arturo Mejia 5d55e07dd3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/21226 only show the "Customize Home" menu on home screen. 3 years ago
Arturo Mejia ea5d0ee63d [fenix] For https://github.com/mozilla-mobile/fenix/issues/21211 hide the ETP in custom tabs. 3 years ago
bendk 739d93372e [fenix] Handle breaking changes from a-s 83.0.0 (https://github.com/mozilla-mobile/fenix/pull/21215) 3 years ago
Noah Bond 434c0b6918 [fenix] Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/20637 - Fixed bug causing the tabs tray to scroll to the wrong tab when opened 3 years ago
mcarare 1d78c8b1a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6968: Use close instead of read to close the response stream. 3 years ago