Commit Graph

5082 Commits (fix-addon-search)

Author SHA1 Message Date
AndiAJ fc964862e0 For #16615: UI Smoke Tests for Recently Closed Tabs 3 years ago
Mozilla L10n Automation Bot 837eaa3282 Import l10n. 3 years ago
Oana Horvath 7ac4af46bc For #10798 & #14526: Apply auto-download test file fix for download UI tests 3 years ago
Oana Horvath 23789c86c4 For #16615: UI smoke test manageDownloadsInDownloadsMenuTest 3 years ago
mcarare 4e736625bd For #8716: Authentication custom tab now considers browsing mode. 3 years ago
Mozilla L10n Automation Bot 6a84eed552 Import l10n. 3 years ago
Mozilla L10n Automation Bot 7fc0ef5379 Import l10n. 3 years ago
Christian Sadilek cef56bef17 Update Android Components version to 71.0.20210108190105 3 years ago
Stefan Arentz c0f1e25f79
String Uplifts for Firefox 85 (#17371)
* Import l10n.

(cherry picked from commit 7bf0f7595c)

* Import l10n.

(cherry picked from commit 5445e61b6a)

* Import l10n.

(cherry picked from commit 57d453dc7f)

* Import l10n.

(cherry picked from commit 96b63485cc)

* Import l10n.

(cherry picked from commit 33272d5447)

* Import l10n.

(cherry picked from commit 16ab8bf1ab)

* Import l10n.

(cherry picked from commit 96be55067d)

* Import l10n.

(cherry picked from commit f8f677ce7f)

* Import l10n.

(cherry picked from commit bad65b5017)

* Import l10n.

(cherry picked from commit 9c776f1d7f)

* Import l10n.

(cherry picked from commit f95547c271)

* Import l10n.

(cherry picked from commit 9966a85bd5)

* Import l10n.

(cherry picked from commit 1fbf227a61)

Co-authored-by: Mozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
3 years ago
Suraj Shah 15f3743ca0
For #16271 - Fixes ripple being cut-off in Saved logins sort toolbar (#16741) 3 years ago
Mugurell 484f167714 For #16249 - ClipboardHandler cleans up returned text 3 years ago
mcarare d110464a91 For #17117: Use proper custom tab session for custom tab toolbar menu. 3 years ago
Mozilla L10n Automation Bot 1fbf227a61 Import l10n. 3 years ago
Arturo Mejia 0aa44c93cd Closes issue #16945 Refactor TrackingProtectionOverlay to observe session via store. 3 years ago
Christian Sadilek 9a53054b28 Use new RestoreUseCase in A-C to handle tab timeouts 3 years ago
Mozilla L10n Automation Bot 9966a85bd5 Import l10n. 3 years ago
Arturo Mejia 743ba6918f Closes issue #16944 Refactor TrackingProtectionPanelDialogFragment to observe session via store. 3 years ago
mcarare 156dee29d8 For #15464: Always dismiss search dialog on url committed. 3 years ago
Hakkı Kaan Çalışkan e41cc5a414 For #17303: Move ext fun runIfFragmentIsAttached to utils
move to ext
3 years ago
Gabriel Luong d0fc086fc4
For #16790 - Allow top sites to have an empty name when renamed (#17290) 3 years ago
Roger Yang afa0454f2b
Closes #16603: Disable pull down when in fullscreen (#17314) 3 years ago
Marcello Galhardo 381f22449b
Closes #17118: Fix font spacing when long pressing a URL (#17164) 3 years ago
Sebastian Kaspari 1b6cebf4d4 Switch to new SessionStorage / session restore API. 3 years ago
Oana Horvath d7a35ed6bd For #16966: Remove unnecessary step from mainMenuAddToHomeScreenTest 3 years ago
ekager d5f625c945 For #17177 - Do not show PBM CFR if entering search on home, make sure fragment attached before showing 3 years ago
Mozilla L10n Automation Bot f95547c271 Import l10n. 3 years ago
Roger Yang 7527851cf0
Closes #17298: Turn on new MediaSession feature for all builds (#17302) 3 years ago
Marcello Galhardo e3a77cb750
Closes #14009: Fix onboarding 'Sign in to Firefox' ripple effect (#17169)
* Closes #14009: Fix onboarding 'Sign in to Firefox' ripple effect

* For #14009: Add 'onboarding_padded_background_color' instead of rely on OS theme/color

Both previous solution, '?android:attr/colorControlHighlight' and '@color/ripple_material_light' were using a OS theme attr or color, which caused problems. To fix it, we introduced a 'onboarding_padded_background_color' which manually define the ripple effect color of the onboarding manual sign in button.
3 years ago
MarcLeclair 24bce64e0b
16373 Count the # of inflations done on startup (#16778)
* For #16373: Added performance Inflater to counter # of inflations

This class is quite straight forward. The only thing that I have to point out is the onCreateView method. It usually
calls its super if you don't override it. The problem with that is that the super.onCreateView actually uses
android.view. as a prefix for the XML element it tries to inflate. So if we have an element that isn't part
of that package, it'll crash. As I said in the code, a good example is ImageButton. Calling android.view.ImageButton
will make the app crash. The method is implemented the same way that PhoneLayoutInflater does (Another example
is the AsyncLayoutInflater)

* For #16373: Added test for PerformanceInflater

This test got quite awkward / complicated fast.  I wanted to test the  to make sure we don't break *any* of our layouts
and to do so, I decided to just retrieve all our XML in our /res/layout folder. However, this gets quite a bit outside of a unit test scope.
The point was to get every layouts and get their LayoutID through the resources using the testContext we have. It gets even weirder, since some
of the XML tags have special implementation in android. One of them is the <fragment> tag. That tag actually is inflated by the OS using the Factory2
that the Activity.java implements. In order to get around the fragment issue, we just return a basic FrameLayout since the system LayoutInflater doesn't deal
won't ever get a <fragment> tag to inflate. Another issue was the <merge> tag. In order to inflate those, you need 1) a root view and 2) attach your view to it.
In order to be able to test those layouts file, I had to create an empty FrameLayout and use it as the root view for testing. Again, I know this is beyond the spirit of a unit test but if we use this inflater, I think it should make sure that no layouts are broken by it.

* For #16373: Overrode getSystemService to return PerformanceInflater

This allows PerformanceInflater to be called in every inflation to keep track of the number of inflations we do.

* For #16373: Added UI test for # of inflations

* For #16373: Lint fix

* For #167373: Changed the LayoutInflater cloneInContext to take this instead of inflater

The inflater parameter is set on the first call from the OS from  the Window object. However, the activity itself sets multiple factories on the inflater
during its creation (usually through AppCompatDelegateImpl.java). This means that, once we initially set the inflater with a null check, we pass an inflater
that has no factory initially. However, since we keep a reference to it, when cloneInContext was called, it cloned the inflater with the original inflater
which didn't have any factories set up. This meant that the app would crash on either browserFragment creation or any thing that required appCompat (such as
ImageView and ImageButton). Now, passing itself with a cloneInContext means we keep all the factories initially set by the activity or the fragment.

* For #16373: Fixed code issues for PR. No behavior change

* For #16373: fixed some code nits
3 years ago
mcarare 251d652833 For #16027: Allow elements to be selected separately by a11y services. 3 years ago
Gabriel Luong 487ba32441
For #17292 - Remove unused static_strings (#17293) 3 years ago
mcarare 2d1df018ff For #15061: Fix error text color in SyncedTabsFragment. 3 years ago
Codrut Topliceanu c0f0c401f3
For #11580 - Tracks text selection context menu usage (#16968)
* For #11580 - Tracks text selection context menu usage

Tracks Copy, Search, Select All and Share items from the text selection context menu. Uses AC's DefaultSelectionActionDelegate to achieve this.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Marcello Galhardo b34cc24f88
For #9778 - Site permission settings item height set to 48dp (#17134) 3 years ago
Mozilla L10n Automation Bot 9c776f1d7f Import l10n. 4 years ago
Adam Novak b707adb7f1 Satisfy the linter 4 years ago
Adam Novak 3b151c25a5 Cut more references to the tab picker onboarding 4 years ago
Adam Novak 847193edd5 Default to grid tab view 4 years ago
Adam Novak c8b0326836 Rip out most other hooks into the tab tray customization code except the translations 4 years ago
Adam Novak 7b9eaa9304 Start ripping out the custom tab tray that I lack the resources to maintain 4 years ago
Adam Novak 39bb01f3c9 Merge tag 'v84.1.2' into beta-sync 4 years ago
Mozilla L10n Automation Bot bad65b5017 Import l10n. 4 years ago
Mozilla L10n Automation Bot f8f677ce7f Import l10n. 4 years ago
Mozilla L10n Automation Bot 96be55067d Import l10n. 4 years ago
Mozilla L10n Automation Bot 16ab8bf1ab Import l10n. 4 years ago
Mozilla L10n Automation Bot 33272d5447 Import l10n. 4 years ago
Mozilla L10n Automation Bot 96b63485cc Import l10n. 4 years ago
Mozilla L10n Automation Bot 57d453dc7f Import l10n. 4 years ago
Christian Sadilek 801ce85898 For #17073: Stop observers after test run 4 years ago
Mozilla L10n Automation Bot 5445e61b6a Import l10n. 4 years ago
Arturo Mejia 81f208bda1 For issue #13981 Use DEEP_LINK_SCHEME instead of hard-coded fenix 4 years ago
Mozilla L10n Automation Bot 7bf0f7595c Import l10n. 4 years ago
Elise Richards 6dadecacc2
For #15703 and #17133: allow ETP redirect trackers setting to be customized (#17137)
* Remove ETP redirect trackers feature flag. Add category to ETP panel view.

* Add redirect tracker category to ETP custom settings
4 years ago
ekager d3e1045ab9 For #17165 - Use application context to get notification localized strings 4 years ago
Christian Sadilek 7a01fcbfa9 Closes #17073: Fix intermittent failures in PwaOnboardingObserverTest 4 years ago
Oana Horvath 095d07598a Code cleanup in BookmarksRobot and BookmarksTest 4 years ago
Christian Sadilek 36a6d364a7 For #17086 #17143: Temporarily turn off Nimbus 4 years ago
jhugman 4565d7381b
No bug- protect nimbus init from StrictMode (#17033) r=christian 4 years ago
Christian Sadilek 0b99669753 Closes #16949: Refactor OpenInAppOnboardingObserver to use browser store 4 years ago
Oana Horvath 0a0dbeb132 Added a description to each smoke test 4 years ago
Oana Horvath b0277c3f39 For #16615: UI smoke test noCrashWithAddonInstalledTest 4 years ago
Sebastian Kaspari d2b8decaeb Switch to new feature-tab-collections API. 4 years ago
ekager e5a5897ef1 l10n import uplifts 4 years ago
ekager af29a2ccdd l10n import uplifts 4 years ago
ekager 30df43d057
For #13321 - Do not hide toolbar when opening multiple bookmarks (#17038) 4 years ago
mcarare 04bd9c61a6 For #16483: Rotate edit arrow when toolbar position is set to bottom. 4 years ago
Mugurell 9c15267de9 For #11578 - Cleanup download telemetry - metrics ping reference
These pings were implemented first as counters.
When changing to events "send_in_pings: - metrics" still remained causing
confusion.
This patch comes to remove this confusion and potential future issues.
4 years ago
mcarare e24ec1c941 For #16068: Update SUMO links. 4 years ago
Mugurell 4d38440594
For #15367 - Cleanup metrics ping reference (#17071)
These pings were implemented first as counters.
When changing to events "send_in_pings: - metrics" still remained causing
confusion.
This patch comes to remove this confusion and potential future issues.
4 years ago
mcarare e0c3193162 For #17061: Prevent appBarLayout from leaking. 4 years ago
mcarare fc43e85e4d For #16827: Send copy url metrics correctly. 4 years ago
mcarare ab0a5a84fb For #15369: Send synced tabs metrics correctly. 4 years ago
Oana Horvath f24c6e1316 For #16615: UI smoke test redirectToAppPermissionsSystemSettingsTest 4 years ago
Kate Glazko 233018df84 For #298: Fenix Quarantine For Delete Downloads UX 4 years ago
Christian Sadilek 5157a3f50e Closes #17045: Crash caused by calling consumeFlow on wrong thread 4 years ago
ekager 419f895364 For #16973 - Use controller handled action instead of toolbar focus 4 years ago
Gabriel Luong 846d618c06
For #16941 - [Telemetry] Bookmark Counts (#16942) 4 years ago
Christian Sadilek d8f3127e08 Closes #16946: Refactor PwaOnboardingObserver to use browser store 4 years ago
Sebastian Kaspari 46813dd89c
Add search current/home region to debug screen. (#17015) 4 years ago
Codrut Topliceanu d0b09b7d69
For #15368 - Adds telemetry for fullscreen, pip (#16833) 4 years ago
mcarare 01db5160ee For #16827: Add copy url from long press metrics. 4 years ago
mcarare c006ae5056 For #16827: Add documentation for copy url metrics. 4 years ago
mcarare 93b13ac977 For #15369: Add synced tabs usage metrics. 4 years ago
mcarare 1d5fa23026 For #15369: Add documentation for synced tabs opening metrics. 4 years ago
mcarare d233229ce4 For #15366: Add recently closed tabs metrics from history fragment. 4 years ago
mcarare 2f360eb474 For #15366: Add recently closed tabs metrics. 4 years ago
mcarare d0f2209cae For #15366: Add documentation for recently closed tabs metrics. 4 years ago
mcarare a59195e2ee For #16422: Handle theme for tab history bottom sheet. 4 years ago
Mugurell 574eac4636
For #15367 - DownloadsFragment telemetry (#16728)
Adds a counter for how many times the user does the following action:
- opens the Downloads section inside the app
- tap to open an item from inside Downloads / from the download dialog
- tap to delete one or more downloads at once
4 years ago
Mugurell d5b33aec43
For #11578 - Add telemetry for how many times we download something (#16730) 4 years ago
Adam Novak a233c796fd Get build working again after merge 4 years ago
Adam Novak 12bbfa9c4c Merge tag 'v84.1.0' into beta-sync 4 years ago
mcarare 4b2dc28d57 For #16992: Align clipboard link and text with scan button. 4 years ago
Michael Debertol 95860eba49
For #4333: Open the keyboard when a search engine is selected (#14353)
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
Arturo Mejia f263b7333a For issue #16847 Show the autoplay icon in the toolbar 4 years ago
ekager 3b0e70a856 For #16937 - Ensure FIP is removed on navigation 4 years ago
ekager 2796a7ff18 For #16675 For #16398 - Fix button styling 4 years ago
Jeff Boek cf61c10c39
For #15403 - Adds a secret debug info screen in settings (#15540)
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
ekager 1ca34a2bc9 For #16807 - Make sure there's only one instance of search dialog 4 years ago
Elise Richards 813693f1d3
Remove hidden fab in tabs tray (#16972) 4 years ago
Codrut Topliceanu 556fea5591
For #15636 - Focus a11y collection on snackbar view tap (#16853)
With accessibility enabled, when adding a site to a collection and tapping "View" on the snackbar, we send a request for focus and an `AccessibilityEvent.TYPE_VIEW_FOCUSED` to the specified collection.
4 years ago
jhugman 9a984f10f1
Add withExperiment extension method to Nimbus (#16926) r=christian, sebastian
* Fixes #16925 Add withExperiment extension method to Nimbus
* Don't call Nimbus at all if not enabled by FeatureFlag
4 years ago
Roger Yang 830cf52e88 Closes #16075: Add distribution_id in telemetry startup metrics (#16821)
(cherry picked from commit ca605d8a95)
4 years ago
Oana Horvath 9d5ec47ec3 Fix #16960 & #16959: updateSavedLoginTest, swipeToSwitchTabTest UI smoke tests 4 years ago
Roger Yang ca605d8a95
Closes #16075: Add distribution_id in telemetry startup metrics (#16821) 4 years ago
Christian Sadilek f0078097f8 Prepare for A-C Session[Manager] observable deprecation 4 years ago
Mozilla L10n Automation Bot cecb8385e7 Import l10n. 4 years ago
ekager dd2615b554
For #16442 - Check if fragment is still attached before updating site permissions rules (#16954) 4 years ago
jhugman 459f1e970f
Fixes #16948: call nimbus.updateExperiments on startup (#16950) r=gl 4 years ago
mcarare a2ad9f7a27 For #16894: Handle adding voice search button depending on state. 4 years ago
mcarare 0a77f4bccf For #16775: Fallback to light mode drawable when ui mode is not resolved 4 years ago
mcarare b4a81c2219 For #15640: Remove private resources from RadioButtonPreference. 4 years ago
mcarare fa08afbc03 For #15640: Remove private resources from TextPercentageSeekBarPref. 4 years ago
mcarare 0a6808d0bc For #15640: Increase PrivateResource warning severity to error. 4 years ago
Mozilla L10n Automation Bot 0ed5ba68c6 Import l10n. 4 years ago
ekager 2bb7bea258 For #16668 - Fix keyboard show/hide from search dialog fragment 4 years ago
Kate Glazko ef01cdcefe For #16541: Download UX Updates 4 years ago
Christian Sadilek faf765a57d Update IntentProcessors after breaking API change 4 years ago
Emilio Cobos Álvarez 9d5afd501e Add support for EME permission.
This accompanies the changes in mozilla-mobile/android-components#9121.

Closes #1175
4 years ago
Mugurell f2191bdbb5 For #13427 - Disable the "selected tab" decoration when in Multiselect
Selecting a tab while in Multiselect would add a different decoration to the one
already set for the last tab opened and this would confuse users.
Let's avoid this.
4 years ago
Christian Sadilek d1345e8f93 Closes #11290: Refactor ToolbarMenu to use browser store 4 years ago
Roger Yang 2ff7ba75c7
Closes #16896: Integrate new MediaSession API to nightly or debug builds (#16909) 4 years ago
Oana Horvath 80ad6dea32 For #16615: UI smoke test updateSavedLoginTest 4 years ago
Oana Horvath 5e046c8f04 For #16615: UI smoke test startBrowsingButtonTest 4 years ago
Mozilla L10n Automation Bot 5cc66f532f Import l10n. 4 years ago
Elise Richards 948db6f77b
Reload restored tabs from collection (#16865) 4 years ago
Sebastian Kaspari 2cada405d8 Update Android Components to 69.0.20201207103252. 4 years ago
Mozilla L10n Automation Bot 507445a400 Import l10n. 4 years ago
Mozilla L10n Automation Bot 68ae35027f Import l10n. 4 years ago
ekager ef38c364ff For #16397 - Fixes SignOutFragment crash and invisible button 4 years ago
ekager e428694a51 For #16397 - Fixes SignOutFragment crash and invisible button 4 years ago
Oana Horvath 7a08175568 For #16615: Smoke UI test swipeToSwitchTabTest 4 years ago
Mugurell c89a7193f5
For #16248 - Cleanup error pages of inlined code (#16834)
Also streamlined the js code.
The errorPageScripts.js from AC had too much or too little of what we needed.
4 years ago
Roger Yang 3c3ddb4f44
For #16133: Simplify OpenInAppOnboardingObserver condition (#16851) 4 years ago
Philipp Klein 2be3fd05f2
For #15362: Remove swipe to delete for bookmarks (#16646)
Removed now obsolete feature flag and tests.
Removed obsolete swipe refresh state from BookmarkFragmentState
Also adapted tests and remove obsolete ones.
4 years ago
Mozilla L10n Automation Bot c63a14af14 Import l10n. 4 years ago
Elise Richards 77f061c362 Closes #8791: Use A-C tab counter and upgrades to A-C 69.0.20201203202830
Upgrades to A-C 69.0.20201203202830 and addresses breaking changes:
- Upgrades androidx workmanager to 2.4.0 in line with A-C.
- RecordingDevicesNotificationFeature was removed
- SearchUseCases accept parent session ID instead of session itself
4 years ago
Codrut Topliceanu 79d1c08402
For #16629 - Fix for collection snackbar View button (#16679) 4 years ago
Oana Horvath 8a579ee62b For #16838: deleted mainMenuOpenInAppTest 4 years ago
Jonathan Almeida c99b2157fb Fix breaking changes from FCM SDK update 4 years ago
jhugman ea9f692007
Nimbus-SDK-119 Get Nimbus server endpoint at build time. (#16682)
This PR builds on [AC##9024][1], and implements setting the Nimbus endpoints from [a secret set at build time][2].

For production use, this requires a secret named `nimbus_url` to be put into CI.

Note: Nimbus is currently behind a feature flag.

If developers wish to use a Nimbus server for local development, you can set the url by adding an entry into local.properties, e.g.:

```
nimbus.remote-settings.url=https://settings.stage.moz4ws.net
```

Without setting server, Nimbus will be able to function, except no experimental definitions will be fetched, and features under experiment will be configured as if not enrolled in the experiment.

[1]: https://github.com/mozilla-mobile/android-components/pull/9024
[2]: https://groups.google.com/a/mozilla.com/g/android-components-team/c/lAGVKQy8aiA/m/rY3uGAwhBAAJ
4 years ago
jhugman 3cd4ff9ac8
Adding menu configuration for A/A experiment and A/B experiment (#16692) 4 years ago
Mozilla L10n Automation Bot eab87555dc Import l10n. 4 years ago
Christian Sadilek 3722033a5c For #16032: Support installing recommended add-ons from AMO 4 years ago
Roger Yang 26051f7c0e
Closes #16603: Disable pull down refresh when activity is in immersive mode (#16793) 4 years ago
Oana Horvath 5867d2830a Split UI smoke tests into smaller tests 4 years ago
Mozilla L10n Automation Bot a2b6ddf457 Import l10n. 4 years ago
Mozilla L10n Automation Bot e587f814c7 Import l10n. 4 years ago
Sebastian Kaspari 57ebc0cb99 ExternalAppBrowserActivity: Add additional test cases. 4 years ago
Sebastian Kaspari 788a8309c2 Issue #16435: Open custom tab in Fenix: Force launch outside of and remove current task. 4 years ago