From feb8f5e363f2a25846bb9130a8494dbeb8565bef Mon Sep 17 00:00:00 2001 From: Jonathan Almeida Date: Fri, 6 Aug 2021 14:58:45 -0400 Subject: [PATCH] [fenix] Close https://github.com/mozilla-mobile/fenix/issues/20726: Fix intermittent failure in AddonsManagementViewTest --- .../org/mozilla/fenix/addons/AddonsManagementViewTest.kt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/test/java/org/mozilla/fenix/addons/AddonsManagementViewTest.kt b/app/src/test/java/org/mozilla/fenix/addons/AddonsManagementViewTest.kt index 11ee765cec..4272124c56 100644 --- a/app/src/test/java/org/mozilla/fenix/addons/AddonsManagementViewTest.kt +++ b/app/src/test/java/org/mozilla/fenix/addons/AddonsManagementViewTest.kt @@ -13,6 +13,7 @@ import io.mockk.mockk import io.mockk.verify import mozilla.components.feature.addons.Addon import mozilla.components.feature.addons.ui.AddonsManagerAdapterDelegate +import org.junit.Assert.assertTrue import org.junit.Before import org.junit.Test import org.junit.runner.RunWith @@ -26,8 +27,9 @@ import org.mozilla.fenix.helpers.FenixRobolectricTestRunner class AddonsManagementViewTest { @RelaxedMockK private lateinit var navController: NavController - @RelaxedMockK private lateinit var showPermissionDialog: (Addon) -> Unit private lateinit var managementView: AddonsManagerAdapterDelegate + private var showPermissionDialog: (Addon) -> Unit = { permissionDialogDisplayed = true } + private var permissionDialogDisplayed = false @Before fun setup() { @@ -111,7 +113,7 @@ class AddonsManagementViewTest { fun `onInstallAddonButtonClicked shows permission dialog`() { val addon = mockk() managementView.onInstallAddonButtonClicked(addon) - verify { showPermissionDialog(addon) } + assertTrue(permissionDialogDisplayed) } @Test