From f6f1b1a407ff857b5923c5f0fbe66b905970ab2d Mon Sep 17 00:00:00 2001 From: Rebeca Tudor Date: Wed, 8 Mar 2023 22:13:31 +0200 Subject: [PATCH] Bug 1815951 - Increase the size of text fields in Edit login Now they have the minimum height recommended by a11y best practices - 48dp. --- app/src/main/res/layout/fragment_edit_login.xml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/app/src/main/res/layout/fragment_edit_login.xml b/app/src/main/res/layout/fragment_edit_login.xml index 76fa01cd6..67834702f 100644 --- a/app/src/main/res/layout/fragment_edit_login.xml +++ b/app/src/main/res/layout/fragment_edit_login.xml @@ -40,7 +40,6 @@ android:focusable="false" android:background="@android:color/transparent" android:textColor="?attr/textPrimary" - android:layout_marginTop="12dp" android:layout_marginStart="3dp" android:contentDescription="@string/saved_login_hostname_description" app:backgroundTint="@android:color/transparent" @@ -53,6 +52,8 @@ android:id="@+id/hostnameText" android:layout_width="match_parent" android:layout_height="wrap_content" + android:paddingTop="12dp" + android:paddingBottom="14dp" android:textSize="16sp" android:fontFamily="sans-serif" android:textStyle="normal" @@ -80,7 +81,7 @@ android:gravity="center_vertical" android:paddingStart="3dp" android:paddingEnd="0dp" - android:layout_marginTop="20dp" + android:layout_marginTop="6dp" android:text="@string/preferences_passwords_saved_logins_username" android:textColor="?attr/textPrimary" android:letterSpacing="0.05" @@ -108,6 +109,7 @@ android:id="@+id/usernameText" android:layout_width="match_parent" android:layout_height="wrap_content" + android:minHeight="@dimen/accessibility_min_height" android:textSize="16sp" android:fontFamily="sans-serif" android:textStyle="normal" @@ -152,7 +154,7 @@ android:paddingEnd="0dp" android:text="@string/preferences_passwords_saved_logins_password" android:textColor="?attr/textPrimary" - android:layout_marginTop="10dp" + android:layout_marginTop="5dp" android:letterSpacing="0.05" app:layout_constraintBottom_toTopOf="@id/inputLayoutPassword" app:layout_constraintEnd_toStartOf="@id/revealPasswordButton" @@ -179,6 +181,7 @@ android:id="@+id/passwordText" android:layout_width="match_parent" android:layout_height="wrap_content" + android:minHeight="@dimen/accessibility_min_height" android:clickable="true" android:colorControlActivated="?attr/textPrimary" android:colorControlHighlight="?attr/textPrimary"