From f6696b57cdb9ce82e71933d0a46d9bf451301f87 Mon Sep 17 00:00:00 2001
From: Cathy Lu <calu@mozilla.com>
Date: Mon, 2 Oct 2023 14:09:08 -0500
Subject: [PATCH] Bug 1848658 - Remove fakespot shopping adjusted rating
 toFloatOrNull call

---
 .../shopping/middleware/ProductAnalysisMapper.kt   | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/app/src/main/java/org/mozilla/fenix/shopping/middleware/ProductAnalysisMapper.kt b/app/src/main/java/org/mozilla/fenix/shopping/middleware/ProductAnalysisMapper.kt
index fc65ca28a9..5d10acf651 100644
--- a/app/src/main/java/org/mozilla/fenix/shopping/middleware/ProductAnalysisMapper.kt
+++ b/app/src/main/java/org/mozilla/fenix/shopping/middleware/ProductAnalysisMapper.kt
@@ -33,7 +33,7 @@ private fun GeckoProductAnalysis.toProductReview(): ProductReviewState =
             ProductReviewState.Error.GenericError
         }
     } else {
-        val mappedRating = adjustedRating?.toFloatOrNull()
+        val mappedRating = adjustedRating?.toFloat()
         val mappedGrade = grade?.toGrade()
         val mappedHighlights = highlights?.toHighlights()?.toSortedMap()
 
@@ -80,17 +80,5 @@ private fun Highlight.highlightsForType(highlightType: HighlightType) =
         HighlightType.COMPETITIVENESS -> competitiveness
     }?.map { it.surroundWithQuotes() }
 
-/**
- * GeckoView sets 0.0 as default instead of null for adjusted rating. This maps 0.0 to null making
- * it easier for the UI layer to decide whether to display a UI element based on the presence of
- * value.
- */
-private fun Double.toFloatOrNull(): Float? =
-    if (this == 0.0) {
-        null
-    } else {
-        toFloat()
-    }
-
 private fun String.surroundWithQuotes(): String =
     "\"$this\""