From f385f62b49ceb200896fe5416ce7e0752257848d Mon Sep 17 00:00:00 2001
From: Tiger Oakes <toakes@mozilla.com>
Date: Thu, 27 Jun 2019 16:47:42 -0400
Subject: [PATCH] [fenix] No issue: Use chains for bookmark items
 (https://github.com/mozilla-mobile/fenix/pull/3696)

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
---
 .../mozilla/fenix/library/bookmarks/BookmarkAdapter.kt    | 8 --------
 app/src/main/res/layout/bookmark_row.xml                  | 6 +++++-
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkAdapter.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkAdapter.kt
index 4d884d078..c308f6f7e 100644
--- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkAdapter.kt
+++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkAdapter.kt
@@ -8,7 +8,6 @@ import android.util.TypedValue
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
-import androidx.constraintlayout.widget.ConstraintSet
 import androidx.core.content.ContextCompat
 import androidx.recyclerview.widget.RecyclerView
 import io.reactivex.Observer
@@ -241,13 +240,6 @@ class BookmarkAdapter(val emptyView: View, val actionEmitter: Observer<BookmarkA
 
         override fun bind(item: BookmarkNode, mode: BookmarkState.Mode, selected: Boolean) {
 
-            val constraintSet = ConstraintSet()
-            constraintSet.clone(bookmark_layout)
-            constraintSet.connect(
-                bookmark_title.id, ConstraintSet.BOTTOM, ConstraintSet.PARENT_ID, ConstraintSet.BOTTOM
-            )
-            constraintSet.applyTo(bookmark_layout)
-
             bookmark_favicon.setImageResource(R.drawable.ic_folder_icon)
             bookmark_favicon.visibility = View.VISIBLE
             bookmark_title.visibility = View.VISIBLE
diff --git a/app/src/main/res/layout/bookmark_row.xml b/app/src/main/res/layout/bookmark_row.xml
index 4bca4fc2d..309cbc398 100644
--- a/app/src/main/res/layout/bookmark_row.xml
+++ b/app/src/main/res/layout/bookmark_row.xml
@@ -42,6 +42,8 @@
         app:layout_constraintEnd_toStartOf="@id/bookmark_overflow"
         app:layout_constraintStart_toEndOf="@id/bookmark_favicon"
         app:layout_constraintTop_toTopOf="parent"
+        app:layout_constraintBottom_toTopOf="@+id/bookmark_url"
+        app:layout_constraintVertical_chainStyle="packed"
         tools:text="Internet" />
 
     <TextView
@@ -56,7 +58,9 @@
         android:textSize="12sp"
         app:layout_constraintEnd_toStartOf="@id/bookmark_overflow"
         app:layout_constraintStart_toEndOf="@id/bookmark_favicon"
-        app:layout_constraintTop_toBottomOf="@id/bookmark_title" />
+        app:layout_constraintTop_toBottomOf="@id/bookmark_title"
+        tools:text="https://github.com/mozilla-mobile/fenix"
+        app:layout_constraintBottom_toBottomOf="parent" />
 
     <ImageButton
         android:id="@+id/bookmark_overflow"