From eef4252b7410478ff6774a69259dd4b21a23675b Mon Sep 17 00:00:00 2001 From: mcarare Date: Wed, 16 Nov 2022 16:08:13 +0200 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/25808: Fix failing 'process make_default_browser deep link for API 23 and below' test. --- .../intent/HomeDeepLinkIntentProcessorTest.kt | 23 +++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/app/src/test/java/org/mozilla/fenix/home/intent/HomeDeepLinkIntentProcessorTest.kt b/app/src/test/java/org/mozilla/fenix/home/intent/HomeDeepLinkIntentProcessorTest.kt index 6434f177b..573296b9b 100644 --- a/app/src/test/java/org/mozilla/fenix/home/intent/HomeDeepLinkIntentProcessorTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/intent/HomeDeepLinkIntentProcessorTest.kt @@ -5,12 +5,15 @@ package org.mozilla.fenix.home.intent import android.content.Intent +import android.content.pm.PackageInfo +import android.content.pm.PackageManager import android.os.Build.VERSION_CODES.M import android.os.Build.VERSION_CODES.N import android.os.Build.VERSION_CODES.P import androidx.core.net.toUri import androidx.navigation.NavController import io.mockk.Called +import io.mockk.every import io.mockk.mockk import io.mockk.verify import mozilla.appservices.places.BookmarkRoot @@ -248,19 +251,31 @@ class HomeDeepLinkIntentProcessorTest { @Test @Config(maxSdk = M) fun `process make_default_browser deep link for API 23 and below`() { + val packageManager: PackageManager = mockk() + val packageInfo = PackageInfo() + + every { activity.packageName } returns "org.mozilla.fenix" + every { activity.packageManager } returns packageManager + @Suppress("DEPRECATION") + every { packageManager.getPackageInfo("org.mozilla.fenix", 0) } returns packageInfo + packageInfo.versionName = "versionName" + assertTrue(processorHome.process(testIntent("make_default_browser"), navController, out)) + val searchTermOrURL = SupportUtils.getSumoURLForTopic( + activity, + SupportUtils.SumoTopic.SET_AS_DEFAULT_BROWSER, + ) + verify { activity.openToBrowserAndLoad( - searchTermOrURL = SupportUtils.getSumoURLForTopic( - activity, - SupportUtils.SumoTopic.SET_AS_DEFAULT_BROWSER, - ), + searchTermOrURL = searchTermOrURL, newTab = true, from = BrowserDirection.FromGlobal, flags = EngineSession.LoadUrlFlags.external(), ) } + verify { navController wasNot Called } verify { out wasNot Called } }