Bug 1830765 - Remove duplicate toolbar position metrics

fenix/115.2.0
Roger Yang 1 year ago committed by mergify[bot]
parent 8c591b923b
commit eaa841be4c

@ -2025,30 +2025,6 @@ metrics:
metadata:
tags:
- Telemetry
toolbar_position:
type: string
lifetime: application
description: |
A string that indicates the new position of the toolbar TOP or BOTTOM
send_in_pings:
- metrics
bugs:
- https://github.com/mozilla-mobile/fenix/issues/6054
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/6608
- https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068
- https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789
- https://github.com/mozilla-mobile/fenix/pull/20517#pullrequestreview-718069041
- https://github.com/mozilla-mobile/fenix/pull/23453#issuecomment-1024694220
- https://github.com/mozilla-mobile/fenix/pull/28502
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: 124
metadata:
tags:
- Toolbar
close_tab_setting:
type: string
lifetime: application

@ -77,7 +77,6 @@ import org.mozilla.fenix.components.appstate.AppAction
import org.mozilla.fenix.components.metrics.MetricServiceType
import org.mozilla.fenix.components.metrics.MozillaProductDetector
import org.mozilla.fenix.components.metrics.clientdeduplication.ClientDeduplicationLifecycleObserver
import org.mozilla.fenix.components.toolbar.ToolbarPosition
import org.mozilla.fenix.experiments.maybeFetchExperiments
import org.mozilla.fenix.ext.areNotificationsEnabledSafe
import org.mozilla.fenix.ext.containsQueryParameters
@ -99,7 +98,6 @@ import org.mozilla.fenix.push.PushFxaIntegration
import org.mozilla.fenix.push.WebPushEngineIntegration
import org.mozilla.fenix.session.PerformanceActivityLifecycleCallbacks
import org.mozilla.fenix.session.VisibilityLifecycleCallback
import org.mozilla.fenix.settings.CustomizationFragment
import org.mozilla.fenix.utils.BrowsersCache
import org.mozilla.fenix.utils.Settings
import org.mozilla.fenix.utils.Settings.Companion.TOP_SITES_PROVIDER_MAX_THRESHOLD
@ -770,13 +768,6 @@ open class FenixApplication : LocaleAwareApplication(), Provider {
mobileBookmarksCount.add(mobileBookmarksSize)
}
toolbarPosition.set(
when (settings.toolbarPosition) {
ToolbarPosition.BOTTOM -> CustomizationFragment.Companion.Position.BOTTOM.name
ToolbarPosition.TOP -> CustomizationFragment.Companion.Position.TOP.name
},
)
tabViewSetting.set(settings.getTabViewPingString())
closeTabSetting.set(settings.getTabTimeoutPingString())

Loading…
Cancel
Save