diff --git a/app/src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt b/app/src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt index 773f1d3464..58bff255d4 100644 --- a/app/src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt +++ b/app/src/test/java/org/mozilla/fenix/browser/BrowserFragmentTest.kt @@ -14,7 +14,6 @@ import io.mockk.every import io.mockk.mockk import io.mockk.spyk import io.mockk.verify -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.ContentAction import mozilla.components.browser.state.action.RestoreCompleteAction import mozilla.components.browser.state.action.TabListAction @@ -27,7 +26,6 @@ import mozilla.components.browser.state.store.BrowserStore import mozilla.components.browser.toolbar.BrowserToolbar import mozilla.components.support.test.ext.joinBlocking import mozilla.components.support.test.rule.MainCoroutineRule -import org.junit.After import org.junit.Assert.fail import org.junit.Before import org.junit.Rule @@ -44,7 +42,6 @@ import org.mozilla.fenix.ext.settings import org.mozilla.fenix.helpers.FenixRobolectricTestRunner import org.mozilla.fenix.onboarding.FenixOnboarding import org.mozilla.fenix.utils.Settings -import java.lang.Exception @RunWith(FenixRobolectricTestRunner::class) class BrowserFragmentTest { @@ -60,10 +57,8 @@ class BrowserFragmentTest { private lateinit var navController: NavController private lateinit var onboarding: FenixOnboarding - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() @Before fun setup() { @@ -95,11 +90,6 @@ class BrowserFragmentTest { every { context.components.core.store } returns store } - @After - fun cleanUp() { - testDispatcher.cleanupTestCoroutines() - } - @Test fun `GIVEN fragment is added WHEN selected tab changes THEN theme is updated`() { browserFragment.observeTabSelection(store) diff --git a/app/src/test/java/org/mozilla/fenix/browser/OpenInAppOnboardingObserverTest.kt b/app/src/test/java/org/mozilla/fenix/browser/OpenInAppOnboardingObserverTest.kt index ff63a6248d..ea9ff6d418 100644 --- a/app/src/test/java/org/mozilla/fenix/browser/OpenInAppOnboardingObserverTest.kt +++ b/app/src/test/java/org/mozilla/fenix/browser/OpenInAppOnboardingObserverTest.kt @@ -15,7 +15,6 @@ import io.mockk.every import io.mockk.mockk import io.mockk.spyk import io.mockk.verify -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.ContentAction import mozilla.components.browser.state.state.BrowserState import mozilla.components.browser.state.state.createTab @@ -48,10 +47,8 @@ class OpenInAppOnboardingObserverTest { private lateinit var container: ViewGroup private lateinit var infoBanner: DynamicInfoBanner - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() @Before fun setUp() { diff --git a/app/src/test/java/org/mozilla/fenix/components/toolbar/MenuPresenterTest.kt b/app/src/test/java/org/mozilla/fenix/components/toolbar/MenuPresenterTest.kt index ed7ea70c18..46e111c2b0 100644 --- a/app/src/test/java/org/mozilla/fenix/components/toolbar/MenuPresenterTest.kt +++ b/app/src/test/java/org/mozilla/fenix/components/toolbar/MenuPresenterTest.kt @@ -7,7 +7,6 @@ package org.mozilla.fenix.components.toolbar import io.mockk.clearMocks import io.mockk.mockk import io.mockk.verify -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.ContentAction import mozilla.components.browser.state.state.BrowserState import mozilla.components.browser.state.state.TabSessionState @@ -27,10 +26,8 @@ class MenuPresenterTest { private lateinit var menuPresenter: MenuPresenter private lateinit var menuToolbar: BrowserToolbar - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() @Before fun setup() { diff --git a/app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt b/app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt index 07a7d1d579..aecd77b757 100644 --- a/app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt @@ -15,7 +15,6 @@ import io.mockk.spyk import io.mockk.unmockkStatic import io.mockk.verify import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.TestCoroutineScope import mozilla.components.browser.state.action.SearchAction import mozilla.components.browser.state.action.TabListAction @@ -65,10 +64,8 @@ import mozilla.components.feature.tab.collections.Tab as ComponentTab @OptIn(ExperimentalCoroutinesApi::class) class DefaultSessionControlControllerTest { - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() private val activity: HomeActivity = mockk(relaxed = true) private val fragmentStore: HomeFragmentStore = mockk(relaxed = true) @@ -144,7 +141,6 @@ class DefaultSessionControlControllerTest { @After fun cleanUp() { scope.cleanupTestCoroutines() - testDispatcher.cleanupTestCoroutines() } @Test diff --git a/app/src/test/java/org/mozilla/fenix/home/RecentTabsListFeatureTest.kt b/app/src/test/java/org/mozilla/fenix/home/RecentTabsListFeatureTest.kt index 5fd0aaf1dd..78ab525ee9 100644 --- a/app/src/test/java/org/mozilla/fenix/home/RecentTabsListFeatureTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/RecentTabsListFeatureTest.kt @@ -7,7 +7,6 @@ package org.mozilla.fenix.home import android.graphics.Bitmap import io.mockk.mockk import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.ContentAction.UpdateIconAction import mozilla.components.browser.state.action.ContentAction.UpdateTitleAction import mozilla.components.browser.state.action.MediaSessionAction @@ -46,7 +45,7 @@ class RecentTabsListFeatureTest { @OptIn(ExperimentalCoroutinesApi::class) @get:Rule - val coroutinesTestRule = MainCoroutineRule(TestCoroutineDispatcher()) + val coroutinesTestRule = MainCoroutineRule() @Before fun setup() { diff --git a/app/src/test/java/org/mozilla/fenix/home/recentbookmarks/DefaultRecentBookmarksControllerTest.kt b/app/src/test/java/org/mozilla/fenix/home/recentbookmarks/DefaultRecentBookmarksControllerTest.kt index 2bf84c29d1..088fc24279 100644 --- a/app/src/test/java/org/mozilla/fenix/home/recentbookmarks/DefaultRecentBookmarksControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/recentbookmarks/DefaultRecentBookmarksControllerTest.kt @@ -12,13 +12,11 @@ import io.mockk.mockk import io.mockk.spyk import io.mockk.verify import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.runBlockingTest import mozilla.appservices.places.BookmarkRoot import mozilla.components.concept.engine.EngineSession import mozilla.components.concept.engine.EngineSession.LoadUrlFlags.Companion.ALLOW_JAVASCRIPT_URL import mozilla.components.support.test.rule.MainCoroutineRule -import org.junit.After import org.junit.Before import org.junit.Rule import org.junit.Test @@ -34,10 +32,8 @@ import org.mozilla.fenix.home.recentbookmarks.controller.DefaultRecentBookmarksC @OptIn(ExperimentalCoroutinesApi::class) class DefaultRecentBookmarksControllerTest { - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() private val activity: HomeActivity = mockk(relaxed = true) private val navController: NavController = mockk(relaxUnitFun = true) @@ -63,11 +59,6 @@ class DefaultRecentBookmarksControllerTest { ) } - @After - fun cleanUp() { - testDispatcher.cleanupTestCoroutines() - } - @Test fun `WHEN a recently saved bookmark is clicked THEN the selected bookmark is opened`() { every { navController.currentDestination } returns mockk { diff --git a/app/src/test/java/org/mozilla/fenix/home/recentbookmarks/RecentBookmarksFeatureTest.kt b/app/src/test/java/org/mozilla/fenix/home/recentbookmarks/RecentBookmarksFeatureTest.kt index 7e8fe24873..a2ac82a83c 100644 --- a/app/src/test/java/org/mozilla/fenix/home/recentbookmarks/RecentBookmarksFeatureTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/recentbookmarks/RecentBookmarksFeatureTest.kt @@ -9,13 +9,11 @@ import io.mockk.coVerify import io.mockk.mockk import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.runBlockingTest import mozilla.components.concept.storage.BookmarkNode import mozilla.components.support.test.libstate.ext.waitUntilIdle import mozilla.components.support.test.middleware.CaptureActionsMiddleware import mozilla.components.support.test.rule.MainCoroutineRule -import org.junit.After import org.junit.Assert.assertEquals import org.junit.Before import org.junit.Rule @@ -31,7 +29,6 @@ class RecentBookmarksFeatureTest { private val middleware = CaptureActionsMiddleware() private val homeStore = HomeFragmentStore(middlewares = listOf(middleware)) private val bookmarksUseCases: BookmarksUseCase = mockk(relaxed = true) - private val testDispatcher = TestCoroutineDispatcher() private val bookmark = RecentBookmark( title = null, url = "https://www.example.com", @@ -39,18 +36,14 @@ class RecentBookmarksFeatureTest { ) @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() + private val testDispatcher = coroutinesTestRule.testDispatcher @Before fun setup() { coEvery { bookmarksUseCases.retrieveRecentBookmarks() }.coAnswers { listOf(bookmark) } } - @After - fun cleanUp() { - testDispatcher.cleanupTestCoroutines() - } - @Test fun `GIVEN no recent bookmarks WHEN feature starts THEN fetch bookmarks and notify store`() = testDispatcher.runBlockingTest { diff --git a/app/src/test/java/org/mozilla/fenix/home/recenttabs/controller/RecentTabControllerTest.kt b/app/src/test/java/org/mozilla/fenix/home/recenttabs/controller/RecentTabControllerTest.kt index 23a4a1c4a2..8823fbd0a9 100644 --- a/app/src/test/java/org/mozilla/fenix/home/recenttabs/controller/RecentTabControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/recenttabs/controller/RecentTabControllerTest.kt @@ -11,7 +11,6 @@ import io.mockk.mockk import io.mockk.spyk import io.mockk.verify import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.TabListAction import mozilla.components.browser.state.state.BrowserState import mozilla.components.browser.state.state.createTab @@ -29,10 +28,8 @@ import org.mozilla.fenix.components.metrics.MetricController @OptIn(ExperimentalCoroutinesApi::class) class RecentTabControllerTest { - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() private val navController: NavController = mockk(relaxed = true) private val selectTabUseCase: TabsUseCases = mockk(relaxed = true) diff --git a/app/src/test/java/org/mozilla/fenix/home/recentvisits/HistoryMetadataServiceTest.kt b/app/src/test/java/org/mozilla/fenix/home/recentvisits/HistoryMetadataServiceTest.kt index 12168721d6..c3114196a2 100644 --- a/app/src/test/java/org/mozilla/fenix/home/recentvisits/HistoryMetadataServiceTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/recentvisits/HistoryMetadataServiceTest.kt @@ -8,7 +8,6 @@ import io.mockk.coVerify import io.mockk.mockk import io.mockk.slot import kotlinx.coroutines.CoroutineScope -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.state.createTab import mozilla.components.concept.storage.DocumentType import mozilla.components.concept.storage.HistoryMetadataKey @@ -27,10 +26,9 @@ class HistoryMetadataServiceTest { private lateinit var service: HistoryMetadataService private lateinit var storage: HistoryMetadataStorage - val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() + val testDispatcher = coroutinesTestRule.testDispatcher @Before fun setup() { diff --git a/app/src/test/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeatureTest.kt b/app/src/test/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeatureTest.kt index 828eb200ed..94140e969f 100644 --- a/app/src/test/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeatureTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeatureTest.kt @@ -12,7 +12,6 @@ import io.mockk.slot import io.mockk.spyk import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.runBlockingTest import mozilla.components.browser.storage.sync.PlacesHistoryStorage import mozilla.components.concept.storage.DocumentType @@ -46,10 +45,10 @@ class RecentVisitsFeatureTest { private val middleware = CaptureActionsMiddleware() private val homeStore = HomeFragmentStore(middlewares = listOf(middleware)) - private val testDispatcher = TestCoroutineDispatcher() @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() + private val testDispatcher = coroutinesTestRule.testDispatcher @Before fun setup() { diff --git a/app/src/test/java/org/mozilla/fenix/home/recentvisits/controller/RecentVisitsControllerTest.kt b/app/src/test/java/org/mozilla/fenix/home/recentvisits/controller/RecentVisitsControllerTest.kt index 61e7b94d6a..9a3674b9e2 100644 --- a/app/src/test/java/org/mozilla/fenix/home/recentvisits/controller/RecentVisitsControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/recentvisits/controller/RecentVisitsControllerTest.kt @@ -14,7 +14,6 @@ import io.mockk.verify import io.mockk.verifyOrder import kotlinx.coroutines.ExperimentalCoroutinesApi import kotlinx.coroutines.launch -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.TestCoroutineScope import mozilla.components.browser.state.action.HistoryMetadataAction import mozilla.components.browser.state.store.BrowserStore @@ -41,10 +40,9 @@ import org.mozilla.fenix.home.recentvisits.RecentlyVisitedItem.RecentHistoryHigh @OptIn(ExperimentalCoroutinesApi::class) class RecentVisitsControllerTest { - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() + private val testDispatcher = coroutinesTestRule.testDispatcher private val selectOrAddTabUseCase: SelectOrAddUseCase = mockk(relaxed = true) private val navController = mockk(relaxed = true) diff --git a/app/src/test/java/org/mozilla/fenix/library/historymetadata/controller/HistoryMetadataGroupControllerTest.kt b/app/src/test/java/org/mozilla/fenix/library/historymetadata/controller/HistoryMetadataGroupControllerTest.kt index 5c4bf92aa0..7ca26f8bb4 100644 --- a/app/src/test/java/org/mozilla/fenix/library/historymetadata/controller/HistoryMetadataGroupControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/library/historymetadata/controller/HistoryMetadataGroupControllerTest.kt @@ -9,7 +9,6 @@ import io.mockk.coVerify import io.mockk.every import io.mockk.mockk import io.mockk.verify -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.TestCoroutineScope import kotlinx.coroutines.test.runBlockingTest import mozilla.components.browser.storage.sync.PlacesHistoryStorage @@ -38,11 +37,10 @@ import org.mozilla.fenix.library.historymetadata.HistoryMetadataGroupFragmentSto @RunWith(FenixRobolectricTestRunner::class) class HistoryMetadataGroupControllerTest { - private val testDispatcher = TestCoroutineDispatcher() - private val scope = TestCoroutineScope() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() + private val testDispatcher = coroutinesTestRule.testDispatcher + private val scope = TestCoroutineScope(testDispatcher) private val activity: HomeActivity = mockk(relaxed = true) private val store: HistoryMetadataGroupFragmentStore = mockk(relaxed = true) diff --git a/app/src/test/java/org/mozilla/fenix/session/PrivateNotificationServiceTest.kt b/app/src/test/java/org/mozilla/fenix/session/PrivateNotificationServiceTest.kt index 050b58ae55..1af19a3ad0 100644 --- a/app/src/test/java/org/mozilla/fenix/session/PrivateNotificationServiceTest.kt +++ b/app/src/test/java/org/mozilla/fenix/session/PrivateNotificationServiceTest.kt @@ -8,7 +8,6 @@ import android.content.ComponentName import android.content.Intent import io.mockk.every import io.mockk.mockk -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.state.BrowserState import mozilla.components.browser.state.state.createTab import mozilla.components.browser.state.store.BrowserStore @@ -16,7 +15,6 @@ import mozilla.components.feature.privatemode.notification.AbstractPrivateNotifi import mozilla.components.feature.tabs.TabsUseCases import mozilla.components.support.test.robolectric.testContext import mozilla.components.support.test.rule.MainCoroutineRule -import org.junit.After import org.junit.Assert.assertEquals import org.junit.Assert.assertNotNull import org.junit.Assert.assertNull @@ -38,10 +36,8 @@ class PrivateNotificationServiceTest { private lateinit var controller: ServiceController private lateinit var store: BrowserStore - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() @Before fun setup() { @@ -56,11 +52,6 @@ class PrivateNotificationServiceTest { ) } - @After - fun cleanUp() { - testDispatcher.cleanupTestCoroutines() - } - @Test fun `service opens home activity in private mode if app is in private mode`() { val selectedPrivateTab = createTab("https://mozilla.org", private = true) diff --git a/app/src/test/java/org/mozilla/fenix/settings/SettingsFragmentTest.kt b/app/src/test/java/org/mozilla/fenix/settings/SettingsFragmentTest.kt index 58be1e8d68..c6e4388c18 100644 --- a/app/src/test/java/org/mozilla/fenix/settings/SettingsFragmentTest.kt +++ b/app/src/test/java/org/mozilla/fenix/settings/SettingsFragmentTest.kt @@ -9,11 +9,9 @@ import androidx.preference.Preference import io.mockk.every import io.mockk.mockk import io.mockk.mockkObject -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.concept.fetch.Client import mozilla.components.support.test.robolectric.testContext import mozilla.components.support.test.rule.MainCoroutineRule -import org.junit.After import org.junit.Assert.assertFalse import org.junit.Assert.assertNotNull import org.junit.Assert.assertTrue @@ -34,10 +32,9 @@ import java.io.IOException @RunWith(FenixRobolectricTestRunner::class) class SettingsFragmentTest { - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() + private val testDispatcher = coroutinesTestRule.testDispatcher @Before fun setup() { @@ -54,11 +51,6 @@ class SettingsFragmentTest { every { Config.channel } returns ReleaseChannel.Nightly } - @After - fun cleanUp() { - testDispatcher.cleanupTestCoroutines() - } - @Test fun `Add-on collection override pref is visible if debug menu active`() { val settingsFragment = SettingsFragment() diff --git a/app/src/test/java/org/mozilla/fenix/settings/creditcards/DefaultCreditCardEditorControllerTest.kt b/app/src/test/java/org/mozilla/fenix/settings/creditcards/DefaultCreditCardEditorControllerTest.kt index 7b4d0d548e..69b58bdb91 100644 --- a/app/src/test/java/org/mozilla/fenix/settings/creditcards/DefaultCreditCardEditorControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/settings/creditcards/DefaultCreditCardEditorControllerTest.kt @@ -9,7 +9,6 @@ import io.mockk.coVerify import io.mockk.mockk import io.mockk.spyk import io.mockk.verify -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.TestCoroutineScope import kotlinx.coroutines.test.runBlockingTest import mozilla.components.concept.storage.CreditCardNumber @@ -32,13 +31,12 @@ class DefaultCreditCardEditorControllerTest { private val navController: NavController = mockk(relaxed = true) private val metrics: MetricController = mockk(relaxed = true) - private val testCoroutineScope = TestCoroutineScope() - private val testDispatcher = TestCoroutineDispatcher() - private lateinit var controller: DefaultCreditCardEditorController @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() + private val testDispatcher = coroutinesTestRule.testDispatcher + private val testCoroutineScope = TestCoroutineScope(testDispatcher) @Before fun setup() { @@ -56,7 +54,6 @@ class DefaultCreditCardEditorControllerTest { @After fun cleanUp() { testCoroutineScope.cleanupTestCoroutines() - testDispatcher.cleanupTestCoroutines() } @Test diff --git a/app/src/test/java/org/mozilla/fenix/settings/deletebrowsingdata/DefaultDeleteBrowsingDataControllerTest.kt b/app/src/test/java/org/mozilla/fenix/settings/deletebrowsingdata/DefaultDeleteBrowsingDataControllerTest.kt index d2a8bf81e7..fd3799d4c6 100644 --- a/app/src/test/java/org/mozilla/fenix/settings/deletebrowsingdata/DefaultDeleteBrowsingDataControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/settings/deletebrowsingdata/DefaultDeleteBrowsingDataControllerTest.kt @@ -11,7 +11,6 @@ import io.mockk.verify import kotlinx.coroutines.DelicateCoroutinesApi import kotlinx.coroutines.ExperimentalCoroutinesApi import kotlinx.coroutines.GlobalScope.coroutineContext -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.runBlockingTest import mozilla.components.browser.icons.BrowserIcons import mozilla.components.browser.state.action.EngineAction @@ -22,7 +21,6 @@ import mozilla.components.concept.storage.HistoryStorage import mozilla.components.feature.downloads.DownloadsUseCases import mozilla.components.feature.tabs.TabsUseCases import mozilla.components.support.test.rule.MainCoroutineRule -import org.junit.After import org.junit.Before import org.junit.Rule import org.junit.Test @@ -31,10 +29,8 @@ import org.mozilla.fenix.components.PermissionStorage @OptIn(ExperimentalCoroutinesApi::class) class DefaultDeleteBrowsingDataControllerTest { - val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() private var removeAllTabs: TabsUseCases.RemoveAllTabsUseCase = mockk(relaxed = true) private var removeAllDownloads: DownloadsUseCases.RemoveAllDownloadsUseCase = mockk(relaxed = true) @@ -60,11 +56,6 @@ class DefaultDeleteBrowsingDataControllerTest { ) } - @After - fun cleanUp() { - testDispatcher.cleanupTestCoroutines() - } - @Test fun deleteTabs() = runBlockingTest { diff --git a/app/src/test/java/org/mozilla/fenix/settings/logins/SavedLoginsStorageControllerTest.kt b/app/src/test/java/org/mozilla/fenix/settings/logins/SavedLoginsStorageControllerTest.kt index e0392af2de..af1b2d7d0e 100644 --- a/app/src/test/java/org/mozilla/fenix/settings/logins/SavedLoginsStorageControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/settings/logins/SavedLoginsStorageControllerTest.kt @@ -10,7 +10,6 @@ import io.mockk.coEvery import io.mockk.coVerify import io.mockk.every import io.mockk.mockk -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.TestCoroutineScope import kotlinx.coroutines.test.runBlockingTest import mozilla.components.concept.storage.EncryptedLogin @@ -32,16 +31,15 @@ import org.mozilla.fenix.settings.logins.fragment.EditLoginFragmentDirections @RunWith(FenixRobolectricTestRunner::class) class SavedLoginsStorageControllerTest { - val testDispatcher = TestCoroutineDispatcher() @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() + private val ioDispatcher = coroutinesTestRule.testDispatcher + private val scope = TestCoroutineScope(ioDispatcher) private val passwordsStorage: SyncableLoginsStorage = mockk(relaxed = true) private lateinit var controller: SavedLoginsStorageController private val navController: NavController = mockk(relaxed = true) private val loginsFragmentStore: LoginsFragmentStore = mockk(relaxed = true) - private val scope = TestCoroutineScope() - private val ioDispatcher = TestCoroutineDispatcher() private val loginMock: Login = mockk(relaxed = true) @Before @@ -64,8 +62,6 @@ class SavedLoginsStorageControllerTest { @After fun cleanUp() { scope.cleanupTestCoroutines() - ioDispatcher.cleanupTestCoroutines() - testDispatcher.cleanupTestCoroutines() } @Test diff --git a/app/src/test/java/org/mozilla/fenix/settings/quicksettings/QuickSettingsSheetDialogFragmentTest.kt b/app/src/test/java/org/mozilla/fenix/settings/quicksettings/QuickSettingsSheetDialogFragmentTest.kt index fafd9b67f1..fafb59b257 100644 --- a/app/src/test/java/org/mozilla/fenix/settings/quicksettings/QuickSettingsSheetDialogFragmentTest.kt +++ b/app/src/test/java/org/mozilla/fenix/settings/quicksettings/QuickSettingsSheetDialogFragmentTest.kt @@ -13,7 +13,6 @@ import io.mockk.slot import io.mockk.spyk import io.mockk.verify import junit.framework.TestCase.assertNotSame -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.TabListAction import mozilla.components.browser.state.action.TrackingProtectionAction.TrackerBlockedAction import mozilla.components.browser.state.action.TrackingProtectionAction.TrackerLoadedAction @@ -25,7 +24,6 @@ import mozilla.components.concept.engine.content.blocking.TrackerLog import mozilla.components.feature.session.TrackingProtectionUseCases import mozilla.components.support.test.ext.joinBlocking import mozilla.components.support.test.rule.MainCoroutineRule -import org.junit.After import org.junit.Before import org.junit.Rule import org.junit.Test @@ -35,10 +33,9 @@ import org.mozilla.fenix.helpers.FenixRobolectricTestRunner @RunWith(FenixRobolectricTestRunner::class) class QuickSettingsSheetDialogFragmentTest { - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() + private lateinit var lifecycleOwner: MockedLifecycleOwner private lateinit var fragment: QuickSettingsSheetDialogFragment private lateinit var store: BrowserStore @@ -54,11 +51,6 @@ class QuickSettingsSheetDialogFragmentTest { every { fragment.activity } returns mockk(relaxed = true) } - @After - fun cleanUp() { - testDispatcher.cleanupTestCoroutines() - } - @Test fun `WHEN a tracker is loaded THEN trackers view is updated`() { val tab = createTab("mozilla.org") diff --git a/app/src/test/java/org/mozilla/fenix/settings/studies/StudiesViewTest.kt b/app/src/test/java/org/mozilla/fenix/settings/studies/StudiesViewTest.kt index 3fc1b094d7..e35f2ed15e 100644 --- a/app/src/test/java/org/mozilla/fenix/settings/studies/StudiesViewTest.kt +++ b/app/src/test/java/org/mozilla/fenix/settings/studies/StudiesViewTest.kt @@ -15,7 +15,6 @@ import io.mockk.mockk import io.mockk.runs import io.mockk.spyk import io.mockk.verify -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.TestCoroutineScope import mozilla.components.service.nimbus.NimbusApi import mozilla.components.support.test.mock @@ -46,12 +45,11 @@ class StudiesViewTest { @RelaxedMockK private lateinit var settings: Settings - private val testCoroutineScope = TestCoroutineScope() - private val testDispatcher = TestCoroutineDispatcher() private lateinit var view: StudiesView @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() + private val testCoroutineScope = TestCoroutineScope(coroutinesTestRule.testDispatcher) @Before fun setup() { @@ -73,7 +71,6 @@ class StudiesViewTest { @After fun cleanUp() { testCoroutineScope.cleanupTestCoroutines() - testDispatcher.cleanupTestCoroutines() } @Test diff --git a/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt b/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt index 1a9afc9b6a..05a76d21aa 100644 --- a/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt @@ -19,7 +19,6 @@ import io.mockk.spyk import io.mockk.verify import io.mockk.verifyOrder import kotlinx.coroutines.runBlocking -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.TestCoroutineScope import mozilla.components.concept.engine.prompt.ShareData import mozilla.components.concept.sync.Device @@ -63,21 +62,21 @@ class ShareControllerTest { TabData("title1", "url1") ) private val textToShare = "${shareData[0].url}\n\n${shareData[1].url}" - private val testDispatcher = TestCoroutineDispatcher() - private val testCoroutineScope = TestCoroutineScope() private val sendTabUseCases = mockk(relaxed = true) private val snackbar = mockk(relaxed = true) private val navController = mockk(relaxed = true) private val dismiss = mockk<(ShareController.Result) -> Unit>(relaxed = true) private val recentAppStorage = mockk(relaxed = true) + + @get:Rule + val coroutinesTestRule = MainCoroutineRule() + private val testDispatcher = coroutinesTestRule.testDispatcher + private val testCoroutineScope = TestCoroutineScope(testDispatcher) private val controller = DefaultShareController( context, shareSubject, shareData, sendTabUseCases, snackbar, navController, recentAppStorage, testCoroutineScope, testDispatcher, dismiss ) - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) - @Before fun setUp() { every { context.metrics } returns metrics diff --git a/app/src/test/java/org/mozilla/fenix/shortcut/PwaOnboardingObserverTest.kt b/app/src/test/java/org/mozilla/fenix/shortcut/PwaOnboardingObserverTest.kt index 64201d91e8..e042c5dbba 100644 --- a/app/src/test/java/org/mozilla/fenix/shortcut/PwaOnboardingObserverTest.kt +++ b/app/src/test/java/org/mozilla/fenix/shortcut/PwaOnboardingObserverTest.kt @@ -11,7 +11,6 @@ import androidx.navigation.NavController import io.mockk.every import io.mockk.mockk import io.mockk.verify -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.ContentAction import mozilla.components.browser.state.state.BrowserState import mozilla.components.browser.state.state.createTab @@ -37,10 +36,8 @@ class PwaOnboardingObserverTest { private lateinit var settings: Settings private lateinit var webAppUseCases: WebAppUseCases - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() @Before fun setUp() { diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/CloseOnLastTabBindingTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/CloseOnLastTabBindingTest.kt index 46cd30a21d..5356b0b363 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/CloseOnLastTabBindingTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/CloseOnLastTabBindingTest.kt @@ -8,7 +8,6 @@ import io.mockk.Called import io.mockk.mockk import io.mockk.verify import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.TabListAction import mozilla.components.browser.state.state.BrowserState import mozilla.components.browser.state.state.createTab @@ -22,7 +21,7 @@ class CloseOnLastTabBindingTest { @OptIn(ExperimentalCoroutinesApi::class) @get:Rule - val coroutinesTestRule = MainCoroutineRule(TestCoroutineDispatcher()) + val coroutinesTestRule = MainCoroutineRule() @Test fun `WHEN the binding starts THEN do nothing`() { diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/FloatingActionButtonBindingTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/FloatingActionButtonBindingTest.kt index f1ce7da8b6..ff742a5e58 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/FloatingActionButtonBindingTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/FloatingActionButtonBindingTest.kt @@ -12,7 +12,6 @@ import io.mockk.mockkStatic import io.mockk.unmockkStatic import io.mockk.verify import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.support.test.libstate.ext.waitUntilIdle import mozilla.components.support.test.rule.MainCoroutineRule import org.junit.After @@ -26,7 +25,7 @@ class FloatingActionButtonBindingTest { @OptIn(ExperimentalCoroutinesApi::class) @get:Rule - val coroutinesTestRule = MainCoroutineRule(TestCoroutineDispatcher()) + val coroutinesTestRule = MainCoroutineRule() private val actionButton: ExtendedFloatingActionButton = mockk(relaxed = true) private val browserTrayInteractor: BrowserTrayInteractor = mockk(relaxed = true) diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/MenuIntegrationTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/MenuIntegrationTest.kt index d28ea3db46..3dd869bbf8 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/MenuIntegrationTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/MenuIntegrationTest.kt @@ -7,7 +7,6 @@ package org.mozilla.fenix.tabstray import io.mockk.mockk import io.mockk.verify import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.support.test.libstate.ext.waitUntilIdle import mozilla.components.support.test.middleware.CaptureActionsMiddleware import mozilla.components.support.test.rule.MainCoroutineRule @@ -19,7 +18,7 @@ class MenuIntegrationTest { @OptIn(ExperimentalCoroutinesApi::class) @get:Rule - val coroutinesTestRule = MainCoroutineRule(TestCoroutineDispatcher()) + val coroutinesTestRule = MainCoroutineRule() private val captureMiddleware = CaptureActionsMiddleware() private val tabsTrayStore = TabsTrayStore(middlewares = listOf(captureMiddleware)) diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/NavigationInteractorTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/NavigationInteractorTest.kt index d17f272783..fbe1348844 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/NavigationInteractorTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/NavigationInteractorTest.kt @@ -7,15 +7,14 @@ package org.mozilla.fenix.tabstray import android.content.Context import androidx.navigation.NavController import androidx.navigation.NavDirections +import io.mockk.coVerify import io.mockk.every import io.mockk.mockk -import io.mockk.spyk -import io.mockk.verify import io.mockk.mockkStatic +import io.mockk.spyk import io.mockk.unmockkStatic -import io.mockk.coVerify +import io.mockk.verify import io.mockk.verifyOrder -import kotlinx.coroutines.test.TestCoroutineDispatcher import kotlinx.coroutines.test.runBlockingTest import mozilla.components.browser.state.selector.findTab import mozilla.components.browser.state.selector.getNormalOrPrivateTabs @@ -53,10 +52,9 @@ class NavigationInteractorTest { private val accountManager: FxaAccountManager = mockk(relaxed = true) private val activity: HomeActivity = mockk(relaxed = true) - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() + private val testDispatcher = coroutinesTestRule.testDispatcher @Before fun setup() { diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/SecureTabsTrayBindingTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/SecureTabsTrayBindingTest.kt index 5d42d4d359..919e5f7c10 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/SecureTabsTrayBindingTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/SecureTabsTrayBindingTest.kt @@ -15,7 +15,6 @@ import io.mockk.mockk import io.mockk.mockkStatic import io.mockk.verify import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.support.test.libstate.ext.waitUntilIdle import mozilla.components.support.test.rule.MainCoroutineRule import org.junit.Before @@ -29,7 +28,7 @@ class SecureTabsTrayBindingTest { @OptIn(ExperimentalCoroutinesApi::class) @get:Rule - val coroutinesTestRule = MainCoroutineRule(TestCoroutineDispatcher()) + val coroutinesTestRule = MainCoroutineRule() private val settings: Settings = mockk(relaxed = true) private val fragment: Fragment = mockk(relaxed = true) diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/TabCounterBindingTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/TabCounterBindingTest.kt index faa3e42ac5..eb594cb546 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/TabCounterBindingTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/TabCounterBindingTest.kt @@ -7,7 +7,6 @@ package org.mozilla.fenix.tabstray import io.mockk.mockk import io.mockk.verify import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.TabListAction import mozilla.components.browser.state.state.createTab import mozilla.components.browser.state.store.BrowserStore @@ -21,7 +20,7 @@ class TabCounterBindingTest { @OptIn(ExperimentalCoroutinesApi::class) @get:Rule - val coroutinesTestRule = MainCoroutineRule(TestCoroutineDispatcher()) + val coroutinesTestRule = MainCoroutineRule() @Test fun `WHEN normalTabs changes THEN update counter`() { diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/TabsTrayInfoBannerBindingTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/TabsTrayInfoBannerBindingTest.kt index 977084061e..3cb089146c 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/TabsTrayInfoBannerBindingTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/TabsTrayInfoBannerBindingTest.kt @@ -11,7 +11,6 @@ import androidx.coordinatorlayout.widget.CoordinatorLayout import io.mockk.mockk import io.mockk.verify import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.TabListAction import mozilla.components.browser.state.state.createTab import mozilla.components.browser.state.store.BrowserStore @@ -36,7 +35,7 @@ class TabsTrayInfoBannerBindingTest { private lateinit var settings: Settings @get:Rule - val coroutinesTestRule = MainCoroutineRule(TestCoroutineDispatcher()) + val coroutinesTestRule = MainCoroutineRule() @Before fun setUp() { diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/browser/SelectedItemAdapterBindingTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/browser/SelectedItemAdapterBindingTest.kt index c4db0c65b1..36bf3685a7 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/browser/SelectedItemAdapterBindingTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/browser/SelectedItemAdapterBindingTest.kt @@ -8,7 +8,6 @@ import io.mockk.every import io.mockk.mockk import io.mockk.verify import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.tabstray.TabsAdapter.Companion.PAYLOAD_DONT_HIGHLIGHT_SELECTED_ITEM import mozilla.components.browser.tabstray.TabsAdapter.Companion.PAYLOAD_HIGHLIGHT_SELECTED_ITEM import mozilla.components.support.test.libstate.ext.waitUntilIdle @@ -23,7 +22,7 @@ class SelectedItemAdapterBindingTest { @OptIn(ExperimentalCoroutinesApi::class) @get:Rule - val coroutinesTestRule = MainCoroutineRule(TestCoroutineDispatcher()) + val coroutinesTestRule = MainCoroutineRule() private val adapter = mockk(relaxed = true) diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/browser/SwipeToDeleteBindingTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/browser/SwipeToDeleteBindingTest.kt index 672738a76c..a94d6e9460 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/browser/SwipeToDeleteBindingTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/browser/SwipeToDeleteBindingTest.kt @@ -6,7 +6,6 @@ package org.mozilla.fenix.tabstray.browser import io.mockk.mockk import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.support.test.libstate.ext.waitUntilIdle import mozilla.components.support.test.rule.MainCoroutineRule import org.junit.Assert.assertFalse @@ -21,7 +20,7 @@ class SwipeToDeleteBindingTest { @OptIn(ExperimentalCoroutinesApi::class) @get:Rule - val coroutinesTestRule = MainCoroutineRule(TestCoroutineDispatcher()) + val coroutinesTestRule = MainCoroutineRule() @Test fun `WHEN started THEN update the swipeable state`() { diff --git a/app/src/test/java/org/mozilla/fenix/tabstray/syncedtabs/SyncButtonBindingTest.kt b/app/src/test/java/org/mozilla/fenix/tabstray/syncedtabs/SyncButtonBindingTest.kt index 38deb7645a..f6c2c857d6 100644 --- a/app/src/test/java/org/mozilla/fenix/tabstray/syncedtabs/SyncButtonBindingTest.kt +++ b/app/src/test/java/org/mozilla/fenix/tabstray/syncedtabs/SyncButtonBindingTest.kt @@ -5,7 +5,6 @@ package org.mozilla.fenix.tabstray.syncedtabs import kotlinx.coroutines.ExperimentalCoroutinesApi -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.support.test.libstate.ext.waitUntilIdle import mozilla.components.support.test.rule.MainCoroutineRule import org.junit.Assert.assertFalse @@ -18,7 +17,7 @@ import org.mozilla.fenix.tabstray.TabsTrayStore class SyncButtonBindingTest { @OptIn(ExperimentalCoroutinesApi::class) @get:Rule - val coroutinesTestRule = MainCoroutineRule(TestCoroutineDispatcher()) + val coroutinesTestRule = MainCoroutineRule() @Test fun `WHEN syncing state is true THEN invoke callback`() { diff --git a/app/src/test/java/org/mozilla/fenix/telemetry/TelemetryMiddlewareTest.kt b/app/src/test/java/org/mozilla/fenix/telemetry/TelemetryMiddlewareTest.kt index da05c59fe6..86677b1ec4 100644 --- a/app/src/test/java/org/mozilla/fenix/telemetry/TelemetryMiddlewareTest.kt +++ b/app/src/test/java/org/mozilla/fenix/telemetry/TelemetryMiddlewareTest.kt @@ -7,7 +7,6 @@ package org.mozilla.fenix.telemetry import androidx.test.core.app.ApplicationProvider import io.mockk.mockk import io.mockk.verify -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.ContentAction import mozilla.components.browser.state.action.EngineAction import mozilla.components.browser.state.action.TabListAction @@ -43,10 +42,9 @@ class TelemetryMiddlewareTest { private lateinit var settings: Settings private lateinit var telemetryMiddleware: TelemetryMiddleware private lateinit var metrics: MetricController - private val testDispatcher = TestCoroutineDispatcher() @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() @get:Rule val gleanRule = GleanTestRule(ApplicationProvider.getApplicationContext()) diff --git a/app/src/test/java/org/mozilla/fenix/toolbar/DefaultToolbarMenuTest.kt b/app/src/test/java/org/mozilla/fenix/toolbar/DefaultToolbarMenuTest.kt index 90953e2f9a..8d9b39c88d 100644 --- a/app/src/test/java/org/mozilla/fenix/toolbar/DefaultToolbarMenuTest.kt +++ b/app/src/test/java/org/mozilla/fenix/toolbar/DefaultToolbarMenuTest.kt @@ -12,7 +12,6 @@ import io.mockk.mockk import io.mockk.mockkStatic import io.mockk.spyk import io.mockk.unmockkStatic -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.state.BrowserState import mozilla.components.browser.state.state.createTab import mozilla.components.browser.state.store.BrowserStore @@ -38,10 +37,8 @@ class DefaultToolbarMenuTest { private lateinit var bookmarksStorage: BookmarksStorage private lateinit var pinnedSiteStorage: PinnedSiteStorage - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() @Before fun setUp() { diff --git a/app/src/test/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelDialogFragmentTest.kt b/app/src/test/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelDialogFragmentTest.kt index 06827fb6d2..7a78361880 100644 --- a/app/src/test/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelDialogFragmentTest.kt +++ b/app/src/test/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelDialogFragmentTest.kt @@ -12,7 +12,6 @@ import io.mockk.mockk import io.mockk.spyk import io.mockk.verify import junit.framework.TestCase.assertNotSame -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.ContentAction import mozilla.components.browser.state.action.TabListAction import mozilla.components.browser.state.action.TrackingProtectionAction.TrackerBlockedAction @@ -23,7 +22,6 @@ import mozilla.components.browser.state.state.createTab import mozilla.components.browser.state.store.BrowserStore import mozilla.components.support.test.ext.joinBlocking import mozilla.components.support.test.rule.MainCoroutineRule -import org.junit.After import org.junit.Before import org.junit.Rule import org.junit.Test @@ -33,10 +31,8 @@ import org.mozilla.fenix.helpers.FenixRobolectricTestRunner @RunWith(FenixRobolectricTestRunner::class) class TrackingProtectionPanelDialogFragmentTest { - private val testDispatcher = TestCoroutineDispatcher() - @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() private lateinit var lifecycleOwner: MockedLifecycleOwner private lateinit var fragment: TrackingProtectionPanelDialogFragment private lateinit var store: BrowserStore @@ -52,11 +48,6 @@ class TrackingProtectionPanelDialogFragmentTest { every { fragment.activity } returns mockk(relaxed = true) } - @After - fun cleanUp() { - testDispatcher.cleanupTestCoroutines() - } - @Test fun `WHEN the url is updated THEN the url view is updated`() { val trackingProtectionStore: TrackingProtectionStore = mockk(relaxed = true) @@ -132,6 +123,7 @@ class TrackingProtectionPanelDialogFragmentTest { fragment.updateTrackers(tab) } } + private fun addAndSelectTab(tab: TabSessionState) { store.dispatch(TabListAction.AddTabAction(tab)).joinBlocking() store.dispatch(TabListAction.SelectTabAction(tab.id)).joinBlocking() diff --git a/app/src/test/java/org/mozilla/fenix/utils/ToolbarPopupWindowTest.kt b/app/src/test/java/org/mozilla/fenix/utils/ToolbarPopupWindowTest.kt index ffc17a5ffb..4c1bde2a83 100644 --- a/app/src/test/java/org/mozilla/fenix/utils/ToolbarPopupWindowTest.kt +++ b/app/src/test/java/org/mozilla/fenix/utils/ToolbarPopupWindowTest.kt @@ -4,7 +4,6 @@ package org.mozilla.fenix.utils -import kotlinx.coroutines.test.TestCoroutineDispatcher import mozilla.components.browser.state.action.ContentAction import mozilla.components.browser.state.state.BrowserState import mozilla.components.browser.state.state.ReaderState @@ -21,10 +20,9 @@ import org.mozilla.fenix.helpers.FenixRobolectricTestRunner @RunWith(FenixRobolectricTestRunner::class) class ToolbarPopupWindowTest { - private val testDispatcher = TestCoroutineDispatcher() @get:Rule - val coroutinesTestRule = MainCoroutineRule(testDispatcher) + val coroutinesTestRule = MainCoroutineRule() @Test fun `getUrlForClipboard should get the right URL`() {