From e671e5314ecbcae3f05a7422eaf56482b3ce8de5 Mon Sep 17 00:00:00 2001 From: Roger Yang Date: Wed, 14 Jul 2021 18:18:48 -0400 Subject: [PATCH] [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19846: Make sure default browser notification only happens once --- .../fenix/home/intent/DefaultBrowserIntentProcessor.kt | 1 - .../fenix/onboarding/DefaultBrowserNotificationWorker.kt | 4 ++++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/intent/DefaultBrowserIntentProcessor.kt b/app/src/main/java/org/mozilla/fenix/home/intent/DefaultBrowserIntentProcessor.kt index 8479bd169b..0c0e272dc3 100644 --- a/app/src/main/java/org/mozilla/fenix/home/intent/DefaultBrowserIntentProcessor.kt +++ b/app/src/main/java/org/mozilla/fenix/home/intent/DefaultBrowserIntentProcessor.kt @@ -24,7 +24,6 @@ class DefaultBrowserIntentProcessor( override fun process(intent: Intent, navController: NavController, out: Intent): Boolean { return if (isDefaultBrowserNotificationIntent(intent)) { activity.openSetDefaultBrowserOption() - activity.settings().defaultBrowserNotificationDisplayed = true true } else { diff --git a/app/src/main/java/org/mozilla/fenix/onboarding/DefaultBrowserNotificationWorker.kt b/app/src/main/java/org/mozilla/fenix/onboarding/DefaultBrowserNotificationWorker.kt index 16ceabcb7d..3727c9b4a5 100644 --- a/app/src/main/java/org/mozilla/fenix/onboarding/DefaultBrowserNotificationWorker.kt +++ b/app/src/main/java/org/mozilla/fenix/onboarding/DefaultBrowserNotificationWorker.kt @@ -35,6 +35,10 @@ class DefaultBrowserNotificationWorker( ensureChannelExists() NotificationManagerCompat.from(applicationContext) .notify(NOTIFICATION_TAG, NOTIFICATION_ID, buildNotification()) + + // default browser notification should only happen once + applicationContext.settings().defaultBrowserNotificationDisplayed = true + return Result.success() }