From d69b5ed456e23883b5aed4eb4428363321b3a05b Mon Sep 17 00:00:00 2001 From: mike a Date: Wed, 3 Nov 2021 21:45:16 -0700 Subject: [PATCH] For #21816: Filename in "Open" PDF dialog overflows screen MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Changing the download file name length to the max allowed by AS (251 char, won’t compile if more; max would be 260 for latest windows versions, but generally it is 255), and changing the UI test to check if the long file name is fully visible. Changing the downloaded dialog layout to properly display really long file names. --- app/src/androidTest/assets/pages/download.html | 2 +- ...OSdpZIwCWGIVM3AZmjFSaiAyZKxJp8G1oZ2md4DBQYy6F1.svg} | 0 .../java/org/mozilla/fenix/helpers/TestAssetHelper.kt | 7 ++++++- .../java/org/mozilla/fenix/ui/DownloadTest.kt | 4 ++-- .../androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt | 2 +- .../java/org/mozilla/fenix/ui/robots/DownloadRobot.kt | 3 +++ app/src/main/res/layout/download_dialog_layout.xml | 10 +++++----- 7 files changed, 18 insertions(+), 10 deletions(-) rename app/src/androidTest/assets/resources/{Globe.svg => tAJwqaWjJsXS8AhzSninBMCfIZbHBGgcc001lx5DIdDwIcfEgQ6vE5Gb5VgAled17DFZ2A7ZDOHA0NpQPHXXFHPSD4wzCkRWiaOorNI574zLtv4Hjiz6O6T7onmUTGgUQ2YQoiQFyrCrPv8ZB9KvmtoRFRVIZh8Pg2a1THrm9gpMoLwP44nDNN5o70USUyVXFxPeTerG9OSdpZIwCWGIVM3AZmjFSaiAyZKxJp8G1oZ2md4DBQYy6F1.svg} (100%) diff --git a/app/src/androidTest/assets/pages/download.html b/app/src/androidTest/assets/pages/download.html index 440a3b0c07..c05677828a 100644 --- a/app/src/androidTest/assets/pages/download.html +++ b/app/src/androidTest/assets/pages/download.html @@ -1,6 +1,6 @@ - Page content: Globe.svg + Page content: tAJwqaWjJsXS8AhzSninBMCfIZbHBGgcc001lx5DIdDwIcfEgQ6vE5Gb5VgAled17DFZ2A7ZDOHA0NpQPHXXFHPSD4wzCkRWiaOorNI574zLtv4Hjiz6O6T7onmUTGgUQ2YQoiQFyrCrPv8ZB9KvmtoRFRVIZh8Pg2a1THrm9gpMoLwP44nDNN5o70USUyVXFxPeTerG9OSdpZIwCWGIVM3AZmjFSaiAyZKxJp8G1oZ2md4DBQYy6F1.svg