[fenix] Address comments

pull/600/head
Arturo Mejia 2 years ago committed by mergify[bot]
parent e3522ee163
commit d4408f8446

@ -84,7 +84,7 @@ object CookieBannerReEngagementDialogUtils {
if (status == CookieBannerHandlingStatus.DETECTED &&
settings.shouldCookieBannerReEngagementDialog()
) {
settings.lastInteractionWithReEngageCookieBannerDialogInMS = System.currentTimeMillis()
settings.lastInteractionWithReEngageCookieBannerDialogInMs = System.currentTimeMillis()
settings.cookieBannerDetectedPreviously = true
val directions =
BrowserFragmentDirections.actionBrowserFragmentToCookieBannerDialogFragment()

@ -552,9 +552,9 @@ class Settings(private val appContext: Context) : PreferencesHolder {
default = false,
)
var lastInteractionWithReEngageCookieBannerDialogInMS by longPreference(
var lastInteractionWithReEngageCookieBannerDialogInMs by longPreference(
appContext.getPreferenceKey(
R.string.pref_key_cookie_banner_re_engage_dialog_last_interaction_with_dialog_in_ms,
R.string.pref_key_cookie_banner_re_engage_dialog_last_interaction_in_ms,
),
default = 0L,
)
@ -584,7 +584,7 @@ class Settings(private val appContext: Context) : PreferencesHolder {
shouldShowCookieBannerUI && !userOptOutOfReEngageCookieBannerDialog && !shouldUseCookieBanner
return if (!shouldShowTotalCookieProtectionCFR && shouldShowDialog) {
!cookieBannerDetectedPreviously ||
timeNowInMillis() - lastInteractionWithReEngageCookieBannerDialogInMS >= timerForCookieBannerDialog
timeNowInMillis() - lastInteractionWithReEngageCookieBannerDialogInMs >= timerForCookieBannerDialog
} else {
false
}

@ -151,7 +151,7 @@
<!-- Cookie Banner Reduction Settings-->
<string name="pref_key_cookie_banner_settings" translatable="false">pref_key_cookie_banner_settings</string>
<string name="pref_key_cookie_banner_re_engage_dialog_last_interaction_with_dialog_in_ms" translatable="false">pref_key_cookie_banner_re_engage_dialog_last_interaction_with_dialog_in_ms</string>
<string name="pref_key_cookie_banner_re_engage_dialog_last_interaction_in_ms" translatable="false">pref_key_cookie_banner_re_engage_dialog_last_interaction_with_dialog_in_ms</string>
<string name="pref_key_cookie_banner_re_engage_dialog_dismissed" translatable="false">pref_key_cookie_banner_re_engage_dialog_dismissed</string>
<string name="pref_key_cookie_banner_first_banner_detected" translatable="false">pref_key_cookie_banner_first_banner_detected</string>
<string name="pref_key_cookie_banner_v1" translatable="false">pref_key_cookie_banner_v1</string>

Loading…
Cancel
Save