Bug 1852748 - Add quotes around each highlight snippet

fenix/119.0
rahulsainani 1 year ago committed by mergify[bot]
parent e2a0ee65be
commit d3ce9b083f

@ -67,7 +67,7 @@ private fun Highlight.highlightsForType(highlightType: HighlightType) =
HighlightType.SHIPPING -> shipping
HighlightType.PACKAGING_AND_APPEARANCE -> appearance
HighlightType.COMPETITIVENESS -> competitiveness
}
}?.map { it.surroundWithQuotes() }
/**
* GeckoView sets 0.0 as default instead of null for adjusted rating. This maps 0.0 to null making
@ -80,3 +80,6 @@ private fun Double.toFloatOrNull(): Float? =
} else {
toFloat()
}
private fun String.surroundWithQuotes(): String =
"\"$this\""

@ -38,11 +38,11 @@ class ProductAnalysisMapperTest {
adjustedRating = 3.4f,
productUrl = "https://example.com",
highlights = sortedMapOf(
HighlightType.QUALITY to listOf("quality"),
HighlightType.PRICE to listOf("price"),
HighlightType.SHIPPING to listOf("shipping"),
HighlightType.PACKAGING_AND_APPEARANCE to listOf("appearance"),
HighlightType.COMPETITIVENESS to listOf("competitiveness"),
HighlightType.QUALITY to listOf("\"quality\""),
HighlightType.PRICE to listOf("\"price\""),
HighlightType.SHIPPING to listOf("\"shipping\""),
HighlightType.PACKAGING_AND_APPEARANCE to listOf("\"appearance\""),
HighlightType.COMPETITIVENESS to listOf("\"competitiveness\""),
),
)
@ -73,9 +73,9 @@ class ProductAnalysisMapperTest {
adjustedRating = 3.4f,
productUrl = "https://example.com",
highlights = sortedMapOf(
HighlightType.QUALITY to listOf("quality"),
HighlightType.PACKAGING_AND_APPEARANCE to listOf("appearance"),
HighlightType.COMPETITIVENESS to listOf("competitiveness"),
HighlightType.QUALITY to listOf("\"quality\""),
HighlightType.PACKAGING_AND_APPEARANCE to listOf("\"appearance\""),
HighlightType.COMPETITIVENESS to listOf("\"competitiveness\""),
),
)

Loading…
Cancel
Save