diff --git a/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt b/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt index c58063d621..3f0b95538c 100644 --- a/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt +++ b/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt @@ -10,6 +10,7 @@ import android.graphics.drawable.BitmapDrawable import androidx.annotation.VisibleForTesting import androidx.appcompat.content.res.AppCompatResources import androidx.core.content.ContextCompat +import mozilla.components.browser.state.search.SearchEngine import mozilla.components.browser.toolbar.BrowserToolbar import mozilla.components.support.ktx.android.content.getColorFromAttr import mozilla.components.support.ktx.android.content.res.resolveAttribute @@ -143,6 +144,13 @@ class ToolbarView( val searchEngine = searchState.searchEngineSource.searchEngine + when (searchEngine?.type) { + SearchEngine.Type.APPLICATION -> + view.edit.hint = context.getString(R.string.application_search_hint) + else -> + view.edit.hint = context.getString(R.string.search_hint) + } + if (!settings.showUnifiedSearchFeature && searchEngine != null) { val iconSize = context.resources.getDimensionPixelSize(R.dimen.preference_icon_drawable_size) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index dcd00f6abe..48ead51b2f 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -16,6 +16,8 @@ Disable private browsing Search or enter address + + Enter search terms Your open tabs will be shown here. diff --git a/app/src/test/java/org/mozilla/fenix/search/toolbar/ToolbarViewTest.kt b/app/src/test/java/org/mozilla/fenix/search/toolbar/ToolbarViewTest.kt index d2d911beaf..96e9c2dc9a 100644 --- a/app/src/test/java/org/mozilla/fenix/search/toolbar/ToolbarViewTest.kt +++ b/app/src/test/java/org/mozilla/fenix/search/toolbar/ToolbarViewTest.kt @@ -13,6 +13,7 @@ import io.mockk.impl.annotations.MockK import io.mockk.mockk import io.mockk.spyk import io.mockk.verify +import mozilla.components.browser.state.search.SearchEngine import mozilla.components.browser.toolbar.BrowserToolbar import mozilla.components.browser.toolbar.edit.EditToolbar import mozilla.components.concept.engine.Engine @@ -45,6 +46,7 @@ class ToolbarViewTest { mockk { every { name } returns "Search Engine" every { icon } returns testContext.getDrawable(R.drawable.ic_search)!!.toBitmap() + every { type } returns SearchEngine.Type.BUNDLED } ), defaultEngine = null,