From c348e03d0e5ac828dab3c59d735928fb241ac902 Mon Sep 17 00:00:00 2001 From: Grisha Kruglov Date: Fri, 25 Sep 2020 13:19:50 -0700 Subject: [PATCH] [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15434: Don't try to display a 'signed in' snackbar in a 'headless' mode --- .../org/mozilla/fenix/settings/account/TurnOnSyncFragment.kt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/src/main/java/org/mozilla/fenix/settings/account/TurnOnSyncFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/account/TurnOnSyncFragment.kt index 262d19b1dd..fae8243782 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/account/TurnOnSyncFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/account/TurnOnSyncFragment.kt @@ -135,6 +135,11 @@ class TurnOnSyncFragment : Fragment(), AccountObserver { } override fun onAuthenticated(account: OAuthAccount, authType: AuthType) { + // If we're in a `shouldLoginJustWithEmail = true` state, we won't have a view available, + // and can't display a snackbar. + if (view == null) { + return + } val snackbarText = requireContext().getString(R.string.sync_syncing_in_progress) val snackbarLength = FenixSnackbar.LENGTH_SHORT