From c243dbfaaa2f9cb0943f88df4d2baa130ca504c3 Mon Sep 17 00:00:00 2001 From: Colin Lee Date: Mon, 13 May 2019 21:03:51 -0500 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/2436: TransactionTooLargeException saving many tabs (https://github.com/mozilla-mobile/fenix/pull/2453) --- .../org/mozilla/fenix/home/HomeFragment.kt | 23 +------------------ 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt index be849e957..963bab961 100644 --- a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt @@ -170,14 +170,6 @@ class HomeFragment : Fragment(), CoroutineScope { // This can get called before onCreateView, before the component is defined view?.let { val state = sessionControlComponent.stateObservable.blockingFirst() - outState.putParcelableArrayList( - KEY_TABS, - ArrayList(state.tabs) - ) - outState.putParcelableArrayList( - KEY_COLLECTIONS, - ArrayList(state.collections) - ) val modeInt = if (state.mode is Mode.Private) 0 else 1 outState.putInt(KEY_MODE, modeInt) } @@ -186,20 +178,7 @@ class HomeFragment : Fragment(), CoroutineScope { override fun onViewStateRestored(savedInstanceState: Bundle?) { super.onViewStateRestored(savedInstanceState) if (savedInstanceState != null) { - getManagedEmitter().onNext( - SessionControlChange.TabsChange( - (savedInstanceState.getParcelableArrayList( - KEY_TABS - ) ?: arrayListOf()).toList() - ) - ) - getManagedEmitter().onNext( - SessionControlChange.CollectionsChange( - (savedInstanceState.getParcelableArrayList( - KEY_COLLECTIONS - ) ?: arrayListOf()).toList() - ) - ) + emitSessionChanges() val mode = if (savedInstanceState.getInt(KEY_MODE) == 0) Mode.Private else Mode.Normal getManagedEmitter().onNext( SessionControlChange.ModeChange(mode)