From c1577cd1f8c2d703d02d1f26384a201da064d7e8 Mon Sep 17 00:00:00 2001 From: Colin Lee Date: Thu, 12 Sep 2019 11:57:10 -0500 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/3106: Improve granular data deletion margins --- .../main/res/layout/delete_browsing_data_item.xml | 3 --- .../res/layout/fragment_delete_browsing_data.xml | 12 ++++++++++++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/app/src/main/res/layout/delete_browsing_data_item.xml b/app/src/main/res/layout/delete_browsing_data_item.xml index c3d2fdb487..c914a1fafb 100644 --- a/app/src/main/res/layout/delete_browsing_data_item.xml +++ b/app/src/main/res/layout/delete_browsing_data_item.xml @@ -15,11 +15,8 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginStart="@dimen/library_item_icon_margin_horizontal" - android:layout_marginTop="@dimen/library_item_icon_margin_vertical" android:layout_marginEnd="16dp" - android:layout_marginBottom="@dimen/library_item_icon_margin_vertical" android:clickable="false" - app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" /> diff --git a/app/src/main/res/layout/fragment_delete_browsing_data.xml b/app/src/main/res/layout/fragment_delete_browsing_data.xml index eea5088a01..780c4901dc 100644 --- a/app/src/main/res/layout/fragment_delete_browsing_data.xml +++ b/app/src/main/res/layout/fragment_delete_browsing_data.xml @@ -33,6 +33,8 @@ android:id="@+id/open_tabs_item" android:layout_width="match_parent" android:layout_height="wrap_content" + android:layout_marginTop="8dp" + android:layout_marginBottom="8dp" android:background="?android:attr/selectableItemBackground" android:clickable="true" android:focusable="true" @@ -42,6 +44,8 @@ android:id="@+id/browsing_data_item" android:layout_width="match_parent" android:layout_height="wrap_content" + android:layout_marginTop="8dp" + android:layout_marginBottom="8dp" android:background="?android:attr/selectableItemBackground" android:clickable="true" android:focusable="true" @@ -51,6 +55,8 @@ android:id="@+id/collections_item" android:layout_width="match_parent" android:layout_height="wrap_content" + android:layout_marginTop="8dp" + android:layout_marginBottom="8dp" android:background="?android:attr/selectableItemBackground" android:clickable="true" android:focusable="true" @@ -60,6 +66,8 @@ android:id="@+id/cookies_item" android:layout_width="match_parent" android:layout_height="wrap_content" + android:layout_marginTop="8dp" + android:layout_marginBottom="8dp" android:background="?android:attr/selectableItemBackground" android:clickable="true" android:focusable="true" @@ -70,6 +78,8 @@ android:id="@+id/cached_files_item" android:layout_width="match_parent" android:layout_height="wrap_content" + android:layout_marginTop="8dp" + android:layout_marginBottom="8dp" android:background="?android:attr/selectableItemBackground" android:clickable="true" android:focusable="true" @@ -80,6 +90,8 @@ android:id="@+id/site_permissions_item" android:layout_width="match_parent" android:layout_height="wrap_content" + android:layout_marginTop="8dp" + android:layout_marginBottom="8dp" android:background="?android:attr/selectableItemBackground" android:clickable="true" android:focusable="true"