From bfc0fa36b1b47a909f9a6f48666cdb163485cd1b Mon Sep 17 00:00:00 2001 From: Emily Kager Date: Tue, 28 May 2019 14:10:46 -0700 Subject: [PATCH] For #2133 - Add destructive text color to delete history button --- .../HistoryDeleteButtonViewHolder.kt | 1 - .../main/res/layout/delete_history_button.xml | 45 ++++++++----------- 2 files changed, 18 insertions(+), 28 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryDeleteButtonViewHolder.kt b/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryDeleteButtonViewHolder.kt index a67bd88918..7734314350 100644 --- a/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryDeleteButtonViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryDeleteButtonViewHolder.kt @@ -17,7 +17,6 @@ class HistoryDeleteButtonViewHolder( private val actionEmitter: Observer ) : RecyclerView.ViewHolder(view) { private var mode: HistoryState.Mode? = null - private val textView = view.delete_history_button_text private val buttonView = view.delete_history_button init { diff --git a/app/src/main/res/layout/delete_history_button.xml b/app/src/main/res/layout/delete_history_button.xml index 735f27ca8b..c817fb7f4e 100644 --- a/app/src/main/res/layout/delete_history_button.xml +++ b/app/src/main/res/layout/delete_history_button.xml @@ -2,32 +2,23 @@ - - - - - \ No newline at end of file + android:layout_height="wrap_content" + android:layout_margin="16dp" + android:background="@drawable/button_background" + android:letterSpacing="0" + android:text="@string/history_delete_all" + android:textAllCaps="false" + android:textColor="?destructive" + android:textStyle="bold" + android:theme="@style/Theme.MaterialComponents.Light" + app:backgroundTint="?neutral" + app:icon="@drawable/ic_delete" + app:iconGravity="textStart" + app:iconPadding="8dp" + app:iconTint="?destructive" + app:rippleColor="?secondaryText" />