From bf758fac0bb99943c7c5bdeb3f01f6db1b3c8f3c Mon Sep 17 00:00:00 2001 From: mcarare Date: Mon, 30 May 2022 18:26:37 +0300 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/25437: Fix label values for labeled counters. --- .../fenix/home/recentsyncedtabs/RecentSyncedTabFeature.kt | 2 +- .../recentsyncedtabs/controller/RecentSyncedTabController.kt | 2 +- .../main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt | 2 +- .../fenix/home/recentsyncedtabs/RecentSyncedTabFeatureTest.kt | 2 +- .../controller/DefaultRecentSyncedTabControllerTest.kt | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/RecentSyncedTabFeature.kt b/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/RecentSyncedTabFeature.kt index 09fee47ae2..ef9b1cb69c 100644 --- a/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/RecentSyncedTabFeature.kt +++ b/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/RecentSyncedTabFeature.kt @@ -110,7 +110,7 @@ class RecentSyncedTabFeature( lastSyncedTab: RecentSyncedTab?, syncStartId: GleanTimerId? ) { - RecentSyncedTabs.recentSyncedTabShown[tab.deviceType.name].add() + RecentSyncedTabs.recentSyncedTabShown[tab.deviceType.name.lowercase()].add() RecentSyncedTabs.recentSyncedTabTimeToLoad.stopAndAccumulate(syncStartId) if (tab == lastSyncedTab) { RecentSyncedTabs.latestSyncedTabIsStale.add() diff --git a/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/controller/RecentSyncedTabController.kt b/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/controller/RecentSyncedTabController.kt index 151f985b07..675a71c027 100644 --- a/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/controller/RecentSyncedTabController.kt +++ b/app/src/main/java/org/mozilla/fenix/home/recentsyncedtabs/controller/RecentSyncedTabController.kt @@ -41,7 +41,7 @@ class DefaultRecentSyncedTabController( private val accessPoint: TabsTrayAccessPoint, ) : RecentSyncedTabController { override fun handleRecentSyncedTabClick(tab: RecentSyncedTab) { - RecentSyncedTabs.recentSyncedTabOpened[tab.deviceType.name].add() + RecentSyncedTabs.recentSyncedTabOpened[tab.deviceType.name.lowercase()].add() addNewTabUseCase.invoke(tab.url) navController.navigate(R.id.browserFragment) } diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt b/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt index 49b6010e2c..5ffe0d9c45 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt @@ -134,7 +134,7 @@ class TabsTrayFragment : AppCompatDialogFragment() { val args by navArgs() args.accessPoint.takeIf { it != TabsTrayAccessPoint.None }?.let { - TabsTray.accessPoint[it.name].add() + TabsTray.accessPoint[it.name.lowercase()].add() } val initialMode = if (args.enterMultiselect) { TabsTrayState.Mode.Select(emptySet()) diff --git a/app/src/test/java/org/mozilla/fenix/home/recentsyncedtabs/RecentSyncedTabFeatureTest.kt b/app/src/test/java/org/mozilla/fenix/home/recentsyncedtabs/RecentSyncedTabFeatureTest.kt index fea0b60cc9..2b044b41f9 100644 --- a/app/src/test/java/org/mozilla/fenix/home/recentsyncedtabs/RecentSyncedTabFeatureTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/recentsyncedtabs/RecentSyncedTabFeatureTest.kt @@ -185,7 +185,7 @@ class RecentSyncedTabFeatureTest { feature.displaySyncedTabs(listOf(tab)) - assertEquals(1, RecentSyncedTabs.recentSyncedTabShown[deviceAccessed1.deviceType.name].testGetValue()) + assertEquals(1, RecentSyncedTabs.recentSyncedTabShown["desktop"].testGetValue()) } @Test diff --git a/app/src/test/java/org/mozilla/fenix/home/recentsyncedtabs/controller/DefaultRecentSyncedTabControllerTest.kt b/app/src/test/java/org/mozilla/fenix/home/recentsyncedtabs/controller/DefaultRecentSyncedTabControllerTest.kt index 44bc47b60f..7aec5de4fc 100644 --- a/app/src/test/java/org/mozilla/fenix/home/recentsyncedtabs/controller/DefaultRecentSyncedTabControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/home/recentsyncedtabs/controller/DefaultRecentSyncedTabControllerTest.kt @@ -102,7 +102,7 @@ class DefaultRecentSyncedTabControllerTest { controller.handleRecentSyncedTabClick(tab) - assertEquals(1, RecentSyncedTabs.recentSyncedTabOpened[deviceType.name].testGetValue()) + assertEquals(1, RecentSyncedTabs.recentSyncedTabOpened["desktop"].testGetValue()) } @Test